[{"id":1762979,"web_url":"http://patchwork.ozlabs.org/comment/1762979/","msgid":"<5538f104-7f18-3635-1ce4-5293925a1dd1@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:30:59","subject":"ACK: [PATCH] uefi: securebootcert: make array\n\tsecurebootcert_info_table const","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 06:03 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array securebootcert_info_table is static and read-only so make it\n> also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/securebootcert/securebootcert.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c\n> index b431b4ce..b58c4e70 100644\n> --- a/src/uefi/securebootcert/securebootcert.c\n> +++ b/src/uefi/securebootcert/securebootcert.c\n> @@ -387,7 +387,7 @@ static void securebootcert_key_ex_key(fwts_framework *fw, fwts_uefi_var *var, ch\n> \t}\n> }\n> \n> -static securebootcert_info securebootcert_info_table[] = {\n> +static const securebootcert_info securebootcert_info_table[] = {\n> \t{ \"SecureBoot\",\t\tsecurebootcert_secure_boot },\n> \t{ \"SetupMode\",\t\tsecurebootcert_setup_mode },\n> \t{ \"db\",\t\t\tsecurebootcert_data_base },\n> @@ -401,7 +401,7 @@ static void securebootcert_var(fwts_framework *fw, fwts_uefi_var *var)\n> {\n> \tchar varname[512];\n> \tchar guid_str[37];\n> -\tsecurebootcert_info *info;\n> +\tconst securebootcert_info *info;\n> \n> \tfwts_uefi_get_varname(varname, sizeof(varname), var);\n> \n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmb0n07tLz9sNq;\n\tTue, 5 Sep 2017 15:31:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6Rz-0002Sk-RZ; Tue, 05 Sep 2017 05:31:03 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6Ry-0002SS-Fq\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:02 +0000","from mail-pf0-f197.google.com ([209.85.192.197])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6Ry-0001bq-4X\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:31:02 +0000","by mail-pf0-f197.google.com with SMTP id e199so4949362pfh.3\n\tfor ;\n\tMon, 04 Sep 2017 22:31:02 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\t188sm12407594pfe.171.2017.09.04.22.31.00\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:31:00 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=yTzUgK0rOlQ6nwqSaRjmZMlOuRxcPeD8bM7nQX9I2Jo=;\n\tb=TaoBtug5qkzVaqziC8LJfPCveIyGv+ZCYn4vImn2Qmr+2Sdb+gz+7IoTp7o+h4EKu8\n\tLpTF711EMBfoEie0kaLfEkVCXDOBWv7tKCSaqS4JR4eHeUDwPz3f2kyNSZh7VV2Q5C4f\n\tTLQ2kDBLm+PVbozNyzZ9725EoohpXflwP8rC62+4v74O7/3hAkye0Wf71+WTWPfPg93Y\n\tDv1RG/Wsh8/gp1Lv/t/koDP7bqXy9pTRojtzLGqXuzHzpYo+ezdETOor0WQ8NSIIRlcY\n\t9gX8dAAHZb12RqpC3o3BhsAGl52TAdtwW6S62/K2WTWVNRiHL3S0WwywxNnrqmsm04Fo\n\tMlBw==","X-Gm-Message-State":"AHPjjUhKtiH4rtDI9QD3V6YJkYT8Tl4hXllZzJljerjnh7CerXtoCG5R\n\tcj6/X7lOcSv0ICHOQBRtIlsh+7bNHQO8VOPXwi8kWvfxk/6Xw26y+sseay8MKhMbvp6ec9f+FYN\n\tJ9Hsvun8J2anbFuCFSP6x6eyh/8hAPvw=","X-Received":["by 10.98.58.16 with SMTP id h16mr2588325pfa.153.1504589460739;\n\tMon, 04 Sep 2017 22:31:00 -0700 (PDT)","by 10.98.58.16 with SMTP id h16mr2588319pfa.153.1504589460592;\n\tMon, 04 Sep 2017 22:31:00 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7jOMj78XDIRCOg+Ow/toqVIsgzcrRP7Lcy+0rp2A8C2h3BV/qLtZkEb+s79g2M8AOghT912w==","Subject":"ACK: [PATCH] uefi: securebootcert: make array\n\tsecurebootcert_info_table const","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130358.12599-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<5538f104-7f18-3635-1ce4-5293925a1dd1@canonical.com>","Date":"Mon, 4 Sep 2017 22:30:59 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130358.12599-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763902,"web_url":"http://patchwork.ozlabs.org/comment/1763902/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:21:01","subject":"ACK: [PATCH] uefi: securebootcert: make array\n\tsecurebootcert_info_table const","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 09:03 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array securebootcert_info_table is static and read-only so make it\n> also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/uefi/securebootcert/securebootcert.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c\n> index b431b4ce..b58c4e70 100644\n> --- a/src/uefi/securebootcert/securebootcert.c\n> +++ b/src/uefi/securebootcert/securebootcert.c\n> @@ -387,7 +387,7 @@ static void securebootcert_key_ex_key(fwts_framework *fw, fwts_uefi_var *var, ch\n> \t}\n> }\n> \n> -static securebootcert_info securebootcert_info_table[] = {\n> +static const securebootcert_info securebootcert_info_table[] = {\n> \t{ \"SecureBoot\",\t\tsecurebootcert_secure_boot },\n> \t{ \"SetupMode\",\t\tsecurebootcert_setup_mode },\n> \t{ \"db\",\t\t\tsecurebootcert_data_base },\n> @@ -401,7 +401,7 @@ static void securebootcert_var(fwts_framework *fw, fwts_uefi_var *var)\n> {\n> \tchar varname[512];\n> \tchar guid_str[37];\n> -\tsecurebootcert_info *info;\n> +\tconst securebootcert_info *info;\n> \n> \tfwts_uefi_get_varname(varname, sizeof(varname), var);\n> \n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGkW3yRNz9s9Y;\n\tWed, 6 Sep 2017 18:21:07 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVa6-00085q-Bv; Wed, 06 Sep 2017 08:21:06 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVa4-00085i-N7\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:21:04 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVa4-0002Zn-6k\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:21:04 +0000"],"Subject":"ACK: [PATCH] uefi: securebootcert: make array\n\tsecurebootcert_info_table const","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130358.12599-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Wed, 6 Sep 2017 16:21:01 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130358.12599-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]