[{"id":1762978,"web_url":"http://patchwork.ozlabs.org/comment/1762978/","msgid":"","list_archive_url":null,"date":"2017-09-05T05:30:50","subject":"ACK: [PATCH] dmi: dmicheck: constify array dmi_used_by_kernel_table","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 06:00 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> The array dmi_used_by_kernel_table is static and read-only so also\n> make it const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/dmi/dmicheck/dmicheck.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c\n> index 20f28b17..61c6b816 100644\n> --- a/src/dmi/dmicheck/dmicheck.c\n> +++ b/src/dmi/dmicheck/dmicheck.c\n> @@ -264,7 +264,7 @@ static const fwts_dmi_version dmi_versions[] = {\n> * we care that work,\n> *\tsee drivers/firmware/dmi_scan.c, dmi_decode()\n> */\n> -static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n> +static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n> \t/* Type 0 BIOS Information fields */\n> \t{ 0, 4 },\n> \t{ 0, 5 },\n> \nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmb0c6bZMz9sNq;\n\tTue, 5 Sep 2017 15:30:56 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6Rr-0002Qf-Oi; Tue, 05 Sep 2017 05:30:55 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6Rp-0002QY-J0\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:53 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6Rp-0001bY-7l\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:53 +0000","by mail-pg0-f71.google.com with SMTP id j6so5202500pgc.4\n\tfor ;\n\tMon, 04 Sep 2017 22:30:53 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tw124sm13278540pfd.179.2017.09.04.22.30.51\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:30:51 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=y1wxjIWM/tpRGg6yrSEKZjT37xl/J0hj+GVghKITGYs=;\n\tb=DYzzKmIfYr4OJRAQrz5gt1Pk9BPknVWrBd89adNS05jnyI7k2fwe5XemD4Xa4QwLMM\n\tGfRM1lHgmlonYat358McAKD/XzOl4aqdmeIazL9qFVGcHCv9sVqNp5qX8nHSWPmrmN3E\n\tNNf8YJhIEfQ4tKzf1K98t4BHIiwEYzakOBIhwF6X//MWt9Uol0GCH9MeIsDL6LgbP/Ib\n\twgCiGDQKzsAQv+TmG0zKSFq3Xwl7ilS6i3yRYO9SFpFCkSpvLJWhDBrg+jF7meb95Blr\n\t67f69ksgEeZH1Eeo1/smDaEYgRrBFa/+yjivCnu/FKtMh3IMs9Q3De5zhwROxG7YXbXu\n\tTjZw==","X-Gm-Message-State":"AHPjjUg3EozLUr6sBr7PUOj3cXo25D58wZOKKikAfxZMPsYSLZVhShyL\n\tfH3y3aYxmqh73Uyjf8weh8f672UdIKqQ/CDaKZ6B7hMa+ZzVs3OcELF3ytiBd34YZEDQlRle4f8\n\tYjf4KyFTYL0yaMB8CpdW54dbyuytiDIg=","X-Received":["by 10.99.115.28 with SMTP id o28mr2869297pgc.374.1504589451776; \n\tMon, 04 Sep 2017 22:30:51 -0700 (PDT)","by 10.99.115.28 with SMTP id o28mr2869287pgc.374.1504589451639; \n\tMon, 04 Sep 2017 22:30:51 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7wSxwbr8u+i+Nj388E3i17WBlZq4t7nz4D10CykplVVT3I0vXywZVHsm69pdhFSb73DrAuIg==","Subject":"ACK: [PATCH] dmi: dmicheck: constify array dmi_used_by_kernel_table","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130041.6286-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"","Date":"Mon, 4 Sep 2017 22:30:50 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130041.6286-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763901,"web_url":"http://patchwork.ozlabs.org/comment/1763901/","msgid":"<834bfe0c-1cec-d6fe-2462-26e59cf2bd6d@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:20:40","subject":"ACK: [PATCH] dmi: dmicheck: constify array dmi_used_by_kernel_table","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 09:00 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The array dmi_used_by_kernel_table is static and read-only so also\n> make it const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/dmi/dmicheck/dmicheck.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c\n> index 20f28b17..61c6b816 100644\n> --- a/src/dmi/dmicheck/dmicheck.c\n> +++ b/src/dmi/dmicheck/dmicheck.c\n> @@ -264,7 +264,7 @@ static const fwts_dmi_version dmi_versions[] = {\n> * we care that work,\n> *\tsee drivers/firmware/dmi_scan.c, dmi_decode()\n> */\n> -static fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n> +static const fwts_dmi_used_by_kernel dmi_used_by_kernel_table[] = {\n> \t/* Type 0 BIOS Information fields */\n> \t{ 0, 4 },\n> \t{ 0, 5 },\n> \n\n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGk52szbz9s9Y;\n\tWed, 6 Sep 2017 18:20:45 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVZk-00083L-7k; Wed, 06 Sep 2017 08:20:44 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVZj-00083F-DL\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:43 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVZi-0002Xm-U7\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:43 +0000"],"Subject":"ACK: [PATCH] dmi: dmicheck: constify array dmi_used_by_kernel_table","To":"fwts-devel@lists.ubuntu.com","References":"<20170904130041.6286-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<834bfe0c-1cec-d6fe-2462-26e59cf2bd6d@canonical.com>","Date":"Wed, 6 Sep 2017 16:20:40 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904130041.6286-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]