[{"id":1762977,"web_url":"http://patchwork.ozlabs.org/comment/1762977/","msgid":"","list_archive_url":null,"date":"2017-09-05T05:30:40","subject":"ACK: [PATCH] bios: multiproc: constify array bus_types","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:57 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> array bus_types is static and read-only, so make it also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/bios/multiproc/mpcheck.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/bios/multiproc/mpcheck.c b/src/bios/multiproc/mpcheck.c\n> index 24941f15..9927e4f5 100644\n> --- a/src/bios/multiproc/mpcheck.c\n> +++ b/src/bios/multiproc/mpcheck.c\n> @@ -147,7 +147,7 @@ static int mpcheck_test_cpu_entries(fwts_framework *fw)\n> \treturn FWTS_OK;\n> }\n> \n> -static char *bus_types[] = {\n> +static const char *const bus_types[] = {\n> \t\"CBUS\",\n> \t\"CBUSII\",\n> \t\"EISA\",\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmb0Q64zhz9sNq;\n\tTue, 5 Sep 2017 15:30:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6Rh-0002Ni-MU; Tue, 05 Sep 2017 05:30:45 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6Rg-0002NN-Fx\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:44 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6Rg-0001bN-4W\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:44 +0000","by mail-pg0-f71.google.com with SMTP id m9so5238435pgd.2\n\tfor ;\n\tMon, 04 Sep 2017 22:30:44 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tg20sm13103526pfg.138.2017.09.04.22.30.41\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:30:42 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OR6yi+uSVYXJoZWCzYtTh/+gEeFnIIj7EQd1XeSIEJ0=;\n\tb=GaKfR/b+8Sfk3hmSbvQxbMqFEbcf062KMjjAUC1O+mHDDOrF1jBTpxNepOJbjnfotd\n\t8ZF7dr2QARRTfqGnenWIk7NeKqv9cDS7wFg7Vh9vq23jaZ4B0/1kIJsmCr72HY5YkJU3\n\tQw4Z6sw/pKe+cIKiOIOjZRbNlZtLbReQJn4GtDHm/OwqNw1wPkfEiTqvVdM8IeofmxWQ\n\tjE8z6nfbUsht+mgzNWPfX06vWoeK4jQymjB0ouRlnkhbnRdyDZjY/Fw6coH6TozKJoNE\n\t+WAQVEkbRi23Oh3wxvcx4QCMXWprFeU7MX4yYNyGv7+Bm0yjrF/Gsd5bq7m0Kfk9XHqh\n\t96YA==","X-Gm-Message-State":"AHPjjUirbB+l51/uY54fqmph//sXxbiqDSdMfuGbatfyjm8L/ndrsAzv\n\t4HppE+9c/iZs7WFHLVD/hzSVfVBh6Zm6/NwErG5K2T5gWyBgtfGEJ0vvRY1ppgEgCJZpZgDggMF\n\taua6SxcfXqjmv1D/Tj/XNzBGQT7G1u/A=","X-Received":["by 10.99.125.82 with SMTP id m18mr2837431pgn.347.1504589442703; \n\tMon, 04 Sep 2017 22:30:42 -0700 (PDT)","by 10.99.125.82 with SMTP id m18mr2837429pgn.347.1504589442559; \n\tMon, 04 Sep 2017 22:30:42 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb57d7iBNS5aVyeWIzSsg6XeszXm6nbHOki2FI4dfejYIcNJwB/aJoRtoVo+eVbn35Cx5llfCQ==","Subject":"ACK: [PATCH] bios: multiproc: constify array bus_types","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125758.6067-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"","Date":"Mon, 4 Sep 2017 22:30:40 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125758.6067-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763900,"web_url":"http://patchwork.ozlabs.org/comment/1763900/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:20:20","subject":"ACK: [PATCH] bios: multiproc: constify array bus_types","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:57 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> array bus_types is static and read-only, so make it also const\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/bios/multiproc/mpcheck.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/bios/multiproc/mpcheck.c b/src/bios/multiproc/mpcheck.c\n> index 24941f15..9927e4f5 100644\n> --- a/src/bios/multiproc/mpcheck.c\n> +++ b/src/bios/multiproc/mpcheck.c\n> @@ -147,7 +147,7 @@ static int mpcheck_test_cpu_entries(fwts_framework *fw)\n> \treturn FWTS_OK;\n> }\n> \n> -static char *bus_types[] = {\n> +static const char *const bus_types[] = {\n> \t\"CBUS\",\n> \t\"CBUSII\",\n> \t\"EISA\",\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGjk2My2z9sNd;\n\tWed, 6 Sep 2017 18:20:26 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVZR-00081k-5l; Wed, 06 Sep 2017 08:20:25 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVZQ-00081b-3b\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:24 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVZP-0002Ws-Jt\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:23 +0000"],"Subject":"ACK: [PATCH] bios: multiproc: constify array bus_types","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125758.6067-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Wed, 6 Sep 2017 16:20:20 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125758.6067-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]