[{"id":1762976,"web_url":"http://patchwork.ozlabs.org/comment/1762976/","msgid":"<5566fe85-1d40-1f66-4595-ab43e8b3c576@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:30:17","subject":"ACK: [PATCH] bios: bios_info: constify array bios_info","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:54 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array bios_info is readonly and static, so also constify it\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/bios/bios_info/bios_info.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c\n> index a9297a52..84a50791 100644\n> --- a/src/bios/bios_info/bios_info.c\n> +++ b/src/bios/bios_info/bios_info.c\n> @@ -29,7 +29,7 @@ typedef struct {\n> \tchar *label;\n> } fwts_bios_info;\n> \n> -static fwts_bios_info bios_info[] = {\n> +static const fwts_bios_info bios_info[] = {\n> \t{ \"bios_vendor\",\t\"BIOS Vendor\" },\n> \t{ \"bios_version\", \t\"BIOS Version\" },\n> \t{ \"bios_date\",\t\t\"BIOS Release Date\" },\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmZzy4sRJz9sP3;\n\tTue, 5 Sep 2017 15:30:22 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6RJ-0002KP-Ga; Tue, 05 Sep 2017 05:30:21 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6RH-0002J5-UV\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:19 +0000","from mail-pf0-f197.google.com ([209.85.192.197])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6RH-0001as-J7\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:19 +0000","by mail-pf0-f197.google.com with SMTP id k3so4966837pfc.1\n\tfor ;\n\tMon, 04 Sep 2017 22:30:19 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tb27sm11281379pfh.107.2017.09.04.22.30.17\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:30:17 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=6iPgx65SGJEqzeNAAiuY56r46Wyp4wNtKstzgW+sRqk=;\n\tb=hXGOi2PSPlPjsoA0+w6uw/MnJWRzvt/h8a0kB7FCSmwGfeR78oxvAkeRO1WSpKdHPE\n\t5uAgzh3F1JBfxBAsLkFtldaGz9r0ulCnO8T/sIUCpxH8ow2lWgeLpe5Y/3geGHacvCee\n\tWnTvPxrOqkreDLid+lFwKofGxrElvGh20sHTX1XZdxrlIQQhyfvxPOsyVjg8N4zWcNGo\n\tPE/0Mh3Bcs4ojJTs17iFIWUzB7MkOWSyonkY2FsFaQ4BMKihxsg8RJt7X4W+audkVg19\n\tkvhSVU6olUfNVfL3eD7cx/trplK5BXfza11aEQxtoMW1CNgtk9ocGSs3PCZjGwoI4LbD\n\tG5Rg==","X-Gm-Message-State":"AHPjjUiQmMsqsdNkZ7Tp39XXgFWXNFXldhujH/qWPOXa/wrW0gyeLCxF\n\tIm5MFj0uXd+B6hWTdqUclhIzrW7ROUt4ZHm1gESdGLaQ6NgcLtvhdOaLI6GvyApcoh5uLa1QDYl\n\tP95pAVttxPt+YW4LXDGPAX8lQbUkYxOE=","X-Received":["by 10.84.131.100 with SMTP id 91mr3004524pld.247.1504589418184; \n\tMon, 04 Sep 2017 22:30:18 -0700 (PDT)","by 10.84.131.100 with SMTP id 91mr3004509pld.247.1504589417994; \n\tMon, 04 Sep 2017 22:30:17 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb71BdY0RP8vpmXhDsVOUsIeOIGIsuC/b3SgRspeIpXTbcRRErZFZne32vJNzhdlkTLi9+Ankg==","Subject":"ACK: [PATCH] bios: bios_info: constify array bios_info","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125443.31661-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<5566fe85-1d40-1f66-4595-ab43e8b3c576@canonical.com>","Date":"Mon, 4 Sep 2017 22:30:17 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125443.31661-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763898,"web_url":"http://patchwork.ozlabs.org/comment/1763898/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:19:58","subject":"ACK: [PATCH] bios: bios_info: constify array bios_info","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:54 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Array bios_info is readonly and static, so also constify it\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/bios/bios_info/bios_info.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/bios/bios_info/bios_info.c b/src/bios/bios_info/bios_info.c\n> index a9297a52..84a50791 100644\n> --- a/src/bios/bios_info/bios_info.c\n> +++ b/src/bios/bios_info/bios_info.c\n> @@ -29,7 +29,7 @@ typedef struct {\n> \tchar *label;\n> } fwts_bios_info;\n> \n> -static fwts_bios_info bios_info[] = {\n> +static const fwts_bios_info bios_info[] = {\n> \t{ \"bios_vendor\",\t\"BIOS Vendor\" },\n> \t{ \"bios_version\", \t\"BIOS Version\" },\n> \t{ \"bios_date\",\t\t\"BIOS Release Date\" },\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGjK28qNz9s9Y;\n\tWed, 6 Sep 2017 18:20:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVZ6-0007yk-31; Wed, 06 Sep 2017 08:20:04 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVZ4-0007yG-8V\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:02 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVZ3-0002Vo-JT\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:20:01 +0000"],"Subject":"ACK: [PATCH] bios: bios_info: constify array bios_info","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125443.31661-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Wed, 6 Sep 2017 16:19:58 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125443.31661-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]