[{"id":1762975,"web_url":"http://patchwork.ozlabs.org/comment/1762975/","msgid":"","list_archive_url":null,"date":"2017-09-05T05:30:06","subject":"ACK: [PATCH] cmos: cmosdump: constify several char * arrays","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:51 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> These arrays are read only and static, so consitfy them too.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/cmos/cmosdump/cmosdump.c | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c\n> index 2050f15f..f9e7ed52 100644\n> --- a/src/cmos/cmosdump/cmosdump.c\n> +++ b/src/cmos/cmosdump/cmosdump.c\n> @@ -32,7 +32,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \tint i;\n> \tunsigned long tmp;\n> \n> -\tstatic char *cmos_shutdown_status[] = {\n> +\tstatic const char *const cmos_shutdown_status[] = {\n> \t\t\"Power on or soft reset\",\n> \t\t\"Memory size pass\",\n> \t\t\"Memory test pass\",\n> @@ -49,7 +49,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Used by 80386\",\n> \t};\n> \n> -\tstatic char *floppy_disk[] = {\n> +\tstatic const char *const floppy_disk[] = {\n> \t\t\"None\",\n> \t\t\"360KB 5.25\\\" Drive\",\n> \t\t\"1.2MB 5.25\\\" Drive\",\n> @@ -60,7 +60,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Unknown\"\n> \t};\n> \n> -\tstatic char *hard_disk[] = {\n> +\tstatic const char *const hard_disk[] = {\n> \t\t\"None\",\n> \t\t\"Type 1\",\n> \t\t\"Unknown\",\n> @@ -79,14 +79,14 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Type 16-47\"\n> \t};\n> \n> -\tstatic char *primary_display[] = {\n> +\tstatic const char *const primary_display[] = {\n> \t\t\"BIOS selected\",\n> \t\t\"CGA 40 column\",\n> \t\t\"CGA 80 column\",\n> \t\t\"Monochrome\"\n> \t};\n> \n> -\tstatic char *divider[8] = {\n> +\tstatic const char *const divider[8] = {\n> \t\t\"4.194 MHz\",\n> \t\t\"1.049 MHz\",\n> \t\t\"32.768 KHz (default)\",\n> @@ -97,7 +97,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"reset / disable\",\n> \t};\n> \n> -\tstatic char *rate_selection[16] = {\n> +\tstatic const char *const rate_selection[16] = {\n> \t\t\"none\",\n> \t\t\"3.90625 millseconds\",\n> \t\t\"7.8215 milliseconds\",\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmZzp4H2nz9sNq;\n\tTue, 5 Sep 2017 15:30:14 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6RB-0002Hm-Do; Tue, 05 Sep 2017 05:30:13 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6R9-0002HP-0L\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:11 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6R8-0001ae-L6\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:10 +0000","by mail-pg0-f71.google.com with SMTP id d8so5240923pgt.1\n\tfor ;\n\tMon, 04 Sep 2017 22:30:10 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tn83sm996533pfi.131.2017.09.04.22.30.07\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:30:07 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=WIRviHt7ylxK+KrrFzB1kiNpeOlppQUFdv19aR8LIW0=;\n\tb=Gp/L/YJ0XhEP6u3XAMG4xNfBrBRc/q8gDUWIAp55wGp8s24yOyhocubbCar/PffLjX\n\tJUihuIlYEThXWmksLF4Z7HXZjDd8Gj0L3ZDG4DR3QltXWtSLVLLmo3iYbVDbXTaGIEi6\n\t8pV6b9B77ciyXUDtfwbYS/+qEftS/ctsmMYKfScrgiW95G7s+whPV997gD2NTlChL39W\n\tov527W/SbXjTy76R22EpwtoMpQqs5V60T2jRU3pyAQ3Iey7L5PqvdYDxpAt9u4SnMOqo\n\tFz894R5FKqyMkJlybqx6zdF1aJyuPdM0R2qk5pWxdiV/UBSfSb7tmg8JExkhoKsB+xOU\n\t0HcA==","X-Gm-Message-State":"AHPjjUibs3zsSBTOJ/hQPDciqYKg/pS8ZZ1ERXvpGjBNvk1w8EBY+xyI\n\tA3oFJkNMGf7DroX0m06/DEkycavDraeY8QeJrS7ny6HJJYPXksTrl08HH2/cblcmAFIFlMGGkIi\n\thGEjCzmKXypWnlQ4+o9uBoxxWte7hvCM=","X-Received":["by 10.159.198.2 with SMTP id f2mr3087610plo.10.1504589409087;\n\tMon, 04 Sep 2017 22:30:09 -0700 (PDT)","by 10.159.198.2 with SMTP id f2mr3087598plo.10.1504589408946;\n\tMon, 04 Sep 2017 22:30:08 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb4uRR/TI4s0rjdUOp9qAA8rlMohdsu/RmLSa01ldVLS9FNySBZoPFjHBPCnf5sH+UNz3TF+vQ==","Subject":"ACK: [PATCH] cmos: cmosdump: constify several char * arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125116.25705-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"","Date":"Mon, 4 Sep 2017 22:30:06 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125116.25705-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763896,"web_url":"http://patchwork.ozlabs.org/comment/1763896/","msgid":"<89e15408-4ee1-3807-93af-051c0f5f391a@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:19:34","subject":"ACK: [PATCH] cmos: cmosdump: constify several char * arrays","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:51 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> These arrays are read only and static, so consitfy them too.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/cmos/cmosdump/cmosdump.c | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/cmos/cmosdump/cmosdump.c b/src/cmos/cmosdump/cmosdump.c\n> index 2050f15f..f9e7ed52 100644\n> --- a/src/cmos/cmosdump/cmosdump.c\n> +++ b/src/cmos/cmosdump/cmosdump.c\n> @@ -32,7 +32,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \tint i;\n> \tunsigned long tmp;\n> \n> -\tstatic char *cmos_shutdown_status[] = {\n> +\tstatic const char *const cmos_shutdown_status[] = {\n> \t\t\"Power on or soft reset\",\n> \t\t\"Memory size pass\",\n> \t\t\"Memory test pass\",\n> @@ -49,7 +49,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Used by 80386\",\n> \t};\n> \n> -\tstatic char *floppy_disk[] = {\n> +\tstatic const char *const floppy_disk[] = {\n> \t\t\"None\",\n> \t\t\"360KB 5.25\\\" Drive\",\n> \t\t\"1.2MB 5.25\\\" Drive\",\n> @@ -60,7 +60,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Unknown\"\n> \t};\n> \n> -\tstatic char *hard_disk[] = {\n> +\tstatic const char *const hard_disk[] = {\n> \t\t\"None\",\n> \t\t\"Type 1\",\n> \t\t\"Unknown\",\n> @@ -79,14 +79,14 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"Type 16-47\"\n> \t};\n> \n> -\tstatic char *primary_display[] = {\n> +\tstatic const char *const primary_display[] = {\n> \t\t\"BIOS selected\",\n> \t\t\"CGA 40 column\",\n> \t\t\"CGA 80 column\",\n> \t\t\"Monochrome\"\n> \t};\n> \n> -\tstatic char *divider[8] = {\n> +\tstatic const char *const divider[8] = {\n> \t\t\"4.194 MHz\",\n> \t\t\"1.049 MHz\",\n> \t\t\"32.768 KHz (default)\",\n> @@ -97,7 +97,7 @@ static int cmosdump_test1(fwts_framework *fw)\n> \t\t\"reset / disable\",\n> \t};\n> \n> -\tstatic char *rate_selection[16] = {\n> +\tstatic const char *const rate_selection[16] = {\n> \t\t\"none\",\n> \t\t\"3.90625 millseconds\",\n> \t\t\"7.8215 milliseconds\",\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGhq6QSBz9s8J;\n\tWed, 6 Sep 2017 18:19:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVYg-0007wP-Nt; Wed, 06 Sep 2017 08:19:38 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVYf-0007wJ-JT\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:19:37 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVYf-0002VP-3v\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:19:37 +0000"],"Subject":"ACK: [PATCH] cmos: cmosdump: constify several char * arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904125116.25705-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<89e15408-4ee1-3807-93af-051c0f5f391a@canonical.com>","Date":"Wed, 6 Sep 2017 16:19:34 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904125116.25705-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]