[{"id":1762974,"web_url":"http://patchwork.ozlabs.org/comment/1762974/","msgid":"<24e713fc-3590-e9d2-1f3c-13d8717d51d4@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:29:57","subject":"ACK: [PATCH] acpica: constify array fwts_default_space_id_list","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:48 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> The array fwts_default_space_id_list is read-only so constify it\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/acpica/fwts_acpica.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c\n> index 0aef4558..bf547c21 100644\n> --- a/src/acpica/fwts_acpica.c\n> +++ b/src/acpica/fwts_acpica.c\n> @@ -811,7 +811,7 @@ void AcpiOsSleep(UINT64 milliseconds)\n> static void fwtsOverrideRegionHandlers(fwts_framework *fw)\n> {\n> \tint i;\n> -\tstatic ACPI_ADR_SPACE_TYPE fwts_default_space_id_list[] = {\n> +\tstatic const ACPI_ADR_SPACE_TYPE fwts_default_space_id_list[] = {\n> \t\tACPI_ADR_SPACE_SYSTEM_MEMORY,\n> \t\tACPI_ADR_SPACE_SYSTEM_IO,\n> \t\tACPI_ADR_SPACE_PCI_CONFIG,\n> \n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmZzb3GPzz9sNq;\n\tTue, 5 Sep 2017 15:30:03 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6R0-0002EX-2f; Tue, 05 Sep 2017 05:30:02 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6Qy-0002E8-JF\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:00 +0000","from mail-pg0-f72.google.com ([74.125.83.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6Qy-0001a0-7q\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:30:00 +0000","by mail-pg0-f72.google.com with SMTP id 188so5220445pgb.3\n\tfor ;\n\tMon, 04 Sep 2017 22:30:00 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\td6sm11919669pfh.113.2017.09.04.22.29.58\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:29:58 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Wxyc9WdWdMS1ggn8o/HW7Q6RpeQqiqpKSBIGKrwKGJA=;\n\tb=NMJQ2CTPEKXfx37MUtlVnXd94RGpzZSsqbTVVrsEq5d5JJDUnwFGUQ2tC1ulBYs0fS\n\tYVErXuVuDfhg53FyiGecgRSLHSwT0Ca5JweVTyVsW4CztybAI2MvClI31ka8AnZTJSGc\n\tKe/yI93eK93z4F3N1TcadZmt+Ys2EH7pYA12UaVlaqYSLAwlIWg6BBUVsRCckz4aZ5zh\n\tgEQGfTa2WbBdULT6ygTC/TTSlDLpo2/fqcmWAPvXsv7+K7PUAuO9HF3ogiGdrcZn5Tvs\n\tqLBoZTgHQCs8wHpDY1Yb/FL1kTDHiN5Jj2XCv2Q8lv6FSpuP+NyxdOYjdfBvKEs9Pgpq\n\t/Uww==","X-Gm-Message-State":"AHPjjUjFjET0xL7bxdQt3BBN3UTweLnKq2heMxw36f+2FoDKJP88zUG9\n\tgy241SMyiGYoKAIe46CHZ1Fh4gXQsVtguOgjs/0P8LZb/POjoHrWiyl0rzn5Cx9Wzvw1vaoBlhT\n\tDweV6FGU2sYNFZZ2N2GMfTYr5Uvi67kU=","X-Received":["by 10.84.128.100 with SMTP id 91mr3188789pla.414.1504589398872; \n\tMon, 04 Sep 2017 22:29:58 -0700 (PDT)","by 10.84.128.100 with SMTP id 91mr3188783pla.414.1504589398749; \n\tMon, 04 Sep 2017 22:29:58 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb5tSBiDTitZ0UgM4Ijmo9vG4dcZ7OjYdrLwHacnegRoJ4RyNzGMJpglKE8qEu3v7bnB8mclmA==","Subject":"ACK: [PATCH] acpica: constify array fwts_default_space_id_list","To":"fwts-devel@lists.ubuntu.com","References":"<20170904124841.25288-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<24e713fc-3590-e9d2-1f3c-13d8717d51d4@canonical.com>","Date":"Mon, 4 Sep 2017 22:29:57 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904124841.25288-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763894,"web_url":"http://patchwork.ozlabs.org/comment/1763894/","msgid":"<1bb1bade-5d26-57d2-af50-8e83ad3027c9@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:19:12","subject":"ACK: [PATCH] acpica: constify array fwts_default_space_id_list","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:48 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The array fwts_default_space_id_list is read-only so constify it\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/acpica/fwts_acpica.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c\n> index 0aef4558..bf547c21 100644\n> --- a/src/acpica/fwts_acpica.c\n> +++ b/src/acpica/fwts_acpica.c\n> @@ -811,7 +811,7 @@ void AcpiOsSleep(UINT64 milliseconds)\n> static void fwtsOverrideRegionHandlers(fwts_framework *fw)\n> {\n> \tint i;\n> -\tstatic ACPI_ADR_SPACE_TYPE fwts_default_space_id_list[] = {\n> +\tstatic const ACPI_ADR_SPACE_TYPE fwts_default_space_id_list[] = {\n> \t\tACPI_ADR_SPACE_SYSTEM_MEMORY,\n> \t\tACPI_ADR_SPACE_SYSTEM_IO,\n> \t\tACPI_ADR_SPACE_PCI_CONFIG,\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGhQ5J5wz9s8J;\n\tWed, 6 Sep 2017 18:19:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVYL-0007sd-IY; Wed, 06 Sep 2017 08:19:17 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVYK-0007sX-1n\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:19:16 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVYJ-0002V0-IX\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:19:15 +0000"],"Subject":"ACK: [PATCH] acpica: constify array fwts_default_space_id_list","To":"fwts-devel@lists.ubuntu.com","References":"<20170904124841.25288-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<1bb1bade-5d26-57d2-af50-8e83ad3027c9@canonical.com>","Date":"Wed, 6 Sep 2017 16:19:12 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904124841.25288-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]