[{"id":1762973,"web_url":"http://patchwork.ozlabs.org/comment/1762973/","msgid":"<20d87ca9-74b5-9045-be9a-57c2b7ba23d1@canonical.com>","list_archive_url":null,"date":"2017-09-05T05:29:42","subject":"ACK: [PATCH] acpi: method: constify arrays","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:20 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Constify some read only arrays\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/acpi/method/method.c | 26 +++++++++++++-------------\n> 1 file changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c\n> index d082fc15..71f0a0ee 100644\n> --- a/src/acpi/method/method.c\n> +++ b/src/acpi/method/method.c\n> @@ -3220,7 +3220,7 @@ static void method_test_CPC_return(\n> {\n> \tuint8_t revision;\n> \n> -\tstatic fwts_package_element elementsv1[] = {\n> +\tstatic const fwts_package_element elementsv1[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -3240,7 +3240,7 @@ static void method_test_CPC_return(\n> \t\t{ ACPI_TYPE_BUFFER,\t\"Enable Register\" }\n> \t};\n> \n> -\tstatic fwts_package_element elementsv2[] = {\n> +\tstatic const fwts_package_element elementsv2[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -3264,7 +3264,7 @@ static void method_test_CPC_return(\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Reference Performance\" }\n> \t};\n> \n> -\tstatic fwts_package_element elementsv3[] = {\n> +\tstatic const fwts_package_element elementsv3[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -4402,7 +4402,7 @@ static void method_test_PUR_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"RevisionID\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"NumProcessors\" },\n> \t};\n> @@ -4641,7 +4641,7 @@ static void method_test_MBM_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Window Size\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Sampling Interval\" },\n> @@ -4936,7 +4936,7 @@ static void method_test_SBS_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic char *sbs_info[] = {\n> +\tstatic const char *sbs_info[] = {\n> \t\t\"Maximum 1 Smart Battery, system manager/selector not present\",\n> \t\t\"Maximum 1 Smart Battery, system manager/selector present\",\n> \t\t\"Maximum 2 Smart Batteries, system manager/selector present\",\n> @@ -5002,7 +5002,7 @@ static void method_test_BIF_return(\n> {\n> \tbool failed = false;\n> \n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Last Full Charge Capacity\" },\n> @@ -5132,7 +5132,7 @@ static void method_test_BIX_return(\n> {\n> \tbool failed = false;\n> \n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n> @@ -5357,7 +5357,7 @@ static int method_test_BST(fwts_framework *fw)\n> \n> static int method_test_BTP(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> +\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> \tint i;\n> \n> \tfor (i = 0; i < 5; i++) {\n> @@ -5418,7 +5418,7 @@ static int method_test_BTH(fwts_framework *fw)\n> \n> static int method_test_BTM(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> +\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> \tint i;\n> \n> \tfor (i = 0 ; i < 5; i++) {\n> @@ -5464,7 +5464,7 @@ static int method_test_BMD(fwts_framework *fw)\n> \n> static int method_test_BMC(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 2, 4 };\n> +\tstatic const int values[] = { 0, 1, 2, 4 };\n> \tint i;\n> \n> \tfor (i = 0; i < 4; i++) {\n> @@ -5542,7 +5542,7 @@ static void method_test_PIF_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Source State\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Output Power\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Input Power\" },\n> @@ -6627,7 +6627,7 @@ static void method_test_DOD_return(\n> \tuint32_t i;\n> \tbool failed = false;\n> \n> -\tstatic char *dod_type[] = {\n> +\tstatic const char *dod_type[] = {\n> \t\t\"Other\",\n> \t\t\"VGA, CRT or VESA Compatible Analog Monitor\",\n> \t\t\"TV/HDTV or other Analog-Video Monitor\",\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmZzK17gWz9sNq;\n\tTue, 5 Sep 2017 15:29:49 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6Ql-0002C1-Vf; Tue, 05 Sep 2017 05:29:47 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6Qj-0002AY-W5\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:29:45 +0000","from mail-pf0-f198.google.com ([209.85.192.198])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6Qj-0001Zi-Ki\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:29:45 +0000","by mail-pf0-f198.google.com with SMTP id x78so4898775pff.7\n\tfor ;\n\tMon, 04 Sep 2017 22:29:45 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\td184sm12097129pfa.9.2017.09.04.22.29.43\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:29:43 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=V78NpY+YcXjKtQClVp2CviDDtWf60lvJeH/90NMfOh4=;\n\tb=Vxczs9rzavgbOMoqcr17hXD53QIUshbKvQFn3DcB3PXV38lHIhgZ5AbnSstOZnlRVK\n\tB5MT1LYzcyr3fiMsM3q/ZnQfZntQRB9tI1AkaV7/D5BhKyboQTOssNcLab7hjnRM9vqV\n\tBvM6+6zzTG19ziVItjwUXmeOm3Q/pK4Ao3VXBrD2dI6q1r12nRPBK9Rx02qekaUApNzW\n\t3TjWmVoP4xgR7aTHDVPewJ9rqdj+H/jHIlCjhbFFZBuYGZyc6ZNqByx27yVcb9cSxjG4\n\tOOU9kKft2y8gF7tFKrJNUOkGleNw7sIjHJel9b8QCi3PEcH1TJSR773yqNb/Me//cT/R\n\tJOpQ==","X-Gm-Message-State":"AHPjjUjY3WJRdHIYl15roEbDeNzpD5txr56DQzkSONaa1isEU95GYyrb\n\t/OOidZq+CcarTOMnAP0N0PXNeLmIKJuLd9BrpmOA8RaxQP0j+4FuxsONVK29B0k7AnKqEjOe0wn\n\tN6wze9IalkkbSLfLlLrz6r2zkyS4SCPQ=","X-Received":["by 10.84.234.196 with SMTP id i4mr3075574plt.262.1504589384208; \n\tMon, 04 Sep 2017 22:29:44 -0700 (PDT)","by 10.84.234.196 with SMTP id i4mr3075566plt.262.1504589384007; \n\tMon, 04 Sep 2017 22:29:44 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb5ThkSnVChRNvOAoznzhaVYY390bupVVeKxzLtCxU0rLbWZm9rb+i19vTYSaHYAh0IcZc+Zfg==","Subject":"ACK: [PATCH] acpi: method: constify arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904122014.18550-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<20d87ca9-74b5-9045-be9a-57c2b7ba23d1@canonical.com>","Date":"Mon, 4 Sep 2017 22:29:42 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904122014.18550-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763892,"web_url":"http://patchwork.ozlabs.org/comment/1763892/","msgid":"<1514f6e8-fa6e-c9c8-2da6-deb4fac573d5@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:18:49","subject":"ACK: [PATCH] acpi: method: constify arrays","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:20 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Constify some read only arrays\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/acpi/method/method.c | 26 +++++++++++++-------------\n> 1 file changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c\n> index d082fc15..71f0a0ee 100644\n> --- a/src/acpi/method/method.c\n> +++ b/src/acpi/method/method.c\n> @@ -3220,7 +3220,7 @@ static void method_test_CPC_return(\n> {\n> \tuint8_t revision;\n> \n> -\tstatic fwts_package_element elementsv1[] = {\n> +\tstatic const fwts_package_element elementsv1[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -3240,7 +3240,7 @@ static void method_test_CPC_return(\n> \t\t{ ACPI_TYPE_BUFFER,\t\"Enable Register\" }\n> \t};\n> \n> -\tstatic fwts_package_element elementsv2[] = {\n> +\tstatic const fwts_package_element elementsv2[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -3264,7 +3264,7 @@ static void method_test_CPC_return(\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Reference Performance\" }\n> \t};\n> \n> -\tstatic fwts_package_element elementsv3[] = {\n> +\tstatic const fwts_package_element elementsv3[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Number of Entries\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTBUF,\t\"Highest Performance\" },\n> @@ -4402,7 +4402,7 @@ static void method_test_PUR_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"RevisionID\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"NumProcessors\" },\n> \t};\n> @@ -4641,7 +4641,7 @@ static void method_test_MBM_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Window Size\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Sampling Interval\" },\n> @@ -4936,7 +4936,7 @@ static void method_test_SBS_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic char *sbs_info[] = {\n> +\tstatic const char *sbs_info[] = {\n> \t\t\"Maximum 1 Smart Battery, system manager/selector not present\",\n> \t\t\"Maximum 1 Smart Battery, system manager/selector present\",\n> \t\t\"Maximum 2 Smart Batteries, system manager/selector present\",\n> @@ -5002,7 +5002,7 @@ static void method_test_BIF_return(\n> {\n> \tbool failed = false;\n> \n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Last Full Charge Capacity\" },\n> @@ -5132,7 +5132,7 @@ static void method_test_BIX_return(\n> {\n> \tbool failed = false;\n> \n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Revision\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Unit\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Design Capacity\" },\n> @@ -5357,7 +5357,7 @@ static int method_test_BST(fwts_framework *fw)\n> \n> static int method_test_BTP(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> +\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> \tint i;\n> \n> \tfor (i = 0; i < 5; i++) {\n> @@ -5418,7 +5418,7 @@ static int method_test_BTH(fwts_framework *fw)\n> \n> static int method_test_BTM(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> +\tstatic const int values[] = { 0, 1, 100, 200, 0x7fffffff };\n> \tint i;\n> \n> \tfor (i = 0 ; i < 5; i++) {\n> @@ -5464,7 +5464,7 @@ static int method_test_BMD(fwts_framework *fw)\n> \n> static int method_test_BMC(fwts_framework *fw)\n> {\n> -\tstatic int values[] = { 0, 1, 2, 4 };\n> +\tstatic const int values[] = { 0, 1, 2, 4 };\n> \tint i;\n> \n> \tfor (i = 0; i < 4; i++) {\n> @@ -5542,7 +5542,7 @@ static void method_test_PIF_return(\n> \tACPI_OBJECT *obj,\n> \tvoid *private)\n> {\n> -\tstatic fwts_package_element elements[] = {\n> +\tstatic const fwts_package_element elements[] = {\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Power Source State\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Output Power\" },\n> \t\t{ ACPI_TYPE_INTEGER,\t\"Maximum Input Power\" },\n> @@ -6627,7 +6627,7 @@ static void method_test_DOD_return(\n> \tuint32_t i;\n> \tbool failed = false;\n> \n> -\tstatic char *dod_type[] = {\n> +\tstatic const char *dod_type[] = {\n> \t\t\"Other\",\n> \t\t\"VGA, CRT or VESA Compatible Analog Monitor\",\n> \t\t\"TV/HDTV or other Analog-Video Monitor\",\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGgz4NDDz9s8J;\n\tWed, 6 Sep 2017 18:18:55 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVXy-0007nW-DU; Wed, 06 Sep 2017 08:18:54 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVXw-0007nG-Vn\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:18:52 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVXw-0002U0-Fz\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:18:52 +0000"],"Subject":"ACK: [PATCH] acpi: method: constify arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904122014.18550-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<1514f6e8-fa6e-c9c8-2da6-deb4fac573d5@canonical.com>","Date":"Wed, 6 Sep 2017 16:18:49 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904122014.18550-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]