[{"id":1762971,"web_url":"http://patchwork.ozlabs.org/comment/1762971/","msgid":"","list_archive_url":null,"date":"2017-09-05T05:29:19","subject":"ACK: [PATCH] lib: constify a couple of arrays","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-04 05:09 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Since these arrays are read-only and static we can also constify them too.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/src/fwts_log.c | 2 +-\n> src/lib/src/fwts_uefi.c | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c\n> index 13d5f6ca..1660ae2a 100644\n> --- a/src/lib/src/fwts_log.c\n> +++ b/src/lib/src/fwts_log.c\n> @@ -221,7 +221,7 @@ fwts_log_field fwts_log_str_to_field(const char *text)\n> {\n> \tint i;\n> \n> -\tstatic struct mapping {\n> +\tstatic const struct mapping {\n> \t\tchar *text;\n> \t\tfwts_log_field field;\n> \t} mappings[] = {\n> diff --git a/src/lib/src/fwts_uefi.c b/src/lib/src/fwts_uefi.c\n> index 1f9d31fa..263bd657 100644\n> --- a/src/lib/src/fwts_uefi.c\n> +++ b/src/lib/src/fwts_uefi.c\n> @@ -425,7 +425,7 @@ int fwts_uefi_get_variable_names(fwts_list *list)\n> return ret;\n> }\n> \n> -static uefistatus_info uefistatus_info_table[] = {\n> +static const uefistatus_info uefistatus_info_table[] = {\n> \t{ EFI_SUCCESS,\t\t\t\"EFI_SUCCESS\",\t\t\t\"The operation completed successfully.\" },\n> \t{ EFI_LOAD_ERROR,\t\t\"EFI_LOAD_ERROR\",\t\t\"The image failed to load.\" },\n> \t{ EFI_INVALID_PARAMETER,\t\"EFI_INVALID_PARAMETER\",\t\"A parameter was incorrect.\" },\n> @@ -466,7 +466,7 @@ static uefistatus_info uefistatus_info_table[] = {\n> void fwts_uefi_print_status_info(fwts_framework *fw, const uint64_t status)\n> {\n> \n> -\tuefistatus_info *info;\n> +\tconst uefistatus_info *info;\n> \n> \tfor (info = uefistatus_info_table; info->mnemonic != NULL; info++) {\n> \t\tif (status == info->statusvalue) {\n> \n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmZys0JdNz9sNq;\n\tTue, 5 Sep 2017 15:29:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dp6QN-00026y-S2; Tue, 05 Sep 2017 05:29:23 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dp6QM-00026k-OA\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:29:22 +0000","from mail-pg0-f71.google.com ([74.125.83.71])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dp6QM-0001ZG-Cn\n\tfor fwts-devel@lists.ubuntu.com; Tue, 05 Sep 2017 05:29:22 +0000","by mail-pg0-f71.google.com with SMTP id q68so5177420pgq.6\n\tfor ;\n\tMon, 04 Sep 2017 22:29:22 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\t70sm11428907pfv.103.2017.09.04.22.29.19\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 22:29:20 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=LFw8Nlj4Ta473RcEtWXMYqsgt9EWQkLWQ0d7H0zce0A=;\n\tb=MEjfys5Y1IVJCxpCaC8Snautfvs4ulyZx2nPLgyEXRRgOLZhd+EGE1GGA8xTd4k2mU\n\tdhfP5/DRiuPLK7A0zjMk1vPRQsgBJ7ruO8zw7oG8IbGf87WVx1gBpMgdA7c+uehQPO4t\n\t0ylaFOK7UKgw/R+sYTHyNy5QYUK70sdtKl0Yq8QO0zqQyz8S4fLjLU6r/5HuQzCd8QPh\n\tEIGkl7AJf1ZWpVBav01fgoUHzGtMcj9KuCMK3OiWwC9OJfBjEkl8EoLKBpiKE5dmhLWR\n\tn2vunoUNSjE913JnjhOC6NRYKFOkX2LGpjNNHdGMZ6i7uKq631la0bTkgdI8Q5VG0FnG\n\tHf9Q==","X-Gm-Message-State":"AHPjjUhf75eqjR3x62rlP31TgFecsvGPFTqTFukUin34SL1x3miYium4\n\tvbSvl+oLurPLMj01xXOcekYN81JOkhX1c8wRQ/5OZqJHDr6ExNUDCUTm6jkbG4dvNWC0xDGvlM0\n\tZSIRVyHhodbSzJXtM980uaLV3kQnYxD0=","X-Received":["by 10.98.204.74 with SMTP id a71mr2636920pfg.126.1504589360938; \n\tMon, 04 Sep 2017 22:29:20 -0700 (PDT)","by 10.98.204.74 with SMTP id a71mr2636914pfg.126.1504589360724; \n\tMon, 04 Sep 2017 22:29:20 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7ptLSN1N/NGnCA/JAvaq9MbaWIc19Jgpwkmtt0lqKV71npz7nDy9tS8QiO6L7j7ZL2VXxPzw==","Subject":"ACK: [PATCH] lib: constify a couple of arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904120920.5932-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"","Date":"Mon, 4 Sep 2017 22:29:19 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904120920.5932-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1763890,"web_url":"http://patchwork.ozlabs.org/comment/1763890/","msgid":"<0373f933-706c-5d7e-6550-bacdb6e9047b@canonical.com>","list_archive_url":null,"date":"2017-09-06T08:17:52","subject":"ACK: [PATCH] lib: constify a couple of arrays","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/04/2017 08:09 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Since these arrays are read-only and static we can also constify them too.\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/src/fwts_log.c | 2 +-\n> src/lib/src/fwts_uefi.c | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/lib/src/fwts_log.c b/src/lib/src/fwts_log.c\n> index 13d5f6ca..1660ae2a 100644\n> --- a/src/lib/src/fwts_log.c\n> +++ b/src/lib/src/fwts_log.c\n> @@ -221,7 +221,7 @@ fwts_log_field fwts_log_str_to_field(const char *text)\n> {\n> \tint i;\n> \n> -\tstatic struct mapping {\n> +\tstatic const struct mapping {\n> \t\tchar *text;\n> \t\tfwts_log_field field;\n> \t} mappings[] = {\n> diff --git a/src/lib/src/fwts_uefi.c b/src/lib/src/fwts_uefi.c\n> index 1f9d31fa..263bd657 100644\n> --- a/src/lib/src/fwts_uefi.c\n> +++ b/src/lib/src/fwts_uefi.c\n> @@ -425,7 +425,7 @@ int fwts_uefi_get_variable_names(fwts_list *list)\n> return ret;\n> }\n> \n> -static uefistatus_info uefistatus_info_table[] = {\n> +static const uefistatus_info uefistatus_info_table[] = {\n> \t{ EFI_SUCCESS,\t\t\t\"EFI_SUCCESS\",\t\t\t\"The operation completed successfully.\" },\n> \t{ EFI_LOAD_ERROR,\t\t\"EFI_LOAD_ERROR\",\t\t\"The image failed to load.\" },\n> \t{ EFI_INVALID_PARAMETER,\t\"EFI_INVALID_PARAMETER\",\t\"A parameter was incorrect.\" },\n> @@ -466,7 +466,7 @@ static uefistatus_info uefistatus_info_table[] = {\n> void fwts_uefi_print_status_info(fwts_framework *fw, const uint64_t status)\n> {\n> \n> -\tuefistatus_info *info;\n> +\tconst uefistatus_info *info;\n> \n> \tfor (info = uefistatus_info_table; info->mnemonic != NULL; info++) {\n> \t\tif (status == info->statusvalue) {\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnGfv2Qdnz9s8J;\n\tWed, 6 Sep 2017 18:17:59 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpVX4-0007fW-5U; Wed, 06 Sep 2017 08:17:58 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpVX2-0007fM-25\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:17:56 +0000","from [175.181.155.140] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpVX1-0002TA-IW\n\tfor fwts-devel@lists.ubuntu.com; Wed, 06 Sep 2017 08:17:55 +0000"],"Subject":"ACK: [PATCH] lib: constify a couple of arrays","To":"fwts-devel@lists.ubuntu.com","References":"<20170904120920.5932-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"<0373f933-706c-5d7e-6550-bacdb6e9047b@canonical.com>","Date":"Wed, 6 Sep 2017 16:17:52 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904120920.5932-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]