[{"id":1771542,"web_url":"http://patchwork.ozlabs.org/comment/1771542/","msgid":"<6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-20T03:52:35","subject":"RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","submitter":{"id":71747,"url":"http://patchwork.ozlabs.org/api/people/71747/","name":"Mani, Rajmohan","email":"rajmohan.mani@intel.com"},"content":"Adding Tomasz...\n\n> -----Original Message-----\n> From: Mohandass, Divagar\n> Sent: Monday, September 04, 2017 3:29 AM\n> To: robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de;\n> sakari.ailus@iki.fi\n> Cc: devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; linux-\n> kernel@vger.kernel.org; Mani, Rajmohan ;\n> Mohandass, Divagar \n> Subject: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n> property \"size\"\n> \n> Obtain the size of the EEPROM chip from DT if the \"size\" property is specified\n> for the device.\n> \n> Signed-off-by: Divagar Mohandass \n> ---\n> drivers/misc/eeprom/at24.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index\n> 764ff5df..2199c42 100644\n> --- a/drivers/misc/eeprom/at24.c\n> +++ b/drivers/misc/eeprom/at24.c\n> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct\n> at24_platform_data *chip)\n> \tif (device_property_present(dev, \"read-only\"))\n> \t\tchip->flags |= AT24_FLAG_READONLY;\n> \n> +\terr = device_property_read_u32(dev, \"size\", &val);\n> +\tif (!err)\n> +\t\tchip->byte_len = val;\n> +\n> \terr = device_property_read_u32(dev, \"pagesize\", &val);\n> \tif (!err) {\n> \t\tchip->page_size = val;\n> --\n> 1.9.1","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxm6X3wccz9s2G\n\tfor ;\n\tWed, 20 Sep 2017 13:52:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751609AbdITDwi convert rfc822-to-8bit (ORCPT\n\t);\n\tTue, 19 Sep 2017 23:52:38 -0400","from mga06.intel.com ([134.134.136.31]:15998 \"EHLO mga06.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751605AbdITDwh (ORCPT );\n\tTue, 19 Sep 2017 23:52:37 -0400","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 19 Sep 2017 20:52:37 -0700","from fmsmsx105.amr.corp.intel.com ([10.18.124.203])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Sep 2017 20:52:36 -0700","from fmsmsx152.amr.corp.intel.com (10.18.125.5) by\n\tFMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Tue, 19 Sep 2017 20:52:36 -0700","from fmsmsx114.amr.corp.intel.com ([169.254.6.69]) by\n\tFMSMSX152.amr.corp.intel.com ([169.254.6.196]) with mapi id\n\t14.03.0319.002; Tue, 19 Sep 2017 20:52:36 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,420,1500966000\"; d=\"scan'208\";a=\"1221249979\"","From":"\"Mani, Rajmohan\" ","To":"\"Mohandass, Divagar\" ,\n\t\"robh+dt@kernel.org\" ,\n\t\"mark.rutland@arm.com\" ,\n\t\"wsa@the-dreams.de\" ,\n\t\"sakari.ailus@iki.fi\" ","CC":"\"devicetree@vger.kernel.org\" ,\n\t\"linux-i2c@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"tfiga@chromium.org\" ","Subject":"RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","Thread-Topic":"[PATCH v6 2/3] eeprom: at24: add support to fetch eeprom\n\tdevice property \"size\"","Thread-Index":"AQHTJWiDXt3pjdNqP0iUn3Z9wjJBKaK9POFg","Date":"Wed, 20 Sep 2017 03:52:35 +0000","Message-ID":"<6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com>","References":"<1504520928-5191-1-git-send-email-divagar.mohandass@intel.com>\n\t<1504520928-5191-3-git-send-email-divagar.mohandass@intel.com>","In-Reply-To":"<1504520928-5191-3-git-send-email-divagar.mohandass@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.1.200.106]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1773722,"web_url":"http://patchwork.ozlabs.org/comment/1773722/","msgid":"","list_archive_url":null,"date":"2017-09-22T16:11:40","subject":"Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan wrote:\n> Adding Tomasz...\n\nPlease, don't top post.\nBetter to resend entire series with all stakeholders included.\n\n>> Obtain the size of the EEPROM chip from DT if the \"size\" property is specified\n>> for the device.\n>>\n\nI guess it lacks\nSuggested-by: Andy Shevchenko \n\nOther than that, looks good to me!\n\nReviewed-by: Andy Shevchenko \n\n\nWolfram, the binding is ACKed by Rob and this one is in a good shape.\nMoreover, it seems like a demand for the property since some IoT stuff\nwould like to use the driver on ACPI enabled platforms with different\nsizes.\n\nCan you go ahead and apply first two patches? It would be really appreciated.\n\n>> Signed-off-by: Divagar Mohandass \n>> ---\n>> drivers/misc/eeprom/at24.c | 4 ++++\n>> 1 file changed, 4 insertions(+)\n>>\n>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index\n>> 764ff5df..2199c42 100644\n>> --- a/drivers/misc/eeprom/at24.c\n>> +++ b/drivers/misc/eeprom/at24.c\n>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct\n>> at24_platform_data *chip)\n>> if (device_property_present(dev, \"read-only\"))\n>> chip->flags |= AT24_FLAG_READONLY;\n>>\n>> + err = device_property_read_u32(dev, \"size\", &val);\n>> + if (!err)\n>> + chip->byte_len = val;\n>> +\n>> err = device_property_read_u32(dev, \"pagesize\", &val);\n>> if (!err) {\n>> chip->page_size = val;\n>> --\n>> 1.9.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c/RC18O2\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzJQ85ggmz9t3w\n\tfor ;\n\tSat, 23 Sep 2017 02:11:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752078AbdIVQLm (ORCPT );\n\tFri, 22 Sep 2017 12:11:42 -0400","from mail-qk0-f193.google.com ([209.85.220.193]:36124 \"EHLO\n\tmail-qk0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752013AbdIVQLl (ORCPT\n\t); Fri, 22 Sep 2017 12:11:41 -0400","by mail-qk0-f193.google.com with SMTP id i14so924591qke.3;\n\tFri, 22 Sep 2017 09:11:41 -0700 (PDT)","by 10.12.134.221 with HTTP; Fri, 22 Sep 2017 09:11:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=6PB+/wS8L93HUOf9nk4KorJHA5g++8l/Yk3Z0Zvu2dM=;\n\tb=c/RC18O2b7X085RBx3Bf4/O7IL4iT1vGX1A6TMR4vHLTEBxqgqslbN2PgsHysNI6bN\n\tUHqA7Mq6gd7ZWj+l5isWbPbh9IgtOG0ObTAe+cLl1k3CEtLaLfCCebGvBBoMFflcwcBB\n\t44tCWG9TtU1QFWPeIDVysj12zgK96bX3kz2vca9VAOgxh5q2JydhdxUDfFNH6jYYm6Ge\n\tAxHCgEEvAjp4YkL5rQjAQlYjCZgHj7OcACi3X8RnqmyJirKuAM7ZfRm/DplVd/4d94uw\n\tC7Jt+9VPr+wQHZclDBNzQE3sIO1ltHe/3XhIXMaANwLMxr4P2LeheHAdNTzG1GIv32cE\n\tV53w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=6PB+/wS8L93HUOf9nk4KorJHA5g++8l/Yk3Z0Zvu2dM=;\n\tb=QSgCwXz6wsnOMKGCNZSsVss5RKsAzYgr9NZT9tnm5KX1JCD+KDpD6soQOwuc5Oai6F\n\tl4GuCHPeyz1DtLWGY8SN3v5lTpDX4/uEuw1h4j+TEEKDK1EFPDgEW7jGueyKdViUQqZ3\n\tOq+/TCNx75KWI8u+IIeSf0gO54GvZ6jnfP/mxcYvnZACizEYJZk6Y348tBCLnN70B/E+\n\t2DmDoB6rKChqWzb55sVpNh1LYIZXsa2lOAMX8QJp+Vy0YE7ZlUtX2HVuY0ucGISl31qM\n\td5huI4FLgOOfuhv/nA+Y1a2N10LKebPeyEDTxe57l61rBIwa5Zy//vRHjsxsYiEcTZtd\n\tQ2gg==","X-Gm-Message-State":"AHPjjUgdkfXTu3AZ0zfTDo1Xf7NQmUvHtGFEz/VEJlGH2DoQdNLVp9MZ\n\t1BXzIqD4Wp+J1Q0sXjKZ14tkYmaUAwSFtktwaS0=","X-Google-Smtp-Source":"AOwi7QBdjZY7WHVw5u46yhY7N7KOTQugWa53OBON5H+a62tfkAFqUfhleV7c2Lq/lvsR12qo0/0evDFyUqBp5mcUNLo=","X-Received":"by 10.55.131.67 with SMTP id f64mr8397196qkd.24.1506096700980;\n\tFri, 22 Sep 2017 09:11:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com>","References":"<1504520928-5191-1-git-send-email-divagar.mohandass@intel.com>\n\t<1504520928-5191-3-git-send-email-divagar.mohandass@intel.com>\n\t<6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com>","From":"Andy Shevchenko ","Date":"Fri, 22 Sep 2017 19:11:40 +0300","Message-ID":"","Subject":"Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","To":"\"Mani, Rajmohan\" ","Cc":"\"Mohandass, Divagar\" ,\n\t\"robh+dt@kernel.org\" ,\n\t\"mark.rutland@arm.com\" ,\n\t\"wsa@the-dreams.de\" ,\n\t\"sakari.ailus@iki.fi\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-i2c@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"tfiga@chromium.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1775171,"web_url":"http://patchwork.ozlabs.org/comment/1775171/","msgid":"<7B8CE47BD58441468D2BB13285B50E6031DF0721@BGSMSX107.gar.corp.intel.com>","list_archive_url":null,"date":"2017-09-26T05:29:06","subject":"RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","submitter":{"id":72054,"url":"http://patchwork.ozlabs.org/api/people/72054/","name":"Divagar Mohandass","email":"divagar.mohandass@intel.com"},"content":"Hi Andy,\r\n\r\nSorry missed the 'Suggested-by' tag. Can I resend the v6 with this change, so that Wolfram can pick these patches ?\r\n\r\n---\r\n^Divagar\r\n\r\n>-----Original Message-----\r\n>From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]\r\n>Sent: Friday, September 22, 2017 9:42 PM\r\n>To: Mani, Rajmohan \r\n>Cc: Mohandass, Divagar ;\r\n>robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de;\r\n>sakari.ailus@iki.fi; devicetree@vger.kernel.org; linux-i2c@vger.kernel.org;\r\n>linux-kernel@vger.kernel.org; tfiga@chromium.org\r\n>Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom\r\n>device property \"size\"\r\n>\r\n>On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan\r\n> wrote:\r\n>> Adding Tomasz...\r\n>\r\n>Please, don't top post.\r\n>Better to resend entire series with all stakeholders included.\r\n>\r\n>>> Obtain the size of the EEPROM chip from DT if the \"size\" property is\r\n>>> specified for the device.\r\n>>>\r\n>\r\n>I guess it lacks\r\n>Suggested-by: Andy Shevchenko \r\n>\r\n>Other than that, looks good to me!\r\n>\r\n>Reviewed-by: Andy Shevchenko \r\n>\r\n>\r\n>Wolfram, the binding is ACKed by Rob and this one is in a good shape.\r\n>Moreover, it seems like a demand for the property since some IoT stuff\r\n>would like to use the driver on ACPI enabled platforms with different sizes.\r\n>\r\n>Can you go ahead and apply first two patches? It would be really appreciated.\r\n>\r\n>>> Signed-off-by: Divagar Mohandass \r\n>>> ---\r\n>>> drivers/misc/eeprom/at24.c | 4 ++++\r\n>>> 1 file changed, 4 insertions(+)\r\n>>>\r\n>>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c\r\n>>> index\r\n>>> 764ff5df..2199c42 100644\r\n>>> --- a/drivers/misc/eeprom/at24.c\r\n>>> +++ b/drivers/misc/eeprom/at24.c\r\n>>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev,\r\n>>> struct at24_platform_data *chip)\r\n>>> if (device_property_present(dev, \"read-only\"))\r\n>>> chip->flags |= AT24_FLAG_READONLY;\r\n>>>\r\n>>> + err = device_property_read_u32(dev, \"size\", &val);\r\n>>> + if (!err)\r\n>>> + chip->byte_len = val;\r\n>>> +\r\n>>> err = device_property_read_u32(dev, \"pagesize\", &val);\r\n>>> if (!err) {\r\n>>> chip->page_size = val;\r\n>>> --\r\n>>> 1.9.1\r\n>>\r\n>\r\n>\r\n>\r\n>--\r\n>With Best Regards,\r\n>Andy Shevchenko","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1Tz73h6mz9t30\n\tfor ;\n\tTue, 26 Sep 2017 15:29:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S935748AbdIZF3V (ORCPT );\n\tTue, 26 Sep 2017 01:29:21 -0400","from mga02.intel.com ([134.134.136.20]:4349 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S934482AbdIZF3U (ORCPT );\n\tTue, 26 Sep 2017 01:29:20 -0400","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Sep 2017 22:29:14 -0700","from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby fmsmga006.fm.intel.com with ESMTP; 25 Sep 2017 22:29:14 -0700","from fmsmsx118.amr.corp.intel.com (10.18.116.18) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Mon, 25 Sep 2017 22:29:14 -0700","from bgsmsx151.gar.corp.intel.com (10.224.48.42) by\n\tfmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Mon, 25 Sep 2017 22:29:13 -0700","from BGSMSX107.gar.corp.intel.com ([169.254.9.43]) by\n\tBGSMSX151.gar.corp.intel.com ([169.254.3.47]) with mapi id\n\t14.03.0319.002; Tue, 26 Sep 2017 10:59:07 +0530"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,439,1500966000\"; d=\"scan'208\";a=\"155993882\"","From":"\"Mohandass, Divagar\" ","To":"Andy Shevchenko ,\n\t\"Mani, Rajmohan\" ","CC":"\"robh+dt@kernel.org\" ,\n\t\"mark.rutland@arm.com\" ,\n\t\"wsa@the-dreams.de\" ,\n\t\"sakari.ailus@iki.fi\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-i2c@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"tfiga@chromium.org\" ","Subject":"RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device\n\tproperty \"size\"","Thread-Topic":"[PATCH v6 2/3] eeprom: at24: add support to fetch eeprom\n\tdevice property \"size\"","Thread-Index":"AQHTJWiECibaB709iEy9EcM98aZcmKK84MWAgAPzKQCABeib4A==","Date":"Tue, 26 Sep 2017 05:29:06 +0000","Message-ID":"<7B8CE47BD58441468D2BB13285B50E6031DF0721@BGSMSX107.gar.corp.intel.com>","References":"<1504520928-5191-1-git-send-email-divagar.mohandass@intel.com>\n\t<1504520928-5191-3-git-send-email-divagar.mohandass@intel.com>\n\t<6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com>\n\t","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.223.10.10]","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]