[{"id":1763596,"web_url":"http://patchwork.ozlabs.org/comment/1763596/","msgid":"<04bb5a08-99fd-5c59-9be6-765a63a06412@redhat.com>","list_archive_url":null,"date":"2017-09-05T19:30:33","subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/04/2017 05:18 AM, Pavel Butsykin wrote:\n> After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this\n> may not happen, because the last call qcow2_store_persistent_dirty_bitmaps()\n> can lead to marking l2/refcont cache as dirty.\n> \n> Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe flushing\n> to fix it.\n> \n> Signed-off-by: Pavel Butsykin \n> ---\n> block/qcow2.c | 16 ++++++++--------\n> 1 file changed, 8 insertions(+), 8 deletions(-)\n> \n\nShould this cc: qemu-stable?\n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmxfK5L5nz9s83\n\tfor ;\n\tWed, 6 Sep 2017 05:31:20 +1000 (AEST)","from localhost ([::1]:32893 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpJZ5-00009E-VG\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 15:31:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43288)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpJYi-00008t-QV\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 15:30:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpJYe-0000UB-7F\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 15:30:52 -0400","from mx1.redhat.com ([209.132.183.28]:45006)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpJYT-0000KZ-Sd; Tue, 05 Sep 2017 15:30:38 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E13F9C0517A5;\n\tTue, 5 Sep 2017 19:30:35 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A07105D6A3;\n\tTue, 5 Sep 2017 19:30:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E13F9C0517A5","To":"Pavel Butsykin , qemu-block@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<20170904101800.22945-1-pbutsykin@virtuozzo.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<04bb5a08-99fd-5c59-9be6-765a63a06412@redhat.com>","Date":"Tue, 5 Sep 2017 14:30:33 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170904101800.22945-1-pbutsykin@virtuozzo.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"j28PvEbAUjD1De7qrKgs8T3mknCSaBPMK\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 05 Sep 2017 19:30:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, den@openvz.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763899,"web_url":"http://patchwork.ozlabs.org/comment/1763899/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:19:25","subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","submitter":{"id":67271,"url":"http://patchwork.ozlabs.org/api/people/67271/","name":"Pavel Butsykin","email":"pbutsykin@virtuozzo.com"},"content":"On 05.09.2017 22:30, Eric Blake wrote:\n> On 09/04/2017 05:18 AM, Pavel Butsykin wrote:\n>> After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this\n>> may not happen, because the last call qcow2_store_persistent_dirty_bitmaps()\n>> can lead to marking l2/refcont cache as dirty.\n>>\n>> Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe flushing\n>> to fix it.\n>>\n>> Signed-off-by: Pavel Butsykin \n>> ---\n>> block/qcow2.c | 16 ++++++++--------\n>> 1 file changed, 8 insertions(+), 8 deletions(-)\n>>\n> \n> Should this cc: qemu-stable?\n\nThe latest stable branch (2.8?) doesn't contain the persistent dirty bitmap.\n\n> Reviewed-by: Eric Blake \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=virtuozzo.com header.i=@virtuozzo.com\n\theader.b=\"AYHX7h4X\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=pbutsykin@virtuozzo.com; "],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnGjS0pMHz9s9Y\n\tfor ;\n\tWed, 6 Sep 2017 18:20:10 +1000 (AEST)","from localhost ([::1]:34911 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpVZA-000562-Kd\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 04:20:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44746)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpVYj-00055a-RR\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:19:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpVYf-0005u8-PY\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:19:41 -0400","from mail-ve1eur01on0117.outbound.protection.outlook.com\n\t([104.47.1.117]:16608\n\thelo=EUR01-VE1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpVYf-0005tk-6r; Wed, 06 Sep 2017 04:19:37 -0400","from [172.16.25.50] (195.214.232.6) by\n\tAM5PR0802MB2548.eurprd08.prod.outlook.com (2603:10a6:203:a1::21) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tWed, 6 Sep 2017 08:19:31 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=zp0AJxZPBwsuZt2JbVE+Zg765CckXA8djQL7ljulqh8=;\n\tb=AYHX7h4XsfTdqr66Ie+M9x9w7TShc4UTJSFcOJAX6k/rMZ3O5fiQc4WhbYUh0S1Wv3uMgwDTRzJ6yv41ypESpSmg7dobkAxN4br9VSchzwWsWAUf+StlXtxUXiMozEjiDePz92xGbOaUDc+z6way7SZhQH2iTzAn41VoX5v7jxw=","To":"Eric Blake , qemu-block@nongnu.org,\n\tqemu-devel@nongnu.org","References":"<20170904101800.22945-1-pbutsykin@virtuozzo.com>\n\t<04bb5a08-99fd-5c59-9be6-765a63a06412@redhat.com>","From":"Pavel Butsykin ","Message-ID":"","Date":"Wed, 6 Sep 2017 11:19:25 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<04bb5a08-99fd-5c59-9be6-765a63a06412@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"quoted-printable","X-Originating-IP":"[195.214.232.6]","X-ClientProxiedBy":"DB6PR02CA0028.eurprd02.prod.outlook.com\n\t(2603:10a6:6:15::41) To AM5PR0802MB2548.eurprd08.prod.outlook.com\n\t(2603:10a6:203:a1::21)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"a7ce04cf-927c-457d-513a-08d4f50000ae","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM5PR0802MB2548; ","X-Microsoft-Exchange-Diagnostics":["1; AM5PR0802MB2548;\n\t3:9cP6en/a5ZyAsxjneNDz7ChM5i51a0/AZIEC4OlwQOpOTxCQ8cnmelCtD7SHZwzHww4Uiun2NBUsSIPt75Bs2B/wF8TxP7Z3RbQAwXQkt4qcTwB3yg7JVp2FlWSiojhyj6YdL4YU08M0CBgF/mZU33A+24fzsXEuzSgtEFdhEjRLHyFf2sAt4qUNP31OopNVgniu8D/6+jQcufGuJkUu2y7VBQVD8kciyjou8xOoHn6zDqxYzi91gJLHgHwEZpGF;\n\t25:2JBGx3Uk9sOc6dMJck5NHODSdyn5qiRZdotVN8sgbYGEjfKkjrobb07hgP/jHsN+InkJM4eEAJlTrf5hlAhHH9uZ5zEqJQn3QPLNrEGD/pf7IJv4Wkur8BaAUs+1kwqi5MhRFrlVJZ9lOQDZBp2rHlACmXAw8tRhtzhN0B5dJgztaKdkxCd6LxHuL2Ud3QwGN6eBd0Bk7uCkgAsQH+vYMZfCbcH179bNbk2QI5+6/d33YdO3uhnotxHWJ3IlpjKlHeU+OQPbp3B83PXRVSUWdleenRUGXj3FCtqi+eXr+02SeL0KC6L4wY3KdjOjManztvRPsy1XeMZ0p4O42MaA7g==;\n\t31:PomPpqgFH7nPu+EUj7d4mLa0KSWbkCc14Nd3j/9j02G2e+1fNW4j5/HJgoyNx0WPNG838+Xx/j3t7/y0mxDVvQXybYdOgCR/yYBE3HDQWcLS46gncydJ/TGC8QInT2cKhI049+Xm46UoylziBIbzZNpm/U2riDigKOKO8Csjo2OlYfuTrYYPe4rV7Ndx++lj4JQ+udcA+Lsmj1OI1aNztIjf7O6bf5HkdDaM2hl7umc=","1; AM5PR0802MB2548;\n\t20:ix+BlBD6e2yJYkv2hS1/Y31uviJN2DwIlrZ+ZW0EqH5B5cBGQtcxg7lkLWScBQrzcEtUVxR8HgDLcs6aAXHJD/JqkGC1vw0hNbvJGkNMx8SZw8twi6PWIvSI2MMEutRD6oQFKYB7th7U3hUaIi5yeQ1I7WS9dReB54ju7XdPy8n6sTqUbEhpwPB44c4En+MOEDL/8/wHKOeDj+4z/E5dwVa7lGCasSeI/46zxHf1jxpxVEnnFvmAJy50f2y3smmQGZgGxFILR8O6ZjP2WXbJB0gdFviGR9AV/Zw3kJNLijXxAzxg8bVgadRmQg0WrbEIT69R9r95WQ8/2E0BFGsS9zQIdD/gF0+kVgb39AQXHr+37V/TI609yh85gpy3aGO6l/a7kIw9dbAXJVETcUbTeYFG4KI0XMbcQx0i0AXCFSw=;\n\t4:8yiRXgQvkGJD4r66TbVfsjOO02QPaxTxhPxZohe0YHUcIKr9ltyLb4LWY9zqJeyWuYH8kTnSTwITHcJMSSFFZszg6/thzHH0QdF34BI0HlmtSJmL7Or3L0f7i4ijSm2plWC+CVI/QfxPtT+S4zw5XbpPUl0SaaUXw/WzSggq5P3uubqQ5fKxhh6c6kVgMItGy8OUbmxc46vwINVQlQz64s6OiX5zVzXSNA/MWJpyE3XFTRWg0rqYzH1k9M0bd1oT","=?us-ascii?Q?1; AM5PR0802MB2548;\n\t23:xBIsYrbESuKg+YEQj8izpth/SkeguXXBAh+MZhL?=\n\t4f2LgMlERNi2lDYVtD3rJK4TR4ZqMSHJt9SnmrtKbieQ/5tHLcKFv/W6RW13V1Mf3s78qwPLToHAcxQAm3jjLcus0GcXs/ue3xVQ3tIEYxlH9aGQ7mNqYmMHSYnTI8VeA99XkQiGYwELx7HFHcJ5WR6jx0auglLSEMBRbIzIVii+Wm+z/X+OlmZEO+Um851QJZHUZAbMeemzuWp2YIDmrPp6zs77MmrkqpV8TXMgQLHuuiLdx8Q+w4MMse0ixSMCDrsKzlecsqIA6gx0OtZzzHkpCBvyHpCMH4f+NHTZLKzVrIwR38OXRh0knapzB7LtQWyGjAgQR0aYzGBVhOpzL0RynKhb8GRtTPKVxuiS+V25kmpgHlRsHMnlTNCHxuWZU3VWC7VdCJnFEhEfPdI53NwgXbH9uyV6eirxPdXMZJ8nOPo5ztTdBI7FIILDKzmzl/8iAKZ4bcctmMbWH34oc9xVdjFqWiGO2OqFBqZ3tp+4FqQuN6FrHt1QVeQR0UekD6i98NiAKW+v6NRsj3srXzF4Gllt9YHtQ6RO+Wnl+4X6uq5mowSmXOWMTfuCQSWrF6wra+pEmYOt2M1tdUIefuk3ARpRL3MYZOwvqPqrz3hHVgeIXKq/iAxoHE0p4Xc20p9bnDhUQTooo+dLYgrdiuB6+V8/zvJC+nisafyvsnK3DmNyi8NC93ZgYE33YKewuaWWI7uEzRvOrG9TnG3moLJcqMkr27MC6LyzUBwfqVfD5qxetivNai8iN5YraWqYmOlrcCPBTWu0DS7VvBHT1gQBcJfR7VjegMPT7u1/x0HgP0oy+mP5Zsj/vpoJPIW92cXaLjB1XU9+KsVEqj7w6YgI++TMzE7zfSaiMRxfqjzsaD4PK3xXFvutDCEOqn3I32nM4Spb+gRTcqneFxx1obcwpOhsCEYZzabTsdiOf/VpA/TjkBksuUbxiFospudhJ+Gi3Sx9Vucqsu/myWWHDtxhhHOoGPiOc8zyG18PgM8txAIcZAfuP8nInhyi3+FUWOCm5cWFYmLO5Jyv9SbWa0/Xp7I4Yvz3URDXCRKAX7mITt3gSILvm37jTluD7bnCOW6XvBk3Nepotz1fx0YrRGHznIfEvxxqBRgRQDT2LrzrtNzHSt2TdsO2Kw97Ohs+sdCwuXOjMxxJSCcZZMVP2qWkup1K6SWpa0ykQtqakcO0rocutbyPk6ejG4iMzClUF43K9NZRE9LpDviHswnkK28ivUQd1yxBj6lKoDfX4dMmxPtSGaW7OFNQ/Hd70AVFkIQ7ch1PZhBDnIN7s/7/hwu5y+hacijHJONk6Tkm5F6e/CZmSyBEZuydOKDsUzTfeAdwo1MlmK5IBe+djTBwvURqt","1; AM5PR0802MB2548;\n\t6:FmV6IDGa3U6kRYz9ZTH+enoa+1i0NxpqSe2HLKbgcEJCCRPuJWqt3EwzKXrdHYJWG6FbRFMabA2pkZ1JvuRTXEtBubmwz1fNxyXy0lNMfti4puYGhISCXvmIFS1MMGkmmnhzRqo7UTTmdmfQierhZWquA7DHn0fQNZcjPDiiVV53mebck4LjeAA3nMIwPuqPkiYBuW3hEPoC+HcuxBGfZHe+P8TQ9Z1p5P9WK9kEO8EObVR+QOmysekCH2+VtpR73XruUqajOB1wbHYc6Y2Gg6lmJbhgAJKUJe+cYMXbSKomKNrlOPnAk8ZHuvOxry5cLKBwLNbnZHi/OVclL0eY3w==;\n\t5:vgGETYss0gP3Y/DF3/me6t5aQGbiVG1BKywYQHBHzVDVlKpobDq+hcy22R6XOxgaj0DArO5LB896CUehFR7ftPyWiHU39tAmt4C3hJKQL6zIK70k2QIxhfwfTnSjgk55eap5n+yO2/B28e70UgwyOQ==;\n\t24:g9RoKOLI78m8kYWzlw4SfG+vPIO0MyeMnZ90nsQhj8BBjOTLx+fTCNG26BcfALtCMtiV+ldYN2Ioc/TCvk/jcQaIRYM+CoE44iRhpy7KMxs=;\n\t7:h21X3uo//9YHk75+i2HSpQ/S4y5kdCDQ4sxy5fW4vegpZAPiJyAm5laPBwq1oH7aQ/58LKCLsJiz1ihytNyCX+d4FOSG6SDBANkL8TwceO57+TjZAo+UV1AOPjc83nUuJnjHHlI8DJ/rKP/kW0437B3+a+utF4vKF8GqAMrB9WkxRgIoSX/OQNU1OvDKkO330AvQ8bgVyEm30wim4aPLxUpylbF3XPKku1Yf9qdS8C4=","1; AM5PR0802MB2548;\n\t20:f7wY+N3WmZsctcS2Ffm2bRVtB52Ja9rFPkV2Jl1NUQs61QkW82sf1SzmTDs0ITGwJx+zOc6DjMWO5KnsR9VbIsnxwaaPqdPdbfjH7KksmbCeRvnu4fJ9KafyalwPIXdnugvVm5GNd/sbh+z/XZUam35hXR/UWGJt7oveUIp48mk="],"X-MS-TrafficTypeDiagnostic":"AM5PR0802MB2548:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM5PR0802MB2548; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM5PR0802MB2548; ","X-Forefront-PRVS":"0422860ED4","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(4630300001)(7370300001)(6049001)(6009001)(189002)(199003)(377454003)(24454002)(68736007)(65826007)(189998001)(2906002)(5660300001)(2950100002)(6666003)(76176999)(50986999)(110136004)(101416001)(54356999)(50466002)(6246003)(33646002)(53936002)(23676002)(8676002)(42186005)(81156014)(105586002)(31696002)(2870700001)(81166006)(106356001)(7736002)(305945005)(478600001)(86362001)(65956001)(97736004)(66066001)(4001350100001)(65806001)(4326008)(53546010)(229853002)(31686004)(64126003)(36756003)(3846002)(25786009)(7350300001)(83506001)(6116002)(47776003)(77096006)(6486002)(15760500002)(14143004);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0802MB2548; H:[172.16.25.50];\n\tFPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: virtuozzo.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"virtuozzo.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"06 Sep 2017 08:19:31.9280\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM5PR0802MB2548","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.1.117","Subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, den@openvz.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764072,"web_url":"http://patchwork.ozlabs.org/comment/1764072/","msgid":"<20170906124050.GG3753@dhcp-200-186.str.redhat.com>","list_archive_url":null,"date":"2017-09-06T12:40:50","subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 06.09.2017 um 10:19 hat Pavel Butsykin geschrieben:\n> On 05.09.2017 22:30, Eric Blake wrote:\n> > On 09/04/2017 05:18 AM, Pavel Butsykin wrote:\n> > > After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this\n> > > may not happen, because the last call qcow2_store_persistent_dirty_bitmaps()\n> > > can lead to marking l2/refcont cache as dirty.\n> > > \n> > > Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe flushing\n> > > to fix it.\n> > > \n> > > Signed-off-by: Pavel Butsykin \n> > > ---\n> > > block/qcow2.c | 16 ++++++++--------\n> > > 1 file changed, 8 insertions(+), 8 deletions(-)\n> > > \n> > \n> > Should this cc: qemu-stable?\n> \n> The latest stable branch (2.8?) doesn't contain the persistent dirty bitmap.\n\nCc: qemu-stable would now be for qemu 2.10.1, which I think does need\nthe fix. I'm adding the tag.\n\nThanks, applied to the block branch.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNWV0kfgz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 22:41:58 +1000 (AEST)","from localhost ([::1]:36022 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpZeW-0006x9-86\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 08:41:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48766)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpZdu-0006sN-JB\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 08:41:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpZdo-0007Ut-Oi\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 08:41:18 -0400","from mx1.redhat.com ([209.132.183.28]:56518)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpZdX-0007OG-5N; Wed, 06 Sep 2017 08:40:55 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DDB554E4CA;\n\tWed, 6 Sep 2017 12:40:53 +0000 (UTC)","from dhcp-200-186.str.redhat.com (dhcp-200-186.str.redhat.com\n\t[10.33.200.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 43CF57E828;\n\tWed, 6 Sep 2017 12:40:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DDB554E4CA","Date":"Wed, 6 Sep 2017 14:40:50 +0200","From":"Kevin Wolf ","To":"Pavel Butsykin ","Message-ID":"<20170906124050.GG3753@dhcp-200-186.str.redhat.com>","References":"<20170904101800.22945-1-pbutsykin@virtuozzo.com>\n\t<04bb5a08-99fd-5c59-9be6-765a63a06412@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 06 Sep 2017 12:40:54 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] qcow2: move\n\tqcow2_store_persistent_dirty_bitmaps() before cache flushing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"den@openvz.org, qemu-devel@nongnu.org, qemu-block@nongnu.org,\n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]