[{"id":1762347,"web_url":"http://patchwork.ozlabs.org/comment/1762347/","msgid":"<1526a6b4-1962-256d-1ada-ef9c7d95e6b1@arm.com>","list_archive_url":null,"date":"2017-09-03T23:37:58","subject":"Re: [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","submitter":{"id":61837,"url":"http://patchwork.ozlabs.org/api/people/61837/","name":"Andre Przywara","email":"andre.przywara@arm.com"},"content":"Hi,\n\nOn 03/09/17 23:40, Stefan Brüns wrote:\n> The A64 SoC has the same dma engine as the H3 (sun8i), with a\n> reduced amount of physical channels. To allow future reuse of the\n> compatible, leave the channel count etc. in the config data blank\n> and retrieve it from the devicetree.\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> drivers/dma/sun6i-dma.c | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c\n> index bd4c2e4a759b..4fae7ffad549 100644\n> --- a/drivers/dma/sun6i-dma.c\n> +++ b/drivers/dma/sun6i-dma.c\n> @@ -1076,6 +1076,16 @@ static struct sun6i_dma_config sun8i_h3_dma_cfg = {\n> \t.nr_max_vchans = 34,\n> \t.dmac_variant = DMAC_VARIANT_H3,\n> };\n> +\n> +/*\n> + * The A64 binding uses the number of dma channels from the\n> + * device tree node.\n> + */\n> +static struct sun6i_dma_config sun50i_a64_dma_cfg = {\n> +\t.nr_max_channels = 0,\n> +\t.nr_max_requests = 0,\n\nBut this does not work with the \"dma-requests\" property being optional\naccording to the binding spec? Either we put the value for the A64 in\nhere (and thus force the R40 and others to specify this in the DT) or we\nmap the \"0\" from struct config to DMA_CHAN_MAX_DRQ in the probe function.\n\n> +\t.nr_max_vchans = 0,\n> +\t.dmac_variant = DMAC_VARIANT_H3,\n> };\n> \n> static const struct of_device_id sun6i_dma_match[] = {\n> @@ -1083,6 +1093,7 @@ static const struct of_device_id sun6i_dma_match[] = {\n> \t{ .compatible = \"allwinner,sun8i-a23-dma\", .data = &sun8i_a23_dma_cfg },\n> \t{ .compatible = \"allwinner,sun8i-a83t-dma\", .data = &sun8i_a83t_dma_cfg },\n> \t{ .compatible = \"allwinner,sun8i-h3-dma\", .data = &sun8i_h3_dma_cfg },\n> +\t{ .compatible = \"allwinner,sun50i-a64-dma\", .data = &sun50i_a64_dma_cfg },\n> \t{ /* sentinel */ }\n> };\n> MODULE_DEVICE_TABLE(of, sun6i_dma_match);\n> @@ -1090,6 +1101,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);\n> static int sun6i_dma_probe(struct platform_device *pdev)\n> {\n> \tconst struct of_device_id *device;\n> +\tstruct device_node *np = pdev->dev.of_node;\n\nIs this some rebase/split artefact?\n\nCheers,\nAndre.\n\n> \tstruct sun6i_dma_dev *sdc;\n> \tstruct resource *res;\n> \tint ret, i;\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"gZ1BXpmS\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlqJY5q64z9t0F\n\tfor ;\n\tMon, 4 Sep 2017 09:42:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doeWg-0001to-0n; Sun, 03 Sep 2017 23:42:02 +0000","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]\n\thelo=foss.arm.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doeWc-0001ro-O3 for linux-arm-kernel@lists.infradead.org;\n\tSun, 03 Sep 2017 23:42:00 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A08515A2;\n\tSun, 3 Sep 2017 16:41:38 -0700 (PDT)","from [192.168.3.22] (usa-sjc-mx-foss1.foss.arm.com\n\t[217.140.101.70])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t8E0263F58F; Sun, 3 Sep 2017 16:41:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=2mgj5p2UQCCLr0BH/h0bK1UVgO6J4wPxpciEBKHqxqM=;\n\tb=gZ1BXpmSKjeGqq\n\tnahLgf3Am3FFAiKH+CRkJ64Tf/RqEo4RhVxoGGHWssdaXRH+fkcVYSdNuELVq8So9/T4Sk1H+pg9b\n\t4mU+hCuLjE3dOS6bh7XIZgDp3uMQf/aNFZpFtcdVuF0W7Ld71QSEadCfojfGUG5fB3R2inoohmfzD\n\tIwgU1M2MUXnd1CCTth5SFSYdJ21dX/TvXOgstCLKCnQwEcpyTubBft1WdpcKYQ1mdhX7VyXg6x7WH\n\tXk/27YnmqRE6I/RstUiiz7suid1VSRclaESFEnJUSh1U1R7ioFsaOfjIf/5Cwd+23H+9ztjzh0Mr9\n\txuxvkWHolGQHydEQPrvw==;","Subject":"Re: [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","To":"=?utf-8?q?Stefan_Br=C3=BCns?= ,\n\tlinux-sunxi@googlegroups.com","References":"<20170903224100.17893-1-stefan.bruens@rwth-aachen.de>\n\t<20170903224100.17893-9-stefan.bruens@rwth-aachen.de>","From":"=?utf-8?q?Andr=C3=A9_Przywara?= ","Organization":"ARM Ltd.","Message-ID":"<1526a6b4-1962-256d-1ada-ef9c7d95e6b1@arm.com>","Date":"Mon, 4 Sep 2017 00:37:58 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170903224100.17893-9-stefan.bruens@rwth-aachen.de>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170903_164158_793678_35D14B06 ","X-CRM114-Status":"GOOD ( 16.42 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Vinod Koul ,\n\tlinux-kernel@vger.kernel.org, Code Kipper ,\n\tChen-Yu Tsai , Rob Herring ,\n\tdmaengine@vger.kernel.org,\n\tMaxime Ripard , \n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1762355,"web_url":"http://patchwork.ozlabs.org/comment/1762355/","msgid":"<5368262.YgOfWCUmp3@pebbles.site>","list_archive_url":null,"date":"2017-09-04T00:13:15","subject":"Re: [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","submitter":{"id":67055,"url":"http://patchwork.ozlabs.org/api/people/67055/","name":"Stefan Brüns","email":"stefan.bruens@rwth-aachen.de"},"content":"On Montag, 4. September 2017 01:37:58 CEST André Przywara wrote:\n\n> > @@ -1090,6 +1101,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);\n> > \n> > static int sun6i_dma_probe(struct platform_device *pdev)\n> > {\n> > \n> > \tconst struct of_device_id *device;\n> > \n> > +\tstruct device_node *np = pdev->dev.of_node;\n> \n> Is this some rebase/split artefact?\n> \n> Cheers,\n> Andre.\n> \n\nYes, that one should be in patch 7/10 ...\n\nKind regards,\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"d9oHRdxj\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlr1650cvz9s8J\n\tfor ;\n\tMon, 4 Sep 2017 10:13:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dof1L-0005Rd-Ux; Mon, 04 Sep 2017 00:13:43 +0000","from mail-out-1.itc.rwth-aachen.de ([134.130.5.46])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dof1G-0005PC-7I for linux-arm-kernel@lists.infradead.org;\n\tMon, 04 Sep 2017 00:13:42 +0000","from rwthex-w2-b.rwth-ad.de ([134.130.26.159])\n\tby mail-in-1.itc.rwth-aachen.de with ESMTP; 04 Sep 2017 02:13:16 +0200","from pebbles.site (92.225.242.208) by rwthex-w2-b.rwth-ad.de\n\t(2002:8682:1a9f::8682:1a9f) with Microsoft SMTP Server (TLS) id\n\t15.0.1320.4; Mon, 4 Sep 2017 02:13:15 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=54L+h+6+mf7FXD9rn6NLGEBnjMyqRanr+6bpfNtEwrE=;\n\tb=d9oHRdxjIjOHAb\n\tn/SQDVUBjzSTdroxIjhGepIq0j42tAJVkFkNbTkTQ5vzflec/hchecMEYxGrQ53SFCBrdKeHIrvBa\n\t0z6ECJ7jYg0dad7sRrJEqEUl7jKkir8jFSSPKngYrCQnML+v9e7c4wea5FEYuC0JCA6zVlvu4lof0\n\t22h/efyDKFQbkkg4tlMLCmRZirdYjxOk/Qi/nB4dOBarbMijPpYUKxfxo3f0F5IeSH/ijvrPeRMas\n\t2wHoVQlanlZm74wW+lwYVBIaHKRw0KOFT1SMLDwDuqO+bE5V1Q5ACkEPgX//Edv5tt1oQxRl2MvAI\n\tB/m49z6ypWU5dBExYlAA==;","X-IronPort-AV":"E=Sophos;i=\"5.41,472,1498514400\"; d=\"scan'208\";a=\"11608015\"","From":"Stefan Bruens ","To":"=?iso-8859-1?q?Andr=E9?= Przywara ","Subject":"Re: [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","Date":"Mon, 4 Sep 2017 02:13:15 +0200","Message-ID":"<5368262.YgOfWCUmp3@pebbles.site>","In-Reply-To":"<1526a6b4-1962-256d-1ada-ef9c7d95e6b1@arm.com>","References":"<20170903224100.17893-1-stefan.bruens@rwth-aachen.de>\n\t<20170903224100.17893-9-stefan.bruens@rwth-aachen.de>\n\t<1526a6b4-1962-256d-1ada-ef9c7d95e6b1@arm.com>","MIME-Version":"1.0","X-Originating-IP":"[92.225.242.208]","X-ClientProxiedBy":"rwthex-w2-b.rwth-ad.de (2002:8682:1a9f::8682:1a9f) To\n\trwthex-w2-b.rwth-ad.de (2002:8682:1a9f::8682:1a9f)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170903_171340_668956_58214960 ","X-CRM114-Status":"UNSURE ( 5.95 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [134.130.5.46 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Vinod Koul ,\n\tlinux-kernel@vger.kernel.org, Code Kipper ,\n\tlinux-sunxi@googlegroups.com, Rob Herring ,\n\tdmaengine@vger.kernel.org,\n\tMaxime Ripard , \n\tChen-Yu Tsai , linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]