[{"id":1767248,"web_url":"http://patchwork.ozlabs.org/comment/1767248/","msgid":"<20170912165220.yj4bcpd4yg3wujyh@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T16:52:20","subject":"Re: [PATCH 06/10] arm64: allwinner: a64: Add devicetree binding for\n\tDMA controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 04, 2017 at 12:40:57AM +0200, Stefan Brüns wrote:\n> The A64 is register compatible with the H3, but has a different number\n> of dma channels and request ports.\n> \n> Attach additional properties to the node to allow future reuse of the\n> compatible for controllers with different number of channels/requests.\n> \n> If dma-requests is not specified, the register layout defined maximum\n> of 32 is used.\n\nThis belongs in the binding.\n\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> index 6b267045f522..66195fb31296 100644\n> --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> @@ -26,6 +26,32 @@ Example:\n> \t\t#dma-cells = <1>;\n> \t};\n> \n> +------------------------------------------------------------------------------\n> +For A64 DMA controller:\n> +\n> +Required properties:\n> +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> +- dma-channels: Number of DMA channels supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n\ndma.txt already explains what these properties are. You just need to \nstate what are valid values.\n\n> +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells\n> +\n> +Optional properties:\n> +- dma-requests: Number of DMA request signals supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> +\n> +Example:\n> +\tdma: dma-controller@01c02000 {\n\nDrop the leading 0. Building dtbs with W=2 will tell you this.\n\n> +\t\tcompatible = \"allwinner,sun50i-a64-dma\";\n> +\t\treg = <0x01c02000 0x1000>;\n> +\t\tinterrupts = ;\n> +\t\tclocks = <&ccu CLK_BUS_DMA>;\n> +\t\tdma-channels = <8>;\n> +\t\tdma-requests = <27>;\n> +\t\tresets = <&ccu RST_BUS_DMA>;\n> +\t\t#dma-cells = <1>;\n> +\t};\n> +------------------------------------------------------------------------------\n> +\n> Clients:\n> \n> DMA clients connected to the A31 DMA controller must use the format\n> -- \n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"U6bvPB0c\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs9p84FN5z9s3T\n\tfor ;\n\tWed, 13 Sep 2017 02:52:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1droQX-0000OK-MQ; Tue, 12 Sep 2017 16:52:45 +0000","from mail-io0-f193.google.com ([209.85.223.193])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1droQU-0000N1-Ih for linux-arm-kernel@lists.infradead.org;\n\tTue, 12 Sep 2017 16:52:44 +0000","by mail-io0-f193.google.com with SMTP id d16so8222320ioj.2\n\tfor ;\n\tTue, 12 Sep 2017 09:52:22 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tu144sm13484810oie.11.2017.09.12.09.52.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 09:52:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=4LWhw11G5MrBvkj4MA9pt1bC4K0+kecErZtU/SFRtfA=;\n\tb=U6bvPB0cyf5HSv\n\tRPy3hXu4cWb5Y9RgETucQtEY7D5Ds+fXWO6BiSDfJfaJbiT/mu++1AD8tuPxNx+R3VR5nL6W9s5mT\n\tmqhr0vtjpetqmlfHkl+s3lTwKgg4RA+XR54v1DlwpoiESg1NZIVA6G0OFsKqg9PQyaDnqCTWduUW3\n\ttV1/zkEUb6tfrGm+9S3IlnOEV0+GfkynuDkJUbNhKpbALWGQX/NkR442/NagCFLe1ps5iR/nPMGVQ\n\tRuqEwAZtSmInfOHAt1FKUx34XLD+OC1nHOzIBsayhoufdjD++SWzXNecItO2GsExv1MGFtTY5gnJ5\n\tW41AO+sGAi8cgOAbd/jg==;","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=IhRPjEkBnFxHEt8R1srIIlFqB3y7VxFDkr1DAHfmV2Q=;\n\tb=KslrGd+CVJlPhJWT81PWd9QMpuSgWDtdqjajMLU+6N3hh469J4DV7+uVPAQCW1161c\n\tl6AnFtNZ+nULgHCqJSn7OuMHgJCh9UkTSvf+4CUYqrz15nKxLBtahaqNTbK4jtfoZIya\n\tt9a4+Wfuznd1c7oKsVuWnRPjoTV/j0Kp1h2cP7dzHrUivVpxniDBbZB0gxPsGxhnnpDv\n\tdp+8AAnaFcQ3YXuarakW+WbhV7jo7L197LoRUFBpi58MYdleuuY6YEAqi5c0vN81RC/s\n\tKUntZbGAlcTEIoiMxW6ZwJ0cxZSimgdfYUC2cD7d0GFxf4eC7Z0S0nibCfZZvXxDFUzP\n\t3w9A==","X-Gm-Message-State":"AHPjjUj2M7lMkrqCfXAOeFlT4wjBtqygNBWYWIrzkaYWImEBOpTlFlxX\n\terxWI2gtCa78Ug==","X-Google-Smtp-Source":"AOwi7QCBma72ofRog4X4/XyGbe7+eBenjAIfVFxvvHHdMstV/i4/WqcXdtsFCPm8Spmvt0yMCvl2hg==","X-Received":"by 10.202.242.197 with SMTP id\n\tq188mr2141630oih.136.1505235141516; \n\tTue, 12 Sep 2017 09:52:21 -0700 (PDT)","Date":"Tue, 12 Sep 2017 11:52:20 -0500","From":"Rob Herring ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Subject":"Re: [PATCH 06/10] arm64: allwinner: a64: Add devicetree binding for\n\tDMA controller","Message-ID":"<20170912165220.yj4bcpd4yg3wujyh@rob-hp-laptop>","References":"<20170903224100.17893-1-stefan.bruens@rwth-aachen.de>\n\t<20170903224100.17893-7-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170903224100.17893-7-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_095242_664282_0E5D7791 ","X-CRM114-Status":"GOOD ( 14.52 )","X-Spam-Score":"-3.8 (---)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-3.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [209.85.223.193 listed in list.dnswl.org]\n\t0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source\n\t[209.85.223.193 listed in dnsbl.sorbs.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (robherring2[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (robherring2[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[209.85.223.193 listed in wl.mailspike.net]\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Vinod Koul ,\n\tAndre Przywara , linux-kernel@vger.kernel.org,\n\tCode Kipper , linux-sunxi@googlegroups.com,\n\tdmaengine@vger.kernel.org,\n\tMaxime Ripard , \n\tChen-Yu Tsai , linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]