[{"id":1767247,"web_url":"http://patchwork.ozlabs.org/comment/1767247/","msgid":"<20170912165220.yj4bcpd4yg3wujyh@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T16:52:20","subject":"Re: [PATCH 06/10] arm64: allwinner: a64: Add devicetree binding for\n\tDMA controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 04, 2017 at 12:40:57AM +0200, Stefan Brüns wrote:\n> The A64 is register compatible with the H3, but has a different number\n> of dma channels and request ports.\n> \n> Attach additional properties to the node to allow future reuse of the\n> compatible for controllers with different number of channels/requests.\n> \n> If dma-requests is not specified, the register layout defined maximum\n> of 32 is used.\n\nThis belongs in the binding.\n\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> index 6b267045f522..66195fb31296 100644\n> --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> @@ -26,6 +26,32 @@ Example:\n> \t\t#dma-cells = <1>;\n> \t};\n> \n> +------------------------------------------------------------------------------\n> +For A64 DMA controller:\n> +\n> +Required properties:\n> +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> +- dma-channels: Number of DMA channels supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n\ndma.txt already explains what these properties are. You just need to \nstate what are valid values.\n\n> +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells\n> +\n> +Optional properties:\n> +- dma-requests: Number of DMA request signals supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> +\n> +Example:\n> +\tdma: dma-controller@01c02000 {\n\nDrop the leading 0. Building dtbs with W=2 will tell you this.\n\n> +\t\tcompatible = \"allwinner,sun50i-a64-dma\";\n> +\t\treg = <0x01c02000 0x1000>;\n> +\t\tinterrupts = ;\n> +\t\tclocks = <&ccu CLK_BUS_DMA>;\n> +\t\tdma-channels = <8>;\n> +\t\tdma-requests = <27>;\n> +\t\tresets = <&ccu RST_BUS_DMA>;\n> +\t\t#dma-cells = <1>;\n> +\t};\n> +------------------------------------------------------------------------------\n> +\n> Clients:\n> \n> DMA clients connected to the A31 DMA controller must use the format\n> -- \n> 2.14.1\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs9nh503Yz9s3T\n\tfor ;\n\tWed, 13 Sep 2017 02:52:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751405AbdILQwX (ORCPT\n\t);\n\tTue, 12 Sep 2017 12:52:23 -0400","from mail-io0-f196.google.com ([209.85.223.196]:37500 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751217AbdILQwW (ORCPT\n\t); Tue, 12 Sep 2017 12:52:22 -0400","by mail-io0-f196.google.com with SMTP id 93so8292270iol.4;\n\tTue, 12 Sep 2017 09:52:21 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tu144sm13484810oie.11.2017.09.12.09.52.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 09:52:20 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=IhRPjEkBnFxHEt8R1srIIlFqB3y7VxFDkr1DAHfmV2Q=;\n\tb=hHrY+zu0A0Rjpqbghw5NXK4pcZAc29lbw41XQXU+XXAhom4MnIiDgarZTmOhos7fj1\n\t2Jx+JyUDynwOw+2QWVS1kSSQkUh0mVh3DqlBY8KI3KP5S4vpIaReqlfxIROrmkfsWqWC\n\tmwu+gmqe/1eJPpkds76hnCRhBkj5Ilno96MyqLfLp1OXSnc+/oC2qnh/zL7zlYrhsVJ5\n\t40z0pH8QiH1w4kNNVjyR5ZWUFgGaQKCvlVJzy7A0MFyYVvY3Z8FwKMMHt1xfJHSN70ke\n\t2o1hFLjB7CyWJBAL4j45SKmx41VCr+ZeLdlIfTYQe5oJrYp8U9jPvq4IIxjE17B5IKGk\n\t+nTQ==","X-Gm-Message-State":"AHPjjUi4DzMtSLiuIgPipy0sYdg27AnPdOvJ5sLYsPSivPwpWrkNdoKN\n\tjxNLTjszU/x7uw==","X-Google-Smtp-Source":"AOwi7QCBma72ofRog4X4/XyGbe7+eBenjAIfVFxvvHHdMstV/i4/WqcXdtsFCPm8Spmvt0yMCvl2hg==","X-Received":"by 10.202.242.197 with SMTP id\n\tq188mr2141630oih.136.1505235141516; \n\tTue, 12 Sep 2017 09:52:21 -0700 (PDT)","Date":"Tue, 12 Sep 2017 11:52:20 -0500","From":"Rob Herring ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Cc":"linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,\n\tdmaengine@vger.kernel.org, Vinod Koul ,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Code Kipper ,\n\tAndre Przywara ","Subject":"Re: [PATCH 06/10] arm64: allwinner: a64: Add devicetree binding for\n\tDMA controller","Message-ID":"<20170912165220.yj4bcpd4yg3wujyh@rob-hp-laptop>","References":"<20170903224100.17893-1-stefan.bruens@rwth-aachen.de>\n\t<20170903224100.17893-7-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170903224100.17893-7-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]