[{"id":1762499,"web_url":"http://patchwork.ozlabs.org/comment/1762499/","msgid":"<20170904080025.eilcinu4ennj5fmb@flea>","list_archive_url":null,"date":"2017-09-04T08:00:25","subject":"Re: [PATCH 04/10] dmaengine: sun6i: Enable additional burst\n\tlengths/widths on H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Mon, Sep 04, 2017 at 12:40:55AM +0200, Stefan Brüns wrote:\n> The H3 supports bursts lengths of 1, 4, 8 and 16 transfers, each with\n> a width of 1, 2, 4 or 8 bytes.\n> \n> The register value for the the width is log2-encoded, change the\n> conversion function to provide the correct value for width == 8.\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> drivers/dma/sun6i-dma.c | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c\n> index c5644bd0f91a..335a8ec88b0b 100644\n> --- a/drivers/dma/sun6i-dma.c\n> +++ b/drivers/dma/sun6i-dma.c\n> @@ -263,8 +263,12 @@ static inline s8 convert_burst(u32 maxburst)\n> \tswitch (maxburst) {\n> \tcase 1:\n> \t\treturn 0;\n> +\tcase 4:\n> +\t\treturn 1;\n> \tcase 8:\n> \t\treturn 2;\n> +\tcase 16:\n> +\t\treturn 3;\n> \tdefault:\n> \t\treturn -EINVAL;\n> \t}\n> @@ -272,7 +276,7 @@ static inline s8 convert_burst(u32 maxburst)\n> \n> static inline s8 convert_buswidth(enum dma_slave_buswidth addr_width)\n> {\n> -\treturn addr_width >> 1;\n> +\treturn ilog2(addr_width);\n> }\n> \n> static size_t sun6i_get_chan_size(struct sun6i_pchan *pchan)\n> @@ -1152,6 +1156,12 @@ static int sun6i_dma_probe(struct platform_device *pdev)\n> \t\t\t\t\t\t BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);\n> \tsdc->src_burst_lengths\t\t\t= BIT(1) | BIT(8);\n> \tsdc->dst_burst_lengths\t\t\t= BIT(1) | BIT(8);\n> +\tif (sdc->cfg->dmac_variant == DMAC_VARIANT_H3) {\n> +\t\tsdc->slave.src_addr_widths |= BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);\n> +\t\tsdc->slave.dst_addr_widths |= BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);\n> +\t\tsdc->src_burst_lengths |= BIT(4) | BIT(16);\n> +\t\tsdc->dst_burst_lengths |= BIT(4) | BIT(16);\n> +\t}\n\nThe rest looks good, but that should be stored in the sun6i_dma_config\nstructure too.\n\nThanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"DyIbzzgN\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm2Nq6sCXz9s82\n\tfor ;\n\tMon, 4 Sep 2017 18:01:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1domK0-0007O4-Kw; Mon, 04 Sep 2017 08:01:28 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1domJq-0006ig-VW for linux-arm-kernel@lists.infradead.org;\n\tMon, 04 Sep 2017 08:01:25 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid EBC9020A2F; Mon, 4 Sep 2017 10:00:56 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 9797A21F23;\n\tMon, 4 Sep 2017 10:00:24 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=39VNXJZIN+FARgWT7lrHUJDuYM3MDjNNuZfIKNITYvU=;\n\tb=DyIbzzgNjxinmLY75QqrCKA9B\n\t7DeehmttNk/e0K6DzQgrf0NI76Q9z65ik9r64BEFKyfjYbdYVcB4/ysgCdImT72Fkjru7UXNdZaI4\n\tltEapGjmtuqqP0j8Yqmwhzkp1JJGss9JyE2T2HacrMflg3Kj623JeOkjUxXbWfJ/bEKdqkH7FxQP5\n\tRofbrMaLn8VSyobUOEPp6AXJGjAlW6inSG/UqiVTCp8/rZJXzLP1U3b6DlaJJQGSP9RZtYQ5BI6Vl\n\tceAVPHQhB6EnVoFNHvbvXS6xGbofdKtN70szKVJOvYpBZUuu6MaxeKQIPbAt83ycz+CT9k9b0KPi4\n\tbsMQlJ2zA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 4 Sep 2017 10:00:25 +0200","From":"Maxime Ripard ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Subject":"Re: [PATCH 04/10] dmaengine: sun6i: Enable additional burst\n\tlengths/widths on H3","Message-ID":"<20170904080025.eilcinu4ennj5fmb@flea>","References":"<20170903224100.17893-1-stefan.bruens@rwth-aachen.de>\n\t<20170903224100.17893-5-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","In-Reply-To":"<20170903224100.17893-5-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170904_010119_528341_DFBDB9D0 ","X-CRM114-Status":"GOOD ( 18.32 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Vinod Koul ,\n\tAndre Przywara , linux-kernel@vger.kernel.org,\n\tCode Kipper , linux-sunxi@googlegroups.com,\n\tRob Herring , dmaengine@vger.kernel.org,\n\tChen-Yu Tsai , linux-arm-kernel@lists.infradead.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============2128956594221122806==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]