[{"id":1762423,"web_url":"http://patchwork.ozlabs.org/comment/1762423/","msgid":"<20170904054004.GA10456@mail>","list_archive_url":null,"date":"2017-09-04T05:40:04","subject":"Re: [PATCH][next] rocker: fix kcalloc parameter order","submitter":{"id":70274,"url":"http://patchwork.ozlabs.org/api/people/70274/","name":"Zahari Doychev","email":"zahari.doychev@linux.com"},"content":"On Sun, Sep 03, 2017 at 10:26:03PM +0200, Zahari Doychev wrote:\n> The function calls to kcalloc use wrong parameter order. The flags\n> have to be passed as last parameter.\n> \n> The change was done using the following coccinelle script:\n> \n> @@\n> expression E1,E2;\n> type T;\n> @@\n> \n> -kcalloc(E1, E2, sizeof(T))\n> +kcalloc(E2, sizeof(T), E1)\n> \n> Signed-off-by: Zahari Doychev \n> ---\n> drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c\n> index da4e26b53a52..2708451ce22a 100644\n> --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c\n> +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c\n> @@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port *ofdpa_port,\n> \tentry->group_id = group_id;\n> \tentry->group_count = group_count;\n> \n> -\tentry->group_ids = kcalloc(flags, group_count, sizeof(u32));\n> +\tentry->group_ids = kcalloc(group_count, sizeof(u32), flags);\n\nI think that the flags are also not used correctly, so I will have to resend\nthe patch.\n\n\n> \tif (!entry->group_ids) {\n> \t\tkfree(entry);\n> \t\treturn -ENOMEM;\n> @@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port *ofdpa_port,\n> \tint err = 0;\n> \tint i;\n> \n> -\tgroup_ids = kcalloc(flags, port_count, sizeof(u32));\n> +\tgroup_ids = kcalloc(port_count, sizeof(u32), flags);\n> \tif (!group_ids)\n> \t\treturn -ENOMEM;\n> \n> -- \n> 2.13.0\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"IqnQcH4k\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlz662f74z9s78\n\tfor ;\n\tMon, 4 Sep 2017 15:33:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750821AbdIDFdc (ORCPT );\n\tMon, 4 Sep 2017 01:33:32 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:35579 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750703AbdIDFdb (ORCPT\n\t); Mon, 4 Sep 2017 01:33:31 -0400","by mail-wr0-f196.google.com with SMTP id a47so2789499wra.2\n\tfor ; Sun, 03 Sep 2017 22:33:30 -0700 (PDT)","from mail ([2a02:810d:1500:e01:80d8:1ff:fe5d:caff])\n\tby smtp.gmail.com with ESMTPSA id\n\tm199sm3596558wmd.14.2017.09.03.22.33.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 22:33:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=sender:from:date:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=od2d0dxgyZ8GBfePMHb9/BO66z1k+1u8KBPD13FTulY=;\n\tb=IqnQcH4kvBDVgCXiiOiU8Aetnm2LQN+ozhYi9dzvtw9JyeCdmP7SqV6y/CdRwjgSDE\n\tuoGFksx+/HfI7CDZkHmbYCUQH9UnXbVdHx+dWFNC1nutWNzMON5T5tiFwDNGozC387jO\n\tlhur38dTkEcYIcGxz01FGIcgAGjTYfFCV1YwOeZt5TPba2Y/3qzQ2tyIRE/P2BzVzYQ0\n\tcskFTvRZCeSgUOBusT/7KcecGUOJfF6ucLu/gvEzt+GsaeCKa643s+6ESQ+l+9awPdEe\n\tsY7EvGELj6gFOw9TxgDFAPi8fPjHVcmS8mQnSCq432pRb4RANiw8U7Ww1MyiW98sXmLE\n\ttoDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:date:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=od2d0dxgyZ8GBfePMHb9/BO66z1k+1u8KBPD13FTulY=;\n\tb=r4TJ1Hsi0BDBnuc1dLzp9Bhok+B+a1qoQjo6CrTFNpMWpoYgltXTxHMxGDUF5Y/RZa\n\tlNpRdGIC1/sip6iBpq8cuvE25a9DZe1sE1Mw1/+TNDETgUIri7itBCJBiSzgVT3VklLz\n\tLdt5Po9+n9txpiHEzzwS/b4EkbDn6oG64BRnQs1856GnvEzwiry0i0Ri9H0lZxeyaEXe\n\tspX1HOx7hJ2rZAOgaYMfsbD0dWpd9JnQV3x23qOvSMDC42nKcr22WTvXMGj1PtjVflHI\n\t6PGSGEqbfMFXJUunxim7BG/bX5qwnmq+Y1vrsUEtD5RMr0Gvg7Ag0BmRUrPKbL8g5mih\n\tEpMw==","X-Gm-Message-State":"AHPjjUhZ4UUSsGN1vt687gEaYWwSHnsxi5538So6YOWm5MrxrXQYX6H1\n\t2XJB8I1mrlS9uA==","X-Google-Smtp-Source":"ADKCNb4Wd/TSs8QUaht8VSKnUJUo9wzCzqG920LHMj8yfZE3XMVpD3FmD5skKD10yjbWPUdrz98ryQ==","X-Received":"by 10.223.134.174 with SMTP id 43mr189385wrx.147.1504503210048; \n\tSun, 03 Sep 2017 22:33:30 -0700 (PDT)","From":"Zahari Doychev ","X-Google-Original-From":"Zahari Doychev ","Date":"Mon, 4 Sep 2017 07:40:04 +0200","To":"Zahari Doychev ","Cc":"jiri@resnulli.us, netdev@vger.kernel.org","Subject":"Re: [PATCH][next] rocker: fix kcalloc parameter order","Message-ID":"<20170904054004.GA10456@mail>","References":"<4d8a3c58c2a4e89319034f5faf41ba4682dc15ae.1504461594.git.zahari.doychev@linux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<4d8a3c58c2a4e89319034f5faf41ba4682dc15ae.1504461594.git.zahari.doychev@linux.com>","User-Agent":"Mutt/1.8.0 (2017-02-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]