[{"id":1762694,"web_url":"http://patchwork.ozlabs.org/comment/1762694/","msgid":"<96371574-0205-fd0e-452e-d001695bd69e@xs4all.nl>","list_archive_url":null,"date":"2017-09-04T14:37:29","subject":"Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image\n\tsensors","submitter":{"id":723,"url":"http://patchwork.ozlabs.org/api/people/723/","name":"Hans Verkuil","email":"hverkuil@xs4all.nl"},"content":"On 09/03/2017 07:49 PM, Sakari Ailus wrote:\n> The lens-focus property contains a phandle to the lens voice coil driver\n> that is associated to the sensor; typically both are contained in the same\n> camera module.\n\nJust to be certain: this lens-focus phandle should also work fine for a motor\ndriver, right?\n\nWe (Cisco) also have a camera that has an iris motor, but since nothing upstream\nuses that I'm not sure if we should bother adding that as well.\n\nRegards,\n\n\tHans\n\n> \n> Signed-off-by: Sakari Ailus \n> Acked-by: Pavel Machek \n> Reviewed-by: Sebastian Reichel \n> Acked-by: Rob Herring \n> ---\n> Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> index fee73cf2a714..73d045127dcf 100644\n> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> @@ -74,6 +74,8 @@ Optional properties\n> - flash: An array of phandles referring to the flash LED, a sub-node\n> of the LED driver device node.\n> \n> +- lens-focus: A phandle to the node of the focus lens controller.\n> +\n> \n> Optional endpoint properties\n> ----------------------------\n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmC9r6Tryz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 00:37:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753697AbdIDOhf (ORCPT\n\t);\n\tMon, 4 Sep 2017 10:37:35 -0400","from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:45462 \"EHLO\n\tlb2-smtp-cloud9.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753789AbdIDOhe (ORCPT\n\t); Mon, 4 Sep 2017 10:37:34 -0400","from [192.168.2.10] ([212.251.195.8])\n\tby smtp-cloud9.xs4all.net with ESMTPA\n\tid osVFd3EuydRLjosVJdWkGI; Mon, 04 Sep 2017 16:37:33 +0200"],"Subject":"Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image\n\tsensors","To":"Sakari Ailus , linux-media@vger.kernel.org","Cc":"niklas.soderlund@ragnatech.se, robh@kernel.org,\n\tlaurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,\n\tpavel@ucw.cz, sre@kernel.org","References":"<20170903174958.27058-1-sakari.ailus@linux.intel.com>\n\t<20170903174958.27058-15-sakari.ailus@linux.intel.com>","From":"Hans Verkuil ","Message-ID":"<96371574-0205-fd0e-452e-d001695bd69e@xs4all.nl>","Date":"Mon, 4 Sep 2017 16:37:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170903174958.27058-15-sakari.ailus@linux.intel.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfHf9UWu1kDFJ56fRRQij4aLJa0dBJa4mjucK1qWlizseR5ethl0oSW9lVNmNOeCABOYxOV9mrk1CnxPpb1cRJt63iyFJ+wPArKNTiCehP4IAHxfsF6Yw\n\tABWm3xuB81h4/qK02FD3KsZ7ue1J/lgIGyo0Hf8nbkt3aDDvTO0fbapPL2IVZB9tbCYBsXkJFLcDwrRMPUknG99hV+DYkrFdh/zkU4iZOZT/oga1Z0VV72iT\n\tWKV/df2daWkVmu1KzA+KNSzFxNoxNK9DRHvWL/+LQhKP1o+BiKpKosqRSvxbY6Z7AKgQkTpY0Gkc8dTu64Yr3LUAfazT9VP60BHZH7Sv+ijlLhlG/0J0WkBA\n\ttzNSA+IrFu5X9nNaWnCz7idtEME3gKzf2vE3WP2Ll9x3p4hPEC3OkGB1JUtk6R7hWK3UAuVr6UZbjbaRy3sCACllFkVFH1luD9K/9aV7I+J8EfqDJxqF4Bhq\n\tUtzOGI41NfGJeHOw","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762768,"web_url":"http://patchwork.ozlabs.org/comment/1762768/","msgid":"<20170904162925.hxtzy5jagv5ylq4c@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-04T16:29:26","subject":"Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image\n\tsensors","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Hans,\n\nOn Mon, Sep 04, 2017 at 04:37:29PM +0200, Hans Verkuil wrote:\n> On 09/03/2017 07:49 PM, Sakari Ailus wrote:\n> > The lens-focus property contains a phandle to the lens voice coil driver\n> > that is associated to the sensor; typically both are contained in the same\n> > camera module.\n> \n> Just to be certain: this lens-focus phandle should also work fine for a motor\n> driver, right?\n\nYes; the commit message specifies what this is used right now but nothing\nprevents using this for different lens control technologies either. The\nproperty itself does not mention voice coil modules.\n\n> \n> We (Cisco) also have a camera that has an iris motor, but since nothing upstream\n> uses that I'm not sure if we should bother adding that as well.\n\nDo you have one for focussing only or for zooming as well?","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmFfz1yZ9z9t32\n\tfor ;\n\tTue, 5 Sep 2017 02:29:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753868AbdIDQ33 (ORCPT\n\t);\n\tMon, 4 Sep 2017 12:29:29 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:59754 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1753847AbdIDQ32 (ORCPT\n\t); Mon, 4 Sep 2017 12:29:28 -0400","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 1844A600EB;\n\tMon, 4 Sep 2017 19:29:27 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1douFa-0002Nw-Iz; Mon, 04 Sep 2017 19:29:26 +0300"],"Date":"Mon, 4 Sep 2017 19:29:26 +0300","From":"Sakari Ailus ","To":"Hans Verkuil ","Cc":"Sakari Ailus ,\n\tlinux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\trobh@kernel.org, laurent.pinchart@ideasonboard.com,\n\tdevicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org","Subject":"Re: [PATCH v7 14/18] dt: bindings: Add lens-focus binding for image\n\tsensors","Message-ID":"<20170904162925.hxtzy5jagv5ylq4c@valkosipuli.retiisi.org.uk>","References":"<20170903174958.27058-1-sakari.ailus@linux.intel.com>\n\t<20170903174958.27058-15-sakari.ailus@linux.intel.com>\n\t<96371574-0205-fd0e-452e-d001695bd69e@xs4all.nl>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<96371574-0205-fd0e-452e-d001695bd69e@xs4all.nl>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]