[{"id":1762691,"web_url":"http://patchwork.ozlabs.org/comment/1762691/","msgid":"<9a68a9a6-0949-f1c2-f029-8045d7d688b0@xs4all.nl>","list_archive_url":null,"date":"2017-09-04T14:31:51","subject":"Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices\n\tassociated to a sensor","submitter":{"id":723,"url":"http://patchwork.ozlabs.org/api/people/723/","name":"Hans Verkuil","email":"hverkuil@xs4all.nl"},"content":"On 09/03/2017 07:49 PM, Sakari Ailus wrote:\n> Camera flash drivers (and LEDs) are separate from the sensor devices in\n> DT. In order to make an association between the two, provide the\n> association information to the software.\n> \n> Signed-off-by: Sakari Ailus \n> Acked-by: Rob Herring \n> ---\n> Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> index 852041a7480c..fee73cf2a714 100644\n> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> @@ -67,6 +67,14 @@ are required in a relevant parent node:\n> \t\t identifier, should be 1.\n> - #size-cells : should be zero.\n> \n> +\n> +Optional properties\n> +-------------------\n> +\n> +- flash: An array of phandles referring to the flash LED, a sub-node\n> + of the LED driver device node.\n\nIf it is an array, then I guess it should say: \"An array of phandles, each referring to\na flash LED,\"\n\nRegards,\n\n\tHans\n\n> +\n> +\n> Optional endpoint properties\n> ----------------------------\n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmC3L3z0yz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 00:31:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753694AbdIDOb4 (ORCPT\n\t);\n\tMon, 4 Sep 2017 10:31:56 -0400","from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:39559 \"EHLO\n\tlb2-smtp-cloud9.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753633AbdIDOb4 (ORCPT\n\t); Mon, 4 Sep 2017 10:31:56 -0400","from [192.168.2.10] ([212.251.195.8])\n\tby smtp-cloud9.xs4all.net with ESMTPA\n\tid osPnd3A8LdRLjosPqdWgv3; Mon, 04 Sep 2017 16:31:55 +0200"],"Subject":"Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices\n\tassociated to a sensor","To":"Sakari Ailus , linux-media@vger.kernel.org","Cc":"niklas.soderlund@ragnatech.se, robh@kernel.org,\n\tlaurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,\n\tpavel@ucw.cz, sre@kernel.org","References":"<20170903174958.27058-1-sakari.ailus@linux.intel.com>\n\t<20170903174958.27058-14-sakari.ailus@linux.intel.com>","From":"Hans Verkuil ","Message-ID":"<9a68a9a6-0949-f1c2-f029-8045d7d688b0@xs4all.nl>","Date":"Mon, 4 Sep 2017 16:31:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170903174958.27058-14-sakari.ailus@linux.intel.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfNX8TWbGfEDw+1cI/tM6oM1rCl+vhaRrIk7ZPMMXT5NCPiEwcGs8U2mlW56jH1aFPhYTLOudrSSwW6gKAAZIef4I9GnH20uabpReNQrhsj6zrP3u4jZ0\n\tF1D4LpdoQQ2oN0w0699c1udAqp2Xz5y2S1Cvo2GAX6kel1wrFhAURxWbodVzNDSgC5mJ2fiG1lHTggMeroqWlXjqNnnE/qFChFllJ/u/2dtJRREzi1ZAUOWw\n\t9jD7xzVg/y59o2rtZ1xXzfzfpks2/Xsh9V08daH1uhxh5v08pCfo4cPpbV4XiILT415PjUrxP9+yC3heSWj9Is8eX44L0pnb0pKIM9JFvkGG8VEYlQeZRn65\n\tsTLTCq6Hh7j9r1EGuzlAUC05uUcyf+RUU8BpIkZbxR+2u0VzYIZrrIY81YgUYmeNRmx2K5kcYakJ1CY0tfGQgm/SR8SDA52CuueeFgsPkJ7Tp3rv3GBOI69M\n\t4UKrohtJhPmugVsg","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762764,"web_url":"http://patchwork.ozlabs.org/comment/1762764/","msgid":"<20170904162705.thujzc7xw6hgjau3@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-04T16:27:05","subject":"Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices\n\tassociated to a sensor","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"On Mon, Sep 04, 2017 at 04:31:51PM +0200, Hans Verkuil wrote:\n> On 09/03/2017 07:49 PM, Sakari Ailus wrote:\n> > Camera flash drivers (and LEDs) are separate from the sensor devices in\n> > DT. In order to make an association between the two, provide the\n> > association information to the software.\n> > \n> > Signed-off-by: Sakari Ailus \n> > Acked-by: Rob Herring \n> > ---\n> > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > index 852041a7480c..fee73cf2a714 100644\n> > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > @@ -67,6 +67,14 @@ are required in a relevant parent node:\n> > \t\t identifier, should be 1.\n> > - #size-cells : should be zero.\n> > \n> > +\n> > +Optional properties\n> > +-------------------\n> > +\n> > +- flash: An array of phandles referring to the flash LED, a sub-node\n> > + of the LED driver device node.\n> \n> If it is an array, then I guess it should say: \"An array of phandles, each referring to\n> a flash LED,\"\n\nSounds good, I'll use that in v8.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmFcG3Dckz9t32\n\tfor ;\n\tTue, 5 Sep 2017 02:27:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753861AbdIDQ1I (ORCPT\n\t);\n\tMon, 4 Sep 2017 12:27:08 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:59718 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1753847AbdIDQ1I (ORCPT\n\t); Mon, 4 Sep 2017 12:27:08 -0400","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 02373600EB;\n\tMon, 4 Sep 2017 19:27:06 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1douDJ-0002Nq-IF; Mon, 04 Sep 2017 19:27:05 +0300"],"Date":"Mon, 4 Sep 2017 19:27:05 +0300","From":"Sakari Ailus ","To":"Hans Verkuil ","Cc":"Sakari Ailus ,\n\tlinux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\trobh@kernel.org, laurent.pinchart@ideasonboard.com,\n\tdevicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org","Subject":"Re: [PATCH v7 13/18] dt: bindings: Add a binding for flash devices\n\tassociated to a sensor","Message-ID":"<20170904162705.thujzc7xw6hgjau3@valkosipuli.retiisi.org.uk>","References":"<20170903174958.27058-1-sakari.ailus@linux.intel.com>\n\t<20170903174958.27058-14-sakari.ailus@linux.intel.com>\n\t<9a68a9a6-0949-f1c2-f029-8045d7d688b0@xs4all.nl>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<9a68a9a6-0949-f1c2-f029-8045d7d688b0@xs4all.nl>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]