[{"id":1762308,"web_url":"http://patchwork.ozlabs.org/comment/1762308/","msgid":"<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>","list_archive_url":null,"date":"2017-09-03T17:05:03","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n> GCC 4.7.2 on SunOS reports that the values assigned to array members are not\n> real constants:\n> \n> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant\n> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\n> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n> \n> Convert the array to switch() to workaround the issue.\n\nI don't like the idea. It's really an array and should be managed as an\narray.\n\nCould you try to use make_floatx80_init() instead of make_floatx80() ?\n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlfWC47ffz9t2f\n\tfor ;\n\tMon, 4 Sep 2017 03:05:43 +1000 (AEST)","from localhost ([::1]:33058 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doYL7-0002Go-Oj\n\tfor incoming@patchwork.ozlabs.org; Sun, 03 Sep 2017 13:05:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47315)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doYKe-0002F6-7D\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 13:05:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doYKZ-0005tn-NM\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 13:05:12 -0400","from mout.kundenserver.de ([217.72.192.74]:54146)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1doYKZ-0005rW-AZ\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 13:05:07 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.183]) with ESMTPSA (Nemesis) id\n\t0MHY8C-1dlG0q2tcC-003J50; Sun, 03 Sep 2017 19:05:04 +0200"],"To":"Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>","From":"Laurent Vivier ","Message-ID":"<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>","Date":"Sun, 3 Sep 2017 19:05:03 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170903163130.14288-1-n54@gmx.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:smHeU/JdZL0LySNv6+o9Q4iQhlYGRurXMI+5ZWpqbHLOXVwCYTW\n\tGyJvy3bHQhXdqyRATYBPabYv41thCVtuqwolJf5jvzAMB/cop1EIEWLTa1ceFzJ/zGXrFcJ\n\tBoxA2e4/PjJx2zRU9QyXoEdNzAkEAtG9zn0W33zIsvvwfcoutFYvKt9001DIFqOuU7PEhu3\n\tOlSMhfTlhG7V/C8jZMiFw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:uq/QcZICqW8=:R5YvYlGUb7lPlMJUB+oIcA\n\tFeFCHpL+aGgyvnMddKMb4tENdpgKIfKRFeM1VZ6D4slFZRUyRTju+YfSB63ECcNaJbTHSG+Qu\n\tRFa1Nzyji0J3GJeZr4/ti1RbCyjABbQ46Hhjm6HY9AODSsjITj7Lu9AueciD8Vu+dqi14BQ7U\n\tXw0+mAS+T+/AkFTTJ40qIIyCsHRQJ7MRa1yVraIVr0F8xjWixDqm3FXs/8UcJM15gB6+4ohh6\n\tJuwQq46pb20N1lL1a/v1VCgNnC0VKyaiQ34thMHX1IBXchCsw/UI+ZjxsqJR1dyWcuhSXArNc\n\t4Ufg5N3VHib4TZQOop23Ek6InAoqcOnLdZbRtpL5v7Cflb/TnwGsJ+IgyZRaI+xEQTK1OAMrI\n\tV2c++SuAFVk9aDLopmHQsK1TrgbdHT/zWjbVfZ2sO+qVbgo3QV87zDVcLucuPtzlvA5PnGd8s\n\tnWWtY/mGDvhjx+z+AwAknwayTOfCla11VFpsR5jhmZEQqzFfLw6G+aYJVyeoUE1iKkMKbuBOj\n\tqN/ruzZqCdVLwxCFyRJiz4slPXo85p8OhR7zUgsnY4UYUQVa9f/GJ5Vwg1MUjnTKEqmYSV++5\n\tes6t0buGn2jGg1ekE8HdgqiSE684uLxarZ/+JMu3JhSZAvnSsBFFM4HJpI5ZkUz5JWBzWUDWm\n\thXYURL8Ogo1X/74PSd26gbZ/Fzd/0nDbqZrEmq6D8XImei4nIwbORVaPCPnGJfX2Fv05jJcct\n\t7VwN32JZQc46is9fWVXKqLCKqlP5iQFtLoz0i9P2rimotd8vXQkJU93twkc=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"217.72.192.74","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762362,"web_url":"http://patchwork.ozlabs.org/comment/1762362/","msgid":"<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>","list_archive_url":null,"date":"2017-09-04T00:27:49","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/03/2017 02:05 PM, Laurent Vivier wrote:\n> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n>> GCC 4.7.2 on SunOS reports that the values assigned to array members are not\n>> real constants:\n>>\n>> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant\n>> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')\n>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>\n>> Convert the array to switch() to workaround the issue.\n> \n> I don't like the idea. It's really an array and should be managed as an\n> array.\n\nI agree with Laurent.\n\n> \n> Could you try to use make_floatx80_init() instead of make_floatx80() ?\n\nI guess the problem comes from the macro which cast as not const:\n\n#define make_floatx80(exp, mant) ((floatx80) { mant, exp })\n\nmake_floatx80_init() doesn't cast so it might work,\nelse we could add a macro such const_floatx80():\n\n#define const_floatx80(exp, mant) ((const floatx80) { mant, exp })","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CkfkZKvz\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlrLT6Xcfz9sNq\n\tfor ;\n\tMon, 4 Sep 2017 10:28:49 +1000 (AEST)","from localhost ([::1]:42252 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dofFw-0006aK-0J\n\tfor incoming@patchwork.ozlabs.org; Sun, 03 Sep 2017 20:28:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55641)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dofF8-0006X9-4b\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 20:28:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dofF3-0005Jj-Hz\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 20:27:58 -0400","from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:38330)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dofF3-0005HK-EP\n\tfor qemu-devel@nongnu.org; Sun, 03 Sep 2017 20:27:53 -0400","by mail-qk0-x22c.google.com with SMTP id n64so12611890qki.5\n\tfor ; Sun, 03 Sep 2017 17:27:52 -0700 (PDT)","from [192.168.1.240] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\to13sm4166615qtg.47.2017.09.03.17.27.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 17:27:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=cj27UhnM+3eburO4SI2XC5DGFvFbwyBdcHJqeee2A24=;\n\tb=CkfkZKvzCqpK5QvkQ/6o0doSw7V/FaMfvWbTykjE9sG5yb/6mQFyHUBskiCsz+aqhW\n\t8IHBDy1Zm6J4J8RVG1PmxIbZPz7rlV8x6EGLFNun7Ydxu+x+75IVDTPX6TE3tqupQeAC\n\ttRFZeVNfmjd/IAqDY3svKzAiGC4cqoUR74BomOXoRS+W1qaGGIHZuxVZnbVVpPJCSbv9\n\tWcxvAGGyBx6jLc2PKn9fXZa/tfJUlVqYKOEDDQwApypGcmIhXSQ/G87cFQRFl7Qbo+2X\n\tiKUe5NTMa4unq0JZB4pKIDOSQ07NtfZpxIPj8BRFqg61uZeqiv0a2BwQUtCdoVW3NZl5\n\tXsyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=cj27UhnM+3eburO4SI2XC5DGFvFbwyBdcHJqeee2A24=;\n\tb=MaV4foUhUbzKomvnP+iWbgyRYcvbJG/pxMVuYOCf7co4WAyI51IuNfbWTGFZs0Z5xx\n\trn25YP8LRdGGy8IXQMuuZ7Ys97C2Wn1EknIVR8qS2nTYWVDe7GI6H/wzpFr7rqalpti2\n\tiOEYWEsjyptAGyO48T0WUnOGKASvh6JiiMTuGxBrt8dzIorIELplmHxitl1FiItI8M6A\n\th0MGlTa34OAR+Cx4OhkYl9CMHiKlFxW8Z8JOAtvdenpwZRi6o1flCAWAwENp4olEDKgR\n\tQ1aK0cUOyEQqRvJFQz1IqUa9NUbfSeQmbNuBKI13xwBZyrToscz7NQPbuQnlcYoj5RR+\n\tJOeg==","X-Gm-Message-State":"AHPjjUjrRg6c7BoFOCqTL521kGd9Ex3RQallE0HKFBpQInNiJ+x+j7ND\n\tf4Dn+mbK2qpeSbsR48s=","X-Google-Smtp-Source":"ADKCNb6TJkKgw7xEENVFXTOZ2njjkSZgS50JI9ruhnrRSfZ8CD1P8DBzTbcFNoxOoU2Yc+Dl2t7+zg==","X-Received":"by 10.55.97.201 with SMTP id v192mr7328629qkb.153.1504484871472; \n\tSun, 03 Sep 2017 17:27:51 -0700 (PDT)","To":"Laurent Vivier , Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>","Date":"Sun, 3 Sep 2017 21:27:49 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::22c","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762498,"web_url":"http://patchwork.ozlabs.org/comment/1762498/","msgid":"<150451201350.17979.9335009903013350834@2f78fa2a9cb4>","list_archive_url":null,"date":"2017-09-04T08:00:14","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series failed build test on FreeBSD host. Please find the details below.\n\nType: series\nMessage-id: 20170903163130.14288-1-n54@gmx.com\nSubject: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/sh\n# Testing script will be invoked under the git checkout with\n# HEAD pointing to a commit that has the patches applied on top of \"base\"\n# branch\nset -e\necho \"=== ENV ===\"\nenv\necho \"=== PACKAGES ===\"\npkg info\necho \"=== TEST BEGIN ===\"\nCC=/usr/local/libexec/ccache/cc\nINSTALL=$PWD/install\nBUILD=$PWD/build\necho -n \"Using CC: \"\nrealpath $CC\nmkdir -p $BUILD $INSTALL\nSRC=$PWD\ncd $BUILD\n$SRC/configure --cc=$CC --prefix=$INSTALL --target-list=x86_64-softmmu\ngmake -j4\n# XXX: we need reliable clean up\n# make check -j4 V=1\ngmake install\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\n9ff84c0445 target/m68k: Change fpu_rom from const static array to switch\n\n=== OUTPUT BEGIN ===\n=== ENV ===\nLOGNAME=patchew-tester\nPATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin\nPWD=/var/tmp/patchew-tester-tmp-cala1q33/src\nHOME=/home/patchew-tester\nUSER=patchew-tester\nSHELL=/bin/sh\nPATCHEW=/home/patchew-tester/patchew/patchew-cli -s http://patchew.org --nodebug\n=== PACKAGES ===\nbash-4.4.12_2 GNU Project's Bourne Again SHell\nbinutils-2.28,1 GNU binary tools\nbison-3.0.4,1 Parser generator from FSF, (mostly) compatible with Yacc\nca_root_nss-3.30.2 Root certificate bundle from the Mozilla Project\nccache-3.3.4_3 Tool to minimize the compile time of C/C++ programs\ncurl-7.54.0 Non-interactive tool to get files from FTP, GOPHER, HTTP(S) servers\ncvsps-2.1_2 Create patchset information from CVS\ndtc-1.4.2_1 Device Tree Compiler\nexpat-2.2.0_1 XML 1.0 parser written in C\ngcc-5.4.0 GNU Compiler Collection 5\ngcc-ecj-4.5 Eclipse Java Compiler used to build GCC Java\ngettext-runtime-0.19.8.1_1 GNU gettext runtime libraries and programs\ngit-2.13.0 Distributed source code management tool\nglib-2.46.2_5 Some useful routines of C programming (current stable version)\ngmake-4.2.1_1 GNU version of 'make' utility\ngmp-6.1.2 Free library for arbitrary precision arithmetic\nindexinfo-0.2.6 Utility to regenerate the GNU info page index\nlibffi-3.2.1 Foreign Function Interface\nlibiconv-1.14_10 Character set conversion library\nlibnghttp2-1.21.0 HTTP/2.0 C Library\nm4-1.4.18,1 GNU M4\nmpc-1.0.3 Library of complex numbers with arbitrarily high precision\nmpfr-3.1.5_1 Library for multiple-precision floating-point computations\np5-Authen-SASL-2.16_1 Perl5 module for SASL authentication\np5-Digest-HMAC-1.03_1 Perl5 interface to HMAC Message-Digest Algorithms\np5-Error-0.17024 Error/exception handling in object-oriented programming style\np5-GSSAPI-0.28_1 Perl extension providing access to the GSSAPIv2 library\npcre-8.40 Perl Compatible Regular Expressions library\nperl5-5.24.1 Practical Extraction and Report Language\npixman-0.34.0 Low-level pixel manipulation library\npkg-1.10.1 Package manager\npkgconf-1.3.0,1 Utility to help to configure compiler and linker flags\npython-2.7_3,2 \"meta-port\" for the default version of Python interpreter\npython2-2_3 The \"meta-port\" for version 2 of the Python interpreter\npython27-2.7.13_3 Interpreted object-oriented programming language\npython3-3_3 The \"meta-port\" for version 3 of the Python interpreter\npython35-3.5.3_1 Interpreted object-oriented programming language\nreadline-6.3.8 Library for editing command lines as they are typed\nsudo-1.8.20p1 Allow others to run commands as root\n=== TEST BEGIN ===\nUsing CC: /usr/local/bin/ccache\nInstall prefix /var/tmp/patchew-tester-tmp-cala1q33/src/install\nBIOS directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu\nbinary directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/bin\nlibrary directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/lib\nmodule directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/lib/qemu\nlibexec directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/libexec\ninclude directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/include\nconfig directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/etc\nlocal state directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/var\nManual directory /var/tmp/patchew-tester-tmp-cala1q33/src/install/share/man\nELF interp prefix /usr/gnemul/qemu-%M\nSource path /var/tmp/patchew-tester-tmp-cala1q33/src\nC compiler /usr/local/libexec/ccache/cc\nHost C compiler cc\nC++ compiler c++\nObjective-C compiler clang\nARFLAGS rv\nCFLAGS -O2 -g \nQEMU_CFLAGS -I/usr/local/include/pixman-1 -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -DNCURSES_WIDECHAR -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wno-string-plus-int -Wno-initializer-overrides -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong \nLDFLAGS -Wl,--warn-common -m64 -g \nmake gmake\ninstall install\npython python -B\nsmbd /usr/sbin/smbd\nmodule support no\nhost CPU x86_64\nhost big endian no\ntarget list x86_64-softmmu\ngprof enabled no\nsparse enabled no\nstrip binaries yes\nprofiler no\nstatic build no\npixman system\nSDL support no \nGTK support no \nGTK GL support no\nVTE support no \nTLS priority NORMAL\nGNUTLS support no\nGNUTLS rnd no\nlibgcrypt no\nlibgcrypt kdf no\nnettle no \nnettle kdf no\nlibtasn1 no\ncurses support yes\nvirgl support no\ncurl support yes\nmingw32 support no\nAudio drivers oss\nBlock whitelist (rw) \nBlock whitelist (ro) \nVirtFS support no\nVNC support yes\nVNC SASL support no\nVNC JPEG support no\nVNC PNG support no\nxen support no\nbrlapi support no\nbluez support no\nDocumentation no\nPIE no\nvde support no\nnetmap support yes\nLinux AIO support no\nATTR/XATTR support no\nInstall blobs yes\nKVM support no\nHAX support no\nTCG support yes\nTCG debug enabled no\nTCG interpreter no\nRDMA support no\nfdt support no\npreadv support yes\nfdatasync no\nmadvise yes\nposix_madvise yes\nlibcap-ng support no\nvhost-net support no\nvhost-scsi support no\nvhost-vsock support no\nvhost-user support yes\nTrace backends log\nspice support no \nrbd support no\nxfsctl support no\nsmartcard support no\nlibusb yes\nusb net redir no\nOpenGL support no\nOpenGL dmabufs no\nlibiscsi support no\nlibnfs support no\nbuild guest agent yes\nQGA VSS support no\nQGA w32 disk info no\nQGA MSI support no\nseccomp support no\ncoroutine backend ucontext\ncoroutine pool yes\ndebug stack usage no\ncrypto afalg no\nGlusterFS support no\ngcov gcov\ngcov enabled no\nTPM support yes\nlibssh2 support no\nTPM passthrough no\nQOM debugging yes\nLive block migration yes\nlzo support no\nsnappy support no\nbzip2 support yes\nNUMA host support no\ntcmalloc support no\njemalloc support no\navx2 optimization no\nreplication support yes\nVxHS block device no\n GEN x86_64-softmmu/config-devices.mak.tmp\n GEN config-host.h\n GEN qemu-options.def\n GEN qmp-commands.h\n GEN x86_64-softmmu/config-devices.mak\n GEN qapi-types.h\n GEN qapi-visit.h\n GEN qapi-event.h\n GEN qmp-marshal.c\n GEN qapi-types.c\n GEN qapi-visit.c\n GEN qapi-event.c\n GEN qmp-introspect.h\n GEN qmp-introspect.c\n GEN trace/generated-tcg-tracers.h\n GEN trace/generated-helpers-wrappers.h\n GEN trace/generated-helpers.h\n GEN trace/generated-helpers.c\n GEN module_block.h\n GEN tests/test-qapi-types.h\n GEN tests/test-qapi-visit.h\n GEN tests/test-qmp-commands.h\n GEN tests/test-qapi-event.h\n GEN tests/test-qmp-introspect.h\n GEN trace-root.h\n GEN util/trace.h\n GEN crypto/trace.h\n GEN io/trace.h\n GEN migration/trace.h\n GEN block/trace.h\n GEN chardev/trace.h\n GEN hw/block/trace.h\n GEN hw/block/dataplane/trace.h\n GEN hw/char/trace.h\n GEN hw/intc/trace.h\n GEN hw/net/trace.h\n GEN hw/virtio/trace.h\n GEN hw/audio/trace.h\n GEN hw/misc/trace.h\n GEN hw/usb/trace.h\n GEN hw/scsi/trace.h\n GEN hw/nvram/trace.h\n GEN hw/display/trace.h\n GEN hw/input/trace.h\n GEN hw/timer/trace.h\n GEN hw/dma/trace.h\n GEN hw/sparc/trace.h\n GEN hw/sd/trace.h\n GEN hw/isa/trace.h\n GEN hw/mem/trace.h\n GEN hw/i386/trace.h\n GEN hw/i386/xen/trace.h\n GEN hw/9pfs/trace.h\n GEN hw/ppc/trace.h\n GEN hw/pci/trace.h\n GEN hw/s390x/trace.h\n GEN hw/vfio/trace.h\n GEN hw/acpi/trace.h\n GEN hw/arm/trace.h\n GEN hw/alpha/trace.h\n GEN hw/xen/trace.h\n GEN ui/trace.h\n GEN audio/trace.h\n GEN net/trace.h\n GEN target/arm/trace.h\n GEN target/i386/trace.h\n GEN target/mips/trace.h\n GEN target/sparc/trace.h\n GEN target/s390x/trace.h\n GEN target/ppc/trace.h\n GEN qom/trace.h\n GEN linux-user/trace.h\n GEN qapi/trace.h\n GEN accel/tcg/trace.h\n GEN accel/kvm/trace.h\n GEN nbd/trace.h\n GEN trace-root.c\n GEN util/trace.c\n GEN crypto/trace.c\n GEN io/trace.c\n GEN migration/trace.c\n GEN block/trace.c\n GEN chardev/trace.c\n GEN hw/block/trace.c\n GEN hw/block/dataplane/trace.c\n GEN hw/char/trace.c\n GEN hw/intc/trace.c\n GEN hw/net/trace.c\n GEN hw/virtio/trace.c\n GEN hw/audio/trace.c\n GEN hw/misc/trace.c\n GEN hw/usb/trace.c\n GEN hw/scsi/trace.c\n GEN hw/nvram/trace.c\n GEN hw/display/trace.c\n GEN hw/input/trace.c\n GEN hw/timer/trace.c\n GEN hw/dma/trace.c\n GEN hw/sparc/trace.c\n GEN hw/sd/trace.c\n GEN hw/isa/trace.c\n GEN hw/mem/trace.c\n GEN hw/i386/trace.c\n GEN hw/i386/xen/trace.c\n GEN hw/9pfs/trace.c\n GEN hw/ppc/trace.c\n GEN hw/pci/trace.c\n GEN hw/s390x/trace.c\n GEN hw/vfio/trace.c\n GEN hw/acpi/trace.c\n GEN hw/arm/trace.c\n GEN hw/alpha/trace.c\n GEN hw/xen/trace.c\n GEN ui/trace.c\n GEN audio/trace.c\n GEN net/trace.c\n GEN target/arm/trace.c\n GEN target/i386/trace.c\n GEN target/mips/trace.c\n GEN target/sparc/trace.c\n GEN target/s390x/trace.c\n GEN target/ppc/trace.c\n GEN qom/trace.c\n GEN linux-user/trace.c\n GEN qapi/trace.c\n GEN accel/tcg/trace.c\n GEN accel/kvm/trace.c\n GEN nbd/trace.c\n GEN config-all-devices.mak\n GEN qga/qapi-generated/qga-qapi-types.h\n GEN qga/qapi-generated/qga-qapi-visit.h\n GEN qga/qapi-generated/qga-qmp-commands.h\n GEN qga/qapi-generated/qga-qapi-types.c\n GEN qga/qapi-generated/qga-qmp-marshal.c\n GEN qga/qapi-generated/qga-qapi-visit.c\n CC qmp-introspect.o\n CC qapi-types.o\n CC qapi-visit.o\n CC qapi-event.o\n CC qapi/qapi-visit-core.o\n CC qapi/qapi-dealloc-visitor.o\n CC qapi/qobject-input-visitor.o\n CC qapi/qobject-output-visitor.o\n CC qapi/qmp-registry.o\n CC qapi/qmp-dispatch.o\n CC qapi/string-input-visitor.o\n CC qapi/string-output-visitor.o\n CC qapi/opts-visitor.o\n CC qapi/qapi-clone-visitor.o\n CC qapi/qmp-event.o\n CC qapi/qapi-util.o\n CC qobject/qnull.o\n CC qobject/qnum.o\n CC qobject/qstring.o\n CC qobject/qdict.o\n CC qobject/qlist.o\n CC qobject/qbool.o\n CC qobject/qjson.o\n CC qobject/qobject.o\n CC qobject/json-lexer.o\n CC qobject/json-streamer.o\n CC qobject/json-parser.o\n CC trace/control.o\n CC trace/qmp.o\n CC util/osdep.o\n CC util/cutils.o\n CC util/unicode.o\n CC util/qemu-timer-common.o\n CC util/bufferiszero.o\n CC util/lockcnt.o\n CC util/aiocb.o\n CC util/async.o\n CC util/thread-pool.o\n CC util/qemu-timer.o\n CC util/main-loop.o\n CC util/iohandler.o\n CC util/aio-posix.o\n CC util/compatfd.o\n CC util/event_notifier-posix.o\n CC util/mmap-alloc.o\n CC util/oslib-posix.o\n CC util/qemu-openpty.o\n CC util/qemu-thread-posix.o\n CC util/memfd.o\n CC util/envlist.o\n CC util/path.o\n CC util/module.o\n CC util/host-utils.o\n CC util/bitmap.o\n CC util/bitops.o\n CC util/hbitmap.o\n CC util/fifo8.o\n CC util/acl.o\n CC util/cacheinfo.o\n CC util/error.o\n CC util/qemu-error.o\n CC util/id.o\n CC util/iov.o\n CC util/qemu-config.o\n CC util/qemu-sockets.o\n CC util/uri.o\n CC util/notify.o\n CC util/qemu-option.o\n CC util/qemu-progress.o\n CC util/keyval.o\n CC util/hexdump.o\n CC util/crc32c.o\n CC util/uuid.o\n CC util/throttle.o\n CC util/getauxval.o\n CC util/readline.o\n CC util/rcu.o\n CC util/qemu-coroutine.o\n CC util/qemu-coroutine-lock.o\n CC util/qemu-coroutine-io.o\n CC util/qemu-coroutine-sleep.o\n CC util/coroutine-ucontext.o\n CC util/timed-average.o\n CC util/buffer.o\n CC util/base64.o\n CC util/log.o\n CC util/qdist.o\n CC util/qht.o\n CC util/range.o\n CC util/stats64.o\n CC util/systemd.o\n CC trace-root.o\n CC util/trace.o\n CC crypto/trace.o\n CC io/trace.o\n CC migration/trace.o\n CC block/trace.o\n CC chardev/trace.o\n CC hw/block/trace.o\n CC hw/block/dataplane/trace.o\n CC hw/char/trace.o\n CC hw/intc/trace.o\n CC hw/net/trace.o\n CC hw/virtio/trace.o\n CC hw/audio/trace.o\n CC hw/misc/trace.o\n CC hw/usb/trace.o\n CC hw/scsi/trace.o\n CC hw/nvram/trace.o\n CC hw/display/trace.o\n CC hw/input/trace.o\n CC hw/timer/trace.o\n CC hw/dma/trace.o\n CC hw/sparc/trace.o\n CC hw/sd/trace.o\n CC hw/isa/trace.o\n CC hw/mem/trace.o\n CC hw/i386/trace.o\n CC hw/i386/xen/trace.o\n CC hw/9pfs/trace.o\n CC hw/ppc/trace.o\n CC hw/pci/trace.o\n CC hw/s390x/trace.o\n CC hw/vfio/trace.o\n CC hw/acpi/trace.o\n CC hw/arm/trace.o\n CC hw/alpha/trace.o\n CC hw/xen/trace.o\n CC ui/trace.o\n CC audio/trace.o\n CC net/trace.o\n CC target/arm/trace.o\n CC target/i386/trace.o\n CC target/mips/trace.o\n CC target/sparc/trace.o\n CC target/s390x/trace.o\n CC target/ppc/trace.o\n CC qom/trace.o\n CC linux-user/trace.o\n CC qapi/trace.o\n CC accel/tcg/trace.o\n CC accel/kvm/trace.o\n CC nbd/trace.o\n CC crypto/pbkdf-stub.o\n CC stubs/arch-query-cpu-def.o\n CC stubs/arch-query-cpu-model-expansion.o\n CC stubs/arch-query-cpu-model-comparison.o\n CC stubs/arch-query-cpu-model-baseline.o\n CC stubs/bdrv-next-monitor-owned.o\n CC stubs/blk-commit-all.o\n CC stubs/blockdev-close-all-bdrv-states.o\n CC stubs/clock-warp.o\n CC stubs/cpu-get-clock.o\n CC stubs/cpu-get-icount.o\n CC stubs/dump.o\n CC stubs/error-printf.o\n CC stubs/fdset.o\n CC stubs/gdbstub.o\n CC stubs/get-vm-name.o\n CC stubs/iothread.o\n CC stubs/iothread-lock.o\n CC stubs/is-daemonized.o\n CC stubs/machine-init-done.o\n CC stubs/migr-blocker.o\n CC stubs/change-state-handler.o\n CC stubs/monitor.o\n CC stubs/notify-event.o\n CC stubs/qtest.o\n CC stubs/replay.o\n CC stubs/runstate-check.o\n CC stubs/set-fd-handler.o\n CC stubs/slirp.o\n CC stubs/sysbus.o\n CC stubs/trace-control.o\n CC stubs/uuid.o\n CC stubs/vm-stop.o\n CC stubs/vmstate.o\n CC stubs/qmp_pc_dimm_device_list.o\n CC stubs/target-monitor-defs.o\n CC stubs/target-get-monitor-def.o\n CC stubs/pc_madt_cpu_entry.o\n CC stubs/vmgenid.o\n CC stubs/xen-common.o\n CC stubs/xen-hvm.o\n CC qemu-nbd.o\n CC block.o\n CC blockjob.o\n CC qemu-io-cmds.o\n CC replication.o\n CC block/raw-format.o\n CC block/qcow.o\n CC block/vdi.o\n CC block/vmdk.o\n CC block/cloop.o\n CC block/bochs.o\n CC block/vpc.o\n CC block/vvfat.o\n CC block/dmg.o\n CC block/qcow2.o\n CC block/qcow2-refcount.o\n CC block/qcow2-cluster.o\n CC block/qcow2-snapshot.o\n CC block/qcow2-cache.o\n CC block/qcow2-bitmap.o\n CC block/qed.o\n CC block/qed-l2-cache.o\n CC block/qed-table.o\n CC block/qed-cluster.o\n CC block/qed-check.o\n CC block/vhdx.o\n CC block/vhdx-endian.o\n CC block/vhdx-log.o\n CC block/quorum.o\n CC block/parallels.o\n CC block/blkdebug.o\n CC block/blkverify.o\n CC block/blkreplay.o\n CC block/block-backend.o\n CC block/snapshot.o\n CC block/qapi.o\n CC block/file-posix.o\n CC block/null.o\n CC block/mirror.o\n CC block/commit.o\n CC block/io.o\n CC block/throttle-groups.o\n CC block/nbd.o\n CC block/nbd-client.o\n CC block/sheepdog.o\n CC block/accounting.o\n CC block/dirty-bitmap.o\n CC block/write-threshold.o\n CC block/backup.o\n CC block/replication.o\n CC block/crypto.o\n CC nbd/server.o\n CC nbd/client.o\n CC nbd/common.o\n CC block/curl.o\n CC block/dmg-bz2.o\n CC crypto/init.o\n CC crypto/hash.o\n CC crypto/hash-glib.o\n CC crypto/hmac.o\n CC crypto/hmac-glib.o\n CC crypto/aes.o\n CC crypto/desrfb.o\n CC crypto/cipher.o\n CC crypto/tlscreds.o\n CC crypto/tlscredsanon.o\n CC crypto/tlscredsx509.o\n CC crypto/tlssession.o\n CC crypto/secret.o\n CC crypto/random-platform.o\n CC crypto/pbkdf.o\n CC crypto/ivgen.o\n CC crypto/ivgen-essiv.o\n CC crypto/ivgen-plain.o\n CC crypto/ivgen-plain64.o\n CC crypto/afsplit.o\n CC crypto/xts.o\n CC crypto/block.o\n CC crypto/block-qcow.o\n CC crypto/block-luks.o\n CC io/channel.o\n CC io/channel-buffer.o\n CC io/channel-command.o\n CC io/channel-file.o\n CC io/channel-socket.o\n CC io/channel-tls.o\n CC io/channel-watch.o\n CC io/channel-websock.o\n CC io/channel-util.o\n CC io/dns-resolver.o\n CC io/task.o\n CC qom/object.o\n CC qom/container.o\n CC qom/qom-qobject.o\n CC qom/object_interfaces.o\n GEN qemu-img-cmds.h\n CC qemu-io.o\n CC blockdev.o\n CC blockdev-nbd.o\n CC bootdevice.o\n CC iothread.o\n CC qdev-monitor.o\n CC device-hotplug.o\n CC os-posix.o\n CC bt-host.o\n CC bt-vhci.o\n CC dma-helpers.o\n CC vl.o\n CC tpm.o\n CC qmp-marshal.o\n CC qmp.o\n CC hmp.o\n CC cpus-common.o\n CC audio/audio.o\n CC audio/noaudio.o\n CC audio/wavaudio.o\n CC audio/mixeng.o\n CC audio/ossaudio.o\n CC audio/wavcapture.o\n CC backends/rng.o\n CC backends/rng-egd.o\n CC backends/rng-random.o\n CC backends/tpm.o\n CC backends/hostmem.o\n CC backends/hostmem-ram.o\n CC backends/cryptodev.o\n CC backends/cryptodev-builtin.o\n CC block/stream.o\n CC chardev/msmouse.o\n CC chardev/wctablet.o\n CC chardev/testdev.o\n CC disas/i386.o\n CC hw/acpi/core.o\n CC hw/acpi/piix4.o\n CC hw/acpi/pcihp.o\n CC hw/acpi/ich9.o\n CC hw/acpi/tco.o\n CC hw/acpi/cpu_hotplug.o\n CC hw/acpi/memory_hotplug.o\n CC hw/acpi/cpu.o\n CC hw/acpi/nvdimm.o\n CC hw/acpi/vmgenid.o\n CC hw/acpi/acpi_interface.o\n CC hw/acpi/bios-linker-loader.o\n CC hw/acpi/aml-build.o\n CC hw/acpi/ipmi.o\n CC hw/acpi/acpi-stub.o\n CC hw/acpi/ipmi-stub.o\n CC hw/audio/sb16.o\n CC hw/audio/es1370.o\n CC hw/audio/ac97.o\n CC hw/audio/fmopl.o\n CC hw/audio/adlib.o\n CC hw/audio/gus.o\n CC hw/audio/gusemu_hal.o\n CC hw/audio/gusemu_mixer.o\n CC hw/audio/cs4231a.o\n CC hw/audio/intel-hda.o\n CC hw/audio/hda-codec.o\n CC hw/audio/pcspk.o\n CC hw/audio/soundhw.o\n CC hw/block/block.o\n CC hw/block/cdrom.o\n CC hw/block/hd-geometry.o\n CC hw/block/fdc.o\n CC hw/block/pflash_cfi01.o\n CC hw/block/nvme.o\n CC hw/bt/core.o\n CC hw/bt/l2cap.o\n CC hw/bt/sdp.o\n CC hw/bt/hci.o\n CC hw/bt/hid.o\n CC hw/bt/hci-csr.o\n CC hw/char/ipoctal232.o\n CC hw/char/parallel.o\n CC hw/char/serial.o\n CC hw/char/serial-isa.o\n CC hw/char/serial-pci.o\n CC hw/char/virtio-console.o\n CC hw/char/debugcon.o\n CC hw/core/qdev.o\n CC hw/core/qdev-properties.o\n CC hw/core/bus.o\n CC hw/core/reset.o\n CC hw/core/fw-path-provider.o\n CC hw/core/irq.o\n CC hw/core/hotplug.o\n CC hw/core/nmi.o\n CC hw/core/sysbus.o\n CC hw/core/machine.o\n CC hw/core/loader.o\n CC hw/core/qdev-properties-system.o\n CC hw/core/register.o\n CC hw/core/or-irq.o\n CC hw/cpu/core.o\n CC hw/display/cirrus_vga.o\n CC hw/display/vga-pci.o\n CC hw/display/vga-isa.o\n CC hw/display/vmware_vga.o\n CC hw/dma/i8257.o\n CC hw/i2c/core.o\n CC hw/i2c/smbus.o\n CC hw/i2c/smbus_eeprom.o\n CC hw/i2c/smbus_ich9.o\n CC hw/i2c/pm_smbus.o\n CC hw/ide/core.o\n CC hw/ide/atapi.o\n CC hw/ide/qdev.o\n CC hw/ide/pci.o\n CC hw/ide/isa.o\n CC hw/ide/piix.o\n CC hw/ide/ahci.o\n CC hw/ide/ich.o\n CC hw/input/hid.o\n CC hw/input/pckbd.o\n CC hw/input/ps2.o\n CC hw/input/vmmouse.o\n CC hw/input/virtio-input.o\n CC hw/input/virtio-input-hid.o\n CC hw/intc/i8259_common.o\n CC hw/intc/i8259.o\n CC hw/intc/ioapic_common.o\n CC hw/intc/intc.o\n CC hw/ipack/ipack.o\n CC hw/ipack/tpci200.o\n CC hw/ipmi/ipmi.o\n CC hw/ipmi/ipmi_bmc_sim.o\n CC hw/ipmi/ipmi_bmc_extern.o\n CC hw/ipmi/isa_ipmi_kcs.o\n CC hw/isa/isa-bus.o\n CC hw/ipmi/isa_ipmi_bt.o\n CC hw/isa/apm.o\n CC hw/mem/pc-dimm.o\n CC hw/mem/nvdimm.o\n CC hw/misc/applesmc.o\n CC hw/misc/debugexit.o\n CC hw/misc/sga.o\n CC hw/misc/pc-testdev.o\n CC hw/misc/pci-testdev.o\n CC hw/misc/edu.o\n CC hw/misc/unimp.o\n CC hw/net/ne2000.o\n CC hw/net/eepro100.o\n CC hw/net/pcnet-pci.o\n CC hw/net/pcnet.o\n CC hw/net/e1000.o\n CC hw/net/e1000x_common.o\n CC hw/net/net_tx_pkt.o\n CC hw/net/net_rx_pkt.o\n CC hw/net/e1000e.o\n CC hw/net/e1000e_core.o\n CC hw/net/rtl8139.o\n CC hw/net/vmxnet3.o\n CC hw/net/ne2000-isa.o\n CC hw/net/rocker/rocker.o\n CC hw/net/rocker/rocker_fp.o\n CC hw/net/rocker/rocker_desc.o\n CC hw/net/rocker/rocker_world.o\n CC hw/net/rocker/rocker_of_dpa.o\n CC hw/nvram/eeprom93xx.o\n CC hw/nvram/fw_cfg.o\n CC hw/nvram/chrp_nvram.o\n CC hw/pci-bridge/pci_bridge_dev.o\n CC hw/pci-bridge/pcie_root_port.o\n CC hw/pci-bridge/gen_pcie_root_port.o\n CC hw/pci-bridge/pci_expander_bridge.o\n CC hw/pci-bridge/xio3130_upstream.o\n CC hw/pci-bridge/xio3130_downstream.o\n CC hw/pci-bridge/ioh3420.o\n CC hw/pci-bridge/i82801b11.o\n CC hw/pci-host/pam.o\n CC hw/pci-host/piix.o\n CC hw/pci-host/q35.o\n CC hw/pci/pci.o\n CC hw/pci/pci_bridge.o\n CC hw/pci/msix.o\n CC hw/pci/msi.o\n CC hw/pci/shpc.o\n CC hw/pci/slotid_cap.o\n CC hw/pci/pci_host.o\n CC hw/pci/pcie_host.o\n CC hw/pci/pcie.o\n CC hw/pci/pcie_aer.o\n CC hw/pci/pcie_port.o\n CC hw/pci/pci-stub.o\n CC hw/pcmcia/pcmcia.o\n CC hw/scsi/scsi-disk.o\n CC hw/scsi/scsi-generic.o\n CC hw/scsi/scsi-bus.o\n CC hw/scsi/lsi53c895a.o\n CC hw/scsi/mptsas.o\n CC hw/scsi/mptconfig.o\n CC hw/scsi/mptendian.o\n CC hw/scsi/megasas.o\n CC hw/scsi/vmw_pvscsi.o\n CC hw/scsi/esp.o\n CC hw/scsi/esp-pci.o\n CC hw/sd/sd.o\n CC hw/sd/core.o\n CC hw/sd/sdhci.o\n CC hw/smbios/smbios.o\n CC hw/smbios/smbios_type_38.o\n CC hw/smbios/smbios-stub.o\n CC hw/smbios/smbios_type_38-stub.o\n CC hw/timer/hpet.o\n CC hw/timer/i8254_common.o\n CC hw/timer/i8254.o\n CC hw/tpm/tpm_tis.o\n CC hw/usb/core.o\n CC hw/usb/combined-packet.o\n CC hw/usb/bus.o\n CC hw/usb/libhw.o\n CC hw/usb/desc.o\n CC hw/usb/desc-msos.o\n CC hw/usb/hcd-uhci.o\n CC hw/usb/hcd-ohci.o\n CC hw/usb/hcd-ehci.o\n CC hw/usb/hcd-ehci-pci.o\n CC hw/usb/hcd-xhci.o\n CC hw/usb/hcd-xhci-nec.o\n CC hw/usb/dev-hub.o\n CC hw/usb/dev-hid.o\n CC hw/usb/dev-wacom.o\n CC hw/usb/dev-storage.o\n CC hw/usb/dev-uas.o\n CC hw/usb/dev-audio.o\n CC hw/usb/dev-serial.o\n CC hw/usb/dev-network.o\n CC hw/usb/dev-bluetooth.o\n CC hw/usb/dev-smartcard-reader.o\n CC hw/usb/dev-mtp.o\n CC hw/usb/host-libusb.o\n CC hw/usb/host-legacy.o\n CC hw/virtio/virtio-rng.o\n CC hw/virtio/virtio-pci.o\n CC hw/virtio/virtio-bus.o\n CC hw/virtio/virtio-mmio.o\n CC hw/virtio/vhost-stub.o\n CC hw/watchdog/watchdog.o\n CC hw/watchdog/wdt_i6300esb.o\n CC hw/watchdog/wdt_ib700.o\n CC migration/migration.o\n CC migration/socket.o\n CC migration/fd.o\n CC migration/exec.o\n CC migration/tls.o\n CC migration/channel.o\n CC migration/savevm.o\n CC migration/colo-comm.o\n CC migration/colo.o\n CC migration/colo-failover.o\n CC migration/vmstate.o\n CC migration/vmstate-types.o\n CC migration/page_cache.o\n CC migration/qemu-file.o\n CC migration/global_state.o\n CC migration/qemu-file-channel.o\n CC migration/xbzrle.o\n CC migration/postcopy-ram.o\n CC migration/qjson.o\n CC migration/block.o\n CC net/net.o\n CC net/queue.o\n CC net/checksum.o\n CC net/util.o\n CC net/hub.o\n CC net/socket.o\n CC net/dump.o\n CC net/eth.o\n CC net/vhost-user.o\n CC net/slirp.o\n CC net/netmap.o\n CC net/filter.o\n CC net/filter-buffer.o\n CC net/filter-mirror.o\n CC net/colo-compare.o\n CC net/colo.o\n CC net/filter-rewriter.o\n CC net/filter-replay.o\n CC net/tap.o\n CC net/tap-bsd.o\n CC qom/cpu.o\n CC replay/replay.o\n CC replay/replay-internal.o\n CC replay/replay-events.o\n CC replay/replay-time.o\n CC replay/replay-input.o\n CC replay/replay-char.o\n CC replay/replay-snapshot.o\n CC replay/replay-net.o\n CC replay/replay-audio.o\n CC slirp/cksum.o\n CC slirp/if.o\n CC slirp/ip_icmp.o\n CC slirp/ip6_icmp.o\n CC slirp/ip6_input.o\n CC slirp/ip6_output.o\n CC slirp/ip_input.o\n CC slirp/ip_output.o\n CC slirp/dnssearch.o\n CC slirp/dhcpv6.o\n CC slirp/slirp.o\n CC slirp/mbuf.o\n CC slirp/misc.o\n CC slirp/sbuf.o\n CC slirp/socket.o\n CC slirp/tcp_input.o\n CC slirp/tcp_output.o\n CC slirp/tcp_subr.o\n CC slirp/tcp_timer.o\n CC slirp/udp.o\n CC slirp/udp6.o\n CC slirp/bootp.o\n CC slirp/tftp.o\n CC slirp/arp_table.o\n CC slirp/ndp_table.o\n CC slirp/ncsi.o\n CC ui/keymaps.o\n CC ui/console.o\n CC ui/cursor.o\n CC ui/qemu-pixman.o\n CC ui/input.o\n CC ui/input-keymap.o\n CC ui/input-legacy.o\n CC ui/curses.o\n CC ui/vnc.o\n CC ui/vnc-enc-zlib.o\n CC ui/vnc-enc-hextile.o\n CC ui/vnc-enc-tight.o\n CC ui/vnc-palette.o\n CC ui/vnc-enc-zrle.o\n CC ui/vnc-auth-vencrypt.o\n CC ui/vnc-ws.o\n CC ui/vnc-jobs.o\n CC chardev/char.o\n CC chardev/char-fd.o\n CC chardev/char-fe.o\n CC chardev/char-file.o\n CC chardev/char-io.o\n CC chardev/char-mux.o\n CC chardev/char-null.o\n CC chardev/char-parallel.o\n CC chardev/char-pipe.o\n CC chardev/char-pty.o\n CC chardev/char-ringbuf.o\n CC chardev/char-serial.o\n CC chardev/char-socket.o\n CC chardev/char-stdio.o\n CC chardev/char-udp.o\n AS optionrom/multiboot.o\n AS optionrom/linuxboot.o\n CC optionrom/linuxboot_dma.o\n CC qga/commands.o\n CC qga/guest-agent-command-state.o\n AS optionrom/kvmvapic.o\n CC qga/main.o\n BUILD optionrom/multiboot.img\n BUILD optionrom/linuxboot.img\n BUILD optionrom/linuxboot_dma.img\n BUILD optionrom/kvmvapic.img\n BUILD optionrom/multiboot.raw\n BUILD optionrom/linuxboot.raw\n BUILD optionrom/linuxboot_dma.raw\n BUILD optionrom/kvmvapic.raw\n SIGN optionrom/multiboot.bin\n SIGN optionrom/linuxboot.bin\n SIGN optionrom/linuxboot_dma.bin\n SIGN optionrom/kvmvapic.bin\n CC qga/commands-posix.o\n CC qga/channel-posix.o\n CC qga/qapi-generated/qga-qapi-types.o\n CC qga/qapi-generated/qga-qapi-visit.o\n CC qga/qapi-generated/qga-qmp-marshal.o\n AR libqemuutil.a\n AR libqemustub.a\n CC qemu-img.o\n LINK qemu-nbd\n LINK qemu-io\n LINK qemu-ga\n GEN x86_64-softmmu/hmp-commands.h\n GEN x86_64-softmmu/hmp-commands-info.h\n GEN x86_64-softmmu/config-target.h\n CC x86_64-softmmu/exec.o\n CC x86_64-softmmu/tcg/tcg.o\n CC x86_64-softmmu/tcg/tcg-op.o\n CC x86_64-softmmu/tcg/optimize.o\n CC x86_64-softmmu/tcg/tcg-common.o\n CC x86_64-softmmu/tcg/tcg-runtime.o\n CC x86_64-softmmu/fpu/softfloat.o\n CC x86_64-softmmu/disas.o\n GEN x86_64-softmmu/gdbstub-xml.c\n CC x86_64-softmmu/hax-stub.o\n CC x86_64-softmmu/arch_init.o\n CC x86_64-softmmu/cpus.o\n CC x86_64-softmmu/monitor.o\n CC x86_64-softmmu/gdbstub.o\n CC x86_64-softmmu/balloon.o\n LINK qemu-img\n CC x86_64-softmmu/ioport.o\n CC x86_64-softmmu/numa.o\n CC x86_64-softmmu/qtest.o\n CC x86_64-softmmu/memory.o\n CC x86_64-softmmu/memory_mapping.o\n CC x86_64-softmmu/dump.o\n CC x86_64-softmmu/migration/ram.o\n CC x86_64-softmmu/accel/accel.o\n CC x86_64-softmmu/accel/stubs/kvm-stub.o\n CC x86_64-softmmu/accel/tcg/tcg-all.o\n CC x86_64-softmmu/accel/tcg/cputlb.o\n CC x86_64-softmmu/accel/tcg/cpu-exec.o\n CC x86_64-softmmu/accel/tcg/translate-all.o\n CC x86_64-softmmu/accel/tcg/cpu-exec-common.o\n CC x86_64-softmmu/hw/block/virtio-blk.o\n CC x86_64-softmmu/hw/block/dataplane/virtio-blk.o\n CC x86_64-softmmu/hw/char/virtio-serial-bus.o\n CC x86_64-softmmu/hw/core/generic-loader.o\n CC x86_64-softmmu/hw/core/null-machine.o\n CC x86_64-softmmu/hw/display/vga.o\n CC x86_64-softmmu/hw/display/virtio-gpu.o\n CC x86_64-softmmu/hw/display/virtio-gpu-3d.o\n CC x86_64-softmmu/hw/display/virtio-gpu-pci.o\n CC x86_64-softmmu/hw/display/virtio-vga.o\n CC x86_64-softmmu/hw/intc/apic.o\n CC x86_64-softmmu/hw/intc/apic_common.o\n CC x86_64-softmmu/hw/intc/ioapic.o\n CC x86_64-softmmu/hw/isa/lpc_ich9.o\n CC x86_64-softmmu/hw/misc/vmport.o\n CC x86_64-softmmu/hw/misc/pvpanic.o\n CC x86_64-softmmu/hw/misc/mmio_interface.o\n CC x86_64-softmmu/hw/net/virtio-net.o\n CC x86_64-softmmu/hw/net/vhost_net.o\n CC x86_64-softmmu/hw/scsi/virtio-scsi.o\n CC x86_64-softmmu/hw/scsi/virtio-scsi-dataplane.o\n CC x86_64-softmmu/hw/timer/mc146818rtc.o\n CC x86_64-softmmu/hw/virtio/virtio.o\n CC x86_64-softmmu/hw/virtio/virtio-balloon.o\n CC x86_64-softmmu/hw/virtio/virtio-crypto.o\n CC x86_64-softmmu/hw/virtio/virtio-crypto-pci.o\n CC x86_64-softmmu/hw/i386/multiboot.o\n CC x86_64-softmmu/hw/i386/pc.o\n CC x86_64-softmmu/hw/i386/pc_piix.o\n CC x86_64-softmmu/hw/i386/pc_q35.o\n CC x86_64-softmmu/hw/i386/pc_sysfw.o\n CC x86_64-softmmu/hw/i386/x86-iommu.o\n CC x86_64-softmmu/hw/i386/intel_iommu.o\n CC x86_64-softmmu/hw/i386/amd_iommu.o\n CC x86_64-softmmu/hw/i386/kvmvapic.o\n CC x86_64-softmmu/hw/i386/acpi-build.o\n CC x86_64-softmmu/hw/i386/pci-assign-load-rom.o\n CC x86_64-softmmu/target/i386/helper.o\n CC x86_64-softmmu/target/i386/cpu.o\n CC x86_64-softmmu/target/i386/gdbstub.o\n CC x86_64-softmmu/target/i386/xsave_helper.o\n CC x86_64-softmmu/target/i386/translate.o\n CC x86_64-softmmu/target/i386/bpt_helper.o\n CC x86_64-softmmu/target/i386/cc_helper.o\n CC x86_64-softmmu/target/i386/excp_helper.o\n CC x86_64-softmmu/target/i386/fpu_helper.o\n CC x86_64-softmmu/target/i386/int_helper.o\n CC x86_64-softmmu/target/i386/mem_helper.o\n CC x86_64-softmmu/target/i386/misc_helper.o\n CC x86_64-softmmu/target/i386/mpx_helper.o\n CC x86_64-softmmu/target/i386/seg_helper.o\n CC x86_64-softmmu/target/i386/smm_helper.o\n CC x86_64-softmmu/target/i386/svm_helper.o\n CC x86_64-softmmu/target/i386/machine.o\n CC x86_64-softmmu/target/i386/arch_memory_mapping.o\n CC x86_64-softmmu/target/i386/arch_dump.o\n CC x86_64-softmmu/target/i386/monitor.o\n CC x86_64-softmmu/target/i386/kvm-stub.o\n GEN trace/generated-helpers.c\n CC x86_64-softmmu/trace/control-target.o\n CC x86_64-softmmu/gdbstub-xml.o\n CC x86_64-softmmu/trace/generated-helpers.o\n LINK x86_64-softmmu/qemu-system-x86_64\ninstall -d -m 0755 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu\"\ninstall -d -m 0755 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/var\"/run\ninstall -d -m 0755 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin\"\ninstall -c -m 0755 qemu-ga qemu-nbd qemu-img qemu-io \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin\"\nstrip \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin/qemu-ga\" \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin/qemu-nbd\" \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin/qemu-img\" \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin/qemu-io\"\nset -e; for x in bios.bin bios-256k.bin sgabios.bin vgabios.bin vgabios-cirrus.bin vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin vgabios-virtio.bin acpi-dsdt.aml ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc QEMU,tcx.bin QEMU,cgthree.bin pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom pxe-pcnet.rom pxe-rtl8139.rom pxe-virtio.rom efi-e1000.rom efi-eepro100.rom efi-ne2k_pci.rom efi-pcnet.rom efi-rtl8139.rom efi-virtio.rom efi-e1000e.rom efi-vmxnet3.rom qemu-icon.bmp qemu_logo_no_text.svg bamboo.dtb petalogix-s3adsp1800.dtb petalogix-ml605.dtb multiboot.bin linuxboot.bin linuxboot_dma.bin kvmvapic.bin s390-ccw.img s390-netboot.img spapr-rtas.bin slof.bin skiboot.lid palcode-clipper u-boot.e500 qemu_vga.ndrv; do \\\n\tinstall -c -m 0644 /var/tmp/patchew-tester-tmp-cala1q33/src/pc-bios/$x \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu\"; \\\ndone\ninstall -d -m 0755 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu/keymaps\"\nset -e; for x in da en-gb et fr fr-ch is lt modifiers no pt-br sv ar de en-us fi fr-be hr it lv nl pl ru th common de-ch es fo fr-ca hu ja mk nl-be pt sl tr bepo cz; do \\\n\tinstall -c -m 0644 /var/tmp/patchew-tester-tmp-cala1q33/src/pc-bios/keymaps/$x \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu/keymaps\"; \\\ndone\ninstall -c -m 0644 /var/tmp/patchew-tester-tmp-cala1q33/src/build/trace-events-all \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/share/qemu/trace-events-all\"\nfor d in x86_64-softmmu; do \\\ngmake --no-print-directory BUILD_DIR=/var/tmp/patchew-tester-tmp-cala1q33/src/build TARGET_DIR=$d/ -C $d install || exit 1 ; \\\n done\ninstall -d -m 0755 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin\"\ninstall -c -m 0755 qemu-system-x86_64 \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin\"\nstrip \"/var/tmp/patchew-tester-tmp-cala1q33/src/install/bin/qemu-system-x86_64\"\nstrip: elf_update() failed: I/O error: No space left on device\ngmake[1]: *** [Makefile:225: install] Error 1\ngmake: *** [Makefile:611: install] Error 1\n=== OUTPUT END ===\n\nTest command exited with code: 2\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm2NR4NT0z9s72\n\tfor ;\n\tMon, 4 Sep 2017 18:01:11 +1000 (AEST)","from localhost ([::1]:41369 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1domJh-0005Lm-Pa\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 04:01:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43748)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1domJD-0005KL-Rp\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 04:00:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1domJ6-0006Dp-8l\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 04:00:39 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21426)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1domJ5-0006BS-PB\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 04:00:32 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 150451201411414.305020297778583;\n\tMon, 4 Sep 2017 01:00:14 -0700 (PDT)"],"Resent-Date":"Mon, 04 Sep 2017 04:00:39 -0400","Resent-Message-Id":"","Message-ID":"<150451201350.17979.9335009903013350834@2f78fa2a9cb4>","In-Reply-To":"<20170903163130.14288-1-n54@gmx.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"n54@gmx.com","Date":"Mon, 4 Sep 2017 01:00:14 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"n54@gmx.com, famz@redhat.com, laurent@vivier.eu, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762656,"web_url":"http://patchwork.ozlabs.org/comment/1762656/","msgid":"<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>","list_archive_url":null,"date":"2017-09-04T13:54:56","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":11273,"url":"http://patchwork.ozlabs.org/api/people/11273/","name":"Kamil Rytarowski","email":"n54@gmx.com"},"content":"On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote:\n> On 09/03/2017 02:05 PM, Laurent Vivier wrote:\n>> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n>>> GCC 4.7.2 on SunOS reports that the values assigned to array members\n>>> are not\n>>> real constants:\n>>>\n>>> target/m68k/fpu_helper.c:32:5: error: initializer element is not\n>>> constant\n>>> target/m68k/fpu_helper.c:32:5: error: (near initialization for\n>>> 'fpu_rom[0]')\n>>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>>\n>>> Convert the array to switch() to workaround the issue.\n>>\n>> I don't like the idea. It's really an array and should be managed as an\n>> array.\n> \n> I agree with Laurent.\n> \n>>\n>> Could you try to use make_floatx80_init() instead of make_floatx80() ?\n> \n> I guess the problem comes from the macro which cast as not const:\n> \n> #define make_floatx80(exp, mant) ((floatx80) { mant, exp })\n> \n\nAdding const to make_floatx80 - ((const floatx80) { mant, exp }) - does\nnot fix the problem.\n\n> make_floatx80_init() doesn't cast so it might work,\n> else we could add a macro such const_floatx80():\n> \n> #define const_floatx80(exp, mant) ((const floatx80) { mant, exp })\n\nSwitching make_floatx80() to make_floatx80_init() in works.\n\nHow about floatx80_zero, floatx80_one etc? We cannot translate them to\nmake_floatx80_init() as this breaks in other parts of the code in\nfunctions like:\n\nvoid helper_fldpi_ST0(CPUX86State *env)\n{\n ST0 = floatx80_pi;\n}\n\n-- target/i386/fpu_helper.c","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBCK6q7Cz9t2R\n\tfor ;\n\tMon, 4 Sep 2017 23:53:49 +1000 (AEST)","from localhost ([::1]:43820 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dorox-0000iE-Vj\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 09:53:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41864)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from )\n\tid 1doro4-0000Px-K0\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:52:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dornz-0005R9-Ly\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:52:52 -0400","from mout.gmx.net ([212.227.17.22]:56796)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dornz-0005O2-Ad\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 09:52:47 -0400","from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx102\n\t[212.227.17.174]) with ESMTPSA (Nemesis) id 0MJFBe-1dnCqH0j9e-002pu6; \n\tMon, 04 Sep 2017 15:52:43 +0200"],"To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tLaurent Vivier ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>","From":"Kamil Rytarowski ","Message-ID":"<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>","Date":"Mon, 4 Sep 2017 15:54:56 +0200","User-Agent":"Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"q3HnPTFspblfRg0crjkppB5re7F8cQNO1\"","X-Provags-ID":"V03:K0:CNYUpcgg9dsfDQXfm+blXYkersiaV1L4yEVut28vzLemP7RM3tY\n\t3U8jVerpqL8aoBzfr7XWSnzG3PluPNOO+kjYZYC7OxbmHguA6NkUfFcD1zX2d5zOJv+nAsN\n\t3i1wxpSxT63MfLyCmdudvIAb7wpDrd8OID5cH7YdUd96ciz27zX39m35aFYUessH+FPt55M\n\t92o7rcaaNS/Wr1sFWWRjA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:757Lhd2D02g=:YnayjL0PPZ1GznZtpUMFbV\n\tmrEf1gJzGzXFhbnNBbKrF05n19OI0AtJgi+weLsuScequYier0lrpZXeQnrL+4cxpkHWVUSB4\n\ty5k4bx4wRahsOyxJsFw0ldB3HO7YouVrDbewQpqm5GdswEXuTW40TQc0hj4MFM3ftXXTH02LZ\n\tPi0G++tBPfLIhVXKXaOjMQzjKExwj0nFX4XUqaFIyMqdDgrsrO6bkxbDt6sye9Ghay8JaVqXF\n\tBTd9Femyk9tSPkNSMlo7P2kvIoK2P7cuAWGtFhtfCIeUGAipRvaX10Na7cDH2SLYs14FnHSnI\n\tLYoD/cPQacikJ7EjdFT9Ov/hXIHeVNB45OWBM5x9e8MbBZNsC0/Lzy0jrrm4pA4K21WDQuuF9\n\thO8K64aP9NcJXzJDNP+aA5IgDf09i4R5jD3J3t4ccO5iLg/bNMzZaQUKZchnynszPHsupcppt\n\tY+tSf+q99PRMHN6v8njIfGKC9+LyxqV/6nI14rehU1TAh/+/F9I4C7cIf9WpF6DiuijQxjav3\n\t8kT9lZTcS+T5i8pGzfeyvZb5TfilMgPIuy1F0xFqmjRrgu3qnAyQlVC4Nuu4mLhr2z5PPMmzn\n\t/bpv8CcHjUIqGkRONUyakj9nS33B8kmRU0xLzS5IQNSHDYxnAjV2IiXXIiOoi/8j/rTzVgxn5\n\tghWAnp6+hG6JlwAsZlpcK4fx00HS5Soc6udshLTc43Fta4JAqRvK00UpaqiZEFtLgnUvfq+fd\n\taMEPd3TwtHvLyqo8tVeMHseYW/ce0yMW3Lybvd8FpIinM7+XGBpOUVyfq6Mrr65s81SOzbjAA\n\tutIPPJZWB9cW3M0UD4e+uXMS3GzJg==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.17.22","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762676,"web_url":"http://patchwork.ozlabs.org/comment/1762676/","msgid":"","list_archive_url":null,"date":"2017-09-04T14:09:01","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit :\n> On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote:\n>> On 09/03/2017 02:05 PM, Laurent Vivier wrote:\n>>> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n>>>> GCC 4.7.2 on SunOS reports that the values assigned to array members\n>>>> are not\n>>>> real constants:\n>>>>\n>>>> target/m68k/fpu_helper.c:32:5: error: initializer element is not\n>>>> constant\n>>>> target/m68k/fpu_helper.c:32:5: error: (near initialization for\n>>>> 'fpu_rom[0]')\n>>>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>>>\n>>>> Convert the array to switch() to workaround the issue.\n>>>\n>>> I don't like the idea. It's really an array and should be managed as an\n>>> array.\n>>\n>> I agree with Laurent.\n>>\n>>>\n>>> Could you try to use make_floatx80_init() instead of make_floatx80() ?\n>>\n>> I guess the problem comes from the macro which cast as not const:\n>>\n>> #define make_floatx80(exp, mant) ((floatx80) { mant, exp })\n>>\n> \n> Adding const to make_floatx80 - ((const floatx80) { mant, exp }) - does\n> not fix the problem.\n> \n>> make_floatx80_init() doesn't cast so it might work,\n>> else we could add a macro such const_floatx80():\n>>\n>> #define const_floatx80(exp, mant) ((const floatx80) { mant, exp })\n> \n> Switching make_floatx80() to make_floatx80_init() in works.\n> \n> How about floatx80_zero, floatx80_one etc? We cannot translate them to\n> make_floatx80_init() as this breaks in other parts of the code in\n> functions like:\n> \n> void helper_fldpi_ST0(CPUX86State *env)\n> {\n> ST0 = floatx80_pi;\n> }\n> \n> -- target/i386/fpu_helper.c\n> \n\nYou can:\n\neither replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\nfloatx80 floatx80_pi = make_floatx80_init(...)\"\n\nor replace all the macros in the m68k/fpu_helper.c array by\nmake_floatx80_init(...)\n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBbR6vzgz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 00:11:15 +1000 (AEST)","from localhost ([::1]:45368 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dos5q-00021o-3J\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 10:11:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51122)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dos3t-0000l3-Ec\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:09:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dos3o-0000xg-LR\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:09:13 -0400","from mout.kundenserver.de ([217.72.192.73]:53248)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dos3o-0000wq-9v\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:09:08 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue101 [212.227.15.183]) with ESMTPSA (Nemesis) id\n\t0MVd0h-1dyym038AB-00Z3Fj; Mon, 04 Sep 2017 16:09:03 +0200"],"To":"Kamil Rytarowski , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>","From":"Laurent Vivier ","Message-ID":"","Date":"Mon, 4 Sep 2017 16:09:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"6TtRvucrTNgLNTjbqF5Hh2jdtrIQsN6dX\"","X-Provags-ID":"V03:K0:srex5/VXzksmGwd/dLBgO1rfxgVxxjeFgzDC7EfQ1s7uQlzwSiZ\n\t9Tre2D9YAZ3r5pa/d2be9v4FDhxngER/cexhGp4lmiZXeZcjJCKp25QR/0fRxOwshssuGeZ\n\tr6B1Qh9Tq304rNY1DM3eHda8UXyB0pSWUVyykSPcTxvzrY4y5+35qNVC4M8QYJ2MAi5Ju1X\n\tK8ZTQIeJT1YtTMq3n+D4A==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:2ZTjbZwVB80=:l6y+v79nZofyRkfwYzyKwy\n\tW2qd/hj1d8m7QwsZR/kBHooLwa0b6bHiQ6EOFdlTk+7P+4QKVRgb6WMpTPUy/Q/OY9JtKn6RR\n\tGYCApBh40thm3oe1EgF8y5IgoFkg7gMdBRPnahV36mqkLPWdfi1+XGyLuDRTIRFPv+sy3DWfH\n\tq+GTlZRPptCgCy/XTVfE1sVsHA0RK/PVEMpJOiIiItKqr2wOuZchKNHusDZrwcYyGX/8Fnb2v\n\tb9ZfwOiOPTMhvC2wB3S1EXctdxku+kF2cK/DnSreu4170BLCT8k9jr0DBW51PlRiHY3bDTh7W\n\tqmYdYfXcS3uRbT2tk/x78tSEoiMqnXzsG2O6SpyWUcPu3SHzRiEMQltLSCseW/aJTTHvRDouK\n\tznkQlY8LWGDfUd+zIHHtBI9M2Dz+C9m6bnzJ7QQXoLaWrkFaOylbwuLP6fZVu/I/RdJJ49lib\n\tJsYGZ29BKe0uNTa/OrPPbxEYcye2A/jAlJJT8V/r18h50Stm//U9wl1D42VH7LCqNMpaHC1Ky\n\tP3Wvjc7cQJS5czDky0N4ko6lb3oGCG/vTc+TgZh/9TxiR5jMo6PsX3/AjPfk8BIvkY+H9xh0D\n\tZdupIfV2v1sx0d0o9k9vkM63E3so2XBg33YJxqcaVl//zeUHtST6UyubjV3RcZSqf8k75V75c\n\tm1z4N6vP1a+v8BEpj5i6jDf3NRrmc1PERLvoOZJFQW/fZeT3EccixnjZM9VICt8NGqucCmLMN\n\thzrJw3QgpFkIIPHApKjJLOmZ4bCZObLFoEG7/g==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"217.72.192.73","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762697,"web_url":"http://patchwork.ozlabs.org/comment/1762697/","msgid":"<047f9b63-2dcc-e8ba-90c1-965e253fcbf5@amsat.org>","list_archive_url":null,"date":"2017-09-04T14:41:35","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/04/2017 11:09 AM, Laurent Vivier wrote:\n> Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit :\n>> On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote:\n>>> On 09/03/2017 02:05 PM, Laurent Vivier wrote:\n>>>> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n>>>>> GCC 4.7.2 on SunOS reports that the values assigned to array members\n>>>>> are not\n>>>>> real constants:\n>>>>>\n>>>>> target/m68k/fpu_helper.c:32:5: error: initializer element is not\n>>>>> constant\n>>>>> target/m68k/fpu_helper.c:32:5: error: (near initialization for\n>>>>> 'fpu_rom[0]')\n>>>>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>>>>\n>>>>> Convert the array to switch() to workaround the issue.\n>>>>\n>>>> I don't like the idea. It's really an array and should be managed as an\n>>>> array.\n>>>\n>>> I agree with Laurent.\n>>>\n>>>>\n>>>> Could you try to use make_floatx80_init() instead of make_floatx80() ?\n>>>\n>>> I guess the problem comes from the macro which cast as not const:\n>>>\n>>> #define make_floatx80(exp, mant) ((floatx80) { mant, exp })\n>>>\n>>\n>> Adding const to make_floatx80 - ((const floatx80) { mant, exp }) - does\n>> not fix the problem.\n>>\n>>> make_floatx80_init() doesn't cast so it might work,\n>>> else we could add a macro such const_floatx80():\n>>>\n>>> #define const_floatx80(exp, mant) ((const floatx80) { mant, exp })\n>>\n>> Switching make_floatx80() to make_floatx80_init() in works.\n>>\n>> How about floatx80_zero, floatx80_one etc? We cannot translate them to\n>> make_floatx80_init() as this breaks in other parts of the code in\n>> functions like:\n>>\n>> void helper_fldpi_ST0(CPUX86State *env)\n>> {\n>> ST0 = floatx80_pi;\n>> }\n>>\n>> -- target/i386/fpu_helper.c\n>>\n> \n> You can:\n> \n> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n> floatx80 floatx80_pi = make_floatx80_init(...)\"\n\nthis won't work with:\n\nconst floatx80 2pi = floatx80_mul(floatx80_pi, floatx80_pi, &s);\n\nhowever this should work fine:\n\n#define floatx80_pi make_floatx80_init(0x4000, 0xc90fdaa22168c235LL)\n\n> \n> or replace all the macros in the m68k/fpu_helper.c array by\n> make_floatx80_init(...)\n> \n> Thanks,\n> Laurent\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ljHFJBAt\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCHm38nkz9sNc\n\tfor ;\n\tTue, 5 Sep 2017 00:42:44 +1000 (AEST)","from localhost ([::1]:48098 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dosaI-0000hD-Ia\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 10:42:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36639)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dosZW-0000Yx-71\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:42:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dosZP-0006z9-Hj\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:41:54 -0400","from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]:35397)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dosZP-0006yh-Cx\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:41:47 -0400","by mail-qt0-x231.google.com with SMTP id k2so2741518qte.2\n\tfor ; Mon, 04 Sep 2017 07:41:47 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tb86sm3835736qkj.1.2017.09.04.07.41.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 07:41:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=NwZlAQOe58jLM30JgEn/ukmTyFGcL7BO8wmfPlQrPuI=;\n\tb=ljHFJBAtAq3ZZxdhpRltkEHlYR41KwLoeZQDIInPmdMUEkE6bMFFdJz2jjqSVMaTOF\n\tG9Y8Vcq2e1+TUN8QVIC1r40WzGiyhoWb6WJjjS1eEq+UICJr+kgW3kia5IWE+SXfG6ZF\n\tVAaVapU7bUGXlXo7u8C36Ue1im7zsk7dZqqSbgfK6CE+mY/5JxiaGXtI1eAIrp93nPrm\n\tUkgPEPUjzNizF4lxkKpAm55zambU0wYpbe+6l7OJA6VGdJqN5jU6sxvgy2un8bCPshYA\n\tQh8TokbLUY/ZRNPZHyvHPcpZ3cmrnpqe+lJMWicM5jDWyXr8SWkl9Wt628nt8QNPrLWN\n\tn7iw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=NwZlAQOe58jLM30JgEn/ukmTyFGcL7BO8wmfPlQrPuI=;\n\tb=YNRDv9DGwaNxjUry2tr18NxL5zwE0EyBkNmrfWFfOKlsWSiO9srzka2tw0YNPKoEBT\n\tYAVL5PTGxK/In2JcMEI8SQ4Mq3JF89AMk/cpAB9/mVLGwfg6y9NfDvVPtw6uJcwkc/os\n\tq6vHAmGBVGA0kwE5jwXmPJRTHRnyB9mB+A1veZxEhvCkziJ1oMf1r9fne4slHEodlg8H\n\tsGNjnzBfZABEkHDNW3uWfVOcBWSTJDyJS5fk4o1eAq1mBhg6KWHgNhfmF3Oaj3aVpTq3\n\tMvqLvtRVBVUXK5fE2CTvN96kycnnVo9GR/BZH6MZNlvYvz1wvRIIkWDPNRWLKikDghWu\n\tIS3g==","X-Gm-Message-State":"AHPjjUim5E8TUhWHAtVv2mZIflLDZPd1P8b1oy/UNVEAXzBHW0Z3/Zno\n\tuL7+UqYoXcoOvrVU63o=","X-Google-Smtp-Source":"ADKCNb4I4ZuW0+DpLrcg2bUyQk7Z8hhv0953h7n6J1mOvULp4UaKItdZaNikRJ5uwd60dNhAbOG+lg==","X-Received":"by 10.237.44.4 with SMTP id f4mr1063392qtd.304.1504536106581;\n\tMon, 04 Sep 2017 07:41:46 -0700 (PDT)","To":"Laurent Vivier , Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<047f9b63-2dcc-e8ba-90c1-965e253fcbf5@amsat.org>","Date":"Mon, 4 Sep 2017 11:41:35 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::231","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762716,"web_url":"http://patchwork.ozlabs.org/comment/1762716/","msgid":"","list_archive_url":null,"date":"2017-09-04T14:53:30","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":11273,"url":"http://patchwork.ozlabs.org/api/people/11273/","name":"Kamil Rytarowski","email":"n54@gmx.com"},"content":"On 04.09.2017 16:41, Philippe Mathieu-Daudé wrote:\n> On 09/04/2017 11:09 AM, Laurent Vivier wrote:\n>> Le 04/09/2017 à 15:54, Kamil Rytarowski a écrit :\n>>> On 04.09.2017 02:27, Philippe Mathieu-Daudé wrote:\n>>>> On 09/03/2017 02:05 PM, Laurent Vivier wrote:\n>>>>> Le 03/09/2017 à 18:31, Kamil Rytarowski a écrit :\n>>>>>> GCC 4.7.2 on SunOS reports that the values assigned to array members\n>>>>>> are not\n>>>>>> real constants:\n>>>>>>\n>>>>>> target/m68k/fpu_helper.c:32:5: error: initializer element is not\n>>>>>> constant\n>>>>>> target/m68k/fpu_helper.c:32:5: error: (near initialization for\n>>>>>> 'fpu_rom[0]')\n>>>>>> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\n>>>>>>\n>>>>>> Convert the array to switch() to workaround the issue.\n>>>>>\n>>>>> I don't like the idea. It's really an array and should be managed\n>>>>> as an\n>>>>> array.\n>>>>\n>>>> I agree with Laurent.\n>>>>\n>>>>>\n>>>>> Could you try to use make_floatx80_init() instead of make_floatx80() ?\n>>>>\n>>>> I guess the problem comes from the macro which cast as not const:\n>>>>\n>>>> #define make_floatx80(exp, mant) ((floatx80) { mant, exp })\n>>>>\n>>>\n>>> Adding const to make_floatx80 - ((const floatx80) { mant, exp }) - does\n>>> not fix the problem.\n>>>\n>>>> make_floatx80_init() doesn't cast so it might work,\n>>>> else we could add a macro such const_floatx80():\n>>>>\n>>>> #define const_floatx80(exp, mant) ((const floatx80) { mant, exp })\n>>>\n>>> Switching make_floatx80() to make_floatx80_init() in works.\n>>>\n>>> How about floatx80_zero, floatx80_one etc? We cannot translate them to\n>>> make_floatx80_init() as this breaks in other parts of the code in\n>>> functions like:\n>>>\n>>> void helper_fldpi_ST0(CPUX86State *env)\n>>> {\n>>> ST0 = floatx80_pi;\n>>> }\n>>>\n>>> -- target/i386/fpu_helper.c\n>>>\n>>\n>> You can:\n>>\n>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n> \n> this won't work with:\n> \n> const floatx80 2pi = floatx80_mul(floatx80_pi, floatx80_pi, &s);\n> \n> however this should work fine:\n> \n> #define floatx80_pi make_floatx80_init(0x4000, 0xc90fdaa22168c235LL)\n> \n\nThis breaks as mentioned above, in target/i386/fpu_helper.c.\n\n>>\n>> or replace all the macros in the m68k/fpu_helper.c array by\n>> make_floatx80_init(...)\n>>\n\nI've copied the float_* numbers to target/m68k/fpu_helper.c and it\nbuilds on SmartOS machine with GCC 4.7.2 (from Joyent shell) and on my\nlocal NetBSD workstation with Clang 5.0.0\n\n>> Thanks,\n>> Laurent\n>>\n\nI'm going to submit the new patch soon.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCjP5wtDz9t2W\n\tfor ;\n\tTue, 5 Sep 2017 01:01:29 +1000 (AEST)","from localhost ([::1]:52844 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dossR-0003HN-VK\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:01:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47583)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from )\n\tid 1dosjc-0005ms-CC\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:53:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dosiY-0008Vv-1b\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:52:20 -0400","from mout.gmx.net ([212.227.17.20]:60803)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dosiX-0008SY-DJ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:51:13 -0400","from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx103\n\t[212.227.17.174]) with ESMTPSA (Nemesis) id 0LlDx4-1dFHJb2r38-00b6vj; \n\tMon, 04 Sep 2017 16:51:09 +0200"],"To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tLaurent Vivier ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t<047f9b63-2dcc-e8ba-90c1-965e253fcbf5@amsat.org>","From":"Kamil Rytarowski ","Message-ID":"","Date":"Mon, 4 Sep 2017 16:53:30 +0200","User-Agent":"Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<047f9b63-2dcc-e8ba-90c1-965e253fcbf5@amsat.org>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"kf65S8wWP2Kw01brJ97i2ppmUiH7i1UxI\"","X-Provags-ID":"V03:K0:uLQjY7IOe7zuXuTeWiR66Cn0Jhec9i0A0NvKqUCI3XvWxnsKgrW\n\teFSIXpFJb2zrynlKf/K81g68GW3z/AKkoNS8GTWvlNrGW+pTG5nlamOyP3VME9OiICZwGpK\n\t9kTOZSDkeEek/GCYxKJ/JpUTSq7wdKBkuqOhE8xHsPdhJolWDCIWlxbkuqZt7zs5wK6hidY\n\txBgqqSvI3LEcbO0qpNAAA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:9z2jVDXvXYY=:3Bv2yGl5yt1PdLCU2eOYD4\n\tROJISEzHeYVrU+Eo7HDGhA4K7LFS2zIDOVBuqAwiWVJQX3NfmEM7Ffs3JzEVipuKD5KijuHiv\n\tsrPZEjAKxOjDY+cQ3mOerfqzETqmyNv+FgqIstLH/ae+FVSMnioSFsB5idVyC1HQKY6thUxd6\n\tsM7t4HFbTtS5jd3W4jOHyPBd+j9heCVj+LPSLJ0/50nQEPamZ2kjDySLGgv47bJdvAEffDycp\n\tC+wTSdcvMxD0TngiezilVmnBF9spScXaoy8tOJB+b/1uwPRfYzm3paSHcNVXPwAE0zv3XUf/z\n\tIh6VZ3iE5pRyRNdG3oJIRQlC+D5ueGwNBYGzQjk83lLjdcz5AOBRoWFJRVwi6SgOioSB2e7Ht\n\thrKWOtO8cEzABXjAmrwYJli3oI1M40oEA7BDpX63UUmx3WAX9OBd6t0BzoF0HdjgmubOQI6br\n\tYXZxoncytMKUj8f5DvgLHBeh8vShPAxu6jXkcgJ4oVx70GsS1mf1hYTC1GyxP8/zGtQ3augE+\n\t6IgPPQt3E+Swam9m7RyDByj5nZPlQrinjH3PhUkmBgA4Oy7aoMbRiedHcXqLXjyQnxx3fdKxD\n\t94gfS9H3eD8kOy3VxTkOwDePaGwTDxuEJPLHh3eVwfex0TCLLpdNoXsYuu/844WM9aAF/LcCF\n\tufVchlLpBwRib80Um5SYlTXwW325JoDDsxecX+6BXLCMqW7rWlP2TYSXY3SwaeJ+cdydog1L4\n\tZE0bcYRFPt7BJyKwhQNBaDvHXPj3xFSpr8yQGSSvvoK55iClUsqAb20tIdMGliW1qZ3oJLgo2\n\t5uguaOGZXXf/nX22RaSTzDdp+KZGw==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.17.20","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762718,"web_url":"http://patchwork.ozlabs.org/comment/1762718/","msgid":"","list_archive_url":null,"date":"2017-09-04T15:02:07","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 4 September 2017 at 15:09, Laurent Vivier wrote:\n> You can:\n>\n> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>\n> or replace all the macros in the m68k/fpu_helper.c array by\n> make_floatx80_init(...)\n\nTaking a step back, what's different about floatx80 and float12\nthat means they need separate _init and non-init versions of\nthe macros, when for float16/float32/float64 we instead have\n#define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n#define const_float32(x) { x }\n\n? Could we move to consistency for the macro naming we're using?\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"hBLGaCir\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmCp16JMzz9t2c\n\tfor ;\n\tTue, 5 Sep 2017 01:05:29 +1000 (AEST)","from localhost ([::1]:53391 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doswJ-0005M7-UZ\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:05:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41198)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dosuU-0004WJ-4n\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:04:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dostR-00030S-1r\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:03:32 -0400","from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:33036)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dostQ-0002zZ-QN\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:02:28 -0400","by mail-wr0-x236.google.com with SMTP id a43so2399251wrc.0\n\tfor ; Mon, 04 Sep 2017 08:02:28 -0700 (PDT)","by 10.223.159.68 with HTTP; Mon, 4 Sep 2017 08:02:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=XfEogsnkf2XXH6rhl0PdoiH05hYpHPgFRSxfYLPNQoE=;\n\tb=hBLGaCirQ7xzv3ivSoKRSDckonk+4Ao9GHVlLR/X8KjcyKV3GXwoPX+1jEdiddrGLP\n\t48tmilF9+iLRQQ4OsmFodyY8t8RUg36V/qiAce+NFSVJIt90wrRCdvpYBCOFT9/dSKUK\n\taDoR91OcOkBniE4t8R/6GODSUj5ihcoi0Htis=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=XfEogsnkf2XXH6rhl0PdoiH05hYpHPgFRSxfYLPNQoE=;\n\tb=Yg9ICgPXxVojAjKRjHAjfjsJFFzld8xUrO8gHZ0MXzLXAMXH1kLfILZxqwFhm0uxy7\n\tsMI3l+gJBKFcvNHFu7fypjhUw+xbzBSnRr1UGVLFsuiRlFSWx8I2tQjB6KeuS08TuAG/\n\tqEK1VlpIN9QkVm/xNpg1nEbrcQNVJQ79HoRslS1isQ9J6FcJCFrE/O+8KV8ATV+8zggI\n\tA/Kt7/knxhNsVL4Va+Hp/FKmmT0bSRaxsLyt5pgvOF+YMRImnnytgg6EJjEYLo5HAxPv\n\t2oe63GEz7CBFntqEgSdLQRN/7+3FC3N/kDfc/Ef5CvVfQvbdchcSfAz+ughET/qRwN8W\n\tobKg==","X-Gm-Message-State":"AHPjjUhgdedyMY2Pzp2sdXB2cnZIXrFUxA85WFc+6kBMcFX+CueSptzE\n\t/M0yJFhEN69KlrsRbZWQnIGwnxu/Gu5T","X-Google-Smtp-Source":"ADKCNb5PjZjMdcApYiyunq/zjbPorQUq0QsFUc1ZZP0HBxPJ0IZTjszPwOfUx5Jcu3JqArrU3WwGAnAni8IvLJa36bM=","X-Received":"by 10.223.145.41 with SMTP id j38mr468602wrj.314.1504537347612; \n\tMon, 04 Sep 2017 08:02:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t","From":"Peter Maydell ","Date":"Mon, 4 Sep 2017 16:02:07 +0100","Message-ID":"","To":"Laurent Vivier ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::236","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kamil Rytarowski , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762725,"web_url":"http://patchwork.ozlabs.org/comment/1762725/","msgid":"<8b848df7-8eb2-b2b4-a4e9-660bc017a74d@gmx.com>","list_archive_url":null,"date":"2017-09-04T15:16:42","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":11273,"url":"http://patchwork.ozlabs.org/api/people/11273/","name":"Kamil Rytarowski","email":"n54@gmx.com"},"content":"On 04.09.2017 17:02, Peter Maydell wrote:\n> On 4 September 2017 at 15:09, Laurent Vivier wrote:\n>> You can:\n>>\n>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>>\n>> or replace all the macros in the m68k/fpu_helper.c array by\n>> make_floatx80_init(...)\n> \n> Taking a step back, what's different about floatx80 and float12\n> that means they need separate _init and non-init versions of\n> the macros, when for float16/float32/float64 we instead have\n> #define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n> #define const_float32(x) { x }\n> \n> ? Could we move to consistency for the macro naming we're using?\n> \n> thanks\n> -- PMM\n> \n\nI don't have insight on the reasoning, but float128 suffers from the\nsame reason as float80.\n\nstatic const float128 fpu_rom123[128] = {\n [0] = make_float128(0, 12)\n};\n\ntarget/m68k/fpu_helper.c:58:1: error: initializer element is not constant\ntarget/m68k/fpu_helper.c:58:1: error: (near initialization for\n'fpu_rom123[0]')\nrules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed\nmake[1]: *** [target/m68k/fpu_helper.o] Error 1\n\n\nOn the other hand, something like this builds:\n\nstatic const float16 fpu_rom123[128] = {\n [0] = make_float16(0)\n};","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmD2X5zh9z9s72\n\tfor ;\n\tTue, 5 Sep 2017 01:16:20 +1000 (AEST)","from localhost ([::1]:54400 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dot6o-0004Le-JK\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:16:18 -0400","from eggs.gnu.org ([208.118.235.92]:47818)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from )\n\tid 1dot5l-00049i-Sv\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:15:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dot51-0005nq-C5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:15:13 -0400","from mout.gmx.net ([212.227.17.20]:63374)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dot51-0005n4-1E\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:14:27 -0400","from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx103\n\t[212.227.17.174]) with ESMTPSA (Nemesis) id 0LvUwp-1dOnaX1PMp-010a16; \n\tMon, 04 Sep 2017 17:14:22 +0200"],"To":"Peter Maydell ,\n\tLaurent Vivier ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t","From":"Kamil Rytarowski ","Message-ID":"<8b848df7-8eb2-b2b4-a4e9-660bc017a74d@gmx.com>","Date":"Mon, 4 Sep 2017 17:16:42 +0200","User-Agent":"Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"8ppGXIqxgMdti1Gv2gmesg7XupaXMRRtr\"","X-Provags-ID":"V03:K0:vvOZSly5727DlWD485ROi93CGJwG/0lk95NwHCA0x1NagUUso4C\n\t6XjuTkN5NMOtIQOFdEnHG3PgQvoiD9YMeNBMkowoGQyrsQjaYUB+F/OKjqMvwrqjv0688N4\n\t1tHVbl6BK8HEzvV3cTBb4wjJapqEiXMIfxZsckkagtkOcdoOegiwB25fXN16MAvKpdoDfp6\n\tVywxNB3MfTqUH6xF9BKcA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:I5HfN/aEriQ=:KB4VCjHfSR9Zs1Wc6kAoEh\n\tJ2oNacE7L0q6mWLKmlptIKpaT+WeHtMfHO36kKzrGEnp71ApsbCVUeVEG5yJSYpg1pCu/RW5f\n\tAKrYhkK6URfsQ7qB2c0TABQSIB5ReyEglxX3XweQNlOW7pD8vxh5fWpeTgi8bq48VA/X/0L6k\n\tXM6gEHMFOS74wIdwRh/gUv8b30HE+C/rbUhVFDDcJO1ptDH2jL1jAnchnjkHhS3SIqlOVHPhB\n\tfEN2160o1+ZAvf9iMUdMfFl5cWEyAN7/F8g8ht9JB9Xyeq5hchSgr/CoWsvogcKPwFJ+rJYuJ\n\tOTnIfytAmqU1GfVXoHecXkqbWt1ANGsnwOn1+VC3gRe+kyRQkAosQTmxxcXdeNmGNMXFEfKI0\n\tSByDa3uvxrdWRs6ppF0KbwhVdeh4YTyPKwa6tEyLR4tQIuqERLm6T0cUP4cKgE3q08X9rMuiN\n\tuRNU7gP63Z4SZFvwIgRNeAHpH3FcFNjPzRjZMD70cCUYEdGIml5C7XpTFgpH2f0pD+6jxXu71\n\tvABflUcNHcLLH5k+yvKyaWk6ce3FOPHF9UU27hLV6IxOFOfltDJ5BP33STr7+KL//uiYnCZb6\n\t5u1cnOlqxHZqWunwS0gixktwPktFuouGJCJhoDsCowHwTphMDdiz9iXlNQlLdzdiJKZgUI0Pt\n\tkEnPQcKlTNbcr/cIIPhLwVTqeK0x5Ia5mzNo+1FbNEmojzo3Il4hmfJgmFUZ+67faPcYbqF4w\n\tHh9Zy5RpZZRKhgdvOgocU8Zvh3nRRFPFoAe/moooxc82UzwkgJRYNmjWES+DDR9B9Cr4pvyQ1\n\t+WsxVgLZTqjfIkSJLPyoZS1F8wI3Q==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.17.20","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762741,"web_url":"http://patchwork.ozlabs.org/comment/1762741/","msgid":"","list_archive_url":null,"date":"2017-09-04T15:53:40","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 04/09/2017 à 17:02, Peter Maydell a écrit :\n> On 4 September 2017 at 15:09, Laurent Vivier wrote:\n>> You can:\n>>\n>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>>\n>> or replace all the macros in the m68k/fpu_helper.c array by\n>> make_floatx80_init(...)\n> \n> Taking a step back, what's different about floatx80 and float12\n> that means they need separate _init and non-init versions of\n> the macros, when for float16/float32/float64 we instead have\n> #define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n> #define const_float32(x) { x }\n\nfloatx80/float128 are structureq while float16/float32/float64 are\nnative data types.\n\n> ? Could we move to consistency for the macro naming we're using?\n\nDo you mean \"s/make_floatx80_init/const_floatx80/\"?\n\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmF7B2vWyz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 02:05:25 +1000 (AEST)","from localhost ([::1]:54644 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dotsI-0004X8-SI\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:05:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41439)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doth8-0004Mq-EH\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:53:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doth4-0007Jz-1o\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:53:50 -0400","from mout.kundenserver.de ([217.72.192.74]:59347)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1doth3-0007JL-Oi\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:53:45 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue102 [212.227.15.183]) with ESMTPSA (Nemesis) id\n\t0MarjW-1e4mgZ2az4-00KLkE; Mon, 04 Sep 2017 17:53:41 +0200"],"To":"Peter Maydell , Kamil Rytarowski ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t","From":"Laurent Vivier ","Message-ID":"","Date":"Mon, 4 Sep 2017 17:53:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Provags-ID":"V03:K0:jDdqus9+DkPyF+IaCEo11VqCuPZr5m0q89buhgS9KzB0LBVx2s5\n\t5RF0A1eIsoP0S5Y6/gEo5GxfYBi2h5M2VW4U3sLv08fYE1T4BAvoip93fD69enHWhaUzoG7\n\txQhxqx4JcaS/OUgpNopI219tUjUQX1jT7DT+4g4RP6iOQe8rbcKqtwOPSmJhvSNw2DjsCWn\n\t00LrLCzgf2jbflla4CqZg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:yd6yToAGnn4=:6gBF1BZ21u2PfPkiHqUBzJ\n\tC7LrdoznRduw07Nx2e7OR/GsKTCSR71FiSpK0ukN0oBzukNJC2K4APpaXonPgSNNZtaeMnbp/\n\tHajE6i4kCP65I+5RQH2+FpNnTcF28vNRywtWERzS5d9XvfbVlCwPxMfYAxTlrRxZY5ZlFTvg2\n\tuCy719QAamP8hBXJcYZAdpHnHBOwT+Y1QITQkkNrIopyvT8KcaL9HP4A057ZA/PjvDEfqow5r\n\t0wGW1kbP1BN+ZrOxWmVRU2fDBFlwrNNsFCjI6zNuq39aON1aI7X7XyZK+5YGCh/e43UL68p8C\n\thgwwZJbETN4Wqy8AF/kwlLeIw8oFOcvwlziv+vrGd4b9NVn30ic2rz30S2DtQDjKxfAqWrOVW\n\tPh7bpXUKuutCEelKjnuGwsjwNfsDqphqQ2UONjJbHyyDxCWziI69k+SM0/t+Vnm/nCpiu4H5F\n\t0ygp6+Aukbb8L6x7/36jsSQDqxMhLWXmMBjtQ26DZml6+VqLmw04XUwLwN141tAEyYlwWgbda\n\t3BbjSpJ8H5jECZYwJjXuoxPSAZW4a7qWBvuCtr3jFbWLy5b8XJAAbVZDdHJ3THjJ0yhSJLuYj\n\tNc64aKfcbbsg+TWgsp0CJc/FH7RAN8lBxihC+qGeHbxxfJnPTOGNlUKKlYGTcrISZ6jyEQboN\n\tz0Vuaamvjt7vurkIh/R6jnYYUWma/lEVxzvWzhzxf5oCdbMlwG6v2SjBtvepR5neH5zzUAoWl\n\t/688kdNWPLGi5RqOWVwXUrwlm8VgqaDFIdzvq0SJsPUT+koRqLLEQg7YjCI=","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"217.72.192.74","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762754,"web_url":"http://patchwork.ozlabs.org/comment/1762754/","msgid":"","list_archive_url":null,"date":"2017-09-04T16:17:25","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 4 September 2017 at 16:53, Laurent Vivier wrote:\n> Le 04/09/2017 à 17:02, Peter Maydell a écrit :\n>> On 4 September 2017 at 15:09, Laurent Vivier wrote:\n>>> You can:\n>>>\n>>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>>>\n>>> or replace all the macros in the m68k/fpu_helper.c array by\n>>> make_floatx80_init(...)\n>>\n>> Taking a step back, what's different about floatx80 and float12\n>> that means they need separate _init and non-init versions of\n>> the macros, when for float16/float32/float64 we instead have\n>> #define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n>> #define const_float32(x) { x }\n>\n> floatx80/float128 are structureq while float16/float32/float64 are\n> native data types.\n\nIf USE_SOFTFLOAT_STRUCT_TYPES is defined then float16/32/64 are\nalso struct types and use the make_ and const_ macros as above.\n\n(We should check whether USE_SOFTFLOAT_STRUCT_TYPES still builds,\nit tends to bitrot. If it does then maybe we should use it by default\nsince gcc 3 is now just a memory...)\n\n>> ? Could we move to consistency for the macro naming we're using?\n>\n> Do you mean \"s/make_floatx80_init/const_floatx80/\"?\n\nYes (and the same implementation would be nice too).\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"URZvWxm8\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmFQG6gnzz9t2W\n\tfor ;\n\tTue, 5 Sep 2017 02:18:30 +1000 (AEST)","from localhost ([::1]:54784 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dou4y-0005gi-UK\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:18:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50813)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dou4O-0005bI-1U\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:17:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dou4J-0004n7-D8\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:17:52 -0400","from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:32910)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dou4J-0004mJ-6M\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:17:47 -0400","by mail-wr0-x22c.google.com with SMTP id a43so2916799wrc.0\n\tfor ; Mon, 04 Sep 2017 09:17:47 -0700 (PDT)","by 10.223.159.68 with HTTP; Mon, 4 Sep 2017 09:17:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=a/Pqsv3HWhHbyXJ+CUKlWI50m8gvDMIDj232t6y9IJs=;\n\tb=URZvWxm8oSW02qThDgyMaBocuiX+r7p/DbEDYsL76E70khmW0SZhXLqiAMV3GxZuzM\n\tzuRbcy2yeVO4ZMdFw5HDIecX45fQ6CO4pr6HrDkksbI4pURaCZP8yaR0Xrhb4S/9eIzt\n\t9h5y9nBFJ23tv88G4sPtxpS2/9c50rooUhomI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=a/Pqsv3HWhHbyXJ+CUKlWI50m8gvDMIDj232t6y9IJs=;\n\tb=WH4FR93s1e46KfhrtqcAS6gze6gip2btzCrVOAOa0JUdAf8zj8vAHmhOfOhrT6P9la\n\tZwp01jKM5TtgIr6909ZKIhp1YaFjJ8y9p46Df+VLoelVh1aBtuQ9NITfyShRwZiUZ7fA\n\tRIzMdL1n3YETzb1pK+RGCIg7eGxIQwXTd26oDu46dgCYNydgTtt8+UurqB5tMCPPS1pU\n\taLNWmkbXwnK8SJjuwQBBF4P+nulvgYtrLlOEfMiKjHAj/51AoSmEvzrKirBg/iTvQjq3\n\tkkVs8DzNuiAKCD90W88hngHnmsytOYkUgqv+jZuWlK2JlpTNUgcWahX1jKl1FEQdJgfx\n\t9q6w==","X-Gm-Message-State":"AHPjjUiwa84bhRk61rSzXjycJdVUB3YygPBAt56kq5RqaZbrFvyQSoVh\n\tcB/QHXDkb+1x2EbXTJVqCiWaMJ3rY+6N","X-Google-Smtp-Source":"ADKCNb7R/nzlmnLQGnpyP7CIQbxSKWfkspZ55Gv2NRIdrTG5OBwWa6dGstXt7JQ/YFgHpF9QlkIvrxFeDTYIeGjl+CM=","X-Received":"by 10.223.187.211 with SMTP id z19mr565250wrg.97.1504541866206; \n\tMon, 04 Sep 2017 09:17:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t\n\t","From":"Peter Maydell ","Date":"Mon, 4 Sep 2017 17:17:25 +0100","Message-ID":"","To":"Laurent Vivier ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22c","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kamil Rytarowski , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762774,"web_url":"http://patchwork.ozlabs.org/comment/1762774/","msgid":"","list_archive_url":null,"date":"2017-09-04T16:38:05","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":11273,"url":"http://patchwork.ozlabs.org/api/people/11273/","name":"Kamil Rytarowski","email":"n54@gmx.com"},"content":"On 04.09.2017 18:17, Peter Maydell wrote:\n> On 4 September 2017 at 16:53, Laurent Vivier wrote:\n>> Le 04/09/2017 à 17:02, Peter Maydell a écrit :\n>>> On 4 September 2017 at 15:09, Laurent Vivier wrote:\n>>>> You can:\n>>>>\n>>>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>>>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>>>>\n>>>> or replace all the macros in the m68k/fpu_helper.c array by\n>>>> make_floatx80_init(...)\n>>>\n>>> Taking a step back, what's different about floatx80 and float12\n>>> that means they need separate _init and non-init versions of\n>>> the macros, when for float16/float32/float64 we instead have\n>>> #define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n>>> #define const_float32(x) { x }\n>>\n>> floatx80/float128 are structureq while float16/float32/float64 are\n>> native data types.\n> \n> If USE_SOFTFLOAT_STRUCT_TYPES is defined then float16/32/64 are\n> also struct types and use the make_ and const_ macros as above.\n> \n> (We should check whether USE_SOFTFLOAT_STRUCT_TYPES still builds,\n> it tends to bitrot. If it does then maybe we should use it by default\n> since gcc 3 is now just a memory...)\n> \n\nUSE_SOFTFLOAT_STRUCT_TYPES breaks for me on SmartOS:\n\nmigration/vmstate-types.c: In function 'put_float64':\nmigration/vmstate-types.c:430:5: error: conversion to non-scalar type\nrequested\n\n>>> ? Could we move to consistency for the macro naming we're using?\n>>\n>> Do you mean \"s/make_floatx80_init/const_floatx80/\"?\n> \n> Yes (and the same implementation would be nice too).\n> \n\nI will push my patch as is and later it can be refactored by a\nmaintainer. Is this fine?\n\nhttps://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-target_m68k_fpu__helper.c\n\n> thanks\n> -- PMM\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmFqP30kfz9s75\n\tfor ;\n\tTue, 5 Sep 2017 02:36:49 +1000 (AEST)","from localhost ([::1]:54859 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1douMh-0004ff-J8\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:36:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56662)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from )\n\tid 1douLq-0004LS-5X\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:35:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1douLl-0002Os-8m\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:35:54 -0400","from mout.gmx.net ([212.227.17.22]:55489)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1douLk-0002O5-UK\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:35:49 -0400","from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx103\n\t[212.227.17.174]) with ESMTPSA (Nemesis) id 0MGRhs-1dkYl62fdg-00DGnH; \n\tMon, 04 Sep 2017 18:35:44 +0200"],"To":"Peter Maydell ,\n\tLaurent Vivier ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t\n\t\n\t","From":"Kamil Rytarowski ","Message-ID":"","Date":"Mon, 4 Sep 2017 18:38:05 +0200","User-Agent":"Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"HF7wsGGERimce3FkprV7CvcH6x2OLSFsQ\"","X-Provags-ID":"V03:K0:fv1rPNVnZNEjaf6D6Dvovl052xmYTwbL67bdWD7Z4y0uHInIIRR\n\tDyrEr3pQP34XBLH685BlllNlO68BHbeInor6LsJjjTlLyjZLxe7wG4ZSsYqvYkcnoungZEU\n\tEBVFEl+z3a6jICMLBgshyCTOwXB/GHAXnIhBnGS06yOpm+GyRuaesHR2u8ipo/y6qeKXZZn\n\tI+5Yh4AYLOqiFnO8l9FKw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:o2kMbHW9pik=:S1ZhrPEAqIU4snO3FkGlNC\n\toZAF4oUuP+ZLjrHMERCEXTipgsuu5wLtrKoHNSGKxHBEMKK5H6WuHMW0fItKkKn9uNsdm3v5W\n\tiMdRJsNqQiWrYk4c7vSeW5hsZCI/wHxj7I80KMxyQyxeGwV3JsB8IhB2zc9FiSLBeP2FkdUc6\n\tUuPFTyQGIZVuH+3BMd8Y0AyPhSDkczf3bH30TOBoWEbISqurzX1kOB6qzhNqgg363k9PBV3Jh\n\tp3+33W1Maysy8eBezB3hkPwz7ZXl4CQiSVNsiXWbVW30/Pli/gqtGDH2nkyeM667m6oA1HUBI\n\twQsNnc078k1n+V2ZuysUljo9PhZO4W+ctT6wTCIKZW3QbgqQ0sZSQedo/yogs5FYVIHFUL4WI\n\ttul91gkTF07NvIxReEX9vD9+wQiqjx+XI0HEm+WlsthWF1RtGsZJm+EZR1uO3zYBX7iDpfIuQ\n\tEp2r+k2LKRJ5yyUV7WUh+9+NlGrPcf5IKpZZ1352FjUW9Z2dTGgkEaYho9f3cbblwzXCMRB9A\n\tyc6+uVYHQSHDEbRbFzpbJYo2RsyHGqfQRBfaM6RiqY6RQngd6MdY/HhLYCjz8DnscM1puYjeo\n\t/mCwHJ+IvBTFHkTXF/FxmQD1Cu5sNlN7EQUKAl4oCoogPR8BtjcS0xOrVc6VqdqS7AL0/Rggl\n\txPZdEZlt3BRyWMTaCNp9MJoMNsQxOxnyKOAvQkoPQsDG1MMfZkmjeptZl+2MGNmkRekvddrRD\n\tE1fzDOpQqgJDyGBaQ93aNOkHMKyfUzxt0lB2eVQ/cunpkGgfdzaCfRd/f+Ahes174nQ/9fjXw\n\t8kzBdvcMvhWwSZiFWTni9ssZtx//w==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"212.227.17.22","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762775,"web_url":"http://patchwork.ozlabs.org/comment/1762775/","msgid":"","list_archive_url":null,"date":"2017-09-04T16:38:32","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":2628,"url":"http://patchwork.ozlabs.org/api/people/2628/","name":"Laurent Vivier","email":"laurent@vivier.eu"},"content":"Le 04/09/2017 à 18:38, Kamil Rytarowski a écrit :\n> On 04.09.2017 18:17, Peter Maydell wrote:\n>> On 4 September 2017 at 16:53, Laurent Vivier wrote:\n>>> Le 04/09/2017 à 17:02, Peter Maydell a écrit :\n>>>> On 4 September 2017 at 15:09, Laurent Vivier wrote:\n>>>>> You can:\n>>>>>\n>>>>> either replace the \"#define floatx80_pi make_floatx80(...)\" by a \"const\n>>>>> floatx80 floatx80_pi = make_floatx80_init(...)\"\n>>>>>\n>>>>> or replace all the macros in the m68k/fpu_helper.c array by\n>>>>> make_floatx80_init(...)\n>>>>\n>>>> Taking a step back, what's different about floatx80 and float12\n>>>> that means they need separate _init and non-init versions of\n>>>> the macros, when for float16/float32/float64 we instead have\n>>>> #define make_float32(x) __extension__ ({ float32 f32_val = {x}; f32_val; })\n>>>> #define const_float32(x) { x }\n>>>\n>>> floatx80/float128 are structureq while float16/float32/float64 are\n>>> native data types.\n>>\n>> If USE_SOFTFLOAT_STRUCT_TYPES is defined then float16/32/64 are\n>> also struct types and use the make_ and const_ macros as above.\n>>\n>> (We should check whether USE_SOFTFLOAT_STRUCT_TYPES still builds,\n>> it tends to bitrot. If it does then maybe we should use it by default\n>> since gcc 3 is now just a memory...)\n>>\n> \n> USE_SOFTFLOAT_STRUCT_TYPES breaks for me on SmartOS:\n> \n> migration/vmstate-types.c: In function 'put_float64':\n> migration/vmstate-types.c:430:5: error: conversion to non-scalar type\n> requested\n> \n>>>> ? Could we move to consistency for the macro naming we're using?\n>>>\n>>> Do you mean \"s/make_floatx80_init/const_floatx80/\"?\n>>\n>> Yes (and the same implementation would be nice too).\n>>\n> \n> I will push my patch as is and later it can be refactored by a\n> maintainer. Is this fine?\n> \n> https://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-target_m68k_fpu__helper.c\n> \n\nIf Peter agrees, the patch is good for me as is: I never liked the mix\nof macros and values in this array. Send it to the list, I will put it\nin my next pull request.\n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmFtb63Spz9t32\n\tfor ;\n\tTue, 5 Sep 2017 02:39:35 +1000 (AEST)","from localhost ([::1]:54866 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1douPO-0006PM-0p\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:39:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57730)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1douOY-00065d-LW\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:38:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1douOT-0003wF-Qi\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:38:42 -0400","from mout.kundenserver.de ([217.72.192.74]:50226)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1douOT-0003uN-Er\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:38:37 -0400","from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de\n\t(mreue104 [212.227.15.183]) with ESMTPSA (Nemesis) id\n\t0Lr24R-1dKGXh0Ynj-00eaz1; Mon, 04 Sep 2017 18:38:34 +0200"],"To":"Kamil Rytarowski , Peter Maydell ","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t\n\t\n\t\n\t","From":"Laurent Vivier ","Message-ID":"","Date":"Mon, 4 Sep 2017 18:38:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"oES6weKIkrH4e8a8b7NJkOW9Pn7b5uevL\"","X-Provags-ID":"V03:K0:allVNPExZkTV6ZPI89fAgf0yZXdX9pDyvo1SdKgyObZdpLw/kP/\n\t/cr3vX7PzaZyoXIcioCYaC8BfMNV5xQqDe2PR9UlsU0LuVzl+WuboBTRh6VNi/r4ax1RsAm\n\t6x511m0Ag6q5NUMcXAFwo5Lpw6KzHI5ch796rYKWSAhe6aBnUvlta7FkVTjVxVmmqfm0jAW\n\tyo1ZC+1flmJ19EBa7hRpQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:LuUnbxzR70Q=:44r6KB0vhKnyaHeJ/UeSDH\n\t1atv3kvIc1X1VZQWcjbWrH/DLiXr0/3W7JAXPsZf6xB727Pc3PvcEqyw0Fz9YYuKTDaERNrGH\n\twZHJjXVALcp5icpSODeC6XLb6/Hv4b5dP02qhZy+QUe/us1ojzaaTUuT+aFnzrdlIEBdaIH7+\n\t7dwby6F+QzXD8ympKJ2wbrOlB0qJy7/5f4w9VYMj2VL+8CwfQDcXj3AKRROoAsHxBEtA5YCFC\n\tmMhJpoGvY8DmdvvFrnLeGmWe4fZkqXTyO/GKK097VVbEJHOewcfQlH+Xijc39tcRE5pUA78eS\n\tv7dvt6ztpL1zyNYKvl1yX/2ntPsCGQSPnpF38JmyvyTcpE4MMxwR679XLXmrtq5g6m7qJNVw4\n\tF341XqZexzYBSy+z7UXzcOlZHNUdhaZigRnE/iUNGX/PHwVps85OQzFZ3bCNsM2TbC4WY8aE1\n\trYA469iHQW80uEAYvn986Ih2gXA/aV+WvLHnnmmbilg8ERVMtr97gAjskBejAeGeaQHNQAC/o\n\tGcdu1z0Ucnen0DlASvUMSMo75+rH5P+/6xF0Qgmtj9QSAmyhsPyKS8PdcsK6Svjr+CORt8VFN\n\tg6kBNCF0SoFFa1kkc7t1jfURserJ3V3Okz4Zp8SwZEDPnhTQNsFAhIvzh7MrvPJwne9qbS3vH\n\tleLGFIJhjXYhYUto2toA/hmLk5sbPKpypuwmoEadnr0qfnQv6rfpNILhMO/s9oRq6GJE8q895\n\t6fhWi12hQ0YD+LPzcCmnQvKRK6B9W6ppcrUMfg==","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"217.72.192.74","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762776,"web_url":"http://patchwork.ozlabs.org/comment/1762776/","msgid":"","list_archive_url":null,"date":"2017-09-04T16:40:02","subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 4 September 2017 at 17:38, Laurent Vivier wrote:\n> Le 04/09/2017 à 18:38, Kamil Rytarowski a écrit :\n>> I will push my patch as is and later it can be refactored by a\n>> maintainer. Is this fine?\n>>\n>> https://github.com/NetBSD/pkgsrc-wip/blob/master/qemu-git/patches/patch-target_m68k_fpu__helper.c\n>>\n>\n> If Peter agrees, the patch is good for me as is: I never liked the mix\n> of macros and values in this array. Send it to the list, I will put it\n> in my next pull request.\n\nOK, if you're happy with it I'm happy with it.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XJq7O/5X\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmFwL2Y8Hz9t2W\n\tfor ;\n\tTue, 5 Sep 2017 02:41:05 +1000 (AEST)","from localhost ([::1]:54874 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1douQm-0007F3-Ui\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 12:41:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58238)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1douQG-0007Be-JU\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1douQB-0004qK-Tw\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:28 -0400","from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:33406)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1douQB-0004po-NS\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 12:40:23 -0400","by mail-wr0-x230.google.com with SMTP id a43so3057478wrc.0\n\tfor ; Mon, 04 Sep 2017 09:40:23 -0700 (PDT)","by 10.223.159.68 with HTTP; Mon, 4 Sep 2017 09:40:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=Ap5JkpRnv5KsIPTacvdhiOu8D+xM1zgfbLZh13gM7/4=;\n\tb=XJq7O/5XrDAzf+xzK158oqYw66JfrHkp7TEXA8MkTrT2PCw+HXEwa9nUR4uQdFqpJ3\n\t1uodZg56CFpi1mit2sQqso4vck5oht3hvsMkgnD+x49wy3nMztcCiGQjJcF7i2Z0uA4h\n\tdG0i+CSt9MuD8w8W7n3yYBDe7+GwCtrmDrBq0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=Ap5JkpRnv5KsIPTacvdhiOu8D+xM1zgfbLZh13gM7/4=;\n\tb=kx9aGOZI3ltqgQEu47WE6C4VkOiODjdnihPfZ1rTAH0DXEIN1cjaMSgnsdK6WgEW51\n\t56TgN2p3QJG0wefF5ukJzJag86SUfqTf9tSWzsHTBkLLzb92C1cUm13c0OPB5esmDv3r\n\tjrysDjYpnbUDCbgKJ/BwbsNAHDZtOfg90yIDV4aNfnz48At9lvRBVb+uOj6DhE+f2Z3E\n\tk8EOyEfe+yBiPwOzoNsg8FykykmSDsvE483VQ/G47AtXc0UYag6OauhWBM6CYl0y9KBj\n\txjPzmmjgFBfj3jgaMxdHQvoE8aNFmmFRwt9WEewL2w/pbtqLRW/0IeNPoeJanIS+71AU\n\tds5A==","X-Gm-Message-State":"AHPjjUh99fQnW5zMcnXZpa4W7eEtXe2CG3ALOm+0dryxjUhapTU9AX8I\n\tezfDwjKrfQ11L/UQ95oyIJH8+Hk5CCxa","X-Google-Smtp-Source":"ADKCNb4I82pUHjS5B/V7B3DcZirUH3bgD/MhN4PB0S1NRGXyJcDOil8+7yToAT7IUK77QUVKIgW+gBMydCjkURZZbT8=","X-Received":"by 10.223.130.21 with SMTP id 21mr646297wrb.196.1504543222633;\n\tMon, 04 Sep 2017 09:40:22 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170903163130.14288-1-n54@gmx.com>\n\t<9f33a768-77d1-191b-8be3-35d625752cbf@vivier.eu>\n\t<1257d6ba-9ca1-0940-af9e-a9ea7dea0287@amsat.org>\n\t<941d403b-7413-517f-23af-2c0c88a3ec57@gmx.com>\n\t\n\t\n\t\n\t\n\t\n\t","From":"Peter Maydell ","Date":"Mon, 4 Sep 2017 17:40:02 +0100","Message-ID":"","To":"Laurent Vivier ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::230","Subject":"Re: [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const\n\tstatic array to switch","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kamil Rytarowski , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]