[{"id":1762510,"web_url":"http://patchwork.ozlabs.org/comment/1762510/","msgid":"","list_archive_url":null,"date":"2017-09-04T08:11:32","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n> +\tRWF_NOWAIT): Define to 0 if undefined already.\n> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n> +\tboils down to 0.\n\nI don't think this is correct. preadv2 etc. are supposed to be part of\nthe GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\nthat's a real bug.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84155-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"uI3suHeU\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm2d84pDwz9s7h\n\tfor ;\n\tMon, 4 Sep 2017 18:12:12 +1000 (AEST)","(qmail 11120 invoked by alias); 4 Sep 2017 08:11:44 -0000","(qmail 11041 invoked by uid 89); 4 Sep 2017 08:11:40 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=U3wqquaWf0fLuc1w\n\tkeL0aQ7wzR3mODocp/IbI9gbV7QgIDKQFNJfNB5p/CQu2oHcYnutXG5taRKM2F2Z\n\tRCErR3uL811Vnzime4UUjS6RX5j2fqcMDotnhSlc7ERsye6CXT48rlsZQgbjeCCS\n\tc1yXoFwB2UyjPKUk6UpPT5FZQfM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=UMfCg14MXd76P0E1L2Lryc\n\tT/Z9E=; b=uI3suHeUsRIvoyc6pFm1lJfbJO/m0EvWczduXO41xjU4E4X4ijMBH5\n\tT3Pbz7IVEqi8BfPZmnVtiDH0Tj9gxxFxxUE8x4u/USCZ9XBrz6pNDPP14Nu95JVE\n\t37uZ0SbjMS71dGx8jnqOFsz/QZM9sl3hiDxn/Wmv2GMF7HdtxurHE=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AA50180461","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"Samuel Thibault , libc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>","From":"Florian Weimer ","Message-ID":"","Date":"Mon, 4 Sep 2017 10:11:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762601,"web_url":"http://patchwork.ozlabs.org/comment/1762601/","msgid":"<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>","list_archive_url":null,"date":"2017-09-04T12:36:07","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 04/09/2017 05:11, Florian Weimer wrote:\n> On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n>> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n>> +\tRWF_NOWAIT): Define to 0 if undefined already.\n>> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n>> +\tboils down to 0.\n> \n> I don't think this is correct. preadv2 etc. are supposed to be part of\n> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\n> that's a real bug.\n\nI agree and the default implementation on sysdeps/posix/preadv2.c (which\nI think it is also the default of hurd) will fail for any flag different\nthan 0. Should we add a note on manual the current flags are Linux only?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84160-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"D62W9MR+\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8V22npmz9t2R\n\tfor ;\n\tMon, 4 Sep 2017 22:36:26 +1000 (AEST)","(qmail 97071 invoked by alias); 4 Sep 2017 12:36:18 -0000","(qmail 96857 invoked by uid 89); 4 Sep 2017 12:36:18 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=Oqj1bAjGRWt6QhWF\n\tMqO4JydXwmtchtKroZRlZU9eeh66FZELKR1t9P3UBiJRMD3BdVFh4etLpJZ7Xafy\n\tBnA9uboQOxfl4Mmsb8pW01N2PjMY0ceBhnTKvCHNAU7Uuj6KrBxsSFioEEWYHzfa\n\tb/efcgQECGuzTS25mmXnko+PD84=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=yKM5FR9+7Qa0Zr62pi+CFV\n\tyaxQg=; b=D62W9MR+94cQL+pSXjoel/ACMZfRTFuv9DVgNhYyJTAZfoDnoBzkBV\n\tFiR5sGT1hjt4ykd1+++XvmvKs8WTzivdaE+fFnU+eLMnZ+nb9xU77nwa1bqyV4CT\n\tjOOjcsygwzMoC/uoRNBoMK3kRe39qTju/WW+NR17l4x0GMTropLUw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-qt0-f177.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=StpGeJK6bpYvjNYWNikMFUBTG9VsFtvQnII+E6nyLIo=;\n\tb=gSVuQDI2iEYH2X6ZrtEFxbkfXZHzxpHphQ0EIl7ARlp1NFjSf7weYk74TsF9MJO2dk\n\twwUeMOfHaOhweLH9idCqu5RINUYBu8o83hOs5CLm1o4IxbGoF+XgZ3/c/aRwfmGXJokT\n\tCYqK4PrA6uTej9OvLjNroTZXJFx5STpD80dC62D1x3bnT2oRytrv1T4qvcg9Vjqs53t5\n\t6moCdgtWda3MIJAYKBKk2auY0R5OmvjclWLfoF+3q0raEZ8zWOh/35aOsKpPKde5+Ymk\n\t5k7DUfQFbJ7/quuviUNv4zEqlNwaCCJMW3+CBlu0JcBfg3crwYJ8aqORlsWq+NwInyNU\n\tTVJQ==","X-Gm-Message-State":"AHPjjUjiZpfitXNafDDPbfL8l7fv3NX/HCMJiLgB/TMhhxe0OG6s8g/h\n\tHOllwZVA5N7BO8R8uxqp9g==","X-Google-Smtp-Source":"ADKCNb6UNUntKwmAGeFsKkCydAK/vmBGdO9611pl7+7adnCT14g2dwZ1/3nOthX55FMm2hbkJw4EXA==","X-Received":"by 10.200.44.123 with SMTP id e56mr423297qta.308.1504528571293; \n\tMon, 04 Sep 2017 05:36:11 -0700 (PDT)","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"libc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>\n\t","From":"Adhemerval Zanella ","Message-ID":"<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>","Date":"Mon, 4 Sep 2017 09:36:07 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762643,"web_url":"http://patchwork.ozlabs.org/comment/1762643/","msgid":"","list_archive_url":null,"date":"2017-09-04T13:40:36","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:\n> \n> \n> On 04/09/2017 05:11, Florian Weimer wrote:\n>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n>>> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n>>> +\tRWF_NOWAIT): Define to 0 if undefined already.\n>>> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n>>> +\tboils down to 0.\n>>\n>> I don't think this is correct. preadv2 etc. are supposed to be part of\n>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\n>> that's a real bug.\n> \n> I agree and the default implementation on sysdeps/posix/preadv2.c (which\n> I think it is also the default of hurd) will fail for any flag different\n> than 0. Should we add a note on manual the current flags are Linux only?\n\nI would have expected that we'd add the flags to the generic API.\n\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84161-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"QjMoQ6Y3\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm9wL34sCz9t16\n\tfor ;\n\tMon, 4 Sep 2017 23:40:50 +1000 (AEST)","(qmail 45386 invoked by alias); 4 Sep 2017 13:40:44 -0000","(qmail 44042 invoked by uid 89); 4 Sep 2017 13:40:43 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=oegq5iCToZo41QXC\n\tnGp7487TuRJZB52dFqsggFZdiJahnRmpUdpZEe0RuF6NaWPnWTZrn+Nj86NujTmJ\n\txnQ5uQEjEArvcZXkND/SFX9yBJDoB3PmYAuIusVeYXGNLFOHOu9twJhuL24mgo5p\n\t7hjc0i6b1UVmsY1u4XBJUn06veM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=ZtcBzQjW5p/EGyhvF/v6AL\n\tM3/NI=; b=QjMoQ6Y3at3S41ykdnTTqQRe2ftlJ0oeqmiykkVwsP+jgWC9ugTVso\n\tNFHSwtxuw8RSYtSmS+7Iob1Ed3uXMdDpDiHVJ9F4PIyd/kN7HPCI4ZDkPRg+kEYY\n\tcV4I8Zco5+8kk3LwlQUJYzPn4MNAmxRqFzwSNstJqnaDAx5uI1xaw=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2\n\tspammy=Hx-languages-length:923","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9639C2BEFF","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"libc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>\n\t\n\t<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>","From":"Florian Weimer ","Message-ID":"","Date":"Mon, 4 Sep 2017 15:40:36 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762663,"web_url":"http://patchwork.ozlabs.org/comment/1762663/","msgid":"<692c91d7-5ef7-05ab-6769-2be5dca565e0@linaro.org>","list_archive_url":null,"date":"2017-09-04T14:04:49","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 04/09/2017 10:40, Florian Weimer wrote:\n> On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:\n>>\n>>\n>> On 04/09/2017 05:11, Florian Weimer wrote:\n>>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n>>>> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n>>>> +\tRWF_NOWAIT): Define to 0 if undefined already.\n>>>> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n>>>> +\tboils down to 0.\n>>>\n>>> I don't think this is correct. preadv2 etc. are supposed to be part of\n>>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\n>>> that's a real bug.\n>>\n>> I agree and the default implementation on sysdeps/posix/preadv2.c (which\n>> I think it is also the default of hurd) will fail for any flag different\n>> than 0. Should we add a note on manual the current flags are Linux only?\n> \n> I would have expected that we'd add the flags to the generic API.\n\nI meant that the flags only really *work* on Linux.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84162-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"fS5o+PvG\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBSQ4r2Kz9t2W\n\tfor ;\n\tTue, 5 Sep 2017 00:05:10 +1000 (AEST)","(qmail 44430 invoked by alias); 4 Sep 2017 14:05:02 -0000","(qmail 44089 invoked by uid 89); 4 Sep 2017 14:05:01 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=RYvvGgOUWCdzIzse\n\t7pTsNPWAtrGEiMNm+Cp1xcWW+bydiBV0vheEPbr42WXmLj0/bqUyKgwzSBQLrTj+\n\tdA+KX4oNdMhPlAWx0ScJWPVYcpIijNqVf90maRIGlnanR5lA5xQL07sE2jPcBx3S\n\tHKCxdByPOLf9C4SRGPRzK2Rnl0k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=S9VEQqY6QTUYFRBIb+yHlU\n\t0+OCY=; b=fS5o+PvGDczgtesmC8apkiL4rATaAUgzpvApBoKkUtKdVuqVqfF+Kb\n\t8jDAkaAW/cDtwyEHO+qa+jdNdgkLLL7O2i9NZ5oOXQGdgYisLYzDkq/4pBf11Q+X\n\thGbAuVNfR0MfvimRrmvMKpw22BY3uuzX5rM/QpNLYBaC4FG5gVEGo=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-qk0-f179.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=GDytDe4lPRXVxJ/dKWG/HQXt5QXUwAx2Yp9CCacL1gc=;\n\tb=NH+UTZvL//T+r92ukcKz2NWCff82g3M98Grt9SZ4uWnxt3Do3qZcAoluPubGFZYgMA\n\tPgit4vDpjWFOz46ZPfh82luMMJRRcjkisS3J1Sr+tvInN0yCMcCekQy17oz6gOwOtKrf\n\tpWbkmqaWCgzaK0QqBPD1UxnfcHHwNRfZAzhC/FpHfKr+xsabeAbdaSvXL7QBmFjKKW4R\n\tZ2G+P4QpxRiJ/SmRr4qc3DEPSk/ofsxwIlfz2MM0WTQorLXTaGEbdKwePi71aHUoKmJu\n\t5/qOBnMkIlHZKFJqodL5n6bM9JynLmqvJCrVerv6U/SdNefrVrHxcx6d3J8saAacAUnr\n\ti6XA==","X-Gm-Message-State":"AHPjjUg80u0+LbawGsU3VXrQUicLrZoPQCt6VXsOvNAb72R/031zO0H1\n\tW/3P1KE6WwhAkEOrK/ZtfA==","X-Google-Smtp-Source":"ADKCNb7lH/08VUjk1QM4V0Gl/Jrsqx4NCQXVDSHgwm/95UKQwE5U99Q49vcCNApH8CVNdqVzwLYzwg==","X-Received":"by 10.55.116.193 with SMTP id p184mr978530qkc.126.1504533894673; \n\tMon, 04 Sep 2017 07:04:54 -0700 (PDT)","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"libc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>\n\t\n\t<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>\n\t","From":"Adhemerval Zanella ","Message-ID":"<692c91d7-5ef7-05ab-6769-2be5dca565e0@linaro.org>","Date":"Mon, 4 Sep 2017 11:04:49 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762664,"web_url":"http://patchwork.ozlabs.org/comment/1762664/","msgid":"<66d9e323-f335-a350-26ec-68d36aebae9e@redhat.com>","list_archive_url":null,"date":"2017-09-04T14:06:02","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/04/2017 04:04 PM, Adhemerval Zanella wrote:\n> \n> \n> On 04/09/2017 10:40, Florian Weimer wrote:\n>> On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:\n>>>\n>>>\n>>> On 04/09/2017 05:11, Florian Weimer wrote:\n>>>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n>>>>> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n>>>>> +\tRWF_NOWAIT): Define to 0 if undefined already.\n>>>>> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n>>>>> +\tboils down to 0.\n>>>>\n>>>> I don't think this is correct. preadv2 etc. are supposed to be part of\n>>>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\n>>>> that's a real bug.\n>>>\n>>> I agree and the default implementation on sysdeps/posix/preadv2.c (which\n>>> I think it is also the default of hurd) will fail for any flag different\n>>> than 0. Should we add a note on manual the current flags are Linux only?\n>>\n>> I would have expected that we'd add the flags to the generic API.\n> \n> I meant that the flags only really *work* on Linux.\n\nYes, I think that would be fine.\n\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84163-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"e4+TesqP\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBTk0S5xz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 00:06:17 +1000 (AEST)","(qmail 116839 invoked by alias); 4 Sep 2017 14:06:11 -0000","(qmail 116299 invoked by uid 89); 4 Sep 2017 14:06:11 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=uPKi4xv20ZNDQmBw\n\tG6YChF5z5AnKA3JGcnBG2+/pcv9nvGB9+ZteMpA6q9M0HAkk5ehbUlcGsRCi52v5\n\tDGavUT+RytrAdfe9TJFKE22Dmz6hRig0btePyHoJZweRP5REQfr8oEXVGZJyf0eV\n\tYflZqbwxFbJCBP5K3BjP7L+P9UM=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=E34xEqieDIPqJNyPyBGzRR\n\tE8ak0=; b=e4+TesqPugoS5D4ebSBFVMcW8M0O4cDyVX6AHy9y71V6CooKbDGUHL\n\tfWclahxanR3/kORDf1jUY8YF/gT9t14k1JRkO8fGPFOG9Z1BfdPN4t4WLweGmKnx\n\tmlGsqoCGmjDN1naPnzHE8FlimUDo7LHVzexEUxRGyytPtgmxyqh/U=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E096C3F738","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"Adhemerval Zanella ,\n\tlibc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>\n\t\n\t<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>\n\t\n\t<692c91d7-5ef7-05ab-6769-2be5dca565e0@linaro.org>","From":"Florian Weimer ","Message-ID":"<66d9e323-f335-a350-26ec-68d36aebae9e@redhat.com>","Date":"Mon, 4 Sep 2017 16:06:02 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<692c91d7-5ef7-05ab-6769-2be5dca565e0@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762666,"web_url":"http://patchwork.ozlabs.org/comment/1762666/","msgid":"","list_archive_url":null,"date":"2017-09-04T14:07:07","subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","submitter":{"id":66065,"url":"http://patchwork.ozlabs.org/api/people/66065/","name":"Adhemerval Zanella Netto","email":"adhemerval.zanella@linaro.org"},"content":"On 04/09/2017 11:06, Florian Weimer wrote:\n> On 09/04/2017 04:04 PM, Adhemerval Zanella wrote:\n>>\n>>\n>> On 04/09/2017 10:40, Florian Weimer wrote:\n>>> On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:\n>>>>\n>>>>\n>>>> On 04/09/2017 05:11, Florian Weimer wrote:\n>>>>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:\n>>>>>> +\t* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,\n>>>>>> +\tRWF_NOWAIT): Define to 0 if undefined already.\n>>>>>> +\t(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED\n>>>>>> +\tboils down to 0.\n>>>>>\n>>>>> I don't think this is correct. preadv2 etc. are supposed to be part of\n>>>>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,\n>>>>> that's a real bug.\n>>>>\n>>>> I agree and the default implementation on sysdeps/posix/preadv2.c (which\n>>>> I think it is also the default of hurd) will fail for any flag different\n>>>> than 0. Should we add a note on manual the current flags are Linux only?\n>>>\n>>> I would have expected that we'd add the flags to the generic API.\n>>\n>> I meant that the flags only really *work* on Linux.\n> \n> Yes, I think that would be fine.\n\nOk, I will work on that patch.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84164-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"oWSaYGqF\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBW10ww8z9s75\n\tfor ;\n\tTue, 5 Sep 2017 00:07:24 +1000 (AEST)","(qmail 59460 invoked by alias); 4 Sep 2017 14:07:18 -0000","(qmail 59246 invoked by uid 89); 4 Sep 2017 14:07:18 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=fqK0L7Ntpj+o/pGd\n\t4CH9E4RTgLroX9ANz94lc3W98Xu53emos8iA+e9Dv+EiqUfkp7EEYdB9SuLCAnbH\n\tRsQnrKDkZPmKVmFIRj65VO34Lp8dVI8+nozeeukb7hfgDL8uHON4DuUGq4E6It0j\n\tU8SMVmQ2hjqix9QJrChH3gK/7go=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=73Q4ScgkFYRGtMWoFaabXW\n\trb+vo=; b=oWSaYGqF2Txt4YTPEYfBEqFKqkyw3hW3ryaviG5+ynk7S4OaIxjGzl\n\ttJy92JPjuPqetRaqFR2R3SAARt4xLl6ksMlpDMBXaCc4mIvJvwq69+vSfK03JTQ9\n\tIxXA4wB/JGpH2PJb2y37UXUuBIZgByznw+NyRtCupew+zFvvFts8k=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-qk0-f173.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=WhcVPhWh+hEtEee1X4Vy8lJRDqcl+1iso9fwkqllK9A=;\n\tb=t0KF83lurvmxlLzH9eNTf4fqi+phw3m/7TTdO6TUCELR1KjN5WUD+feuI3v7AgXjsA\n\tMt8yJecybBKGkb0RnGjnDRBGgBAjaKHjFxvYHbde1q2mwMendMUfXXQdvWMd9eJHIjd0\n\ts6Qyf6ljDV2uIJnqjLVGMf+yVVYCIYvTbz5BXuB8FwX829XrSaUgNnBWk9bF2CIBXvr+\n\t2WChzT8S8afy8RioUsmhpIjoKzs2lLzK9DTWvmBIL5tPzsLNSyMQ8OPMua5LjnPo7LL7\n\tJMFJox3i9WQuKpSKMA6yhw2Pa0cxUXizUmf1XnC9155q1mbvhgpkIl9p4nqEcggdXNda\n\tsR/Q==","X-Gm-Message-State":"AHPjjUjkixbjGe7a1DFrThCC79IthutAnrUr8qr8ndGyzFNo8ER80tWc\n\t0/5ITB0ey250XxN0e+9+hQ==","X-Google-Smtp-Source":"ADKCNb566ZvRGWRbq6Ug/IvSgfNjZJ9NzJ8zjZBrbSii/5lrN7Pj3V1rkNXDtFvPu6bA41pCS9SwZA==","X-Received":"by 10.55.169.10 with SMTP id s10mr902820qke.280.1504534031415;\n\tMon, 04 Sep 2017 07:07:11 -0700 (PDT)","Subject":"Re: [hurd,commited] hurd: Fix build ot\n\tmisc/tst-preadvwritev2-common.c","To":"Florian Weimer , libc-alpha@sourceware.org","References":"<20170903155209.3911-1-samuel.thibault@ens-lyon.org>\n\t\n\t<35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>\n\t\n\t<692c91d7-5ef7-05ab-6769-2be5dca565e0@linaro.org>\n\t<66d9e323-f335-a350-26ec-68d36aebae9e@redhat.com>","From":"Adhemerval Zanella ","Message-ID":"","Date":"Mon, 4 Sep 2017 11:07:07 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<66d9e323-f335-a350-26ec-68d36aebae9e@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]