[{"id":1764879,"web_url":"http://patchwork.ozlabs.org/comment/1764879/","msgid":"<1504809136.6238.16.camel@that.guru>","list_archive_url":null,"date":"2017-09-07T18:32:16","subject":"Re: [PATCH 4/4] Test postgresql support in Travis CI","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Mon, 2017-09-04 at 01:14 +1000, Daniel Axtens wrote:\n> Use the most recent version of postgres (9.6) because we need a\n> more recent version than the default to show up the broken\n> bundle behaviour.\n> \n> This should prevent us from causing any further regressions.\n> \n> I've also had to flick from using the 'travis' user to the 'root'\n> user for mysql - not entirely sure why it suddenly broke, but oh\n> well.\n> \n> Signed-off-by: Daniel Axtens <dja@axtens.net>\n> ---\n>  .travis.yml | 10 +++++++++-\n>  1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/.travis.yml b/.travis.yml\n> index 25d150e3e3db..f19fe4f3fa35 100644\n> --- a/.travis.yml\n> +++ b/.travis.yml\n> @@ -1,5 +1,6 @@\n>  language: python\n>  \n> +dist: trusty\n\nWhy is this trusty rather than xenial?\n\n>  sudo: false\n>  \n>  python:\n> @@ -7,17 +8,24 @@ python:\n>    - 3.4\n>    - 3.5\n>  \n> +addons:\n> +  postgresql: \"9.6\"\n> +\n>  services:\n>    - mysql\n> +  - postgresql\n>  \n>  env:\n> +  matrix:\n> +    - PW_TEST_DB_TYPE=postgres PW_TEST_DB_USER=postgres\n> +    - PW_TEST_DB_TYPE=mysql PW_TEST_DB_USER=root\n\nRelated to the above?\n\n>    global:\n> -    - PW_TEST_DB_USER=travis\n>      - PW_TEST_DB_PASS=\"\"\n>      - PW_SKIP_BROWSER_TESTS=yes\n>  \n>  before_script:\n>    - mysql -e 'create database patchwork character set utf8;'\n> +  - psql -c \"create database patchwork with ENCODING = 'UTF8';\" -U postgres\n>  \n>  install:\n>    - pip install tox-travis\n\nCan't argue with any of this, to be honest. However, I'm assuming you've tested\nthis against your private repo. Does it work with tox-travis as expected? I'd\nexpect to see 2x the # of jobs - are we seeing these?\n\nStephen","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp8Fc2Lkdz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 04:32:36 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xp8Fc19C0zDrYD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 04:32:36 +1000 (AEST)","from camel.ash.relay.mailchannels.net\n\t(camel.ash.relay.mailchannels.net [23.83.222.29])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xp8FT0gnpzDrWp\n\tfor <patchwork@lists.ozlabs.org>;\n\tFri,  8 Sep 2017 04:32:28 +1000 (AEST)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 99BEA8A8516;\n\tThu,  7 Sep 2017 18:32:21 +0000 (UTC)","from one.mxroute.com (unknown [100.96.129.229])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 364158A8F6D;\n\tThu,  7 Sep 2017 18:32:21 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.82.214])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 07 Sep 2017 18:32:21 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"ToOPO9Pr\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"ToOPO9Pr\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=23.83.222.29; helo=camel.ash.relay.mailchannels.net;\n\tenvelope-from=stephen@that.guru; receiver=<UNKNOWN>)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"ToOPO9Pr\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Zesty-Madly":"78e6a8895bfb0c5a_1504809141473_2881834085","X-MC-Loop-Signature":"1504809141473:2082553569","X-MC-Ingress-Time":"1504809141473","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=Xu3UQDsaEdqxBg6Iljb/d2RCsfdM0N4TgIdjqtRUQ9E=;\n\tb=ToOPO9PrqoAzktUtUPcwpWtK5M\n\t4+0IFJjpFRCIqxVueMh0eDluQxRi62hzgaJfzk5yhBZzYe5b3XotYfBO7b6CGHGZazPtFuSy5gDWI\n\tmUtlrDYd5qmrxwXs/iyasLoWLYrVj7uj4ugosQ1EDtX7t02r56u4umZbmsKQ0mQTTtVixzykWCebU\n\thccvxlfAv8Rh+NFZI77XQZcDY5ROuQHZ/r9O1I3iiwbCB81M77FYXBCzF65P10XAAQ5HmXK10rWRi\n\tv7hO47yzpAma2+bVAzcEYzCtSwKG92ada0OnK6l39U4wSc1q+J8mEc8g/Qoa80n3qvQgbv+8tkQ1L\n\tj+d48/Qw==;","Message-ID":"<1504809136.6238.16.camel@that.guru>","Subject":"Re: [PATCH 4/4] Test postgresql support in Travis CI","From":"Stephen Finucane <stephen@that.guru>","To":"Daniel Axtens <dja@axtens.net>, patchwork@lists.ozlabs.org","Date":"Thu, 07 Sep 2017 19:32:16 +0100","In-Reply-To":"<20170903151444.25660-5-dja@axtens.net>","References":"<20170903151444.25660-1-dja@axtens.net>\n\t<20170903151444.25660-5-dja@axtens.net>","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1775386,"web_url":"http://patchwork.ozlabs.org/comment/1775386/","msgid":"<87poadya1u.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-26T11:27:25","subject":"Re: [PATCH 4/4] Test postgresql support in Travis CI","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Stephen,\n\n>> +dist: trusty\n>\n> Why is this trusty rather than xenial?\n\nBecause Travis suuuper out of date, it supports precise and trusty for\nnow.\n\n>\n>>  sudo: false\n>>  \n>>  python:\n>> @@ -7,17 +8,24 @@ python:\n>>    - 3.4\n>>    - 3.5\n>>  \n>> +addons:\n>> +  postgresql: \"9.6\"\n>> +\n>>  services:\n>>    - mysql\n>> +  - postgresql\n>>  \n>>  env:\n>> +  matrix:\n>> +    - PW_TEST_DB_TYPE=postgres PW_TEST_DB_USER=postgres\n>> +    - PW_TEST_DB_TYPE=mysql PW_TEST_DB_USER=root\n>\n> Related to the above?\n>\nYes, this gives us a matrix with two entries, one postgres and one mysql.\n\n>>    global:\n>> -    - PW_TEST_DB_USER=travis\n>>      - PW_TEST_DB_PASS=\"\"\n>>      - PW_SKIP_BROWSER_TESTS=yes\n>>  \n>>  before_script:\n>>    - mysql -e 'create database patchwork character set utf8;'\n>> +  - psql -c \"create database patchwork with ENCODING = 'UTF8';\" -U postgres\n>>  \n>>  install:\n>>    - pip install tox-travis\n>\n> Can't argue with any of this, to be honest. However, I'm assuming you've tested\n> this against your private repo. Does it work with tox-travis as expected? I'd\n> expect to see 2x the # of jobs - are we seeing these?\n>\nYes: https://travis-ci.org/daxtens/patchwork/builds/271401910\n(v2 to come soon)\n\nRegards,\nDaniel","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1dxd5cPZz9tXP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 21:28:37 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3y1dxd4D9vzDsPn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 21:28:37 +1000 (AEST)","from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com\n\t[IPv6:2607:f8b0:400e:c00::22a])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3y1dwQ1p5dzDsQ6\n\tfor <patchwork@lists.ozlabs.org>;\n\tTue, 26 Sep 2017 21:27:33 +1000 (AEST)","by mail-pf0-x22a.google.com with SMTP id u12so5395077pfl.4\n\tfor <patchwork@lists.ozlabs.org>;\n\tTue, 26 Sep 2017 04:27:33 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tv31sm14998547pgn.43.2017.09.26.04.27.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Sep 2017 04:27:30 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"TRanMdLm\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"TRanMdLm\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=axtens.net\n\t(client-ip=2607:f8b0:400e:c00::22a; helo=mail-pf0-x22a.google.com;\n\tenvelope-from=dja@axtens.net; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"TRanMdLm\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:subject:in-reply-to:references:date:message-id:mime-version;\n\tbh=jAx5UizZSeYH2aK59aN8NOJGZ+RxBJ9/gVc+iUA6hNs=;\n\tb=TRanMdLmM5IR6uNqdwqFMc390vGn5d/NNYeUwDuTDJphuJIxHOcq+PeM1V3rfEw2AZ\n\tAPOjgYGodpMCtRVA3U0/kmoqRV/VSlqOfjlb9tsswNWgLzIGXyiDR7fRUYGvgMAVcvIP\n\tyLvcBwFq5BiNoWWfxoy4fmMYqi5xWt9K09zDk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=jAx5UizZSeYH2aK59aN8NOJGZ+RxBJ9/gVc+iUA6hNs=;\n\tb=MdRjHv+czS3DL4+U2bpbYXSYBMjx3jFoJCT7AP09abBiF+zaOlvtkBMPiJNnyQRY5N\n\tlDQkkFEgMqOUkVT2e0AWiRrmBqGuYY9LgUQOZFaI9EKVkWz6wfmhe2DPEySiAL3Si1A2\n\twspbBVy6TBYMdFEv42VNgyYJZGy4J3Xi967Ex5ERjDd5xvgJxBhOYHC310D2+OwvLnYD\n\tEdn0DwQQOtgW70a497AOOx5w9eAM6jwd35PAp9wOtwq3v5sXjz0zVQmF17Emf8GMzl9X\n\tEjcksc7yAm/Ae8QKTb4N6kSNuzhF6+sw9jJeQSy2CfdSRx16WKIOKflY9nEZcVU4+3Ce\n\tLxgQ==","X-Gm-Message-State":"AHPjjUgRl0Y1GPlC1rA+xUsqpjI+NJCN3Tn9cyoR5eVzDbhhHFcK9gNU\n\t3ntmblH9VTOx9ZcIPdqeaC4W8Q==","X-Google-Smtp-Source":"AOwi7QAuESjkXTZeZa0cq2IWGYRrigePHQnVY2W8ZCHe1K7qvQyPWrn6F2Jw27u+3gQPklPyB2vy3g==","X-Received":"by 10.98.57.129 with SMTP id u1mr10469109pfj.197.1506425251243; \n\tTue, 26 Sep 2017 04:27:31 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"Stephen Finucane <stephen@that.guru>, patchwork@lists.ozlabs.org","Subject":"Re: [PATCH 4/4] Test postgresql support in Travis CI","In-Reply-To":"<1504809136.6238.16.camel@that.guru>","References":"<20170903151444.25660-1-dja@axtens.net>\n\t<20170903151444.25660-5-dja@axtens.net>\n\t<1504809136.6238.16.camel@that.guru>","Date":"Tue, 26 Sep 2017 21:27:25 +1000","Message-ID":"<87poadya1u.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]