[{"id":1764875,"web_url":"http://patchwork.ozlabs.org/comment/1764875/","msgid":"<1504808312.6238.7.camel@that.guru>","list_archive_url":null,"date":"2017-09-07T18:18:32","subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Mon, 2017-09-04 at 01:14 +1000, Daniel Axtens wrote:\n> This is required to make the tests pass on a recent version of\n> postgres.\n> \n> Signed-off-by: Daniel Axtens <dja@axtens.net>\n> ---\n>  patchwork/tests/test_rest_api.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/patchwork/tests/test_rest_api.py\n> b/patchwork/tests/test_rest_api.py\n> index abffd17fddec..d4a84bd8c5ad 100644\n> --- a/patchwork/tests/test_rest_api.py\n> +++ b/patchwork/tests/test_rest_api.py\n> @@ -738,7 +738,7 @@ class TestBundleAPI(APITestCase):\n>          # authenticated user\n>          # should see the public and private bundle\n>          self.client.force_authenticate(user=user)\n> -        resp = self.client.get(self.api_url())\n> +        resp = self.client.get(self.api_url() + '?order=id')\n\nMaybe I'm misunderstanding things here, but doesn't this suggest users would\nalways need to add the 'order' filter just to get things working sanely on a\nPostgreSQL-backed instance? If so that doesn't sound very useful, and it would\nsuggest that the test is doing its job.\n\nIt doesn't seem like there's a way to apply a default filter using the\n'OrderingFilter' [1]. However, could we simply add a sort to the queryset\nreturned by 'patchwork.api.bundle.BundleFilter.get_queryset'?\n\n>          self.assertEqual(status.HTTP_200_OK, resp.status_code)\n>          self.assertEqual(2, len(resp.data))\n>          for bundle_rsp, bundle_obj in zip(\n\nStephen\n\n[1] http://www.django-rest-framework.org/api-guide/filtering/#orderingfilter","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7xw1X0Bz9ryk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 04:19:00 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xp7xv4cydzDrXh\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 04:18:59 +1000 (AEST)","from camel.maple.relay.mailchannels.net\n\t(camel.maple.relay.mailchannels.net [23.83.214.29])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xp7xZ1x0TzDrWZ\n\tfor <patchwork@lists.ozlabs.org>;\n\tFri,  8 Sep 2017 04:18:40 +1000 (AEST)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 9CA10201D65;\n\tThu,  7 Sep 2017 18:18:37 +0000 (UTC)","from one.mxroute.com (unknown [100.96.126.162])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 14602201DA7;\n\tThu,  7 Sep 2017 18:18:37 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.52.122])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Thu, 07 Sep 2017 18:18:37 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"lUQ8Qh/n\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"lUQ8Qh/n\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=23.83.214.29; helo=camel.maple.relay.mailchannels.net;\n\tenvelope-from=stephen@that.guru; receiver=<UNKNOWN>)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"lUQ8Qh/n\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Power-Vacuous":"37fd53911389739b_1504808317369_1273981825","X-MC-Loop-Signature":"1504808317368:4127122284","X-MC-Ingress-Time":"1504808317368","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=vaMDZpqme3tIM8EnGKo8If/IODLZL0Pj+PIl0ykYjMk=;\n\tb=lUQ8Qh/nhQ17sYUoVbKmdTq1/Q\n\twWmbKNtoD6JtMj7xwJC8+kHc0hWMdeO+Y3MI49Yb8LVVYTOzCLMPfc6c0Tk63nxYV4+RV7SyYZSKV\n\tnhVXSveWwd9NecFYNxzzi3pID5+5PqAAfHyD33VSjxhYj8y6pS5oF/8Y4sUvBQQ8++pS3jEdSnP/L\n\tq3YTKhQaFHGkEk3NnePyXKNtDY2RzpdIkogVoDasyG155PGVVXUiILHOp5j01jWTbBYngjK1m004H\n\tM/r8dTnnI9BHwiqzCaLQ47oCmHhLyJPY6eWJIObmYTZ8rMS7AMD3ygf62Js4M7S6xlp4Bkrvo63Mv\n\t9OW5wxZw==;","Message-ID":"<1504808312.6238.7.camel@that.guru>","Subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","From":"Stephen Finucane <stephen@that.guru>","To":"Daniel Axtens <dja@axtens.net>, patchwork@lists.ozlabs.org","Date":"Thu, 07 Sep 2017 19:18:32 +0100","In-Reply-To":"<20170903151444.25660-2-dja@axtens.net>","References":"<20170903151444.25660-1-dja@axtens.net>\n\t<20170903151444.25660-2-dja@axtens.net>","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1764948,"web_url":"http://patchwork.ozlabs.org/comment/1764948/","msgid":"<87d1728atw.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-07T21:20:43","subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Stephen Finucane <stephen@that.guru> writes:\n\n> On Mon, 2017-09-04 at 01:14 +1000, Daniel Axtens wrote:\n>> This is required to make the tests pass on a recent version of\n>> postgres.\n>> \n>> Signed-off-by: Daniel Axtens <dja@axtens.net>\n>> ---\n>>  patchwork/tests/test_rest_api.py | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/patchwork/tests/test_rest_api.py\n>> b/patchwork/tests/test_rest_api.py\n>> index abffd17fddec..d4a84bd8c5ad 100644\n>> --- a/patchwork/tests/test_rest_api.py\n>> +++ b/patchwork/tests/test_rest_api.py\n>> @@ -738,7 +738,7 @@ class TestBundleAPI(APITestCase):\n>>          # authenticated user\n>>          # should see the public and private bundle\n>>          self.client.force_authenticate(user=user)\n>> -        resp = self.client.get(self.api_url())\n>> +        resp = self.client.get(self.api_url() + '?order=id')\n>\n> Maybe I'm misunderstanding things here, but doesn't this suggest users would\n> always need to add the 'order' filter just to get things working sanely on a\n> PostgreSQL-backed instance? If so that doesn't sound very useful, and it would\n> suggest that the test is doing its job.\n\nI didn't think bundles were intrinsically ordered - unlike\npatches/series which have a pretty obvious date-ordering, I think\nbundles are a bit more arbitrary. Is there an obvious sane ordering we\nshould be enforcing? (IMO you could make a decent argument for either\nsorting by name or sorting by (creation|modification) date.)\n\n>\n> It doesn't seem like there's a way to apply a default filter using the\n> 'OrderingFilter' [1]. However, could we simply add a sort to the queryset\n> returned by 'patchwork.api.bundle.BundleFilter.get_queryset'?\n\nIf we went down this route, I think we would probably want to order them\nusing a class Meta ordering statement in the model (see e.g. the\nordering of projects by linkname in models.py around line 101.) I assume\nthe REST stuff honours that ordering.\n\nRegards,\nDaniel\n>\n>>          self.assertEqual(status.HTTP_200_OK, resp.status_code)\n>>          self.assertEqual(2, len(resp.data))\n>>          for bundle_rsp, bundle_obj in zip(\n>\n> Stephen\n>\n> [1] http://www.django-rest-framework.org/api-guide/filtering/#orderingfilter","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpD026b3Xz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 07:21:06 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpD0253pqzDrYg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 07:21:06 +1000 (AEST)","from mail-pf0-x22b.google.com (mail-pf0-x22b.google.com\n\t[IPv6:2607:f8b0:400e:c00::22b])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpCzm2kgSzDrX7\n\tfor <patchwork@lists.ozlabs.org>;\n\tFri,  8 Sep 2017 07:20:50 +1000 (AEST)","by mail-pf0-x22b.google.com with SMTP id e199so1364399pfh.3\n\tfor <patchwork@lists.ozlabs.org>;\n\tThu, 07 Sep 2017 14:20:50 -0700 (PDT)","from localhost (124-171-202-56.dyn.iinet.net.au. [124.171.202.56])\n\tby smtp.gmail.com with ESMTPSA id\n\to5sm711711pfh.67.2017.09.07.14.20.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 14:20:48 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"Gen30LML\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"Gen30LML\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=axtens.net\n\t(client-ip=2607:f8b0:400e:c00::22b; helo=mail-pf0-x22b.google.com;\n\tenvelope-from=dja@axtens.net; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"Gen30LML\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:subject:in-reply-to:references:date:message-id:mime-version;\n\tbh=4DclyvDZXNmh+xKfWDc9lJF9IHcVNEUaF0KfmVjxEoA=;\n\tb=Gen30LMLGy9bGGeGjbLosW6r4bt1bglAwuwHe198vpgzd0yLAH8xSxS76R3w44bb/r\n\txVw7uI0YUJBfGeC97W2bd39fpHaBUAoLvtE105ypsmUXw8JDoDsuGKH27xvK+YuJ+wap\n\tIrFT1E0WyFzrPJOlmy7eAHIfhMljBAItJqjNk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=4DclyvDZXNmh+xKfWDc9lJF9IHcVNEUaF0KfmVjxEoA=;\n\tb=FbK5Jy1JMGZdnrwejOsqfJAwBfuApJFB6d+CI88bhhzV9qavOQIDYQgZHUV3lf+AHV\n\tPycyKvjoHivZbJ8qruSQ1LO2tIGzREYz0pAX4u08Nq1AIB0tyqMd46bxTD1wx96dI3hC\n\tYV7qAeyOfTLfHejZz2jChRKfqqRE6+oWGDxC6TJ+jgBvaPziz1xbJXkDQmvI7eiOvpl5\n\t2OGf833Ed8U+l24V1XqdrRzgwgdHo001z9B/R+1GZYTHm/S0lRD/mIwirranbZdPz35Y\n\tc+k3gdWMKnzNo1xCKucLEzf1wj3PZdCJRT479YHGK5Shu6+HVQDUjNwIYbqF7OO4Yalk\n\t3dFA==","X-Gm-Message-State":"AHPjjUgXAow8YjVB2rPQmt1Uoc8Q/t2uecoYX1VUHieB8unSvRCyW32B\n\t7tg6wQ21s9y85BkZX4w3uQ==","X-Google-Smtp-Source":"ADKCNb7N8SOTVN0Se9Q8khOSm9VLGFH6KyCFC+z42eaG4KoIIWgfPjdXlbS2s/J3JRUEv8KSbnAC4A==","X-Received":"by 10.98.134.206 with SMTP id x197mr775668pfd.26.1504819248900; \n\tThu, 07 Sep 2017 14:20:48 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"Stephen Finucane <stephen@that.guru>, patchwork@lists.ozlabs.org","Subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","In-Reply-To":"<1504808312.6238.7.camel@that.guru>","References":"<20170903151444.25660-1-dja@axtens.net>\n\t<20170903151444.25660-2-dja@axtens.net>\n\t<1504808312.6238.7.camel@that.guru>","Date":"Fri, 08 Sep 2017 07:20:43 +1000","Message-ID":"<87d1728atw.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1765150,"web_url":"http://patchwork.ozlabs.org/comment/1765150/","msgid":"<1504859499.28795.9.camel@that.guru>","list_archive_url":null,"date":"2017-09-08T08:31:39","subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","submitter":{"id":69991,"url":"http://patchwork.ozlabs.org/api/people/69991/","name":"Stephen Finucane","email":"stephen@that.guru"},"content":"On Fri, 2017-09-08 at 07:20 +1000, Daniel Axtens wrote:\n> Stephen Finucane <stephen@that.guru> writes:\n> \n> > On Mon, 2017-09-04 at 01:14 +1000, Daniel Axtens wrote:\n> > > This is required to make the tests pass on a recent version of\n> > > postgres.\n> > > \n> > > Signed-off-by: Daniel Axtens <dja@axtens.net>\n> > > ---\n> > >  patchwork/tests/test_rest_api.py | 2 +-\n> > >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/patchwork/tests/test_rest_api.py\n> > > b/patchwork/tests/test_rest_api.py\n> > > index abffd17fddec..d4a84bd8c5ad 100644\n> > > --- a/patchwork/tests/test_rest_api.py\n> > > +++ b/patchwork/tests/test_rest_api.py\n> > > @@ -738,7 +738,7 @@ class TestBundleAPI(APITestCase):\n> > >          # authenticated user\n> > >          # should see the public and private bundle\n> > >          self.client.force_authenticate(user=user)\n> > > -        resp = self.client.get(self.api_url())\n> > > +        resp = self.client.get(self.api_url() + '?order=id')\n> > \n> > Maybe I'm misunderstanding things here, but doesn't this suggest users\n> > would always need to add the 'order' filter just to get things working\n> > sanely on a PostgreSQL-backed instance? If so that doesn't sound very\n> > useful, and it would suggest that the test is doing its job.\n> \n> I didn't think bundles were intrinsically ordered - unlike\n> patches/series which have a pretty obvious date-ordering, I think\n> bundles are a bit more arbitrary. Is there an obvious sane ordering we\n> should be enforcing? (IMO you could make a decent argument for either\n> sorting by name or sorting by (creation|modification) date.)\n\nThat's a very good point. I looked at 'patchwork.view.bundle.bundle_list', and\nnoted that there is no default bundling applied, however, I do think we want to\navoid the same request returning different responses simply because of the\ndatabase backend in use. Given that there's no precedent here, I guess this\nmeans we're free to choose? Name or ID (which is implicitly data-based) would\nbe equal in my mind.\n\n> > It doesn't seem like there's a way to apply a default filter using the\n> > 'OrderingFilter' [1]. However, could we simply add a sort to the queryset\n> > returned by 'patchwork.api.bundle.BundleFilter.get_queryset'?\n> \n> If we went down this route, I think we would probably want to order them\n> using a class Meta ordering statement in the model (see e.g. the\n> ordering of projects by linkname in models.py around line 101.) I assume\n> the REST stuff honours that ordering.\n\nThe only disadvantage to taking this route is that it will introduce a\nmigration, and I'm not sure if a migration is something we should be in the\nhabit of backporting. Perhaps we modify 'get_queryset' for 'stable/2.0' (with\ntests, of course) and take the Meta class approach for 'master'? Open to other\nideas here, of course.\n\nStephen","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpVt46lsbz9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 18:31:56 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpVt45bGwzDrbR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 18:31:56 +1000 (AEST)","from camel.maple.relay.mailchannels.net\n\t(camel.maple.relay.mailchannels.net [23.83.214.29])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpVsw6YgQzDrZv\n\tfor <patchwork@lists.ozlabs.org>;\n\tFri,  8 Sep 2017 18:31:47 +1000 (AEST)","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id EABB15C83B3;\n\tFri,  8 Sep 2017 08:31:43 +0000 (UTC)","from one.mxroute.com (unknown [100.96.147.9])\n\t(Authenticated sender: mxroute)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 330F25C85B1;\n\tFri,  8 Sep 2017 08:31:43 +0000 (UTC)","from one.mxroute.com (one-outgoing.mxroute.com [172.20.66.218])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Fri, 08 Sep 2017 08:31:43 +0000"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"Qhvdya68\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"Qhvdya68\"; dkim-atps=neutral","ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=that.guru\n\t(client-ip=23.83.214.29; helo=camel.maple.relay.mailchannels.net;\n\tenvelope-from=stephen@that.guru; receiver=<UNKNOWN>)","lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=that.guru header.i=@that.guru\n\theader.b=\"Qhvdya68\"; dkim-atps=neutral"],"X-Sender-Id":["mxroute|x-authuser|stephen@that.guru","mxroute|x-authuser|stephen@that.guru"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"mxroute|x-authuser|stephen@that.guru","X-MailChannels-Auth-Id":"mxroute","X-Oafish-Vacuous":"7b7a28a9279b61e0_1504859503715_2915924777","X-MC-Loop-Signature":"1504859503714:866407542","X-MC-Ingress-Time":"1504859503714","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n\ts=default;\n\th=Content-Transfer-Encoding:Mime-Version:Content-Type:References:\n\tIn-Reply-To:Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=r/yMEY3PgSFFFIFVygmPPh+RaaIm46ICAkX8t0972ok=;\n\tb=Qhvdya68FlryI9i2aGjlbhT6Z5\n\t6zcCChd7zSe29o/c0aMThvj1+1oL1Ik45fMoinPxvgl3dw/cB9Jrfx7U2Zesa8OZN/tGJjW4QDE4I\n\tIK6Z4PWRTzBLsiavN8EB6qd/pmBlMFxl4GUjK9VyuopOJWFgKyaHg0uswBsVFTYSHJOp4KkST0LTY\n\tz+Vz6wpUKSv3WQeDZPDYdGUdHVAIv4tjNypuJJAFyHQuandqNioCLqy3PTTDv7beTkn/mrJ9b4bd5\n\tplxDA730QmH8wNPqoNH8cCSroGrQVTAeg+4N3wSM9FygNqy0VE0SN/4Lp1e/JKwnNVhdCiI987KId\n\tebx+T0tQ==;","Message-ID":"<1504859499.28795.9.camel@that.guru>","Subject":"Re: [PATCH 1/4] Enforce ordering of bundles in REST test","From":"Stephen Finucane <stephen@that.guru>","To":"Daniel Axtens <dja@axtens.net>, patchwork@lists.ozlabs.org","Date":"Fri, 08 Sep 2017 09:31:39 +0100","In-Reply-To":"<87d1728atw.fsf@linkitivity.dja.id.au>","References":"<20170903151444.25660-1-dja@axtens.net>\n\t<20170903151444.25660-2-dja@axtens.net>\n\t<1504808312.6238.7.camel@that.guru>\n\t<87d1728atw.fsf@linkitivity.dja.id.au>","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","X-AuthUser":"stephen@that.guru","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]