[{"id":1762289,"web_url":"http://patchwork.ozlabs.org/comment/1762289/","msgid":"","list_archive_url":null,"date":"2017-09-03T15:32:26","subject":"Re: [PATCH] netfilter: xt_TEE: Fix potential deadlock when TEE\n\ttarget is inserted","submitter":{"id":13886,"url":"http://patchwork.ozlabs.org/api/people/13886/","name":"Jan Engelhardt","email":"jengelh@inai.de"},"content":"On Sunday 2017-09-03 16:30, Taehee Yoo wrote:\n\n>When xt_TEE target is inserted, lockdep warns about possible\n>DEADLOCK situation. to avoid deadlock situation\n>the register_netdevice_notifier() should be called by only init routine.\n>\n>+#include \n> \n> struct xt_tee_tginfo {\n> \tunion nf_inet_addr gw;\n>-\tchar oif[16];\n>+\tchar oif[IFNAMSIZ];\n\nThis should not be done, as xt_tee_tginfo is exported to userspace.\n(It also has nothing to do with fixing the deadlock, really.)\n\n>+\t\tcase NETDEV_UNREGISTER:\n>+\t\t\tif ((dev->ifindex == priv->oif) &&\n\nredundant new parenthesis group\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlcRd4Zg8z9t33\n\tfor ;\n\tMon, 4 Sep 2017 01:32:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752999AbdICPc2 (ORCPT );\n\tSun, 3 Sep 2017 11:32:28 -0400","from a3.inai.de ([88.198.180.161]:42828 \"EHLO a3.inai.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752917AbdICPc2 (ORCPT );\n\tSun, 3 Sep 2017 11:32:28 -0400","by a3.inai.de (Postfix, from userid 25121)\n\tid EF62619244967; Sun, 3 Sep 2017 17:32:26 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby a3.inai.de (Postfix) with ESMTP id E9F9717AAF18;\n\tSun, 3 Sep 2017 17:32:26 +0200 (CEST)"],"Date":"Sun, 3 Sep 2017 17:32:26 +0200 (CEST)","From":"Jan Engelhardt ","To":"Taehee Yoo ","cc":"pablo@netfilter.org, netfilter-devel@vger.kernel.org","Subject":"Re: [PATCH] netfilter: xt_TEE: Fix potential deadlock when TEE\n\ttarget is inserted","In-Reply-To":"<20170903143034.25844-1-ap420073@gmail.com>","Message-ID":"","References":"<20170903143034.25844-1-ap420073@gmail.com>","User-Agent":"Alpine 2.21 (LSU 202 2017-01-01)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1762294,"web_url":"http://patchwork.ozlabs.org/comment/1762294/","msgid":"","list_archive_url":null,"date":"2017-09-03T15:51:24","subject":"Re: [PATCH] netfilter: xt_TEE: Fix potential deadlock when TEE\n\ttarget is inserted","submitter":{"id":68997,"url":"http://patchwork.ozlabs.org/api/people/68997/","name":"Taehee Yoo","email":"ap420073@gmail.com"},"content":"2017-09-04 0:32 GMT+09:00 Jan Engelhardt :\n>\n> On Sunday 2017-09-03 16:30, Taehee Yoo wrote:\n>\n>>When xt_TEE target is inserted, lockdep warns about possible\n>>DEADLOCK situation. to avoid deadlock situation\n>>the register_netdevice_notifier() should be called by only init routine.\n>>\n>>+#include \n>>\n>> struct xt_tee_tginfo {\n>> union nf_inet_addr gw;\n>>- char oif[16];\n>>+ char oif[IFNAMSIZ];\n>\n> This should not be done, as xt_tee_tginfo is exported to userspace.\n> (It also has nothing to do with fixing the deadlock, really.)\n>\n>>+ case NETDEV_UNREGISTER:\n>>+ if ((dev->ifindex == priv->oif) &&\n>\n> redundant new parenthesis group\n\nThank you for your review!\n\nI will send v2 patch.\n\nThanks\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jqq3W9CE\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlcsV6cMwz9t33\n\tfor ;\n\tMon, 4 Sep 2017 01:51:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753093AbdICPv0 (ORCPT );\n\tSun, 3 Sep 2017 11:51:26 -0400","from mail-yw0-f194.google.com ([209.85.161.194]:37968 \"EHLO\n\tmail-yw0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752915AbdICPvZ (ORCPT\n\t);\n\tSun, 3 Sep 2017 11:51:25 -0400","by mail-yw0-f194.google.com with SMTP id e9so2477770ywh.5\n\tfor ;\n\tSun, 03 Sep 2017 08:51:25 -0700 (PDT)","by 10.37.72.70 with HTTP; Sun, 3 Sep 2017 08:51:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=LRVChKn3DeMscafxyteheykND22Db4mR2+D7wCna0wk=;\n\tb=jqq3W9CEg0WFbu796+htszdU/a3G+Wi3+2MmiZRmGvvNR6nJ1ebVlLipXjmwOxyfaJ\n\tESKw0Blgh6Q+FaSCa+E54e4ZA5SVaOV51bnQzI1TK0uWciYjHPEJmOqX4aQiJUPUuk50\n\tZWmXmEqZUFkqn4Stlumy4R73jy6xo/zuTjpF8iPVd8KkY9u4Hc0alMoUs3tEucF3FECQ\n\tm0jG7o7raN8Io/yY9YTpz/g0XD0NcHP0TVMAiNJTk/mxlHTVCqMlf4fZZYhRjHe9Da/k\n\tLMskTcp7586rLOJSTjW41WxJH3zcP1sQexMJpVLt5Y+drFxANPorWo8ScHoKEwUmQCem\n\tOTbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=LRVChKn3DeMscafxyteheykND22Db4mR2+D7wCna0wk=;\n\tb=Rnb9rgSpdDKnmbiH7rGoqoUjGxB/pmjF4B7WdWyCivcZTbTeJTVeToEEjAE4MHQBC+\n\tHxPAwm0Uz08em415NDerW88JYQqQWAUSDIrES3/8eC9ylJ5aDJEl8vRKXMwtICbU2b6B\n\tvLm7INSRGGoKgsrKrtXxSSn90MvEy+uftKKLUtPfsbwH08SakX7FKMXrpjU9m8dzZOO6\n\tFCfJ3qRgJ2qzQyNpPocesqEBLMPg51rZKO8tYEeulbxj3e0CZF3vcu2uiNgYzbLuRQcJ\n\tO7LYs9GzKA49FGaRys9NzbW4Hom4wIU+KKg7BodVxozT6BFblCViF0lFn9BoIGDFmz2z\n\t6Z8w==","X-Gm-Message-State":"AHPjjUjpN0Kf4/hPZqomGFGXn5ySAwVqRKeWXXg92qOOtQey0hiTq9/j\n\tnzGdcFihePWj5Agz1URBvrdfBXG/7u2L","X-Google-Smtp-Source":"ADKCNb46fO2ucVIHAXeRxOYERgr3/Gru6BlEl+ASSMprWOoGSbc1u1tv/SasnbCABIgyRRJO4PwvarjnO65Y5GVQXUw=","X-Received":"by 10.37.56.132 with SMTP id f126mr6562812yba.203.1504453884974; \n\tSun, 03 Sep 2017 08:51:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170903143034.25844-1-ap420073@gmail.com>\n\t","From":"Taehee Yoo ","Date":"Mon, 4 Sep 2017 00:51:24 +0900","Message-ID":"","Subject":"Re: [PATCH] netfilter: xt_TEE: Fix potential deadlock when TEE\n\ttarget is inserted","To":"Jan Engelhardt ","Cc":"Pablo Neira Ayuso ,\n\tNetfilter Developer Mailing List ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]