[{"id":1762448,"web_url":"http://patchwork.ozlabs.org/comment/1762448/","msgid":"","list_archive_url":null,"date":"2017-09-04T06:42:19","subject":"Re: [U-Boot] [PATCH] mvebu: turris_omnia: Only set eth?addr env if\n\tCONFIG_CMD_NET","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"Hi Marek,\n\nOn 03.09.2017 15:13, Marek Behún wrote:\n> Otherwise the linking will fail since eth_env_set_enetaddr cannot\n> be found.\n> \n> Signed-off-by: Marek Behun \n> ---\n> board/CZ.NIC/turris_omnia/turris_omnia.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c\n> index af66837909..7db3b8ff3b 100644\n> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c\n> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c\n> @@ -470,6 +470,7 @@ out:\n> \treturn 0;\n> }\n> \n> +#if defined(CONFIG_ATSHA204A) && defined(CONFIG_CMD_NET)\n> static void increment_mac(u8 *mac)\n> {\n> \tint i;\n> @@ -480,10 +481,11 @@ static void increment_mac(u8 *mac)\n> \t\t\tbreak;\n> \t}\n> }\n> +#endif\n> \n> int misc_init_r(void)\n> {\n> -#ifdef CONFIG_ATSHA204A\n> +#if defined(CONFIG_ATSHA204A) && defined(CONFIG_CMD_NET)\n> \tint err;\n> \tstruct udevice *dev = get_atsha204a_dev();\n> \tu8 mac0[4], mac1[4], mac[6];\n> \n\nPerhaps its better to select or imply ATSHA204A and CMD_NET for\nturris_omnia in Kconfig instead. You can then remove all the #ifdef's\nfrom the code here.\n\nJust curious:\nWhere did you see this compile / linking problem. Compiling current\nmainline does not cause any issues.\n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm0dk5VwTz9s72\n\tfor ;\n\tMon, 4 Sep 2017 16:42:34 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 434A5C21E93; Mon, 4 Sep 2017 06:42:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E31C2C21DAD;\n\tMon, 4 Sep 2017 06:42:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0FF12C21DAD; Mon, 4 Sep 2017 06:42:24 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id C14B4C21DA1\n\tfor ; Mon, 4 Sep 2017 06:42:23 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 6EEAF436EE;\n\tMon, 4 Sep 2017 08:42:23 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de\n\t[80.241.56.116]) (amavisd-new, port 10030)\n\twith ESMTP id 6OuZkpImyzZk; Mon, 4 Sep 2017 08:42:21 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"=?utf-8?q?Marek_Beh=C3=BAn?= , u-boot@lists.denx.de","References":"<20170903131342.1092-1-marek.behun@nic.cz>","From":"Stefan Roese ","Message-ID":"","Date":"Mon, 4 Sep 2017 08:42:19 +0200","MIME-Version":"1.0","In-Reply-To":"<20170903131342.1092-1-marek.behun@nic.cz>","Content-Language":"en-US","Cc":"=?utf-8?q?Andreas_F=C3=A4rber?= ","Subject":"Re: [U-Boot] [PATCH] mvebu: turris_omnia: Only set eth?addr env if\n\tCONFIG_CMD_NET","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1770649,"web_url":"http://patchwork.ozlabs.org/comment/1770649/","msgid":"<1b6c735d-3ea6-69f6-1ed7-e4b048a23f8b@denx.de>","list_archive_url":null,"date":"2017-09-19T04:50:26","subject":"Re: [U-Boot] [PATCH] mvebu: turris_omnia: Only set eth?addr env if\n\tCONFIG_CMD_NET","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"Hi Marek,\n\nOn 04.09.2017 08:42, Stefan Roese wrote:\n> On 03.09.2017 15:13, Marek Behún wrote:\n>> Otherwise the linking will fail since eth_env_set_enetaddr cannot\n>> be found.\n>>\n>> Signed-off-by: Marek Behun \n>> ---\n>> board/CZ.NIC/turris_omnia/turris_omnia.c | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c \n>> b/board/CZ.NIC/turris_omnia/turris_omnia.c\n>> index af66837909..7db3b8ff3b 100644\n>> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c\n>> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c\n>> @@ -470,6 +470,7 @@ out:\n>> return 0;\n>> }\n>> +#if defined(CONFIG_ATSHA204A) && defined(CONFIG_CMD_NET)\n>> static void increment_mac(u8 *mac)\n>> {\n>> int i;\n>> @@ -480,10 +481,11 @@ static void increment_mac(u8 *mac)\n>> break;\n>> }\n>> }\n>> +#endif\n>> int misc_init_r(void)\n>> {\n>> -#ifdef CONFIG_ATSHA204A\n>> +#if defined(CONFIG_ATSHA204A) && defined(CONFIG_CMD_NET)\n>> int err;\n>> struct udevice *dev = get_atsha204a_dev();\n>> u8 mac0[4], mac1[4], mac[6];\n>>\n> \n> Perhaps its better to select or imply ATSHA204A and CMD_NET for\n> turris_omnia in Kconfig instead. You can then remove all the #ifdef's\n> from the code here.\n> \n> Just curious:\n> Where did you see this compile / linking problem. Compiling current\n> mainline does not cause any issues.\n\nI didn't receive any answers on these questions. Could you please\ncheck again?\n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx9Rf683rz9s5L\n\tfor ;\n\tTue, 19 Sep 2017 14:50:38 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 85202C21E3D; Tue, 19 Sep 2017 04:50:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DCA64C21C3F;\n\tTue, 19 Sep 2017 04:50:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 90195C21C3F; Tue, 19 Sep 2017 04:50:29 +0000 (UTC)","from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215])\n\tby lists.denx.de (Postfix) with ESMTPS id 3413EC21C34\n\tfor ; Tue, 19 Sep 2017 04:50:29 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx2.mailbox.org (Postfix) with ESMTPS id F2F0B49879;\n\tTue, 19 Sep 2017 06:50:28 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby hefe.heinlein-support.de (hefe.heinlein-support.de\n\t[91.198.250.172]) (amavisd-new, port 10030)\n\twith ESMTP id PeCwiO0IZjUo; Tue, 19 Sep 2017 06:50:27 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","From":"Stefan Roese ","To":"=?utf-8?q?Marek_Beh=C3=BAn?= , u-boot@lists.denx.de","References":"<20170903131342.1092-1-marek.behun@nic.cz>\n\t","Message-ID":"<1b6c735d-3ea6-69f6-1ed7-e4b048a23f8b@denx.de>","Date":"Tue, 19 Sep 2017 06:50:26 +0200","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"=?utf-8?q?Andreas_F=C3=A4rber?= ","Subject":"Re: [U-Boot] [PATCH] mvebu: turris_omnia: Only set eth?addr env if\n\tCONFIG_CMD_NET","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]