[{"id":1762331,"web_url":"http://patchwork.ozlabs.org/comment/1762331/","msgid":"<20170903204634.GZ20805@n2100.armlinux.org.uk>","list_archive_url":null,"date":"2017-09-03T20:46:35","subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","submitter":{"id":69080,"url":"http://patchwork.ozlabs.org/api/people/69080/","name":"Russell King (Oracle)","email":"linux@armlinux.org.uk"},"content":"On Sun, Sep 03, 2017 at 03:31:13PM +0300, Baruch Siach wrote:\n> Add device-tree binding documentation SFP transceivers. Support for SFP\n> transceivers has been recently introduced (drivers/net/phy/sfp.c).\n> \n> Signed-off-by: Baruch Siach \n> ---\n> v3:\n> Mention gpios phandle and specifier\n> Mention the polarity of each gpio\n> Fix example property names\n> \n> v2:\n> Rename -gpio properties to -gpios\n> Rename the rate-select-gpio property to rate-select0-gpios\n> Add the rate-select1-gpios property\n> Add examples\n> ---\n> Documentation/devicetree/bindings/net/sff,sfp.txt | 78 +++++++++++++++++++++++\n> 1 file changed, 78 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/net/sff,sfp.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> new file mode 100644\n> index 000000000000..b98ee5945265\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> @@ -0,0 +1,78 @@\n> +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)\n> +Transceiver\n> +\n> +Required properties:\n> +\n> +- compatible : must be \"sff,sfp\"\n> +\n> +Optional Properties:\n> +\n> +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial\n> + interface\n> +\n> +- moddef0-gpios : GPIO phandle and a single specifier of the MOD-DEF0 (AKA\n> + Mod_ABS) module presence input gpio signal, active (module absent) high\n> +\n> +- los-gpios : GPIO phandle and a single specifier of the Receiver Loss of\n> + Signal Indication input gpio signal, active (signal lost) high\n> +\n> +- tx-fault-gpios : GPIO phandle and a single specifier of the Module\n> + Transmitter Fault input gpio signal, active (fault condition) high\n> +\n> +- tx-disable-gpios : GPIO phandle and a single specifier of the Transmitter\n> + Disable output gpio signal, active (Tx disable) high\n> +\n> +- rate-select0-gpios : GPIO phandle and a single specifier of the Rx Signaling\n> + Rate Select (AKA RS0) output gpio signal, low: low Rx rate, high: high Rx\n> + rate\n> +\n> +- rate-select1-gpios : GPIO phandle and a single specifier of the Tx Signaling\n> + Rate Select (AKA RS1) output gpio signal (SFP+ only), low: low Tx rate,\n> + high: high Tx rate\n> +\n> +Example #1: Direct serdes to SFP connection\n> +\n> +sfp_eth3: sfp-eth3 {\n> +\tcompatible = \"sff,sfp\";\n> +\ti2c-bus = <&sfp_1g_i2c>;\n> +\tlos-gpios = <&cpm_gpio2 22 GPIO_ACTIVE_HIGH>;\n> +\tmoddef0-gpios = <&cpm_gpio2 21 GPIO_ACTIVE_LOW>;\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&cpm_sfp_1g_pins &cps_sfp_1g_pins>;\n> +\ttx-disable-gpios = <&cps_gpio1 24 GPIO_ACTIVE_HIGH>;\n> +\ttx-fault-gpios = <&cpm_gpio2 19 GPIO_ACTIVE_HIGH>;\n> +};\n> +\n> +&cps_emac3 {\n> +\tphy-mode = \"sgmii\";\n> +\tphy-names = \"comphy\";\n> +\tphys = <&cps_comphy 5 COMPHY_SGMII2>;\n\nI don't like this level of example - SGMII is Cisco SGMII which is not\nthe same as 1000Base-X - the two are incompatible. Fibre SFP modules\nonly work with 1000Base-X.\n\nThe SFP/phylink takes care of informing the MAC which mode it should\nbe in, and the MAC must configure itself appropriately in response to\nthat, otherwise the module can't be supported.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=armlinux.org.uk header.i=@armlinux.org.uk\n\theader.b=\"ZXJ/aNGK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xllR24rTYz9t24\n\tfor ;\n\tMon, 4 Sep 2017 06:47:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752389AbdICUqz (ORCPT );\n\tSun, 3 Sep 2017 16:46:55 -0400","from pandora.armlinux.org.uk ([78.32.30.218]:44978 \"EHLO\n\tpandora.armlinux.org.uk\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751649AbdICUqy (ORCPT\n\t); Sun, 3 Sep 2017 16:46:54 -0400","from n2100.armlinux.org.uk\n\t([2002:4e20:1eda:1:214:fdff:fe10:4f86]:38043)\n\tby pandora.armlinux.org.uk with esmtpsa\n\t(TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82_1-5b7a7c0-XX)\n\t(envelope-from )\n\tid 1dobmx-0000JE-Ko; Sun, 03 Sep 2017 21:46:39 +0100","from linux by n2100.armlinux.org.uk with local (Exim 4.76)\n\t(envelope-from )\n\tid 1dobmt-0005oL-RG; Sun, 03 Sep 2017 21:46:35 +0100"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=armlinux.org.uk; s=pandora-2014; \n\th=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;\n\tbh=Gi4r2Z3FnNvMBIZDO5W6tvUOoW61h9/mfxszlBc0cqI=; \n\tb=ZXJ/aNGK+zgYUiwYXQrgCDKzTX7Sm00MRIzJUwfYKr+U4Ygv+RL2jl9djAFhf03n1uiv2cZFaaEY4MVDrg8K3KuO4datNrD9l2CUC41Tt4oePEe8+OSjHfIH3NQBZP0WlwLceofBSVSifn1SPVc5CkncnP7kU8x7MTU0dTBXypg=;","Date":"Sun, 3 Sep 2017 21:46:35 +0100","From":"Russell King - ARM Linux ","To":"Baruch Siach ","Cc":"Rob Herring , Mark Rutland ,\n\tAndrew Lunn , Florian Fainelli ,\n\t\"David S. Miller\" , netdev@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tSergei Shtylyov ","Subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","Message-ID":"<20170903204634.GZ20805@n2100.armlinux.org.uk>","References":"\n\t<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762433,"web_url":"http://patchwork.ozlabs.org/comment/1762433/","msgid":"<20170904055512.f34afju4crd2ciu6@sapphire.tkos.co.il>","list_archive_url":null,"date":"2017-09-04T05:55:12","subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Russell,\n\nOn Sun, Sep 03, 2017 at 09:46:35PM +0100, Russell King - ARM Linux wrote:\n> On Sun, Sep 03, 2017 at 03:31:13PM +0300, Baruch Siach wrote:\n> > Add device-tree binding documentation SFP transceivers. Support for SFP\n> > transceivers has been recently introduced (drivers/net/phy/sfp.c).\n> > \n> > Signed-off-by: Baruch Siach \n> > ---\n> > v3:\n> > Mention gpios phandle and specifier\n> > Mention the polarity of each gpio\n> > Fix example property names\n> > \n> > v2:\n> > Rename -gpio properties to -gpios\n> > Rename the rate-select-gpio property to rate-select0-gpios\n> > Add the rate-select1-gpios property\n> > Add examples\n> > ---\n> > Documentation/devicetree/bindings/net/sff,sfp.txt | 78 +++++++++++++++++++++++\n> > 1 file changed, 78 insertions(+)\n> > create mode 100644 Documentation/devicetree/bindings/net/sff,sfp.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> > new file mode 100644\n> > index 000000000000..b98ee5945265\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> > @@ -0,0 +1,78 @@\n> > +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)\n> > +Transceiver\n> > +\n> > +Required properties:\n> > +\n> > +- compatible : must be \"sff,sfp\"\n> > +\n> > +Optional Properties:\n> > +\n> > +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial\n> > + interface\n> > +\n> > +- moddef0-gpios : GPIO phandle and a single specifier of the MOD-DEF0 (AKA\n> > + Mod_ABS) module presence input gpio signal, active (module absent) high\n> > +\n> > +- los-gpios : GPIO phandle and a single specifier of the Receiver Loss of\n> > + Signal Indication input gpio signal, active (signal lost) high\n> > +\n> > +- tx-fault-gpios : GPIO phandle and a single specifier of the Module\n> > + Transmitter Fault input gpio signal, active (fault condition) high\n> > +\n> > +- tx-disable-gpios : GPIO phandle and a single specifier of the Transmitter\n> > + Disable output gpio signal, active (Tx disable) high\n> > +\n> > +- rate-select0-gpios : GPIO phandle and a single specifier of the Rx Signaling\n> > + Rate Select (AKA RS0) output gpio signal, low: low Rx rate, high: high Rx\n> > + rate\n> > +\n> > +- rate-select1-gpios : GPIO phandle and a single specifier of the Tx Signaling\n> > + Rate Select (AKA RS1) output gpio signal (SFP+ only), low: low Tx rate,\n> > + high: high Tx rate\n> > +\n> > +Example #1: Direct serdes to SFP connection\n> > +\n> > +sfp_eth3: sfp-eth3 {\n> > +\tcompatible = \"sff,sfp\";\n> > +\ti2c-bus = <&sfp_1g_i2c>;\n> > +\tlos-gpios = <&cpm_gpio2 22 GPIO_ACTIVE_HIGH>;\n> > +\tmoddef0-gpios = <&cpm_gpio2 21 GPIO_ACTIVE_LOW>;\n> > +\tpinctrl-names = \"default\";\n> > +\tpinctrl-0 = <&cpm_sfp_1g_pins &cps_sfp_1g_pins>;\n> > +\ttx-disable-gpios = <&cps_gpio1 24 GPIO_ACTIVE_HIGH>;\n> > +\ttx-fault-gpios = <&cpm_gpio2 19 GPIO_ACTIVE_HIGH>;\n> > +};\n> > +\n> > +&cps_emac3 {\n> > +\tphy-mode = \"sgmii\";\n> > +\tphy-names = \"comphy\";\n> > +\tphys = <&cps_comphy 5 COMPHY_SGMII2>;\n> \n> I don't like this level of example - SGMII is Cisco SGMII which is not\n> the same as 1000Base-X - the two are incompatible. Fibre SFP modules\n> only work with 1000Base-X.\n> \n> The SFP/phylink takes care of informing the MAC which mode it should\n> be in, and the MAC must configure itself appropriately in response to\n> that, otherwise the module can't be supported.\n\nSo, if I understand you correctly, the PHY mode should not be coded in the DT \nsince the mode is run-time configurable, and depends on the SFP module. Is \nthat correct?\n\nHow about the following then:\n\n&cps_emac3 {\n phy-names = \"comphy\";\n phys = <&cps_comphy 5>;\n sfp = <&sfp_eth3>;\n};\n\nThanks,\nbaruch","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlzbD6yZwz9s7h\n\tfor ;\n\tMon, 4 Sep 2017 15:55:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751002AbdIDFzS (ORCPT );\n\tMon, 4 Sep 2017 01:55:18 -0400","from guitar.tcltek.co.il ([192.115.133.116]:47319 \"EHLO\n\tmx.tkos.co.il\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750782AbdIDFzR (ORCPT );\n\tMon, 4 Sep 2017 01:55:17 -0400","from sapphire.tkos.co.il (unknown [10.0.4.3])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id 74C1D44075A;\n\tMon, 4 Sep 2017 08:55:13 +0300 (IDT)"],"Date":"Mon, 4 Sep 2017 08:55:12 +0300","From":"Baruch Siach ","To":"Russell King - ARM Linux ","Cc":"Rob Herring , Mark Rutland ,\n\tAndrew Lunn , Florian Fainelli ,\n\t\"David S. Miller\" , netdev@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tSergei Shtylyov ","Subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","Message-ID":"<20170904055512.f34afju4crd2ciu6@sapphire.tkos.co.il>","References":"\n\t<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>\n\t<20170903204634.GZ20805@n2100.armlinux.org.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170903204634.GZ20805@n2100.armlinux.org.uk>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762546,"web_url":"http://patchwork.ozlabs.org/comment/1762546/","msgid":"","list_archive_url":null,"date":"2017-09-04T09:59:29","subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","submitter":{"id":22564,"url":"http://patchwork.ozlabs.org/api/people/22564/","name":"Sergei Shtylyov","email":"sergei.shtylyov@cogentembedded.com"},"content":"Hello!\n\nOn 9/3/2017 3:31 PM, Baruch Siach wrote:\n\n> Add device-tree binding documentation SFP transceivers. Support for SFP\n> transceivers has been recently introduced (drivers/net/phy/sfp.c).\n> \n> Signed-off-by: Baruch Siach \n[...]\n> diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> new file mode 100644\n> index 000000000000..b98ee5945265\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> @@ -0,0 +1,78 @@\n> +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)\n> +Transceiver\n> +\n> +Required properties:\n> +\n> +- compatible : must be \"sff,sfp\"\n> +\n> +Optional Properties:\n> +\n> +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial\n> + interface\n> +\n> +- moddef0-gpios : GPIO phandle and a single specifier of the MOD-DEF0 (AKA\n\n There's always a single specifier following a phandle, tho it may have \ndifferent # of cells, no need to spell that out.\n\n> + Mod_ABS) module presence input gpio signal, active (module absent) high\n> +\n> +- los-gpios : GPIO phandle and a single specifier of the Receiver Loss of\n\n Same here.\n\n> + Signal Indication input gpio signal, active (signal lost) high\n> +\n> +- tx-fault-gpios : GPIO phandle and a single specifier of the Module\n\n And here.\n\n> + Transmitter Fault input gpio signal, active (fault condition) high\n> +\n> +- tx-disable-gpios : GPIO phandle and a single specifier of the Transmitter\n\n And here.\n\n> + Disable output gpio signal, active (Tx disable) high\n> +\n> +- rate-select0-gpios : GPIO phandle and a single specifier of the Rx Signaling\n\n Here too.\n\n> + Rate Select (AKA RS0) output gpio signal, low: low Rx rate, high: high Rx\n> + rate\n> +\n> +- rate-select1-gpios : GPIO phandle and a single specifier of the Tx Signaling\n\n Here ass well.\n\n> + Rate Select (AKA RS1) output gpio signal (SFP+ only), low: low Tx rate,\n> + high: high Tx rate\n> +\n[...]\n\nMBR, Sergei","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=cogentembedded-com.20150623.gappssmtp.com\n\theader.i=@cogentembedded-com.20150623.gappssmtp.com\n\theader.b=\"kbTCPwN5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm5106FnQz9s7f\n\tfor ;\n\tMon, 4 Sep 2017 19:59:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753457AbdIDJ73 (ORCPT );\n\tMon, 4 Sep 2017 05:59:29 -0400","from mail-lf0-f43.google.com ([209.85.215.43]:33002 \"EHLO\n\tmail-lf0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753422AbdIDJ71 (ORCPT\n\t); Mon, 4 Sep 2017 05:59:27 -0400","by mail-lf0-f43.google.com with SMTP id s11so150116lfe.0\n\tfor ; Mon, 04 Sep 2017 02:59:26 -0700 (PDT)","from [192.168.4.126] ([31.173.82.180])\n\tby smtp.gmail.com with ESMTPSA id\n\tu83sm1180901lff.47.2017.09.04.02.59.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 02:59:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cogentembedded-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=tQgQ9GCAe73InhSVJKmfyV/1NaLOyqFF2ZBth6wpYPk=;\n\tb=kbTCPwN5wlk4ANg9iCh97cM+yGuHWrnbaw77DwbRdKSz3S4qAIa0GKkPiGDm+XQBXm\n\tU7P5vByL/V8yS2Z6rcBlPr7djqmlR6PhDyKQoc9oz+WciEvRnZyijU85e56BTd4M0O54\n\t66X+OwMf+A6treEupkY5TwxAMPZEyG4VQ6pOG5iCPZ+zj3EcOlmdUymkgi8ikp94DNY3\n\t9s7j/Cpd/TOAyFHNNChk90mNP5D7+9sSJZfUrVrf82o9UydhN9p3awGSQrDBrO/itwyr\n\taOgTCv4hCE75SaNcEUj0xDmnL3hxFUDtCXcbo6O63uZRw3zhGMXJ7AeJwxkPu0z8Reae\n\ttz1A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=tQgQ9GCAe73InhSVJKmfyV/1NaLOyqFF2ZBth6wpYPk=;\n\tb=SxHookdnqRc2nJJDzlJtuXGxju4waHbwPxNpyjhptGFHNh/xpYKoVB0Cmt+Y0DUBvp\n\t0LRJU3QZNAkT2j5abzw7ghfCPeM0596UVEWcd15DjKH2NwDwqQTLW89YsIVQM7KftPGx\n\tdMvdNf3RfNyM1vH05NXBjJRPZt0z/Meuh9F+38RaXdgZYGzrqMDbZX+jHZJWmAo+Hi8S\n\tebA+bHzeRKnDMy03w/hvijKr1hqRk7Qe0EDk33lkMy8OXrr3FwDuOk3xGYgfiDvYgoRF\n\tEEkzFBuOC5/fG9f0ovegZt/onqPNMydZNA3Ghjzm54pvmpXphcLFTjHBSTuTCA4kD5Cw\n\tMSDg==","X-Gm-Message-State":"AHPjjUgwZGWCAHhi0BS74cQk0GZrvNz6WsgkpAyFU9RWzg+hMzmXn522\n\tPwQyMQYB/5dALi76","X-Google-Smtp-Source":"ADKCNb6vAJH6kRMeVC5hBSno3NWulknLyU7MgoVH7Mbt1PBJWN76Z9oygYVaGvktI7oMu4YhQQlQZg==","X-Received":"by 10.25.162.65 with SMTP id l62mr3400185lfe.141.1504519165985; \n\tMon, 04 Sep 2017 02:59:25 -0700 (PDT)","Subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","To":"Baruch Siach , Rob Herring ,\n\tMark Rutland , Andrew Lunn ,\n\tFlorian Fainelli ,\n\t\"David S. Miller\" ,\n\tRussell King ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org","References":"\n\t<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","From":"Sergei Shtylyov ","Message-ID":"","Date":"Mon, 4 Sep 2017 12:59:29 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762859,"web_url":"http://patchwork.ozlabs.org/comment/1762859/","msgid":"<5df7f2f5-04f7-85b1-4a53-935360001b7c@gmail.com>","list_archive_url":null,"date":"2017-09-04T20:16:26","subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"Le 09/03/17 à 05:31, Baruch Siach a écrit :\n> Add device-tree binding documentation SFP transceivers. Support for SFP\n> transceivers has been recently introduced (drivers/net/phy/sfp.c).\n> \n> Signed-off-by: Baruch Siach \n> ---\n> v3:\n> Mention gpios phandle and specifier\n> Mention the polarity of each gpio\n> Fix example property names\n> \n> v2:\n> Rename -gpio properties to -gpios\n> Rename the rate-select-gpio property to rate-select0-gpios\n> Add the rate-select1-gpios property\n> Add examples\n> ---\n> Documentation/devicetree/bindings/net/sff,sfp.txt | 78 +++++++++++++++++++++++\n> 1 file changed, 78 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/net/sff,sfp.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> new file mode 100644\n> index 000000000000..b98ee5945265\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> @@ -0,0 +1,78 @@\n> +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)\n> +Transceiver\n> +\n> +Required properties:\n> +\n> +- compatible : must be \"sff,sfp\"\n> +\n> +Optional Properties:\n> +\n> +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial\n> + interface\n> +\n> +- moddef0-gpios : GPIO phandle and a single specifier of the MOD-DEF0 (AKA\n> + Mod_ABS) module presence input gpio signal, active (module absent) high\n\nSorry for nitpicking on this, why are not we naming this mod-def0-gpios\nwhich would be consistent with how other GPIOs are named?\n\n> +\n> +- los-gpios : GPIO phandle and a single specifier of the Receiver Loss of\n> + Signal Indication input gpio signal, active (signal lost) high\n> +\n> +- tx-fault-gpios : GPIO phandle and a single specifier of the Module\n> + Transmitter Fault input gpio signal, active (fault condition) high\n> +\n> +- tx-disable-gpios : GPIO phandle and a single specifier of the Transmitter\n> + Disable output gpio signal, active (Tx disable) high\n> +\n> +- rate-select0-gpios : GPIO phandle and a single specifier of the Rx Signaling\n> + Rate Select (AKA RS0) output gpio signal, low: low Rx rate, high: high Rx\n> + rate\n> +\n> +- rate-select1-gpios : GPIO phandle and a single specifier of the Tx Signaling\n> + Rate Select (AKA RS1) output gpio signal (SFP+ only), low: low Tx rate,\n> + high: high Tx rate\n> +\n> +Example #1: Direct serdes to SFP connection\n> +\n> +sfp_eth3: sfp-eth3 {\n> +\tcompatible = \"sff,sfp\";\n> +\ti2c-bus = <&sfp_1g_i2c>;\n> +\tlos-gpios = <&cpm_gpio2 22 GPIO_ACTIVE_HIGH>;\n> +\tmoddef0-gpios = <&cpm_gpio2 21 GPIO_ACTIVE_LOW>;\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&cpm_sfp_1g_pins &cps_sfp_1g_pins>;\n> +\ttx-disable-gpios = <&cps_gpio1 24 GPIO_ACTIVE_HIGH>;\n> +\ttx-fault-gpios = <&cpm_gpio2 19 GPIO_ACTIVE_HIGH>;\n> +};\n> +\n> +&cps_emac3 {\n> +\tphy-mode = \"sgmii\";\n> +\tphy-names = \"comphy\";\n> +\tphys = <&cps_comphy 5 COMPHY_SGMII2>;\n> +\tsfp = <&sfp_eth3>;\n> +};\n> +\n> +Example #2: Serdes to PHY to SFP connection\n> +\n> +sfp_eth0: sfp-eth0 {\n> +\tcompatible = \"sff,sfp+\";\n> +\ti2c-bus = <&sfpp0_i2c>;\n> +\tlos-gpios = <&cps_gpio1 28 GPIO_ACTIVE_HIGH>;\n> +\tmoddef0-gpios = <&cps_gpio1 27 GPIO_ACTIVE_LOW>;\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&cps_sfpp0_pins>;\n> +\ttx-disable-gpios = <&cps_gpio1 29 GPIO_ACTIVE_HIGH>;\n> +\ttx-fault-gpios = <&cps_gpio1 26 GPIO_ACTIVE_HIGH>;\n> +};\n> +\n> +p0_phy: ethernet-phy@0 {\n> +\tcompatible = \"ethernet-phy-ieee802.3-c45\";\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&cpm_phy0_pins &cps_phy0_pins>;\n> +\treg = <0>;\n> +\tinterrupt = <&cpm_gpio2 18 IRQ_TYPE_EDGE_FALLING>;\n> +\tsfp = <&sfp_eth0>;\n> +};\n> +\n> +&cpm_eth0 {\n> +\tphy = <&p0_phy>;\n> +\tphy-mode = \"10gbase-kr\";\n> +};\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FphJenJQ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmLhz5HmZz9t2V\n\tfor ;\n\tTue, 5 Sep 2017 06:16:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754024AbdIDUQd (ORCPT );\n\tMon, 4 Sep 2017 16:16:33 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:36140 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753968AbdIDUQb (ORCPT\n\t); Mon, 4 Sep 2017 16:16:31 -0400","by mail-oi0-f68.google.com with SMTP id g15so1086799oib.3;\n\tMon, 04 Sep 2017 13:16:30 -0700 (PDT)","from ?IPv6:2001:470:d:73f:94d3:4b37:3fbf:f2bd?\n\t([2001:470:d:73f:94d3:4b37:3fbf:f2bd])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg65sm11505788oic.50.2017.09.04.13.16.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 13:16:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Ii1qlq53QpWp9BGI+PDZDqZeF+ADX94/I2W0mhlJfTQ=;\n\tb=FphJenJQuyBbmPcdUkGk9zNdFbsQ+yC93GvCtVyUA2tAPI6ILSydJGz9d9SjiMbeO1\n\t4JwT9RYZ4bDLR5uzSuIyfJyVo9b4n3dTz13jskpx/ZiaMoYgH2njah3LPytIRy5w5zlf\n\tV0R5zPOZgikrGl+py3yK/4zVQWltygFT66Zk2cDngGhs3o/pC8mfVgAeGbfbXIxWEpk7\n\tx0JvfMp9/WrC4QBkDD1tErZs1DHk1/vfV5Rzo1HotGMjS+mbpivNPb1TRnf8bn3ysGJ9\n\tnFJoI6xzi7sZq4N8fjsu8ulHaHnZerA2asXNqwY3XuT4XpaKtqrBvbihAVdZ6O1676Ri\n\tmCxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Ii1qlq53QpWp9BGI+PDZDqZeF+ADX94/I2W0mhlJfTQ=;\n\tb=jAZU8wU/Is3/xYNDwuSUEhLbKGFc5NWQhXd2S6W5E8AyUhQNfU8O5+AH4hHGxSxo3a\n\tsFn+TORkywL3/UTxxDIgJ+LVAkstDeVmQcrwL6dMnPVckFWuuIr0bPYfOO9VBCK/W6sp\n\tO5eEBUJegxldTHeF+mOCIF8URInaQNy4Yx3rrjqKbFKKS/9exnrnmJGi2Jb77UDFUwsc\n\tR239SPzGDgKAPFJpBHaOfG1Sk8NqoU0Z07xhItQai4NnYLEIpJsvHN/oHdRy34u/4xp6\n\t8mqOHvGfACsHMBvtW6L0gE8z6cRUrgV01k20DKB4CouMvDUW34r1W6C/5n6nKWJeRyff\n\tBL+A==","X-Gm-Message-State":"AHPjjUjw9o5csdsYQeO6geiqhS/qAXzL6ZZilLkSPJv+SdSWhquwt33Z\n\tGqQESCnuesODrg==","X-Google-Smtp-Source":"ADKCNb4SEavXyMwl8LJYozsR360OtIDkS8LXuJZ53Dd69L7oJUvtqPuZ5mKmapsBMhcPdWphWSB6tg==","X-Received":"by 10.202.80.8 with SMTP id e8mr1448694oib.96.1504556190418;\n\tMon, 04 Sep 2017 13:16:30 -0700 (PDT)","Subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","To":"Baruch Siach , Rob Herring ,\n\tMark Rutland , Andrew Lunn ,\n\t\"David S. Miller\" ,\n\tRussell King ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tSergei Shtylyov ","References":"\n\t<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","From":"Florian Fainelli ","Message-ID":"<5df7f2f5-04f7-85b1-4a53-935360001b7c@gmail.com>","Date":"Mon, 4 Sep 2017 13:16:26 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762878,"web_url":"http://patchwork.ozlabs.org/comment/1762878/","msgid":"<20170904211121.hl2gnwxiizli5brd@tarshish>","list_archive_url":null,"date":"2017-09-04T21:11:21","subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","submitter":{"id":1458,"url":"http://patchwork.ozlabs.org/api/people/1458/","name":"Baruch Siach","email":"baruch@tkos.co.il"},"content":"Hi Florian,\n\nOn Mon, Sep 04, 2017 at 01:16:26PM -0700, Florian Fainelli wrote:\n> Le 09/03/17 à 05:31, Baruch Siach a écrit : \n\n[...]\n\n> > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> > new file mode 100644\n> > index 000000000000..b98ee5945265\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt\n> > @@ -0,0 +1,78 @@\n> > +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)\n> > +Transceiver\n> > +\n> > +Required properties:\n> > +\n> > +- compatible : must be \"sff,sfp\"\n> > +\n> > +Optional Properties:\n> > +\n> > +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial\n> > + interface\n> > +\n> > +- moddef0-gpios : GPIO phandle and a single specifier of the MOD-DEF0 (AKA\n> > + Mod_ABS) module presence input gpio signal, active (module absent) high\n> \n> Sorry for nitpicking on this, why are not we naming this mod-def0-gpios\n> which would be consistent with how other GPIOs are named?\n\nI'm fine with that as well. It only requires changing the implementation to \nmatch.\n\n> > +\n> > +- los-gpios : GPIO phandle and a single specifier of the Receiver Loss of\n> > + Signal Indication input gpio signal, active (signal lost) high\n> > +\n> > +- tx-fault-gpios : GPIO phandle and a single specifier of the Module\n> > + Transmitter Fault input gpio signal, active (fault condition) high\n> > +\n> > +- tx-disable-gpios : GPIO phandle and a single specifier of the Transmitter\n> > + Disable output gpio signal, active (Tx disable) high\n> > +\n> > +- rate-select0-gpios : GPIO phandle and a single specifier of the Rx Signaling\n> > + Rate Select (AKA RS0) output gpio signal, low: low Rx rate, high: high Rx\n> > + rate\n> > +\n> > +- rate-select1-gpios : GPIO phandle and a single specifier of the Tx Signaling\n> > + Rate Select (AKA RS1) output gpio signal (SFP+ only), low: low Tx rate,\n> > + high: high Tx rate\n\nbaruch","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmMwM28Vdz9t1t\n\tfor ;\n\tTue, 5 Sep 2017 07:11:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753993AbdIDVL1 (ORCPT );\n\tMon, 4 Sep 2017 17:11:27 -0400","from guitar.tcltek.co.il ([192.115.133.116]:47443 \"EHLO\n\tmx.tkos.co.il\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751329AbdIDVL0 (ORCPT );\n\tMon, 4 Sep 2017 17:11:26 -0400","from tarshish (unknown [10.0.8.6])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx.tkos.co.il (Postfix) with ESMTPS id A3A5044083B;\n\tTue, 5 Sep 2017 00:11:22 +0300 (IDT)"],"Date":"Tue, 5 Sep 2017 00:11:21 +0300","From":"Baruch Siach ","To":"Florian Fainelli ","Cc":"Rob Herring , Mark Rutland ,\n\tAndrew Lunn , \"David S. Miller\" ,\n\tRussell King ,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tSergei Shtylyov ","Subject":"Re: [PATCH v3 2/3] dt-binding: net: sfp binding documentation","Message-ID":"<20170904211121.hl2gnwxiizli5brd@tarshish>","References":"\n\t<01ae7bc45d68322669d18a4feeaeef733ba888d7.1504441874.git.baruch@tkos.co.il>\n\t<5df7f2f5-04f7-85b1-4a53-935360001b7c@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<5df7f2f5-04f7-85b1-4a53-935360001b7c@gmail.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]