[{"id":1762261,"web_url":"http://patchwork.ozlabs.org/comment/1762261/","msgid":"","list_archive_url":null,"date":"2017-09-03T13:14:38","subject":"Re: [PATCH 7/10] net/mlx4_core: Use ARRAY_SIZE macro","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 03/09/2017 3:19 PM, Thomas Meyer wrote:\n> Use ARRAY_SIZE macro, rather than explicitly coding some variant of it\n> yourself.\n> Found with: find -type f -name \"*.c\" -o -name \"*.h\" | xargs perl -p -i -e\n> 's/\\bsizeof\\s*\\(\\s*(\\w+)\\s*\\)\\s*\\ /\\s*sizeof\\s*\\(\\s*\\1\\s*\\[\\s*0\\s*\\]\\s*\\)\n> /ARRAY_SIZE(\\1)/g' and manual check/verification.\n> \n> Signed-off-by: Thomas Meyer \n> ---\n\n\nReviewed-by: Tariq Toukan \n\nThanks Thomas!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"PWqTSNy5\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlYNr1jlqz9s8J\n\tfor ;\n\tSun, 3 Sep 2017 23:14:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752884AbdICNOt (ORCPT );\n\tSun, 3 Sep 2017 09:14:49 -0400","from mail-db5eur01on0061.outbound.protection.outlook.com\n\t([104.47.2.61]:42832\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751617AbdICNOr (ORCPT );\n\tSun, 3 Sep 2017 09:14:47 -0400","from [10.8.2.253] (193.47.165.251) by\n\tVI1PR05MB1806.eurprd05.prod.outlook.com (2a01:111:e400:7a60::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tSun, 3 Sep 2017 13:14:42 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=DtmV3GWzGZaPatyhIZoX2wtBWWxMvbABmzahtYBpGzQ=;\n\tb=PWqTSNy5xZB+dVgB1nzvzHnmLhbrGSJttLTzBJfaiCLdhlndjcbq6yX3rsCgho1e49Hkr9hbHewwtbOBsX9IY4i3EulIP16NqxIYQ3ldCg8Y7fKCvrkkPbTKFr6Cx9W08oHT8L6Wk9OXIbd5gEVgGJk3qT1eNAtjjyz5Nb6OLQ4=","Subject":"Re: [PATCH 7/10] net/mlx4_core: Use ARRAY_SIZE macro","To":"Thomas Meyer , netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<1504439110050-939061377-0-diffsplit-thomas@m3y3r.de>\n\t<1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de>","From":"Tariq Toukan ","Message-ID":"","Date":"Sun, 3 Sep 2017 16:14:38 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"AM5PR0602CA0002.eurprd06.prod.outlook.com\n\t(2603:10a6:203:a3::12) To VI1PR05MB1806.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a60::16)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"bcbb3297-bf8e-4569-bb8f-08d4f2cdbe22","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR05MB1806; ","X-Microsoft-Exchange-Diagnostics":["1; VI1PR05MB1806;\n\t3:zA0fobCNRUU5KuSw+PPZxlVYqEqAp11HcD8Zghqf2YSkFGPYLFzq2MghDSaIczoXkFC+Y3PTJ/QX17GAfhntWfLCA2yYBaChyJ1hZ3pZ7MLScaTfyNfi2YDGFBFizgUzkLyEqnSpPtdBFxfeKZqrcGRiM7n9utjxwKYN0ztzHx8Gra5csWLLlMhYjDw2eBOZn30Qovglgo+gPJAH9ZvmMJxq7WpddOtFKuAl1l1zV3JfC+yeLmRcEX4uL3vRSGFq;\n\t25:uODYd9u+1q0LG6rBvLKs6EFTnsjWtjk78FlHm8POSROJgn24Vq5WVdivB79FytCpGwwXed1l86wCXxB8adThWx0VW2OwOC+ix0ng8+SPEqQ8XVCdfnRdwZDn/QiYsTGuNJ2rm3CLghZM18MyNkHhDsrr54TMUMVVNddtxCBguBXgrg9VHlP6mOlbbkDHzj+FjXfhbKZT6JGwJpUxni5KENnIhGWcaOxbP1iJE+ldXtysFlsiVD58RJBtx+qeL0T3T/MeRsGgTf89dKdkYxR1HhyZviMaCro5RryDC1ieUhry5L83BUFqy7wjyCpW6+2BkjCU+BieG/ywJzGIGpQhlA==;\n\t31:PSak90vkPYcOhJQuIBelsxawxP32GlvQwvjjsrVosbrJsOBUVesALI9QgJ7r1qQRxCqM5Yjc0ga4UXWxCD9lr/p0m6IkUMqMtLu9zj69d2B8Qq8J1gtV6nW0olnpxvZiRPKy0/6q/2tuZuAISiIhX2C8qdZhgTNU9y+Df6Pvxm1nsaeu5JDaB9pPuRbIBfyBQMPXMCJjvSkLaRpXL8VGIzT7b2Y2cYsAROTs5dHrkE4=","1; VI1PR05MB1806;\n\t20:EndunoPPJSD/GbjHDWCXixibeGzPEnIGF0wxM/ly2byFLDqESFKPZBn7X+Ywu0kyiTbzg6aNX9hPtTrw1DKQf8gA0ADt+v2Ot4AdteZPyv3YOyBsE24rPtgDJO84ApPmLKbqQemUdWZwvpHEmQqY484cQd8q4OLdGYw9Ermq7yzFXo7+7baHdX9N3/0rxbyXN6kLmbcLfsI0WP7Hl3pIA7FDR16Xm8TNIPJ8PBK4rPfxthtRvCI797Rd+VFNWsaCMQZOxXFhOnSkA/k2UfhNs6u45YVxOQ/LyvFvl7nQz2okdvB2C/1OQr8HeY6ptwjT4mnLK8yhsas/VJOHgawxvxDLBz0MXh2s7flxPUt4wc7ujG7hyWlocl+rKAmYGio8I3I/Qv43qplDq7aUXKS95+c6wnwjnWHnPHwdr/x475xn1rkAunlGSyo6mnNJzu+zLjpWXlpmBsPqrOyx1wOflNBxDLAlcTqCV1ceVmUYNnUWQ+flAFfnGTPB8up+8Hlt;\n\t4:szjoSfeTh8JuBiDB13CsSD2v7Nmnz/Iz8IEF0Ez2KRIO9M40LnBvmhkJEpJoK/sdS2QtHPwEHMyrLJLCH6qY/yzwhwtulDqJzNsNwKiokOsgvMd792W6xKUs6xeHb4dBucj+6PqmQgeboiV0FrUd7FZhq1dUA5CNnLk1o1DvYT8GzSx5476JeGj9yz5LZhIIGW+VKHhQr1gXW9FrC06cV/Dcs9rZKoaUEZBwfdpGQAtnX84m2JAOtE3ToH1R4izB","=?utf-8?q?1=3BVI1PR05MB1806=3B23=3AE/3u?=\n\t=?utf-8?q?k6GnSupUZA3rcUqWNKPUQQ4Qz+H8lxgmZ9iMRwxGT60ymxC/a6Wrr9pX?=\n\t=?utf-8?q?JLTKqNiaGwiwcW/cabcCz97btBRouQBBd2ZNqBmkn7gQzWtJUWoJlaMt?=\n\t=?utf-8?q?9sODaqYLcagW8zYt0sdFSxPr+kPKCGWqHsUBuZCpSD6A8nANxmWIIAem?=\n\t=?utf-8?q?q+Qk3sfZcv670I7j19lQ0p76La52/WIJ2DvG2ezHg41BX5IWib9K+Y8S?=\n\t=?utf-8?q?Bbf34CP8FHzzjxEEd1213YEKQ6028LAfP06jz11HotlB/7mTiZljT8IB?=\n\t=?utf-8?q?R5rob9mFcOUjzxOmrAbrt/9DzMvjQkNRDb2G4+KBfkxD+cei5pyzzrmx?=\n\t=?utf-8?q?vXyRpZXdabx1Kmk6XchOseBKWOCP//TeLID30MyeajVMVahR5rjCGDju?=\n\t=?utf-8?q?jcljauaHmi7mD0lgYCYt/8LvB2KWx6yjE90N7MMR1DXpGFtGjXZDoHXa?=\n\t=?utf-8?q?4e4gAQil0CtxoMOb3YCvBp9r/LznNLiUe3M49YE6D+VANZtcJtVjjTET?=\n\t=?utf-8?q?IQIZhkQiaM7gySgiHYP96WB5MJbUB15P4O/kKJ/EnrnCmb9kh2qpAnq4?=\n\t=?utf-8?q?1cpKN1Fxzoq5j92iYQcedagFY4q92FRq+XWWrXO4UOPN4XF1GwbnkKN1?=\n\t=?utf-8?q?DE67RHXV9S+r3liCUW6V884gFvYz7I6okyhplJ5sK9ZZvlGEQlyynNM5?=\n\t=?utf-8?q?QsS4EsYMYiXPIfoH8EUggUb8FbqYaOUvy2B/5KXWlvCm1fYGzdYk/M9P?=\n\t=?utf-8?q?xm8wiAWGHZ9GL74oGpDmIlduZ8XneRQWiYF/2lGglUlglU4tADbiiBGq?=\n\t=?utf-8?q?koCxn7p+V89qIES5nNRi8O1dZrewsGS/vszhVH0kz0ctRQemIJvpp/Qz?=\n\t=?utf-8?q?ewjeZ7Oy/CBsTCUPqkdyjxLDul832dFOaqsZdr0LB84IYZrGBEGeIiXT?=\n\t=?utf-8?q?f7uPOpBVbj9xPuyEesFg/kzEXUS1SVppTGNyRRYFW2c3Ez2s+SAnSHmY?=\n\t=?utf-8?q?ptLqpkkstifWipi7QquiyZ3OO1d6bIIE4D9P+MFGdRT+i1nL23/aJUxE?=\n\t=?utf-8?q?pN5HfNHrfNZ0VPEdexiW4DolpiXgucTOzPRMHh8EhjqzQ/lnYdEfeYgs?=\n\t=?utf-8?q?Rnl9z3W+QIcOjcDHwXnfWJfxQuYrs+r2PMiuYzFIcSaqw0aaE2xWZvzn?=\n\t=?utf-8?q?37fcCJu9wR+H9V96d0SizyJJ7zCupD1jNxu23LxuuqKtISIu2NMjqupd?=\n\t=?utf-8?q?C70axs1Zecf4sHt3dS5EcWSOB6krIwP7302LM1O2M51LCpe0yucT2rQC?=\n\t=?utf-8?q?fl/nEuKhEKU4jeaKbWE8p9pe/LXbw+vixPI4rZS6FHiwjIImTQJvmCQd?=\n\t=?utf-8?q?vIWCXyy2s0r/Z9RAN0UkkpQz6L5maNS+bd/5Qm6BpFagdqb/16zZFAOQ?=\n\t=?utf-8?q?DSDjhsFG/W2imtuhAw=3D=3D?=","1; VI1PR05MB1806;\n\t6:xfrwPHGn0tL55f+ZgD6awM41G4oGMW89Mbl2gddieVojNu6LzkVJUJT9CG0qy56nTl53QwFBqwmR1737R9nYou00ARyTLLWh5VnD1iSEqQT3XqyWj8s64KT5hDhVK5OdQGD/mHNeyBprFxJPT2KE3RzuQeK9Elfp9CnrVv+6v9mk9HEkO7vJo98ieUh7WkeBiRR2fciYorHsgNijD0Z7rwGWPMs4QZ+ekaNAaTCuu9uQ7soqrGR/LlBuquNYI/YbjQ2/UeNMKRfvduOT1Zhgsl5xHf45nt0Iuc/ZHvNpAFJRanXSmiudU7xwMHsX0yKjYdv0H2VaZYlHESugAuOKJw==;\n\t5:f0DWggWAlPAAJ6EAAzo4OQvqEr0Mjc8knAiGblTefEU8t7eTIxSYzWbb4VYzNvGPsK3BTyC4CAxBTt/h4AWI8rpGRdkn7I4dIo93SPtiUlQOhfkgp3CKqXrhLZL5UWT9ETyB9pT4o+EffoN1Ky92CQ==;\n\t24:GrQbkNFG6+Yp+85KlQUIecHegOLw4VEEoEW8dttlmtgkBSYje11WHNiQdbnxBZorCK+sHhDT/fUAdqxq09i1zVQtCQa2N1wUbXnJhJPx8LU=;\n\t7:bDNfdmwWkAE8gJwxAKdEptcnlgQfaK2/yEJ8A/hCgy6zgLrjEP0j7kBvNXyYO/F085kZN6Z+sE1WSIDCL6Lzvv1kJ6uUrftbmm0o6qwmvmuQGO4mtAvhdWD1tZADLfD0j69PZAe1uj9onF2uPD4HKbU73THQ19X7yLPC+x/kCJw6lZmtDjcNNAEQHiUKazMiYWiKm9QIVk5t7jydo4VWIMR5j6l5FC6sIfzi6XpYsd4="],"X-MS-TrafficTypeDiagnostic":"VI1PR05MB1806:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR05MB1806; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR05MB1806; ","X-Forefront-PRVS":"041963B986","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(189002)(377454003)(24454002)(199003)(6486002)(77096006)(81156014)(5660300001)(189998001)(65826007)(101416001)(106356001)(105586002)(33646002)(229853002)(97736004)(68736007)(83506001)(4001350100001)(31696002)(81166006)(8676002)(54356999)(76176999)(50986999)(31686004)(2906002)(305945005)(86362001)(7736002)(2950100002)(47776003)(478600001)(230700001)(6666003)(50466002)(7350300001)(3846002)(64126003)(6116002)(53546010)(110136004)(6246003)(65956001)(66066001)(65806001)(36756003)(42186005)(23676002)(53936002)(25786009);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1806; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Sep 2017 13:14:42.9965\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR05MB1806","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1763573,"web_url":"http://patchwork.ozlabs.org/comment/1763573/","msgid":"<20170905.115051.353243810279371029.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T18:50:51","subject":"Re: [PATCH 7/10] net/mlx4_core: Use ARRAY_SIZE macro","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Thomas Meyer \nDate: Sun, 03 Sep 2017 14:19:31 +0200\n\n> Use ARRAY_SIZE macro, rather than explicitly coding some variant of it\n> yourself.\n> Found with: find -type f -name \"*.c\" -o -name \"*.h\" | xargs perl -p -i -e\n> 's/\\bsizeof\\s*\\(\\s*(\\w+)\\s*\\)\\s*\\ /\\s*sizeof\\s*\\(\\s*\\1\\s*\\[\\s*0\\s*\\]\\s*\\)\n> /ARRAY_SIZE(\\1)/g' and manual check/verification.\n> \n> Signed-off-by: Thomas Meyer \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmwlw5tLGz9sR9\n\tfor ;\n\tWed, 6 Sep 2017 04:51:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753172AbdIESu4 (ORCPT );\n\tTue, 5 Sep 2017 14:50:56 -0400","from shards.monkeyblade.net ([184.105.139.130]:36894 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752113AbdIESuw (ORCPT\n\t); Tue, 5 Sep 2017 14:50:52 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 2068613DA3B74;\n\tTue, 5 Sep 2017 11:50:52 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 11:50:51 -0700 (PDT)","Message-Id":"<20170905.115051.353243810279371029.davem@davemloft.net>","To":"thomas@m3y3r.de","Cc":"netdev@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 7/10] net/mlx4_core: Use ARRAY_SIZE macro","From":"David Miller ","In-Reply-To":"<1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de>","References":"<1504439110050-939061377-0-diffsplit-thomas@m3y3r.de>\n\t<1504439110050-1961876957-7-diffsplit-thomas@m3y3r.de>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 11:50:52 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]