[{"id":1782056,"web_url":"http://patchwork.ozlabs.org/comment/1782056/","msgid":"","list_archive_url":null,"date":"2017-10-07T09:59:57","subject":"Re: [Buildroot] [PATCH 1/8] arch: introduce minimal required gcc\n\tversion","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Yann, All,\n\nLe 03/09/2017 à 11:44, Yann E. MORIN a écrit :\n> Some CPU variants require that a recent-enough gcc be selected. For\n> example, ARM's cortex-a35 requires gcc-5, while cortex-a73 requires\n> gcc-7. Same goes for other architectures, of course.\n> \n> Currently, we hard-code every such conditions in the gcc version choice,\n> as well as in the individual external toolchains.\n> \n> However, as we add even more CPU variants, the conditions are getting\n> more and more complex to write and maintain.\n> \n> Introduce new symbols, that architectures can select if they have a\n> specific requirement on the gcc version. gcc and external toolchains\n> can then properly depend on those symbols.\n> \n> The burden of maintaining the requirements on the gcc version now falls\n> down to the architeture, instead of being split up in gcc and all the\n> external toolchains.\n> \n> As the oldest gcc version to handle, we can either choose gcc-4.9, as\n> the odlest version we support in our internal toolchain, or choose\n> gcc-4.8, as the oldest external toolchain we support (except for the\n> custom ones, but they'll be handled specifically in upcoming changes).\n> We choose to go back up to gcc-4.8.\n> \n> Signed-off-by: \"Yann E. MORIN\" \n> Cc: Thomas Petazzoni \n> ---\n> arch/Config.in | 21 +++++++++++++++++++++\n> 1 file changed, 21 insertions(+)\n> \n> diff --git a/arch/Config.in b/arch/Config.in\n> index c10bf16809..607da36c1d 100644\n> --- a/arch/Config.in\n> +++ b/arch/Config.in\n> @@ -261,6 +261,27 @@ config BR2_ARCH_HAS_TOOLCHAIN_BUILDROOT\n> \tbool\n> \tdefault y if !BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT\n> \n> +# The following symbols are selected by the individual\n> +# Config.in.$ARCH files\n\nI believe something is missing from this patch.\n\nBest regards,\nRomain\n\n> +config BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n> +\tbool\n> +\n> +config BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n> +\tbool\n> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n> +\n> +config BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n> +\tbool\n> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n> +\n> +config BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n> +\tbool\n> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n> +\n> +config BR2_ARCH_NEEDS_GCC_AT_LEAST_7\n> +\tbool\n> +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n> +\n> # The following string values are defined by the individual\n> # Config.in.$ARCH files\n> config BR2_ARCH\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"K6drTuDg\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8MSX1Gfvz9t73\n\tfor ;\n\tSat, 7 Oct 2017 21:00:11 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EF0ED8947B;\n\tSat, 7 Oct 2017 10:00:06 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qrT98gf+i69x; Sat, 7 Oct 2017 10:00:03 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BAE8989427;\n\tSat, 7 Oct 2017 10:00:02 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9B1481BFB1F\n\tfor ;\n\tSat, 7 Oct 2017 10:00:01 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 86BC626695\n\tfor ;\n\tSat, 7 Oct 2017 09:59:47 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AD--cDMifyCP for ;\n\tSat, 7 Oct 2017 09:59:46 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9A3A225F60\n\tfor ; Sat, 7 Oct 2017 09:59:46 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id 131so7326350wmk.3\n\tfor ; Sat, 07 Oct 2017 03:00:00 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\ty40sm3436804ede.0.2017.10.07.02.59.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 07 Oct 2017 02:59:58 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ixpmsibGyKlO5NMfjV2h2w2BazAETXNiZPFf8Em5uqY=;\n\tb=K6drTuDgAukRnh5DztsBN7n0pCe9/68lSVxktLtIych1UNB9kYbnrku26qGbT7tU+0\n\tX4XrAMW8HSdneO4x/DXpX+I/IYbWgBNSICX6ibSeIxb6Akfq3LqOaaNWBNIIjzo0tIh+\n\tBQtFOiuQOpcDtRcSV2opntj7liuPC7RwRFyEVnzDdVPPlhwPqVxPBXjp89BKJSCqKRcK\n\tlnQ1JH3i8OtPcaTlEcK6qFK/NiBMDlFIQqg16NBmgBI7JAB7xktkKJ+r88AskTG0A6eV\n\tNOIXmDb8OFwOBXN3/UAwpIYBliFK9YhvdEz6xi9P2Ue8nwfw1ri5xgrpz/xmnfxG8PAh\n\tff3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ixpmsibGyKlO5NMfjV2h2w2BazAETXNiZPFf8Em5uqY=;\n\tb=IPloViZsV/qqpVc/XuxjT7ZXr0LYcca+K91XOuO+wLiODrVtbdGL5Z0Z1ABJLfr91V\n\trW3gZrV9qww5pSUq8nrhPHUK+mN8kYiGdRYW2kzCl1dD9YCGO08f+w4m2LUebkzSum3v\n\t9X1gYDV4cDh5u7bjiZNwxoSF6bkX/Kwwlj26IBgufBKZWcP61rNGnBNAOQwZniI9CZz3\n\t8V3qd8mWGIRgRHLC7BO2X1qwyDuYBReoOrDaf6XgN4FIZbR2BSOqcIumfedEGnlKkjKK\n\tLcwDzZQPD3/mCbEhu7SPzucQuSF0bU2C/LXAZeJ7w/VDyuj6Xg7h8QG4d9+JJYL5xKfd\n\tMpeg==","X-Gm-Message-State":"AMCzsaVYV6t550mNgez7qCx0WFHNUqHSc1GFH8K/38SG0LPLiQJ9x7lW\n\t4hZHRBpN6CUVQn+eSV359Ks=","X-Google-Smtp-Source":"AOwi7QCPXqblCOYFrg3JISa9ui/ifzX5oUCStIFacftcTLEpmeMC4A9MYEJS7ccBupWbCI8pF0U7MA==","X-Received":"by 10.80.180.214 with SMTP id x22mr6441953edd.230.1507370399048; \n\tSat, 07 Oct 2017 02:59:59 -0700 (PDT)","To":"\"Yann E. MORIN\" , buildroot@buildroot.org","References":"\n\t<8de5375c8ca0110ebd5baaec946fed002cc7eb80.1504431850.git.yann.morin.1998@free.fr>","From":"Romain Naour ","Message-ID":"","Date":"Sat, 7 Oct 2017 11:59:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<8de5375c8ca0110ebd5baaec946fed002cc7eb80.1504431850.git.yann.morin.1998@free.fr>","Content-Language":"en-US","Cc":"Thomas Petazzoni ","Subject":"Re: [Buildroot] [PATCH 1/8] arch: introduce minimal required gcc\n\tversion","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1782066,"web_url":"http://patchwork.ozlabs.org/comment/1782066/","msgid":"<20171007102616.GF21901@scaer>","list_archive_url":null,"date":"2017-10-07T10:26:16","subject":"Re: [Buildroot] [PATCH 1/8] arch: introduce minimal required gcc\n\tversion","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Romain, All,\n\nOn 2017-10-07 11:59 +0200, Romain Naour spake thusly:\n> Le 03/09/2017 à 11:44, Yann E. MORIN a écrit :\n> > Some CPU variants require that a recent-enough gcc be selected. For\n> > example, ARM's cortex-a35 requires gcc-5, while cortex-a73 requires\n> > gcc-7. Same goes for other architectures, of course.\n> > \n> > Currently, we hard-code every such conditions in the gcc version choice,\n> > as well as in the individual external toolchains.\n> > \n> > However, as we add even more CPU variants, the conditions are getting\n> > more and more complex to write and maintain.\n> > \n> > Introduce new symbols, that architectures can select if they have a\n> > specific requirement on the gcc version. gcc and external toolchains\n> > can then properly depend on those symbols.\n> > \n> > The burden of maintaining the requirements on the gcc version now falls\n> > down to the architeture, instead of being split up in gcc and all the\n> > external toolchains.\n> > \n> > As the oldest gcc version to handle, we can either choose gcc-4.9, as\n> > the odlest version we support in our internal toolchain, or choose\n> > gcc-4.8, as the oldest external toolchain we support (except for the\n> > custom ones, but they'll be handled specifically in upcoming changes).\n> > We choose to go back up to gcc-4.8.\n> > \n> > Signed-off-by: \"Yann E. MORIN\" \n> > Cc: Thomas Petazzoni \n> > ---\n> > arch/Config.in | 21 +++++++++++++++++++++\n> > 1 file changed, 21 insertions(+)\n> > \n> > diff --git a/arch/Config.in b/arch/Config.in\n> > index c10bf16809..607da36c1d 100644\n> > --- a/arch/Config.in\n> > +++ b/arch/Config.in\n> > @@ -261,6 +261,27 @@ config BR2_ARCH_HAS_TOOLCHAIN_BUILDROOT\n> > \tbool\n> > \tdefault y if !BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT\n> > \n> > +# The following symbols are selected by the individual\n> > +# Config.in.$ARCH files\n> \n> I believe something is missing from this patch.\n\nNope, this patch only adds the symbols. The follow-up patches convert\nthe individual architectures, one by one, over to using them.\n\nRegards,\nYann E. MORIN.\n\n> Best regards,\n> Romain\n> \n> > +config BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n> > +\tbool\n> > +\n> > +config BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n> > +\tbool\n> > +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_8\n> > +\n> > +config BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n> > +\tbool\n> > +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_4_9\n> > +\n> > +config BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n> > +\tbool\n> > +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_5\n> > +\n> > +config BR2_ARCH_NEEDS_GCC_AT_LEAST_7\n> > +\tbool\n> > +\tselect BR2_ARCH_NEEDS_GCC_AT_LEAST_6\n> > +\n> > # The following string values are defined by the individual\n> > # Config.in.$ARCH files\n> > config BR2_ARCH\n> > \n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"n+otUoFk\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8N2s23xfz9t7B\n\tfor ;\n\tSat, 7 Oct 2017 21:26:29 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D0A1626561;\n\tSat, 7 Oct 2017 10:26:12 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Dyfb4LEOEmDz; Sat, 7 Oct 2017 10:26:11 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 105C425D7D;\n\tSat, 7 Oct 2017 10:26:11 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 722701C080F\n\tfor ;\n\tSat, 7 Oct 2017 10:26:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5DC1F87B77\n\tfor ;\n\tSat, 7 Oct 2017 10:26:23 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id K8daGPB5K0RF for ;\n\tSat, 7 Oct 2017 10:26:22 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1118C87B6C\n\tfor ; Sat, 7 Oct 2017 10:26:22 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id u138so12023581wmu.5\n\tfor ; Sat, 07 Oct 2017 03:26:21 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb088610730034fd954a27dc1711.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:34fd:954a:27dc:1711])\n\tby smtp.gmail.com with ESMTPSA id\n\tp77sm3519703wmd.28.2017.10.07.03.26.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 07 Oct 2017 03:26:18 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tSat, 07 Oct 2017 12:26:16 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=FGG2sJ3A8fIvik9dbFqet+WNPbm0wgPPgMvosbz0JaY=;\n\tb=n+otUoFkIvrw8hl+LliQaEYFY34dIhzE6T1Fg/5BGnsPXF/EZ0JVKLiEULSfmVhQr9\n\tnjU51gaIJc19TsuUPu17IhgZgVS+yWfYFCPxpDkKlKbyrgnbzTxmjAaFLZW1rtYwY3eq\n\tKcfo+r7MRAq8OiasbWAb0xmKnE2RTOCiwJpM9aGExevyWDxKW0NNQRo1u6TUi+anpZKz\n\toFi157LghucYzr5E/3suPj2DL5lpWrTcP+yrJCT7LCOFsqBBCLcHLSFPFFz8tTpW/hvR\n\tprrOb7EB9yyDIx55nML6QtLZ3xKqvFNjYWzHwXPgVM4htbIUsLv4WC68T9hYSQPYv2y2\n\t4hRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition\n\t:content-transfer-encoding:in-reply-to:user-agent;\n\tbh=FGG2sJ3A8fIvik9dbFqet+WNPbm0wgPPgMvosbz0JaY=;\n\tb=B4WCU3e3PTwbWVNkRcOXuR2HQ9QVDTjAc60MftebjTxNKW6kCO3yW70yHOPY7AtnuD\n\tIGMxUSIaTsmUCBHO3CeMim396CM71XdFUx4IL3jCe2nXx4slmBiK7cuoETspOD1tpnRP\n\t/XBVgfLH5znakDQc5PP/LVRiLfdjUJCb70RFpBheI8gNg2Ew280JZNcPKiFa2QY4i20X\n\tD6qb+4AFGLoDvmZBIZDhDuzYWHoO6mGfXNLehU1wkhXa0H7opi4LjETqifnfqBho4gZN\n\t1yQtWcftPgIsYpc//LNXLkmDY86RiK3ZUJyEOYtCD5FUEmHzbbf6r5iOeZGFC/HlOlo+\n\tlbyQ==","X-Gm-Message-State":"AMCzsaXlEftVckwFjUAkaph9YN2FsH2/a4XofDTrKKX96xbQhbkSmEKA\n\t7aiiodKU+Tr3X2o4C5XqYU/vGA==","X-Google-Smtp-Source":"AOwi7QBgWOKL5OXHpc54bkZ6JN+n6EUwjKJAgTh1WtSColXJcP89DyolG6dqtwYF4sl0b6IeyCXEvg==","X-Received":"by 10.28.16.142 with SMTP id 136mr4267042wmq.62.1507371980490;\n\tSat, 07 Oct 2017 03:26:20 -0700 (PDT)","Date":"Sat, 7 Oct 2017 12:26:16 +0200","From":"\"Yann E. MORIN\" ","To":"Romain Naour ","Message-ID":"<20171007102616.GF21901@scaer>","References":"\n\t<8de5375c8ca0110ebd5baaec946fed002cc7eb80.1504431850.git.yann.morin.1998@free.fr>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"Thomas Petazzoni ,\n\tbuildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/8] arch: introduce minimal required gcc\n\tversion","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]