[{"id":1762250,"web_url":"http://patchwork.ozlabs.org/comment/1762250/","msgid":"","list_archive_url":null,"date":"2017-09-03T12:19:50","subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 03.09.17 08:17, Heinrich Schuchardt wrote:\n> The target\n> $(obj)/helloworld.so:\n> exists twice in Makefile.lib.\n> \n> If you add an echo command to each of the two recipes you get\n> warnings like:\n> \n> scripts/Makefile.lib:383: warning:\n> overriding recipe for target 'drivers/power/battery/helloworld.so'\n> scripts/Makefile.lib:379: warning:\n> ignoring old recipe for target 'drivers/power/battery/helloworld.so'\n> \n> This patch removes the obsolete target.\n> \n> Signed-off-by: Heinrich Schuchardt \n> ---\n> Hello Alex,\n> \n> could you, please, review the change as it relates to EFI.\n\nMy Makefile foo isn't quite as good as it should be, but doesn't the \nexisting code simply add another dependency to the required build chain?\n\n\nAlex\n\n> \n> Best regards\n> \n> Heinrich\n> ---\n> scripts/Makefile.lib | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib\n> index 9ce47b4d22..7f97e8ebf3 100644\n> --- a/scripts/Makefile.lib\n> +++ b/scripts/Makefile.lib\n> @@ -375,8 +375,6 @@ cmd_efi_ld = $(LD) -nostdlib -znocombreloc -T $(EFI_LDS_PATH) -shared \\\n> \n> EFI_LDS_PATH = $(srctree)/arch/$(ARCH)/lib/$(EFI_LDS)\n> \n> -$(obj)/helloworld.so: $(EFI_LDS_PATH)\n> -\n> $(obj)/helloworld.so: $(obj)/helloworld.o arch/$(ARCH)/lib/$(EFI_CRT0) \\\n> \t\tarch/$(ARCH)/lib/$(EFI_RELOC)\n> \t$(call cmd,efi_ld)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlX9X2Fkkz9t3F\n\tfor ;\n\tSun, 3 Sep 2017 22:20:00 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 164BAC21DC5; Sun, 3 Sep 2017 12:19:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E9360C21C4F;\n\tSun, 3 Sep 2017 12:19:54 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 809D8C21C4F; Sun, 3 Sep 2017 12:19:53 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 3E72DC21C35\n\tfor ; Sun, 3 Sep 2017 12:19:53 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id CFC26AAD0;\n\tSun, 3 Sep 2017 12:19:52 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Heinrich Schuchardt ","References":"<20170903061746.29129-1-xypron.glpk@gmx.de>","From":"Alexander Graf ","Message-ID":"","Date":"Sun, 3 Sep 2017 14:19:50 +0200","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170903061746.29129-1-xypron.glpk@gmx.de>","Content-Language":"en-US","Cc":"Tom Rini , Mark Kettenis ,\n\tAndy Shevchenko , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762287,"web_url":"http://patchwork.ozlabs.org/comment/1762287/","msgid":"<1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de>","list_archive_url":null,"date":"2017-09-03T15:26:43","subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/03/2017 02:19 PM, Alexander Graf wrote:\n> \n> \n> On 03.09.17 08:17, Heinrich Schuchardt wrote:\n>> The target\n>> $(obj)/helloworld.so:\n>> exists twice in Makefile.lib.\n>>\n>> If you add an echo command to each of the two recipes you get\n>> warnings like:\n>>\n>> scripts/Makefile.lib:383: warning:\n>> overriding recipe for target 'drivers/power/battery/helloworld.so'\n>> scripts/Makefile.lib:379: warning:\n>> ignoring old recipe for target 'drivers/power/battery/helloworld.so'\n>>\n>> This patch removes the obsolete target.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> Hello Alex,\n>>\n>> could you, please, review the change as it relates to EFI.\n> \n> My Makefile foo isn't quite as good as it should be, but doesn't the\n> existing code simply add another dependency to the required build chain?\n> \n\nThe target is overridden so why should the dependency be executed?\n\nhttps://www.gnu.org/software/make/manual/html_node/Overriding-Makefiles.html\nsays:\n\"However, it is invalid for two makefiles to give different recipes for\nthe same target. I guess this will be valid for a single makefile too.\"\n\nIf you think the dependency is necessary, I can add it to the remaining\ntarget. Is this what you prefer?\n\nRegards\n\nHeinrich\n\n> \n> Alex\n> \n>>\n>> Best regards\n>>\n>> Heinrich\n>> ---\n>> scripts/Makefile.lib | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib\n>> index 9ce47b4d22..7f97e8ebf3 100644\n>> --- a/scripts/Makefile.lib\n>> +++ b/scripts/Makefile.lib\n>> @@ -375,8 +375,6 @@ cmd_efi_ld = $(LD) -nostdlib -znocombreloc -T\n>> $(EFI_LDS_PATH) -shared \\\n>> EFI_LDS_PATH = $(srctree)/arch/$(ARCH)/lib/$(EFI_LDS)\n>> -$(obj)/helloworld.so: $(EFI_LDS_PATH)\n>> -\n>> $(obj)/helloworld.so: $(obj)/helloworld.o\n>> arch/$(ARCH)/lib/$(EFI_CRT0) \\\n>> arch/$(ARCH)/lib/$(EFI_RELOC)\n>> $(call cmd,efi_ld)\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlcKg2kTlz9t33\n\tfor ;\n\tMon, 4 Sep 2017 01:27:18 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 79981C21F2C; Sun, 3 Sep 2017 15:27:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CAE25C21DBF;\n\tSun, 3 Sep 2017 15:27:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 43BFAC21DBF; Sun, 3 Sep 2017 15:27:11 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lists.denx.de (Postfix) with ESMTPS id D822AC21D65\n\tfor ; Sun, 3 Sep 2017 15:27:10 +0000 (UTC)","from [192.168.8.100] ([188.29.165.50]) by mail.gmx.com (mrgmx101\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 0MeLKt-1e85SW3Ns7-00Q97o;\n\tSun, 03 Sep 2017 17:27:01 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Alexander Graf ","References":"<20170903061746.29129-1-xypron.glpk@gmx.de>\n\t","From":"Heinrich Schuchardt ","Message-ID":"<1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de>","Date":"Sun, 3 Sep 2017 17:26:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Provags-ID":"V03:K0:VrZVKu6US/4Hf1B37wWS86aLkLJF6+/QD01a6pX6ApHIWH4ImWR\n\tG+Z9TB1AKnH8m4EWSK8bZ/uKC15T1JjeJFQolPthGpW5B7LHh0tFUAMWTKZbU2sBI9DhnzJ\n\t9CI1Ec1GCxaPoHotcOGU1oBJ7gYf+rsYNzWwHsko4S5NHaYGbp5CeWjKAJ1icrLqJrvGReJ\n\tP1pljStd0xQW1FTdTER6Q==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:uwFZNBlnruw=:iE2bMHULL8BjS4KI7KLIEw\n\tTGpHlQpITHY7xbIc9brS66e+hjUdXCgE5M4wMbPFrjf55pGZpohN6a+te33iuX8JFR/XTgCuM\n\t/aE929csl2ShL5Ik4YFyGaIZbdDDIwe6KwaWavw+80JKhMrQcmx4QoBKBBaOtUMGshrsaciTo\n\t+gY3ZZuOJxyRMD04swYKAOTRzoBR9XKI6j+QhUV/RHH38cCNNo6Zj9HqjgXJ4xsZ2Yg8WKlUX\n\t5al8CKF3W6VVMLJNlRF5JaQbJexR+DRwitcocLs2Rr+8BiuZf/hEAgwUUTUvuMpFBHAOIV2dl\n\t/Q8HIJPWFu2eBDr/l3kPgRaY3CIdEvGEC/miVJgkqVx9bbVGmLQwNmMyYCMVCFZ75/cEh5IYM\n\txrONI7t2jXaI+2MeO5nQUFBh+Ey/Fm48+PoJZhC3CxVMn5CCu/Ip1DpJeAuj14lqTAa0zFIEo\n\tf5E2zyiUIrKyaFll498s2x4qUNRZkCmz6J5+br8ycy+WZDcfN5Ae1+YL7u9wF4P78RuPR5N26\n\txK020IpQWPVobHDOHYQnqelL/6IqfO+6JYe4y2VeNFrO8pAKs0IZT3xzu/gThYWqcvYQ0bvYu\n\t8GxYcc4grQwIrs6O0FmZi0QEoBX90Sv/YezQ7ylYn1LeZMu4z0dn+eLoadx1scgu3syZFEMiE\n\tdJ8p8Ee3qzGuzmro2xT5qFno/a+qlcuFLobsO9WtbQK/UO09qi8QH/wH+zfPl7dY11tbdDvtP\n\tXzhfUE7eOk1ABqwCH6Adp3+4JhsD4hbB22+0uSXmCRx534c+rz5FMEJO7kDA42N2Bijn/X2xi\n\tof2BAXyBlmvrHCloVb4/5ZBuE/yfUXWaXNKhalXWJNPoAr9B3fv+LkdGjmDnuAhHfa0Y7mW","Cc":"Tom Rini , Mark Kettenis ,\n\tAndy Shevchenko , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762299,"web_url":"http://patchwork.ozlabs.org/comment/1762299/","msgid":"","list_archive_url":null,"date":"2017-09-03T16:31:57","subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/03/2017 02:19 PM, Alexander Graf wrote:\n> \n> \n> On 03.09.17 08:17, Heinrich Schuchardt wrote:\n>> The target\n>> $(obj)/helloworld.so:\n>> exists twice in Makefile.lib.\n>>\n>> If you add an echo command to each of the two recipes you get\n>> warnings like:\n>>\n>> scripts/Makefile.lib:383: warning:\n>> overriding recipe for target 'drivers/power/battery/helloworld.so'\n>> scripts/Makefile.lib:379: warning:\n>> ignoring old recipe for target 'drivers/power/battery/helloworld.so'\n>>\n>> This patch removes the obsolete target.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> Hello Alex,\n>>\n>> could you, please, review the change as it relates to EFI.\n> \n> My Makefile foo isn't quite as good as it should be, but doesn't the\n> existing code simply add another dependency to the required build chain?\n> \n\nBut the value given as \"dependency\" is not a valid target:\n\n$ make arch/x86/lib/elf_ia32_efi.lds\nmake: Nothing to be done for 'arch/x86/lib/elf_ia32_efi.lds'.\n\nSo the line removed by the patch is just bogus.\n\nBut as it is overridden it is not executed.\n\nRegards\n\nHeinrich\n\n> \n> Alex\n> \n>>\n>> Best regards\n>>\n>> Heinrich\n>> ---\n>> scripts/Makefile.lib | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib\n>> index 9ce47b4d22..7f97e8ebf3 100644\n>> --- a/scripts/Makefile.lib\n>> +++ b/scripts/Makefile.lib\n>> @@ -375,8 +375,6 @@ cmd_efi_ld = $(LD) -nostdlib -znocombreloc -T\n>> $(EFI_LDS_PATH) -shared \\\n>> EFI_LDS_PATH = $(srctree)/arch/$(ARCH)/lib/$(EFI_LDS)\n>> -$(obj)/helloworld.so: $(EFI_LDS_PATH)\n>> -\n>> $(obj)/helloworld.so: $(obj)/helloworld.o\n>> arch/$(ARCH)/lib/$(EFI_CRT0) \\\n>> arch/$(ARCH)/lib/$(EFI_RELOC)\n>> $(call cmd,efi_ld)\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xldmm5FPrz9t33\n\tfor ;\n\tMon, 4 Sep 2017 02:32:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6BDDFC21F01; Sun, 3 Sep 2017 16:32:20 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A7EE7C21DE1;\n\tSun, 3 Sep 2017 16:32:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3687EC21DE1; Sun, 3 Sep 2017 16:32:17 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lists.denx.de (Postfix) with ESMTPS id DD200C21DBF\n\tfor ; Sun, 3 Sep 2017 16:32:16 +0000 (UTC)","from [192.168.8.100] ([94.197.121.135]) by mail.gmx.com (mrgmx102\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0LzYY2-1dTHaC39zW-014jHV; Sun, 03 Sep 2017 18:32:03 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Alexander Graf ","References":"<20170903061746.29129-1-xypron.glpk@gmx.de>\n\t","From":"Heinrich Schuchardt ","Message-ID":"","Date":"Sun, 3 Sep 2017 18:31:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Provags-ID":"V03:K0:UH/wrCZEPt9mSEDDoyEbp47UJVb8isX9peMvaqjNcyQgLSCzINz\n\tclI1T2VoIP2q90aQxq24AzqL5n1VfGzCtV17AlTHpk6cGgPu1AB5Ez7M+wGhy9foSPwMOvx\n\t9vlsLlW20NjCLUYmWd0kEHv6sDeFT1u8wA81BJ2iOJlUib9SY+/yJgj8G2bg8whvyIZzaJC\n\tinvrEmNOYZIU3UqeXaozA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:2xHc95wDnYw=:vK2Xi8aluDChRebIg+k6h5\n\tE8vdcim/MzoVMRfFngN2mVoyLS6vVVt0PGDT41TMqDLKYhcWB2Ch7z1flN1WA0vGDSXgriQ4h\n\tG5A571n726R1MnkPm+7dxKTdNJkiwebu8YP7lPqdr0hpuk1yZ0FHgQuQ3P85BsdusjgtG3rgv\n\tm1O4WYxegjE+iTWE0eeowdfNNUW4fJETALhMkW6wg+UAu5c2vAaC3mjDahmZqxFXc9tWJbB6D\n\tpNQa3hXodDac4MFxbZt58dx8nCPD5i/xm3Fg5fmeD+Xv/KJat2ZLYfs/V7XVAq4BQJs1FH9HB\n\tVdE4+dKeuY0Ao+NC9j82ax4S7AB7kjpXTM1PjAEQ94oeiAP3YFsRZ9+IVyJxevuUtroQj7P2j\n\t1NdcBrg71ueRKhvZBhBXm8xB8er2xXk4//bf2O9D6acJr5FaQDwhmqLZgltFsKUOjFupsDnr5\n\tKEJw8ypFLH8AZUO6PN0Uytvpvm0GEfpVXkqCPFj/ly3lBpvdcFqPGy1WHHjYw/Zffp4Oxby6D\n\t6IBWjbOhP+L0kNk07b4yn71xa+fLzXZXMFIlda6YB4q7LVKwrt1CJAJBcLQUV6TY9x+WSQXnq\n\tbW/z8MwEIXk2GyykkhMtXxvBE7Nj8/M8s1tFzpCZptip8maBEVSkBfiuYqhH02EzbUVWh5tkt\n\t2T3N9ao8QngUX64EhHymCl5reUDxT3pNv4UJE6ppQQrKH/8/10JgYI4IooAf7P12qQyJzTPaa\n\tgFn1mNCK2GCZ03kT1FTl2pewObo2PnogmWMM4E9bJjZoXBnUDja/vQNP5kdvAnfO9TJ6sYl03\n\tPL1KPALafBUxT+inGzOOgIfZqGPFhCLKSaZcSzvyL3QgW9g3nE=","Cc":"Tom Rini , Mark Kettenis ,\n\tAndy Shevchenko , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1764880,"web_url":"http://patchwork.ozlabs.org/comment/1764880/","msgid":"<2994282.mGfOXkTzPg@sbruens-linux>","list_archive_url":null,"date":"2017-09-07T18:32:36","subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","submitter":{"id":67055,"url":"http://patchwork.ozlabs.org/api/people/67055/","name":"Stefan Brüns","email":"stefan.bruens@rwth-aachen.de"},"content":"On Sonntag, 3. September 2017 17:26:43 CEST Heinrich Schuchardt wrote:\n> On 09/03/2017 02:19 PM, Alexander Graf wrote:\n> > On 03.09.17 08:17, Heinrich Schuchardt wrote:\n> >> The target\n> >> $(obj)/helloworld.so:\n> >> exists twice in Makefile.lib.\n> >> \n> >> If you add an echo command to each of the two recipes you get\n> >> warnings like:\n> >> \n> >> scripts/Makefile.lib:383: warning:\n> >> overriding recipe for target 'drivers/power/battery/helloworld.so'\n> >> scripts/Makefile.lib:379: warning:\n> >> ignoring old recipe for target 'drivers/power/battery/helloworld.so'\n> >> \n> >> This patch removes the obsolete target.\n> >> \n> >> Signed-off-by: Heinrich Schuchardt \n> >> ---\n> >> Hello Alex,\n> >> \n> >> could you, please, review the change as it relates to EFI.\n> > \n> > My Makefile foo isn't quite as good as it should be, but doesn't the\n> > existing code simply add another dependency to the required build chain?\n> \n> The target is overridden so why should the dependency be executed?\n> \n> https://www.gnu.org/software/make/manual/html_node/Overriding-Makefiles.html\n> says:\n> \"However, it is invalid for two makefiles to give different recipes for\n> the same target. I guess this will be valid for a single makefile too.\"\n> \n> If you think the dependency is necessary, I can add it to the remaining\n> target. Is this what you prefer?\n\nNote there is a difference between prerequisite and recipe - specifying a \ntarget multiple times without recipe adds the the prerequisite to the existing \nset, see\n\nhttps://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html#Multiple-Targets\n\n---\nfoo: a\n\nfoo: b c\n\na:\n @echo \"Creating prereq a\"\n\n%:\n @echo \"Creating $@\"\n----\n\nThis tries to create the default target foo (first specified target), which \nhas three prerequisites (a, b, c), which are run in parallel.\n\nKind regards,\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp8Fw5wzmz9s7C\n\tfor ;\n\tFri, 8 Sep 2017 04:32:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid EBCB6C21E21; Thu, 7 Sep 2017 18:32:42 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D7C28C21D70;\n\tThu, 7 Sep 2017 18:32:39 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7F848C21D70; Thu, 7 Sep 2017 18:32:38 +0000 (UTC)","from mail-out-1.itc.rwth-aachen.de (mail-out-1.itc.rwth-aachen.de\n\t[134.130.5.46]) by lists.denx.de (Postfix) with ESMTPS id\n\tC9510C21C73\n\tfor ; Thu, 7 Sep 2017 18:32:37 +0000 (UTC)","from rwthex-w2-a.rwth-ad.de ([134.130.26.158])\n\tby mail-in-1.itc.rwth-aachen.de with ESMTP; 07 Sep 2017 20:32:37 +0200","from rwthex-w2-b.rwth-ad.de (2002:8682:1a9f::8682:1a9f) by\n\trwthex-w2-a.rwth-ad.de (2002:8682:1a9e::8682:1a9e) with Microsoft\n\tSMTP Server (TLS) id 15.0.1320.4; Thu, 7 Sep 2017 20:32:36 +0200","from rwthex-w2-b.rwth-ad.de ([fe80::200c:2ee4:85cf:8127]) by\n\trwthex-w2-b.rwth-ad.de ([fe80::200c:2ee4:85cf:8127%21]) with mapi id\n\t15.00.1320.000; Thu, 7 Sep 2017 20:32:36 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-IronPort-AV":"E=Sophos;i=\"5.42,359,1500933600\"; d=\"scan'208\";a=\"12345990\"","From":"=?iso-8859-1?q?Br=FCns=2C_Stefan?= ","To":"\"u-boot@lists.denx.de\" ","Thread-Topic":"[U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","Thread-Index":"AQHTJK8Bzxu8xZ145UmrPteBRNthV6KjJzKAgAZ9QoA=","Date":"Thu, 7 Sep 2017 18:32:36 +0000","Message-ID":"<2994282.mGfOXkTzPg@sbruens-linux>","References":"<20170903061746.29129-1-xypron.glpk@gmx.de>\n\t\n\t<1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de>","In-Reply-To":"<1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de>","Accept-Language":"en-US, de-DE","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-messagesentrepresentingtype":"1","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[78.35.13.203]","Content-ID":"<9E2B8780C7DB194B862676A362C315BE@rwth-ad.de>","MIME-Version":"1.0","Subject":"Re: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden\n\ttarget $(obj)/helloworld.so:","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]