[{"id":1823233,"web_url":"http://patchwork.ozlabs.org/comment/1823233/","msgid":"<876098j7ij.fsf@euler.schwinge.homeip.net>","list_archive_url":null,"date":"2017-12-15T16:11:32","subject":"Re: [hurd,commited] hurd: Fix rtld link","submitter":{"id":6153,"url":"http://patchwork.ozlabs.org/api/people/6153/","name":"Thomas Schwinge","email":"thomas@codesourcery.com"},"content":"Hi Samuel!\n\nOn Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault wrote:\n> --- a/sysdeps/mach/hurd/dl-sysdep.c\n> +++ b/sysdeps/mach/hurd/dl-sysdep.c\n\n> +int weak_function\n> +__access_noerrno (const char *file, int type)\n> +{\n> + errno = ENOSYS;\n> + return -1;\n> +}\n\nI just stumbled across this -- OK to push the following? Note that I\nhave not tested this. If approving this, please respond with\n\"Reviewed-by: NAME \" so that your effort will be recorded. See\n.\n\ncommit 336e16f8e6a588ba048997722a114f9d4462dbdb\nAuthor: Thomas Schwinge \nDate: Fri Dec 15 17:00:50 2017 +0100\n\n Don't set errno in Hurd rtld's __access_noerrno\n \n * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set\n errno.\n \n Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.\n---\n sysdeps/mach/hurd/dl-sysdep.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c\nindex 2cc342ec8e..5121ce325c 100644\n--- sysdeps/mach/hurd/dl-sysdep.c\n+++ sysdeps/mach/hurd/dl-sysdep.c\n@@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);\n int weak_function\n __access_noerrno (const char *file, int type)\n {\n- errno = ENOSYS;\n return -1;\n }\n \n\n\nGrüße\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-88191-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"FVUtD1c0\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yywRd3dwRz9sNr\n\tfor ;\n\tSat, 16 Dec 2017 03:11:57 +1100 (AEDT)","(qmail 21253 invoked by alias); 15 Dec 2017 16:11:50 -0000","(qmail 21189 invoked by uid 89); 15 Dec 2017 16:11:43 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\tq=dns; s=default; b=H0sDdImVWj3QF6MDoJCdncK6hVOpmcdcRS03pUhAQet\n\t6vkcQBdZft5r87LV6qdiE4L55EyMGbdPPBJpwXbyfbZOGUiFIk5Io8vsVzdh05nP\n\t7SrcPguhT47Q5p9TWGePyXJ/E2NbvJW2smwmOW82yepo9dZgKa1U3nLS+/QTcl8U\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\ts=default; bh=0lmHnUEhq3KlceKsMmJe/90isgM=; b=FVUtD1c0NHMjy3Tg9\n\tmg1JrLCP1oSWVRKAt8dOo6xxE9dPLt2mfxUnVHEKqgxTa2xstwEo0kYPEYSLQw7a\n\tAKgtLlOBWVEgkVOLMXq4ngjYjWBw6+UFJc1+7zgeJ2yRFVFH1CP8gdDbitJaAS8Y\n\t+8u+mMycV3ERa1+VGnfpbal2sU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.8 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=Samuel, samuel,\n\tH*r:PST, respond","X-HELO":"relay1.mentorg.com","From":"Thomas Schwinge ","To":"Samuel Thibault ","CC":"","Subject":"Re: [hurd,commited] hurd: Fix rtld link","In-Reply-To":"<20170903023345.24804-1-samuel.thibault@ens-lyon.org>","References":"<20170903023345.24804-1-samuel.thibault@ens-lyon.org>","User-Agent":"Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2\n\t(x86_64-pc-linux-gnu)","Date":"Fri, 15 Dec 2017 17:11:32 +0100","Message-ID":"<876098j7ij.fsf@euler.schwinge.homeip.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":1823268,"web_url":"http://patchwork.ozlabs.org/comment/1823268/","msgid":"<20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr>","list_archive_url":null,"date":"2017-12-15T16:48:42","subject":"Re: [hurd,commited] hurd: Fix rtld link","submitter":{"id":418,"url":"http://patchwork.ozlabs.org/api/people/418/","name":"Samuel Thibault","email":"samuel.thibault@ens-lyon.org"},"content":"Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote:\n> Hi Samuel!\n> \n> On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault wrote:\n> > --- a/sysdeps/mach/hurd/dl-sysdep.c\n> > +++ b/sysdeps/mach/hurd/dl-sysdep.c\n> \n> > +int weak_function\n> > +__access_noerrno (const char *file, int type)\n> > +{\n> > + errno = ENOSYS;\n> > + return -1;\n> > +}\n\nD'oh...\n\n> I just stumbled across this -- OK to push the following? Note that I\n> have not tested this. If approving this, please respond with\n> \"Reviewed-by: NAME \" so that your effort will be recorded. See\n> .\n> \n> commit 336e16f8e6a588ba048997722a114f9d4462dbdb\n> Author: Thomas Schwinge \n> Date: Fri Dec 15 17:00:50 2017 +0100\n> \n> Don't set errno in Hurd rtld's __access_noerrno\n> \n> * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set\n> errno.\n> \n> Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.\n\n\nReviewed-by: Samuel Thibault \n\nThanks!\n\n> ---\n> sysdeps/mach/hurd/dl-sysdep.c | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c\n> index 2cc342ec8e..5121ce325c 100644\n> --- sysdeps/mach/hurd/dl-sysdep.c\n> +++ sysdeps/mach/hurd/dl-sysdep.c\n> @@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);\n> int weak_function\n> __access_noerrno (const char *file, int type)\n> {\n> - errno = ENOSYS;\n> return -1;\n> }\n> \n> \n> \n> Grüße\n> Thomas\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-88195-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"UT3lrbUv\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yyxGF4DT2z9sNr\n\tfor ;\n\tSat, 16 Dec 2017 03:48:53 +1100 (AEDT)","(qmail 99031 invoked by alias); 15 Dec 2017 16:48:48 -0000","(qmail 98883 invoked by uid 89); 15 Dec 2017 16:48:47 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:content-transfer-encoding\n\t:in-reply-to; q=dns; s=default; b=TRcFaj/sE8VsBDx51P40xzwT7Z0Ml1\n\tGofpsscI/JSqt6diQRksjhNJe2/YAmE0sd10PrKEUUM1seS7xAsOdy+AxlXa525L\n\tLpZBGFE5QFXJJKRC+iZqhx7AOCbey01zf8R56g5y1rCDqNcAygqYwIFgsRhO1U3j\n\ty3I/TmNiGhVRU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-type:content-transfer-encoding\n\t:in-reply-to; s=default; bh=y2LOOnqK4otaZHg51pY/ncoJ4Fk=; b=UT3l\n\trbUvq1YB5ROyJv6h3vhFHKLtuuaRfeoCuZoybMwwO7OHPtYF1DW2CU2wi4DYTwlf\n\tp/gLZRcr8Qz4eTKIZYXbS+bHW/YIM+LNScljUyh7aOmdTER5p5HvXsLNnWtlvN81\n\tiWHdwwotV3kx62TGL9Mbvd70rMUm8WiwJrv0f8w=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"=?iso-8859-1?q?No=2C_score=3D-23=2E6_required=3D5=2E?=\n\t=?iso-8859-1?q?0_tests=3DAWL=2CBAYES_00=2CGIT_PATCH_0=2CGIT_PATCH_?=\n\t=?iso-8859-1?q?1=2CGIT_PATCH_2=2CGIT_PATCH_3=2CKAM_SHORT=2CSPF_NEU?=\n\t=?iso-8859-1?q?TRAL=2CURIBL_RED_autolearn=3Dham_version=3D3=2E3=2E?=\n\t=?iso-8859-1?q?2_spammy=3DGr=2C_Gr=C3=BC=C3=2C_H*r=3Ask=3AAES256-?=\n\t=?iso-8859-1?q?=2C_HTo=3AU*thomas?=","X-HELO":"mail2-relais-roc.national.inria.fr","Date":"Fri, 15 Dec 2017 17:48:42 +0100","From":"Samuel Thibault ","To":"Thomas Schwinge ","Cc":"libc-alpha@sourceware.org","Subject":"Re: [hurd,commited] hurd: Fix rtld link","Message-ID":"<20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr>","References":"<20170903023345.24804-1-samuel.thibault@ens-lyon.org>\n\t<876098j7ij.fsf@euler.schwinge.homeip.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<876098j7ij.fsf@euler.schwinge.homeip.net>","User-Agent":"NeoMutt/20170113 (1.7.2)"}},{"id":1823277,"web_url":"http://patchwork.ozlabs.org/comment/1823277/","msgid":"<87374bkjdj.fsf@euler.schwinge.homeip.net>","list_archive_url":null,"date":"2017-12-15T17:10:00","subject":"Re: [hurd,commited] hurd: Fix rtld link","submitter":{"id":6153,"url":"http://patchwork.ozlabs.org/api/people/6153/","name":"Thomas Schwinge","email":"thomas@codesourcery.com"},"content":"Hi!\n\nOn Fri, 15 Dec 2017 17:48:42 +0100, Samuel Thibault wrote:\n> Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote:\n> > On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault wrote:\n> > > --- a/sysdeps/mach/hurd/dl-sysdep.c\n> > > +++ b/sysdeps/mach/hurd/dl-sysdep.c\n> > \n> > > +int weak_function\n> > > +__access_noerrno (const char *file, int type)\n> > > +{\n> > > + errno = ENOSYS;\n> > > + return -1;\n> > > +}\n> \n> D'oh...\n\n;-)\n\nPushed:\n\ncommit d232f2e137127139addde487f0f01881b52cc446\nAuthor: Thomas Schwinge \nDate: Fri Dec 15 17:00:50 2017 +0100\n\n Don't set errno in Hurd rtld's __access_noerrno\n \n * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set\n errno.\n \n Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.\n \n Reviewed-by: Samuel Thibault \n---\n ChangeLog | 5 +++++\n sysdeps/mach/hurd/dl-sysdep.c | 1 -\n 2 files changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git ChangeLog ChangeLog\nindex 00161628c5..027f948ec9 100644\n--- ChangeLog\n+++ ChangeLog\n@@ -1,3 +1,8 @@\n+2017-12-15 Thomas Schwinge \n+\n+\t* sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set\n+\terrno.\n+\n 2017-12-15 Joseph Myers \n \n \t* scripts/build-many-glibcs.py (Context.add_all_configs): Use\ndiff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c\nindex 2cc342ec8e..5121ce325c 100644\n--- sysdeps/mach/hurd/dl-sysdep.c\n+++ sysdeps/mach/hurd/dl-sysdep.c\n@@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);\n int weak_function\n __access_noerrno (const char *file, int type)\n {\n- errno = ENOSYS;\n return -1;\n }\n \n\n\nGrüße\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-88199-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"AEw8zsOh\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yyxkw48Zkz9sNw\n\tfor ;\n\tSat, 16 Dec 2017 04:10:16 +1100 (AEDT)","(qmail 44885 invoked by alias); 15 Dec 2017 17:10:09 -0000","(qmail 44875 invoked by uid 89); 15 Dec 2017 17:10:09 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\tq=dns; s=default; b=x7ExeOWOEelztGMuHDQopQZvvWidV370UY+SLPAXPw0\n\t9+PNtpWvr+ax6AnHIhyPFnRehQSv0IbXZ+kKiNhM2z/Pr8RtmbSQxuYBnGx5X5ja\n\t0VHqFufAK00Ejudt+/ArN5TBk54+PXo8prAO2g6FS9BZBz8uWV5VPKdxHIQehU7w\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:in-reply-to:references:date\n\t:message-id:mime-version:content-type:content-transfer-encoding;\n\ts=default; bh=/XROa+/dTTLjjdsb/yPCBCtVHM0=; b=AEw8zsOhzzUNkIKse\n\tZY/yXHF6RSC/WqYKAJlCNCr6lDuGWfRCLiTnYIDsZaRyW5UbaaYx6oD8djs/Uzuz\n\tSh3oAXFsFor9Ab2z9yKLm4vmXmCPm27cnHUdeh0BD5iDtpMdgE1K7iYiyVnHQV42\n\tMv6dp1AAPLK2IFDxUbdNeqyrH8=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.9 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=H*r:PST","X-HELO":"relay1.mentorg.com","From":"Thomas Schwinge ","To":"Samuel Thibault ,\n\t","Subject":"Re: [hurd,commited] hurd: Fix rtld link","In-Reply-To":"<20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr>","References":"<20170903023345.24804-1-samuel.thibault@ens-lyon.org>\n\t<876098j7ij.fsf@euler.schwinge.homeip.net>\n\t<20171215164842.tvnqspomnvzt4umd@var.youpi.perso.aquilenet.fr>","User-Agent":"Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/25.2.2\n\t(x86_64-pc-linux-gnu)","Date":"Fri, 15 Dec 2017 18:10:00 +0100","Message-ID":"<87374bkjdj.fsf@euler.schwinge.homeip.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable"}}]