[{"id":1762476,"web_url":"http://patchwork.ozlabs.org/comment/1762476/","msgid":"","list_archive_url":null,"date":"2017-09-04T07:27:57","subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","submitter":{"id":71764,"url":"http://patchwork.ozlabs.org/api/people/71764/","name":"Arturo Borrero Gonzalez","email":"arturo@netfilter.org"},"content":"On 3 September 2017 at 01:32, Shyam Saini wrote:\n> These test cases can be used to test upcoming \"import json\" command.\n>\n> Here is the short description of the files:\n> all_ruleset_list -> contains list of all the individual rules\n> json_import_0 -> script that runs json run-tests.sh\n>\n> For Example:\n> $ ./run-tests.sh testcases/import/json_import_0\n>\n> Below mentioned files contains individual rules in json format and\n> are added for the reference:\n> rules_ipv4* -> ip table rules files\n> rules_ipv6* -> ip6 table rules files\n> rules_arp* -> arp table rules files\n> rules_bridge* -> bridge table rules files\n>\n> Signed-off-by: Shyam Saini \n> ---\n\nThis is v2: generally in this patch section we include patch changelog\ninformation.\nPlease, take a look at this when sending v3 :-)\n\n> tests/shell/testcases/import/all_ruleset_list | 46 ++++++++++++++\n> tests/shell/testcases/import/json_import_0 | 72 ++++++++++++++++++++++\n> .../testcases/import/rules_arp_hlen_range.json | 1 +\n> tests/shell/testcases/import/rules_arp_htype.json | 1 +\n> .../testcases/import/rules_arp_operation.json | 1 +\n> .../import/rules_arp_operation_check.json | 1 +\n> .../shell/testcases/import/rules_arp_ptype_ip.json | 1 +\n> .../shell/testcases/import/rules_bridge_vlan.json | 1 +\n> .../testcases/import/rules_bridge_vlan_id.json | 1 +\n> ...bridge_vlan_id_saddr_udp_dport_drop_domain.json | 1 +\n> .../import/rules_ipv4_ct_state_accept.json | 1 +\n> .../rules_ipv4_icmp_type_echo-request_accept.json | 1 +\n> .../rules_ipv4_icmp_type_echo-request_counter.json | 1 +\n> .../import/rules_ipv4_iifname_accept.json | 1 +\n> .../import/rules_ipv4_saddr_daddr_counter.json | 1 +\n> .../testcases/import/rules_ipv4_set_elements.json | 1 +\n> .../import/rules_ipv4_tcp_dport_http_ssh.json | 1 +\n> .../testcases/import/rules_ipv4_tcp_flags.json | 1 +\n> .../import/rules_ipv6_daddr_udp_dport_counter.json | 1 +\n> ...es_ipv6_daddr_udp_dport_counter_masquerade.json | 1 +\n> .../testcases/import/rules_ipv6_icmpv6_id.json | 1 +\n> ...iifname_ct_state_tcp_dport_vmap_masquerade.json | 1 +\n> .../import/rules_ipv6_l4proto_tcp_masquerade.json | 1 +\n> ...dport_ssh_daddr_mapping_ether_saddr_accept.json | 1 +\n> 24 files changed, 140 insertions(+)\n> create mode 100644 tests/shell/testcases/import/all_ruleset_list\n> create mode 100755 tests/shell/testcases/import/json_import_0\n> create mode 100644 tests/shell/testcases/import/rules_arp_hlen_range.json\n> create mode 100644 tests/shell/testcases/import/rules_arp_htype.json\n> create mode 100644 tests/shell/testcases/import/rules_arp_operation.json\n> create mode 100644 tests/shell/testcases/import/rules_arp_operation_check.json\n> create mode 100644 tests/shell/testcases/import/rules_arp_ptype_ip.json\n> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan.json\n> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan_id.json\n> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan_id_saddr_udp_dport_drop_domain.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_ct_state_accept.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_icmp_type_echo-request_accept.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_icmp_type_echo-request_counter.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_iifname_accept.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_saddr_daddr_counter.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_set_elements.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_tcp_dport_http_ssh.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv4_tcp_flags.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_daddr_udp_dport_counter.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_daddr_udp_dport_counter_masquerade.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_icmpv6_id.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_iifname_ct_state_tcp_dport_vmap_masquerade.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_l4proto_tcp_masquerade.json\n> create mode 100644 tests/shell/testcases/import/rules_ipv6_tcp_dport_ssh_daddr_mapping_ether_saddr_accept.json\n>\n> diff --git a/tests/shell/testcases/import/all_ruleset_list b/tests/shell/testcases/import/all_ruleset_list\n> new file mode 100644\n> index 000000000000..4e25a76d8016\n> --- /dev/null\n> +++ b/tests/shell/testcases/import/all_ruleset_list\n> @@ -0,0 +1,46 @@\n> +table ip mangle {\n> + set blackhole {\n> + type ipv4_addr\n> + elements = { 192.168.1.4, 192.168.1.5 }\n> + }\n> +\n> + chain prerouting {\n> + type filter hook prerouting priority 0; policy accept;\n> + tcp dport { ssh, http } accept\n> + ip saddr @blackhole drop\n> + icmp type echo-request accept\n> + iifname \"lo\" accept\n> + icmp type echo-request counter packets 0 bytes 0\n> + ct state established,related accept\n> + tcp flags != syn counter packets 7 bytes 841\n> + ip saddr 192.168.1.100 ip daddr 192.168.1.1 counter packets 0 bytes 0\n> + }\n> +}\n> +table arp x {\n> + chain y {\n> + arp htype 22\n> + arp ptype ip\n> + arp operation != rrequest\n> + arp operation { request, reply, rrequest, rreply, inrequest, inreply, nak }\n> + arp hlen 33-45\n> + }\n> +}\n> +table bridge x {\n> + chain y {\n> + type filter hook input priority 0; policy accept;\n> + vlan id 4094\n> + vlan id 4094 vlan cfi 0\n> + vlan id 1 ip saddr 10.0.0.0/23 udp dport domain\n> + }\n> +}\n> +table ip6 x {\n> + chain y {\n> + type nat hook postrouting priority 0; policy accept;\n> + icmpv6 id 33-45\n> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0\n> + meta l4proto tcp masquerade to :1024\n> + iifname \"wlan0\" ct state established,new tcp dport vmap { ssh : drop, 222 : drop } masquerade\n> + tcp dport ssh ip6 daddr 1::2 ether saddr 00:0f:54:0c:11:04 accept\n> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0 masquerade\n> + }\n> +}\n\nNow that we included the ruleset in the testcase itself this file is\nno longer useful?\nPlease, drop it.\n\n> diff --git a/tests/shell/testcases/import/json_import_0 b/tests/shell/testcases/import/json_import_0\n> new file mode 100755\n> index 000000000000..a469a4dda754\n> --- /dev/null\n> +++ b/tests/shell/testcases/import/json_import_0\n> @@ -0,0 +1,72 @@\n> +#!/bin/bash\n> +\n> +tmpfile=$(mktemp)\n> +\n> +if [ ! -w $tmpfile ] ; then\n> + echo \"Failed to create tmp file\" >&2\n> + exit 0\n> +fi\n> +\n> +trap \"rm -rf $tmpfile\" EXIT # cleanup if aborted\n> +\n> +RULESET=\"table ip mangle {\n> + set blackhole {\n> + type ipv4_addr\n> + elements = { 192.168.1.4, 192.168.1.5 }\n> + }\n> +\n> + chain prerouting {\n> + type filter hook prerouting priority 0; policy accept;\n> + tcp dport { ssh, http } accept\n> + ip saddr @blackhole drop\n> + icmp type echo-request accept\n> + iifname \\\"lo\\\" accept\n> + icmp type echo-request counter packets 0 bytes 0\n> + ct state established,related accept\n> + tcp flags != syn counter packets 7 bytes 841\n> + ip saddr 192.168.1.100 ip daddr 192.168.1.1 counter packets 0 bytes 0\n> + }\n> +}\n> +table arp x {\n> + chain y {\n> + arp htype 22\n> + arp ptype ip\n> + arp operation != rrequest\n> + arp operation { request, reply, rrequest, rreply, inrequest, inreply, nak }\n> + arp hlen 33-45\n> + }\n> +}\n> +table bridge x {\n> + chain y {\n> + type filter hook input priority 0; policy accept;\n> + vlan id 4094\n> + vlan id 4094 vlan cfi 0\n> + vlan id 1 ip saddr 10.0.0.0/23 udp dport domain\n> + }\n> +}\n> +table ip6 x {\n> + chain y {\n> + type nat hook postrouting priority 0; policy accept;\n> + icmpv6 id 33-45\n> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0\n> + meta l4proto tcp masquerade to :1024\n> + iifname \\\"wlan0\\\" ct state established,new tcp dport vmap { ssh : drop, 222 : drop } masquerade\n> + tcp dport ssh ip6 daddr 1::2 ether saddr 00:0f:54:0c:11:04 accept\n> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0 masquerade\n> + }\n> +}\"\n> +\n> +echo \"$RULESET\" > $tmpfile\n> +$NFT -f $tmpfile\n> +$NFT export json > $tmpfile\n> +$NFT flush ruleset\n> +cat $tmpfile | $NFT import json\n> +\n> +RESULT=\"$($NFT list ruleset)\"\n> +\n> +\n> +if [ \"$RULESET\" != \"$RESULT\" ] ; then\n> + DIFF=\"$(which diff)\"\n> + [ -x $DIFF ] && $DIFF -u <(echo \"$RULESET\") <(echo \"$RESULT\")\n\nexit 1 in this case?\n\n> +fi\n> +\n\n\nWhat is the pourpose of these json files? I guess they are no longer useful.\n\n> diff --git a/tests/shell/testcases/import/rules_arp_hlen_range.json b/tests/shell/testcases/import/rules_arp_hlen_range.json\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm1fY6PM4z9s82\n\tfor ;\n\tMon, 4 Sep 2017 17:28:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753263AbdIDH2U (ORCPT );\n\tMon, 4 Sep 2017 03:28:20 -0400","from mail-wm0-f67.google.com ([74.125.82.67]:37526 \"EHLO\n\tmail-wm0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751949AbdIDH2U (ORCPT\n\t);\n\tMon, 4 Sep 2017 03:28:20 -0400","by mail-wm0-f67.google.com with SMTP id x189so5591075wmg.4\n\tfor ;\n\tMon, 04 Sep 2017 00:28:19 -0700 (PDT)","from mail-wm0-f41.google.com (mail-wm0-f41.google.com.\n\t[74.125.82.41]) by smtp.gmail.com with ESMTPSA id\n\tx29sm3860259eda.50.2017.09.04.00.28.18\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 00:28:18 -0700 (PDT)","by mail-wm0-f41.google.com with SMTP id 137so13595306wmj.1\n\tfor ;\n\tMon, 04 Sep 2017 00:28:18 -0700 (PDT)","by 10.80.167.166 with HTTP; Mon, 4 Sep 2017 00:27:57 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=a6hXUcwnQsw4MI2ucLMzsclT7v1l2VRGtbW78wIo+BU=;\n\tb=eskA6W2DFqvZR9EJtlfCe/4uvgijiBuQuFAldmCzh/NnoiqnmdXZ2oWWigyl2I+77h\n\tvd5coKW46jNpTjakqQ9GgOczmC8kwSgNNeAtXPRy73qJpWzG/0ypK3zDKkAVPWT9uwlb\n\tjXR/7zaY6uR/WbseH2i4QQq23KOeTRbyEIKzjyDJIScyBKRpimoz2CQBJc1/8wLUnTrA\n\t8UUDyi0gmWkLjcCtak7xZLrIfkoxDw7FbV9KtLVd9GE6dEyiCH325i/FqJyQ4cwkXY/Y\n\t6Rkx4LjghNL52/v+ShRhjZY1rTw+7gVyu8XqLOWRmQz1tdxQ3wz4j23yv225zWqvZYU9\n\tg0gQ==","X-Gm-Message-State":"AHPjjUioNuPKbwFbtOvMcaZHC8Chhp8c/O5RLY6grbWo479wBE8PRTmw\n\t8pYCSOwqgv5rU4vO+O4=","X-Received":["by 10.80.155.92 with SMTP id a28mr8342791edj.265.1504510098540; \n\tMon, 04 Sep 2017 00:28:18 -0700 (PDT)","by 10.80.152.25 with SMTP id g25mr7444840edb.142.1504510098064; \n\tMon, 04 Sep 2017 00:28:18 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb7Ir2bsbNu+kGv3OTz7RAbNcXwP1TDaeEeceQcyVOvieo2thtHUEbfODjzqJL9KGgNmsF+BQBJnUimjHFp0mIw=","MIME-Version":"1.0","In-Reply-To":"<1504395174-15192-1-git-send-email-mayhs11saini@gmail.com>","References":"<1504395174-15192-1-git-send-email-mayhs11saini@gmail.com>","From":"Arturo Borrero Gonzalez ","Date":"Mon, 4 Sep 2017 09:27:57 +0200","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","To":"Shyam Saini ","Cc":"Netfilter Development Mailing list ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1762604,"web_url":"http://patchwork.ozlabs.org/comment/1762604/","msgid":"","list_archive_url":null,"date":"2017-09-04T12:39:59","subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","submitter":{"id":69683,"url":"http://patchwork.ozlabs.org/api/people/69683/","name":"Shyam Saini","email":"mayhs11saini@gmail.com"},"content":">> These test cases can be used to test upcoming \"import json\" command.\n>>\n>> Here is the short description of the files:\n>> all_ruleset_list -> contains list of all the individual rules\n>> json_import_0 -> script that runs json run-tests.sh\n>>\n>> For Example:\n>> $ ./run-tests.sh testcases/import/json_import_0\n>>\n>> Below mentioned files contains individual rules in json format and\n>> are added for the reference:\n>> rules_ipv4* -> ip table rules files\n>> rules_ipv6* -> ip6 table rules files\n>> rules_arp* -> arp table rules files\n>> rules_bridge* -> bridge table rules files\n>>\n>> Signed-off-by: Shyam Saini \n>> ---\n>\n> This is v2: generally in this patch section we include patch changelog\n> information.\n> Please, take a look at this when sending v3 :-)\n>\n>> tests/shell/testcases/import/all_ruleset_list | 46 ++++++++++++++\n>> tests/shell/testcases/import/json_import_0 | 72 ++++++++++++++++++++++\n>> .../testcases/import/rules_arp_hlen_range.json | 1 +\n>> tests/shell/testcases/import/rules_arp_htype.json | 1 +\n>> .../testcases/import/rules_arp_operation.json | 1 +\n>> .../import/rules_arp_operation_check.json | 1 +\n>> .../shell/testcases/import/rules_arp_ptype_ip.json | 1 +\n>> .../shell/testcases/import/rules_bridge_vlan.json | 1 +\n>> .../testcases/import/rules_bridge_vlan_id.json | 1 +\n>> ...bridge_vlan_id_saddr_udp_dport_drop_domain.json | 1 +\n>> .../import/rules_ipv4_ct_state_accept.json | 1 +\n>> .../rules_ipv4_icmp_type_echo-request_accept.json | 1 +\n>> .../rules_ipv4_icmp_type_echo-request_counter.json | 1 +\n>> .../import/rules_ipv4_iifname_accept.json | 1 +\n>> .../import/rules_ipv4_saddr_daddr_counter.json | 1 +\n>> .../testcases/import/rules_ipv4_set_elements.json | 1 +\n>> .../import/rules_ipv4_tcp_dport_http_ssh.json | 1 +\n>> .../testcases/import/rules_ipv4_tcp_flags.json | 1 +\n>> .../import/rules_ipv6_daddr_udp_dport_counter.json | 1 +\n>> ...es_ipv6_daddr_udp_dport_counter_masquerade.json | 1 +\n>> .../testcases/import/rules_ipv6_icmpv6_id.json | 1 +\n>> ...iifname_ct_state_tcp_dport_vmap_masquerade.json | 1 +\n>> .../import/rules_ipv6_l4proto_tcp_masquerade.json | 1 +\n>> ...dport_ssh_daddr_mapping_ether_saddr_accept.json | 1 +\n>> 24 files changed, 140 insertions(+)\n>> create mode 100644 tests/shell/testcases/import/all_ruleset_list\n>> create mode 100755 tests/shell/testcases/import/json_import_0\n>> create mode 100644 tests/shell/testcases/import/rules_arp_hlen_range.json\n>> create mode 100644 tests/shell/testcases/import/rules_arp_htype.json\n>> create mode 100644 tests/shell/testcases/import/rules_arp_operation.json\n>> create mode 100644 tests/shell/testcases/import/rules_arp_operation_check.json\n>> create mode 100644 tests/shell/testcases/import/rules_arp_ptype_ip.json\n>> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan.json\n>> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan_id.json\n>> create mode 100644 tests/shell/testcases/import/rules_bridge_vlan_id_saddr_udp_dport_drop_domain.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_ct_state_accept.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_icmp_type_echo-request_accept.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_icmp_type_echo-request_counter.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_iifname_accept.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_saddr_daddr_counter.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_set_elements.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_tcp_dport_http_ssh.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv4_tcp_flags.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_daddr_udp_dport_counter.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_daddr_udp_dport_counter_masquerade.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_icmpv6_id.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_iifname_ct_state_tcp_dport_vmap_masquerade.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_l4proto_tcp_masquerade.json\n>> create mode 100644 tests/shell/testcases/import/rules_ipv6_tcp_dport_ssh_daddr_mapping_ether_saddr_accept.json\n>>\n>> diff --git a/tests/shell/testcases/import/all_ruleset_list b/tests/shell/testcases/import/all_ruleset_list\n>> new file mode 100644\n>> index 000000000000..4e25a76d8016\n>> --- /dev/null\n>> +++ b/tests/shell/testcases/import/all_ruleset_list\n>> @@ -0,0 +1,46 @@\n>> +table ip mangle {\n>> + set blackhole {\n>> + type ipv4_addr\n>> + elements = { 192.168.1.4, 192.168.1.5 }\n>> + }\n>> +\n>> + chain prerouting {\n>> + type filter hook prerouting priority 0; policy accept;\n>> + tcp dport { ssh, http } accept\n>> + ip saddr @blackhole drop\n>> + icmp type echo-request accept\n>> + iifname \"lo\" accept\n>> + icmp type echo-request counter packets 0 bytes 0\n>> + ct state established,related accept\n>> + tcp flags != syn counter packets 7 bytes 841\n>> + ip saddr 192.168.1.100 ip daddr 192.168.1.1 counter packets 0 bytes 0\n>> + }\n>> +}\n>> +table arp x {\n>> + chain y {\n>> + arp htype 22\n>> + arp ptype ip\n>> + arp operation != rrequest\n>> + arp operation { request, reply, rrequest, rreply, inrequest, inreply, nak }\n>> + arp hlen 33-45\n>> + }\n>> +}\n>> +table bridge x {\n>> + chain y {\n>> + type filter hook input priority 0; policy accept;\n>> + vlan id 4094\n>> + vlan id 4094 vlan cfi 0\n>> + vlan id 1 ip saddr 10.0.0.0/23 udp dport domain\n>> + }\n>> +}\n>> +table ip6 x {\n>> + chain y {\n>> + type nat hook postrouting priority 0; policy accept;\n>> + icmpv6 id 33-45\n>> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0\n>> + meta l4proto tcp masquerade to :1024\n>> + iifname \"wlan0\" ct state established,new tcp dport vmap { ssh : drop, 222 : drop } masquerade\n>> + tcp dport ssh ip6 daddr 1::2 ether saddr 00:0f:54:0c:11:04 accept\n>> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0 masquerade\n>> + }\n>> +}\n>\n> Now that we included the ruleset in the testcase itself this file is\n> no longer useful?\n> Please, drop it.\n>\n>> diff --git a/tests/shell/testcases/import/json_import_0 b/tests/shell/testcases/import/json_import_0\n>> new file mode 100755\n>> index 000000000000..a469a4dda754\n>> --- /dev/null\n>> +++ b/tests/shell/testcases/import/json_import_0\n>> @@ -0,0 +1,72 @@\n>> +#!/bin/bash\n>> +\n>> +tmpfile=$(mktemp)\n>> +\n>> +if [ ! -w $tmpfile ] ; then\n>> + echo \"Failed to create tmp file\" >&2\n>> + exit 0\n>> +fi\n>> +\n>> +trap \"rm -rf $tmpfile\" EXIT # cleanup if aborted\n>> +\n>> +RULESET=\"table ip mangle {\n>> + set blackhole {\n>> + type ipv4_addr\n>> + elements = { 192.168.1.4, 192.168.1.5 }\n>> + }\n>> +\n>> + chain prerouting {\n>> + type filter hook prerouting priority 0; policy accept;\n>> + tcp dport { ssh, http } accept\n>> + ip saddr @blackhole drop\n>> + icmp type echo-request accept\n>> + iifname \\\"lo\\\" accept\n>> + icmp type echo-request counter packets 0 bytes 0\n>> + ct state established,related accept\n>> + tcp flags != syn counter packets 7 bytes 841\n>> + ip saddr 192.168.1.100 ip daddr 192.168.1.1 counter packets 0 bytes 0\n>> + }\n>> +}\n>> +table arp x {\n>> + chain y {\n>> + arp htype 22\n>> + arp ptype ip\n>> + arp operation != rrequest\n>> + arp operation { request, reply, rrequest, rreply, inrequest, inreply, nak }\n>> + arp hlen 33-45\n>> + }\n>> +}\n>> +table bridge x {\n>> + chain y {\n>> + type filter hook input priority 0; policy accept;\n>> + vlan id 4094\n>> + vlan id 4094 vlan cfi 0\n>> + vlan id 1 ip saddr 10.0.0.0/23 udp dport domain\n>> + }\n>> +}\n>> +table ip6 x {\n>> + chain y {\n>> + type nat hook postrouting priority 0; policy accept;\n>> + icmpv6 id 33-45\n>> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0\n>> + meta l4proto tcp masquerade to :1024\n>> + iifname \\\"wlan0\\\" ct state established,new tcp dport vmap { ssh : drop, 222 : drop } masquerade\n>> + tcp dport ssh ip6 daddr 1::2 ether saddr 00:0f:54:0c:11:04 accept\n>> + ip6 daddr fe00::1-fe00::200 udp dport domain counter packets 0 bytes 0 masquerade\n>> + }\n>> +}\"\n>> +\n>> +echo \"$RULESET\" > $tmpfile\n>> +$NFT -f $tmpfile\n>> +$NFT export json > $tmpfile\n>> +$NFT flush ruleset\n>> +cat $tmpfile | $NFT import json\n>> +\n>> +RESULT=\"$($NFT list ruleset)\"\n>> +\n>> +\n>> +if [ \"$RULESET\" != \"$RESULT\" ] ; then\n>> + DIFF=\"$(which diff)\"\n>> + [ -x $DIFF ] && $DIFF -u <(echo \"$RULESET\") <(echo \"$RESULT\")\n>\n> exit 1 in this case?\n>\n>> +fi\n>> +\n>\n>\n> What is the pourpose of these json files? I guess they are no longer useful.\n>\n>> diff --git a/tests/shell/testcases/import/rules_arp_hlen_range.json b/tests/shell/testcases/import/rules_arp_hlen_range.json\n\nThanks a lot Arturo for all these suggestions :)\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ToaJLrE6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm8ZB58HYz9t2R\n\tfor ;\n\tMon, 4 Sep 2017 22:40:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753515AbdIDMkB (ORCPT );\n\tMon, 4 Sep 2017 08:40:01 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:33543 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753497AbdIDMkB (ORCPT\n\t);\n\tMon, 4 Sep 2017 08:40:01 -0400","by mail-oi0-f68.google.com with SMTP id k191so193665oih.0\n\tfor ;\n\tMon, 04 Sep 2017 05:40:00 -0700 (PDT)","by 10.74.2.3 with HTTP; Mon, 4 Sep 2017 05:39:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=2cOdyE6Xk8aq8yFL8kzZ6Zq7aM8tlXE3bJkNsy7Kdgg=;\n\tb=ToaJLrE6nzPpxV8XcGqJKmqBvI75eev7cqU+K1hwEtLAgY+2wOOhsdrJnhpSHy8b10\n\tbPVmirXy1Ivm75/JhDbUZn2Z7Zssm3pHWqgAGB+R440hevtXUSN7meKNdeC8Bo22UqYq\n\t1Pj3eAPyPzkn6EAODm4pSN86g4b2slV28SiekWQdkdQ2UccNKxt1oGLAR8kyf9/Pwh98\n\tloEEm9Kmym50JeRQJTz5/9P6gxYufHAug7V+gHvzQ+dKFwUu4tAZ/CQTTOXHxBkrDtLR\n\tHmEXcD59DGnrv5VosP8GA+iuqbzSf/8FY6LZXhtUHgxCKJB1SlofkDey33EOauSxXp3V\n\tYXdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=2cOdyE6Xk8aq8yFL8kzZ6Zq7aM8tlXE3bJkNsy7Kdgg=;\n\tb=jul/gJckhe7te1kfNqnMIdAmX0amBo7ExTyYiH11+yYRF3ug/RiYGRVMAOYFaY8aLC\n\tWTVsh/ohTG3h0vhJNHcSy5TVGpUnwNEKXJXPSvodVaURtXbzIW97jNmKkLkCAS4r9n0W\n\tBL85P3pAFXOjnaD2z3NNUUube0jcOPhTEqRH9OcfyvH/sXKBMaHwmzYXxVf5WQJWLw0x\n\tNV/cfm3JqVuepCTAQpjf7W3sUgwe57lBVvKGCXrpiU+3uVVLIVaQU0NRaeXQZ13guDEo\n\t0xY6vcd224h3wNtFSk/i9QyvAwukGC2I0JaTElyyrdOMlkCrXujsakjD/bs8A6/W4SN4\n\tM9uw==","X-Gm-Message-State":"AHPjjUj3BD2t1rz/LDBkkJlEUHudLY2YS9lu9K9foYKu25+gAazHuune\n\tJzDIznWes3IkyMiHERFA0BGRkNcO3g==","X-Google-Smtp-Source":"ADKCNb6O6XyzoNrutOAjLi508RQc6nPoR8srLv4+HNITByB7u67Um4xvdEWt0IB4qj8Ota0ialVTms8pmUi8jPyg7fM=","X-Received":"by 10.202.86.132 with SMTP id k126mr425755oib.277.1504528800023; \n\tMon, 04 Sep 2017 05:40:00 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504395174-15192-1-git-send-email-mayhs11saini@gmail.com>\n\t","From":"Shyam Saini ","Date":"Mon, 4 Sep 2017 18:09:59 +0530","Message-ID":"","Subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","To":"Arturo Borrero Gonzalez ","Cc":"Netfilter Development Mailing list ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1763184,"web_url":"http://patchwork.ozlabs.org/comment/1763184/","msgid":"","list_archive_url":null,"date":"2017-09-05T10:26:57","subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","submitter":{"id":71764,"url":"http://patchwork.ozlabs.org/api/people/71764/","name":"Arturo Borrero Gonzalez","email":"arturo@netfilter.org"},"content":"On 4 September 2017 at 14:39, Shyam Saini wrote:\n>>> These test cases can be used to test upcoming \"import json\" command.\n>>>\n\nHi Shyam,\n\nyour v3 looks fine.\n\nI was going to test it out, but it seems the first patch [0] in the\nseries requires a refresh.\nPlease, refresh this first patch.\n\nthanks for your work!\n\n[0] http://patchwork.ozlabs.org/patch/803561/\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmjZd5sm6z9s3w\n\tfor ;\n\tTue, 5 Sep 2017 20:27:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750775AbdIEK1U (ORCPT );\n\tTue, 5 Sep 2017 06:27:20 -0400","from mail-wm0-f42.google.com ([74.125.82.42]:35229 \"EHLO\n\tmail-wm0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750755AbdIEK1U (ORCPT\n\t);\n\tTue, 5 Sep 2017 06:27:20 -0400","by mail-wm0-f42.google.com with SMTP id h144so3185512wme.0\n\tfor ;\n\tTue, 05 Sep 2017 03:27:19 -0700 (PDT)","from mail-wm0-f47.google.com (mail-wm0-f47.google.com.\n\t[74.125.82.47]) by smtp.gmail.com with ESMTPSA id\n\tk19sm81985eda.73.2017.09.05.03.27.18\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 05 Sep 2017 03:27:18 -0700 (PDT)","by mail-wm0-f47.google.com with SMTP id 187so16859290wmn.1\n\tfor ;\n\tTue, 05 Sep 2017 03:27:18 -0700 (PDT)","by 10.80.167.166 with HTTP; Tue, 5 Sep 2017 03:26:57 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=PpM4M/m/splj1xy4r1uM8QNiy/eptWZYE2o+t8I+GuU=;\n\tb=RZSH2OIBOgA7hBK/7GMb4nvBKor6mnaMxzXQc1XTl+mGjgHO8YXYuZn1n2cYvigbsn\n\txnDAEqdmX5nuiBY3ERe/tlHPM1aXJuZVPyT7sXpw1op7Xbs7r7xu3jaXKGQkPnRho2Fw\n\tsCXe08QmqHCjB2EzR44gkmhv/YzLY2xKq5l+VRD2YyEVS+AdkizjrWmzA9ALi++sj/ne\n\tR7MMu/35oEd6xicNv0/YdiAHLz769YEPh5Otumvyq1nUpx2f346V3FSfNOQJ5Iti8i0F\n\tpGs0wWiVHDyxfFSadGtOLkiALJAmFXHk4H3gwpmYQsRHCs4vuUWtFRZOPojvBvceiFwx\n\tHNew==","X-Gm-Message-State":"AHPjjUh87a0KMfbneOMMtscSZD9R1wF3P55NT1UxxLLB8swV/FPQe88w\n\te/aHM/bjipFXyFeykkU=","X-Received":["by 10.80.155.14 with SMTP id o14mr549818edi.39.1504607238737;\n\tTue, 05 Sep 2017 03:27:18 -0700 (PDT)","by 10.80.240.26 with SMTP id r26mr2927948edl.142.1504607238325; \n\tTue, 05 Sep 2017 03:27:18 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb5WtrHAlANZ34v1J599xQJYygdMmQi7XFRppFwqXMyZSBbKxWBPLo3Hgrjhhmf6OIka/mHzbgJEeeGQSYqoY3o=","MIME-Version":"1.0","In-Reply-To":"","References":"<1504395174-15192-1-git-send-email-mayhs11saini@gmail.com>\n\t\n\t","From":"Arturo Borrero Gonzalez ","Date":"Tue, 5 Sep 2017 12:26:57 +0200","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","To":"Shyam Saini ","Cc":"Netfilter Development Mailing list ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1763801,"web_url":"http://patchwork.ozlabs.org/comment/1763801/","msgid":"","list_archive_url":null,"date":"2017-09-06T04:06:52","subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","submitter":{"id":69683,"url":"http://patchwork.ozlabs.org/api/people/69683/","name":"Shyam Saini","email":"mayhs11saini@gmail.com"},"content":"> Hi Shyam,\n\nHi Arturo,\n\n> your v3 looks fine.\nThank you :)\n\n> I was going to test it out, but it seems the first patch [0] in the\n> series requires a refresh.\n> Please, refresh this first patch.\n>\n> thanks for your work!\n>\n> [0] http://patchwork.ozlabs.org/patch/803561/\n\nSorry, for the inconvenience caused.\nWill send the new patch asap.\n\n\nThanks,\nShyam\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VZ9VxYiD\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn95C0Vbzz9s82\n\tfor ;\n\tWed, 6 Sep 2017 14:06:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750788AbdIFEGy (ORCPT );\n\tWed, 6 Sep 2017 00:06:54 -0400","from mail-oi0-f49.google.com ([209.85.218.49]:35282 \"EHLO\n\tmail-oi0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750716AbdIFEGx (ORCPT\n\t);\n\tWed, 6 Sep 2017 00:06:53 -0400","by mail-oi0-f49.google.com with SMTP id n18so35548652oig.2\n\tfor ;\n\tTue, 05 Sep 2017 21:06:53 -0700 (PDT)","by 10.74.2.3 with HTTP; Tue, 5 Sep 2017 21:06:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=YoF8XBGzQvA8gXdqLnrbs/0rbySFHsr2c1inzGeJLyc=;\n\tb=VZ9VxYiDWNZbqcwGNOBT/MjPp6P6WKSBFwulcppI7P6rY1/PBhTjz6Q5tfeh1w9fn0\n\tk9oN5avStSfuq/MB9wgnoLfxec2zlmB6TkKhZRJsl6QI8EtXeOAtCR7P6adCkw2uCywV\n\t5yBjc3+n1GDfZ7quE51KwW8KiX+XYWZCPa8gQNmNA4OpPLw1yBQnqbvZx6XZyK1sOdCN\n\t6njusBgpI3mI+Wr9Q4EuILOI/tiDQ5wnL51RxRseO+jVR/EGxsLd8/UZNPplFjJpWIvM\n\tLuYT/Zzszkh48kWmED1xdVjv5y0hxLuQPCxY9FJYrPEvdb+Rh9X2jDMdVMoszs2GKqqk\n\tEI2g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=YoF8XBGzQvA8gXdqLnrbs/0rbySFHsr2c1inzGeJLyc=;\n\tb=pPZuNz/3Kp3FcNW04BZAT5y2kyiyd5v/PLep6N7LZA6O/i4bWaljyHiDjRrqMzaUQk\n\tdvCwGmQIGdlFyFgUoQqwc2rPf1drWbXBxAbdCAazrnebtHU/0jh7C57spadjNKauvBZa\n\twm4HBP12ry4//g8OHz4TY/uYMEpO6INe8z5JjmnISztBMwzGgT8OZAWHyrOP2cyVTqJ9\n\tKp7zM1mb7NgcKFoSB2CI82ULcnBsBZ9wi8O06VfqAgCZG5GQiajERHvkn4LyXesRckDr\n\twRvUec/js7xF0ATtYVlfdlAovp6gdxR4CWYBgUyzKlI+35ugE16D7Mwnl9hNLIx9O+51\n\tRx2A==","X-Gm-Message-State":"AHPjjUiBZ2MS4nwIvozZalINaz5xfwFkSnwuWE86UTChrEdTcGNjd/vC\n\tbAMCwuQTr2gxDJV9zyXEuuHXWQzUow==","X-Google-Smtp-Source":"ADKCNb5eZXxDkIQJiApzVtsPfxdwbN3dxTFU63PLhubGIO6rfagh70+DjYItoWA6Lht/ttrTaZGCHPGfPHXJNGda1GI=","X-Received":"by 10.202.72.146 with SMTP id v140mr1483656oia.308.1504670812756;\n\tTue, 05 Sep 2017 21:06:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504395174-15192-1-git-send-email-mayhs11saini@gmail.com>\n\t\n\t\n\t","From":"Shyam Saini ","Date":"Wed, 6 Sep 2017 09:36:52 +0530","Message-ID":"","Subject":"Re: [nft PATCH V2] tests: shell: Add tests for json import","To":"Arturo Borrero Gonzalez ","Cc":"Netfilter Development Mailing list ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]