[{"id":1762194,"web_url":"http://patchwork.ozlabs.org/comment/1762194/","msgid":"<20170902231252.44d10e64@windsurf.lan>","list_archive_url":null,"date":"2017-09-02T21:12:52","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Sat,  2 Sep 2017 22:54:19 +0200, Romain Naour wrote:\n> This doesn't compile with glibc 2.26 where reallocarray() as been introduced.\n> \n> Fixes:\n> stage1flex-misc.o: In function `allocate_array':\n> misc.c:(.text+0x38f): undefined reference to `reallocarray'\n> stage1flex-misc.o: In function `reallocate_array':\n> misc.c:(.text+0xc8a): undefined reference to `reallocarray'\n> collect2: error: ld returned 1 exit status\n\nThis commit log is a bit mysterious: if reallocarray() has been\nintroduced in glibc 2.26, why isn't flex able to use it ?\n\nThomas","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl8364TKwz9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 07:13:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D31DE86DE7;\n\tSat,  2 Sep 2017 21:13:04 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4fnzuyVIic4p; Sat,  2 Sep 2017 21:12:59 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2CD6D86C04;\n\tSat,  2 Sep 2017 21:12:59 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7EDC41C1539\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:12:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C5BA72EC14\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:12:52 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1ufThG4eyfdf for <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:12:50 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby silver.osuosl.org (Postfix) with ESMTP id 79B402694E\n\tfor <buildroot@buildroot.org>; Sat,  2 Sep 2017 21:12:50 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 737B0209FD; Sat,  2 Sep 2017 23:12:53 +0200 (CEST)","from windsurf.lan (unknown [185.94.29.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 31876209CB;\n\tSat,  2 Sep 2017 23:12:53 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 2 Sep 2017 23:12:52 +0200","From":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","To":"Romain Naour <romain.naour@gmail.com>","Message-ID":"<20170902231252.44d10e64@windsurf.lan>","In-Reply-To":"<20170902205423.21288-8-romain.naour@gmail.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1762201,"web_url":"http://patchwork.ozlabs.org/comment/1762201/","msgid":"<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>","list_archive_url":null,"date":"2017-09-02T22:23:40","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Thomas,\n\nLe 02/09/2017 à 23:12, Thomas Petazzoni a écrit :\n> Hello,\n> \n> On Sat,  2 Sep 2017 22:54:19 +0200, Romain Naour wrote:\n>> This doesn't compile with glibc 2.26 where reallocarray() as been introduced.\n>>\n>> Fixes:\n>> stage1flex-misc.o: In function `allocate_array':\n>> misc.c:(.text+0x38f): undefined reference to `reallocarray'\n>> stage1flex-misc.o: In function `reallocate_array':\n>> misc.c:(.text+0xc8a): undefined reference to `reallocarray'\n>> collect2: error: ld returned 1 exit status\n> \n> This commit log is a bit mysterious: if reallocarray() has been\n> introduced in glibc 2.26, why isn't flex able to use it ?\n\nIt's a nasty issue, when reallocarray() is available for the target, flex will\nbuild a small tool called stage1flex for the host (using _FOR_BUILD) but with\nthe config.h generated for the target.\n\nMy host doesn't have glibc 2.26, so reallocarray() is never defined while\nbuilding stage1flex:\n\nmisc.c:147:8: warning : implicit declaration of function « reallocarray »\n[-Wimplicit-function-declaration]\n  mem = reallocarray(NULL, (size_t) size, element_size);\n        ^~~~~~~~~~~~\nmisc.c:147:6: warning : assignment makes pointer from integer without a cast\n[-Wint-conversion]\n  mem = reallocarray(NULL, (size_t) size, element_size);\n      ^\n\nI don't know how to fix this, except by disabling reallocarray() for the target...\n\nBest regards,\nRomain\n\n> \n> Thomas\n>","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JZ5QflN0\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl9cn6s2Qz9sPs\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 08:23:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B4A2E88C3A;\n\tSat,  2 Sep 2017 22:23:47 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tr6eD38yPPIZ; Sat,  2 Sep 2017 22:23:45 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B57B488C2F;\n\tSat,  2 Sep 2017 22:23:45 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4D9461C15D4\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 22:23:44 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8563024ED5\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 22:23:39 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R+XYAgrY82eB for <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 22:23:39 +0000 (UTC)","from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C572322F4C\n\tfor <buildroot@buildroot.org>; Sat,  2 Sep 2017 22:23:38 +0000 (UTC)","by mail-wm0-f47.google.com with SMTP id v2so17360558wmf.0\n\tfor <buildroot@buildroot.org>; Sat, 02 Sep 2017 15:23:43 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tf65sm3492815wmd.41.2017.09.02.15.23.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 15:23:41 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=aZLS+rBmzIfln6g+k5+YVGV5Cv917mizwGlIMFS6DLo=;\n\tb=JZ5QflN05IkI/WqxXTXfkveCkspcuddnnUM7MguUmvm2bDSduJ8a0yHAopWcQzUQYL\n\tkryM+LelEqvMgu46TtPQjgkZo5PqxMniiz8chMdSUeq6fvVpF1kAt+N6G0Xrknt+evX7\n\tcNZlgleTLg/sIHcAdNXFr1Pwjn3W7f2pBq1U0K/Kkn55BPvY0JlTVusN3B1HwfUKMhhW\n\tk1ZTuaPnx6hqElfU+DxRnAkC85LYRzeJK4ugjVI8rve8QNWBDnlavLLiVKiQiD6qm1SS\n\tcmYpYIaei/GffWYDPkRnPVJe0H19aJ0apmql76k1s+QRcwYQvKhRKdTIGKRioDHNVNMs\n\tt5rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=aZLS+rBmzIfln6g+k5+YVGV5Cv917mizwGlIMFS6DLo=;\n\tb=M/T3pe2OHfkw83mhYGEN7XRR/FFxKLJWzTeB/GykuDcuE1ywGdsz0yr7ASxUi5ImTB\n\tVT7dCz9HAq4+3XE30yvG6Wz/+ITn0mQoZAQgMHxWIkOHiFA9BwdWBMIq4o/IZFxZ6kkz\n\tPkycRjCS9f1dt/aokzz1aSzRTyl5aEZaQbAy0TEfsm2r5U9YC+bj4QOgAe0iKqikUAOL\n\tFAabo1+zWs1F//UDoM8UKjtAXX4nslE4CxKdq8ZGCVOs3A2mu8WrBi82/T6FSzqcGoyS\n\ti5ysCOzHLXU2TbjEo9gdUhBILllPHFNYbvrB8+PF5+fcjVDPTNKvOn7ouU7vfCdQU5iu\n\tr31Q==","X-Gm-Message-State":"AHPjjUijwQywQf/GbIhRjHsNmXTifYpf+ljVRrplt1IDPJ2lXa8djkxi\n\tw/k57BWOyATIii3jI6A=","X-Google-Smtp-Source":"ADKCNb73m1FroauaJyQrFjyiJ2ub6KSSWmpIGnWltGN1OFsTtYLj21lsTIhddkx5laG+G5PSzYamXg==","X-Received":"by 10.28.29.149 with SMTP id d143mr1200837wmd.175.1504391021633; \n\tSat, 02 Sep 2017 15:23:41 -0700 (PDT)","To":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>","From":"Romain Naour <romain.naour@gmail.com>","Message-ID":"<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>","Date":"Sun, 3 Sep 2017 00:23:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170902231252.44d10e64@windsurf.lan>","Content-Language":"en-US","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1762233,"web_url":"http://patchwork.ozlabs.org/comment/1762233/","msgid":"<20170903091432.659bd28f@windsurf.lan>","list_archive_url":null,"date":"2017-09-03T07:14:32","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n\n> > This commit log is a bit mysterious: if reallocarray() has been\n> > introduced in glibc 2.26, why isn't flex able to use it ?  \n> \n> It's a nasty issue, when reallocarray() is available for the target, flex will\n> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n> the config.h generated for the target.\n> \n> My host doesn't have glibc 2.26, so reallocarray() is never defined while\n> building stage1flex:\n> \n> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n> [-Wimplicit-function-declaration]\n>   mem = reallocarray(NULL, (size_t) size, element_size);\n>         ^~~~~~~~~~~~\n> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n> [-Wint-conversion]\n>   mem = reallocarray(NULL, (size_t) size, element_size);\n>       ^\n> \n> I don't know how to fix this, except by disabling reallocarray() for the target...\n\nThis should all be explained in the commit log, and a short comment in\nflex.mk should be added as well.\n\nGenerally speaking, the commit logs in this series are too terse: they\njust say \"fix build with glibc 2.26\" with no explanations, or they\nbackport some seemingly random glibc patches, without explaining why\nthey are needed. Could you improve this a bit ?\n\nThanks a lot!\n\nThomas","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlSm96tbvz9s71\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 19:46:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C32486906;\n\tSun,  3 Sep 2017 09:46:15 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y2JwA6zaxlVc; Sun,  3 Sep 2017 09:46:12 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 65CDD86914;\n\tSun,  3 Sep 2017 09:46:12 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2E0BD1C41C7\n\tfor <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 09:46:10 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 26B9C86F9B\n\tfor <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 09:46:10 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JKHUIIBGY+77 for <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 09:46:08 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AE3F8821AB\n\tfor <buildroot@buildroot.org>; Sun,  3 Sep 2017 09:46:08 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 866A220832; Sun,  3 Sep 2017 11:46:06 +0200 (CEST)","from windsurf.lan (unknown [185.94.29.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 40BAD20800;\n\tSun,  3 Sep 2017 11:46:06 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sun, 3 Sep 2017 09:14:32 +0200","From":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","To":"Romain Naour <romain.naour@gmail.com>","Message-ID":"<20170903091432.659bd28f@windsurf.lan>","In-Reply-To":"<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1764954,"web_url":"http://patchwork.ozlabs.org/comment/1764954/","msgid":"<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>","list_archive_url":null,"date":"2017-09-07T21:32:41","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Hi Thomas,\n\nLe 03/09/2017 à 09:14, Thomas Petazzoni a écrit :\n> Hello,\n> \n> On Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n> \n>>> This commit log is a bit mysterious: if reallocarray() has been\n>>> introduced in glibc 2.26, why isn't flex able to use it ?  \n>>\n>> It's a nasty issue, when reallocarray() is available for the target, flex will\n>> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n>> the config.h generated for the target.\n>>\n>> My host doesn't have glibc 2.26, so reallocarray() is never defined while\n>> building stage1flex:\n>>\n>> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n>> [-Wimplicit-function-declaration]\n>>   mem = reallocarray(NULL, (size_t) size, element_size);\n>>         ^~~~~~~~~~~~\n>> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n>> [-Wint-conversion]\n>>   mem = reallocarray(NULL, (size_t) size, element_size);\n>>       ^\n>>\n>> I don't know how to fix this, except by disabling reallocarray() for the target...\n> \n> This should all be explained in the commit log, and a short comment in\n> flex.mk should be added as well.\n\nActually I looked further into this issue after sending the patch.\n\n> \n> Generally speaking, the commit logs in this series are too terse: they\n> just say \"fix build with glibc 2.26\" with no explanations, or they\n> backport some seemingly random glibc patches, without explaining why\n> they are needed. Could you improve this a bit ?\n\nWell, the glibc bump is more complicated than expected and I need to spent more\ntime on it to understand what's going on...\n\nAt least we have a link to the upstream reference as a starting point.\nOk, this patch is really too terse, I added it just before sending the series :-/\n\nI'll try to continue this week-end.\n\nBest regards,\nRomain\n\n> \n> Thanks a lot!\n> \n> Thomas\n>","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FXEnkiqP\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpDFf45DQz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  8 Sep 2017 07:32:54 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 01AEA89612;\n\tThu,  7 Sep 2017 21:32:49 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DgpfjP-6GTMY; Thu,  7 Sep 2017 21:32:47 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1690A8981C;\n\tThu,  7 Sep 2017 21:32:47 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C4A931C3F85\n\tfor <buildroot@lists.busybox.net>;\n\tThu,  7 Sep 2017 21:32:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BDF66272D4\n\tfor <buildroot@lists.busybox.net>;\n\tThu,  7 Sep 2017 21:32:45 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YvIGAVgIsRfF for <buildroot@lists.busybox.net>;\n\tThu,  7 Sep 2017 21:32:45 +0000 (UTC)","from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 15E47271CA\n\tfor <buildroot@buildroot.org>; Thu,  7 Sep 2017 21:32:45 +0000 (UTC)","by mail-wr0-f193.google.com with SMTP id p37so398179wrb.5\n\tfor <buildroot@buildroot.org>; Thu, 07 Sep 2017 14:32:45 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\t29sm419837wrz.77.2017.09.07.14.32.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Sep 2017 14:32:42 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=V53YA1XkjaPADFZvVEAaH/TcP21kDWjxV2GYJoX9sUc=;\n\tb=FXEnkiqP/TmONc1ks4zn8bBzPqZ+xu5iMaSICqxMqfjAAppD+2/tMnoo7ENi4mVbg0\n\tpPA+9Sl4s8amtPYtK1jaQrFgDFylB6PIFYMlSCxhY12OSpsPyuPpYYqpkSag6MqdEBIw\n\tWteczBzcKORmgGorR8w2VvZdF4QNRFn3PiRLhJc0bsqgZtfgB0R4710M0IX8yG1XYHXx\n\tipoDLIDJShMmHj41nhT1KW/92MntRrfewxYWmbBwAaKmAOpkBgry2qTZIkkii545RoEF\n\tYtJrXpRy8v+NBoET9OugoOLZO46+Q0ffZsrX0BirW1Zab4BiM4PTXZZFCAA0zKieJk3n\n\tWGbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=V53YA1XkjaPADFZvVEAaH/TcP21kDWjxV2GYJoX9sUc=;\n\tb=oZ85uYYNtd3VBmSmLZ5epgaLkpM5VUPFSlQoKl9enXV2gHMMmDusIQWGFND1Ys4KRV\n\tBFGTPHvXWg0WGpLHUey6yLULPl2h6jB1KuHuViPTQrzaDx6RqnYdlXGO7fNDga2E+qlS\n\tCmdKjzyWRsaJViAXUvgXpH3algVF5FPeCp4K565g+cYIz9N/am6rBclqpqZfE2Jkfazf\n\tklXSwvyCBrhw2kqpyU9QW24vkjRA7Jfei91dx/h7vVN5K0QRk9rqFqi9Xbrv6KklJRjN\n\ti+qJsY6rpJs933k2rhIAy3ozYJ3SQgXsP187PTtEoCkwaOwYzrsDGDJm8bsjo8D/G63M\n\t4yVg==","X-Gm-Message-State":"AHPjjUhRb3CTAMzd7Ru+mwAkMEz8uFfmgmGk6kU32MgunGRuK1WgYD+M\n\tQR8OWewQEUllE+gsCgo=","X-Google-Smtp-Source":"ADKCNb5CkiGdMznlEG8tByLAc2YgJfCSNlILU91Ab0PVtwflZLNMnl8xpgfQupIRrEm9emF6dMS5nA==","X-Received":"by 10.223.128.137 with SMTP id 9mr545815wrl.235.1504819963105;\n\tThu, 07 Sep 2017 14:32:43 -0700 (PDT)","To":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>\n\t<20170903091432.659bd28f@windsurf.lan>","From":"Romain Naour <romain.naour@gmail.com>","Message-ID":"<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>","Date":"Thu, 7 Sep 2017 23:32:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170903091432.659bd28f@windsurf.lan>","Content-Language":"en-US","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1768083,"web_url":"http://patchwork.ozlabs.org/comment/1768083/","msgid":"<1505328815.3138.1.camel@embedded.rocks>","list_archive_url":null,"date":"2017-09-13T18:53:35","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":65665,"url":"http://patchwork.ozlabs.org/api/people/65665/","name":"Jörg Krause","email":"joerg.krause@embedded.rocks"},"content":"Hi,\n\nOn Thu, 2017-09-07 at 23:32 +0200, Romain Naour wrote:\n> Hi Thomas,\n> \n> Le 03/09/2017 à 09:14, Thomas Petazzoni a écrit :\n> > Hello,\n> > \n> > On Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n> > \n> > > > This commit log is a bit mysterious: if reallocarray() has been\n> > > > introduced in glibc 2.26, why isn't flex able to use it ?  \n> > > \n> > > It's a nasty issue, when reallocarray() is available for the target, flex will\n> > > build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n> > > the config.h generated for the target.\n> > > \n> > > My host doesn't have glibc 2.26, so reallocarray() is never defined while\n> > > building stage1flex:\n> > > \n> > > misc.c:147:8: warning : implicit declaration of function « reallocarray »\n> > > [-Wimplicit-function-declaration]\n> > >   mem = reallocarray(NULL, (size_t) size, element_size);\n> > >         ^~~~~~~~~~~~\n> > > misc.c:147:6: warning : assignment makes pointer from integer without a cast\n> > > [-Wint-conversion]\n> > >   mem = reallocarray(NULL, (size_t) size, element_size);\n> > >       ^\n> > > \n> > > I don't know how to fix this, except by disabling reallocarray() for the target...\n> > \n> > This should all be explained in the commit log, and a short comment in\n> > flex.mk should be added as well.\n> \n> Actually I looked further into this issue after sending the patch.\n> \n> > \n> > Generally speaking, the commit logs in this series are too terse: they\n> > just say \"fix build with glibc 2.26\" with no explanations, or they\n> > backport some seemingly random glibc patches, without explaining why\n> > they are needed. Could you improve this a bit ?\n> \n> Well, the glibc bump is more complicated than expected and I need to spent more\n> time on it to understand what's going on...\n> \n> At least we have a link to the upstream reference as a starting point.\n> Ok, this patch is really too terse, I added it just before sending the series :-/\n> \n> I'll try to continue this week-end.\n\nFixed upstream:\nhttps://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3d\nf2f6380\n\nMeanwhile, another patch was provided:\nhttp://patchwork.ozlabs.org/patch/813474/\n\nBest regards,\nJörg Krause","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsrRK19TWz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 04:53:49 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 34D3D88FBC;\n\tWed, 13 Sep 2017 18:53:46 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XcK9pQmF5DL6; Wed, 13 Sep 2017 18:53:44 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 60826889F6;\n\tWed, 13 Sep 2017 18:53:44 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C03891C059E\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 18:53:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B659030CD5\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 18:53:42 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nKat3pYgHNDO for <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 18:53:41 +0000 (UTC)","from mout02.posteo.de (mout02.posteo.de [185.67.36.142])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 6DA2030BB7\n\tfor <buildroot@buildroot.org>; Wed, 13 Sep 2017 18:53:41 +0000 (UTC)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 3xsrR608zZz10Hm;\n\tWed, 13 Sep 2017 20:53:37 +0200 (CEST)","from mail.embedded.rocks ([127.0.0.1])\n\tby localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new,\n\tport 10025)\n\twith ESMTP id jfT99CPYYyP2; Wed, 13 Sep 2017 20:53:35 +0200 (CEST)","from nzxt.fritz.box (port-92-195-68-97.dynamic.qsc.de\n\t[92.195.68.97]) (Authenticated sender: joerg.krause@embedded.rocks)\n\tby mail.embedded.rocks (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 20:53:35 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Message-ID":"<1505328815.3138.1.camel@embedded.rocks>","From":"=?iso-8859-1?q?J=F6rg?= Krause <joerg.krause@embedded.rocks>","To":"Romain Naour <romain.naour@gmail.com>, Thomas Petazzoni\n\t<thomas.petazzoni@free-electrons.com>","Date":"Wed, 13 Sep 2017 20:53:35 +0200","In-Reply-To":"<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>\n\t<20170903091432.659bd28f@windsurf.lan>\n\t<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>","Organization":"Embedded Rocks","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1768108,"web_url":"http://patchwork.ozlabs.org/comment/1768108/","msgid":"<26528000-6f59-01d7-72bf-c0d1ed2a530a@gmail.com>","list_archive_url":null,"date":"2017-09-13T19:54:31","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Hi Jörg,\n\nLe 13/09/2017 à 20:53, Jörg Krause a écrit :\n> Hi,\n> \n> On Thu, 2017-09-07 at 23:32 +0200, Romain Naour wrote:\n>> Hi Thomas,\n>>\n>> Le 03/09/2017 à 09:14, Thomas Petazzoni a écrit :\n>>> Hello,\n>>>\n>>> On Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n>>>\n>>>>> This commit log is a bit mysterious: if reallocarray() has been\n>>>>> introduced in glibc 2.26, why isn't flex able to use it ?  \n>>>>\n>>>> It's a nasty issue, when reallocarray() is available for the target, flex will\n>>>> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n>>>> the config.h generated for the target.\n>>>>\n>>>> My host doesn't have glibc 2.26, so reallocarray() is never defined while\n>>>> building stage1flex:\n>>>>\n>>>> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n>>>> [-Wimplicit-function-declaration]\n>>>>   mem = reallocarray(NULL, (size_t) size, element_size);\n>>>>         ^~~~~~~~~~~~\n>>>> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n>>>> [-Wint-conversion]\n>>>>   mem = reallocarray(NULL, (size_t) size, element_size);\n>>>>       ^\n>>>>\n>>>> I don't know how to fix this, except by disabling reallocarray() for the target...\n>>>\n>>> This should all be explained in the commit log, and a short comment in\n>>> flex.mk should be added as well.\n>>\n>> Actually I looked further into this issue after sending the patch.\n>>\n>>>\n>>> Generally speaking, the commit logs in this series are too terse: they\n>>> just say \"fix build with glibc 2.26\" with no explanations, or they\n>>> backport some seemingly random glibc patches, without explaining why\n>>> they are needed. Could you improve this a bit ?\n>>\n>> Well, the glibc bump is more complicated than expected and I need to spent more\n>> time on it to understand what's going on...\n>>\n>> At least we have a link to the upstream reference as a starting point.\n>> Ok, this patch is really too terse, I added it just before sending the series :-/\n>>\n>> I'll try to continue this week-end.\n> \n> Fixed upstream:\n> https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3d\n> f2f6380\n> \n> Meanwhile, another patch was provided:\n> http://patchwork.ozlabs.org/patch/813474/\n\nTanks for the link but this is a different issue.\n\nThe issue reported here is when the toolchain provide glibc 2.26 and the host\nuse an older glibc version which doesn't provide reallocarray().\n\nThe issue reported by Adrian is when glibc 2.26 is installed on the host.\n\nSadly, the patch provided by Adrian doesn't fix this issue.\n\nBest regards,\nRomain\n\n> \n> Best regards,\n> Jörg Krause\n>","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"etaS5omt\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xssnc24y1z9s72\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 05:54:43 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4E71C30DC6;\n\tWed, 13 Sep 2017 19:54:40 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qt222+55G4hw; Wed, 13 Sep 2017 19:54:38 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 750B630DC1;\n\tWed, 13 Sep 2017 19:54:38 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DB1451CEB72\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 19:54:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D421C8A616\n\tfor <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 19:54:36 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bzEUkfCheelV for <buildroot@lists.busybox.net>;\n\tWed, 13 Sep 2017 19:54:36 +0000 (UTC)","from mail-wr0-f194.google.com (mail-wr0-f194.google.com\n\t[209.85.128.194])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id AA1D78A607\n\tfor <buildroot@buildroot.org>; Wed, 13 Sep 2017 19:54:35 +0000 (UTC)","by mail-wr0-f194.google.com with SMTP id p37so590102wrb.5\n\tfor <buildroot@buildroot.org>; Wed, 13 Sep 2017 12:54:35 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\tc83sm1261652wmd.2.2017.09.13.12.54.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 12:54:33 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=PkVAy8JKD4//JyKp91HqRUeaGzpj0+DOFnZhPTpKSIY=;\n\tb=etaS5omtEhs/ElfOiRvwYXhuUusUsqCnq8xGHm5/l9jXGjZTH68QZbuXONbSCIfaJF\n\t8ll1szTO7duA72WtN/YY5d5cdPLU2zCKcVfe/Fw7r6/scO2g8z+RtBdjnZkvtJRShZPt\n\tZdKyvRIQgv495wa7slPnOicoyt8FZpljQF+UC8KjsyFGK2oBCZiVUV96HbvHbmdyH6a8\n\ty9sDON3JpZ2rpzblOZ6YwWJvmLass7hKSJOHoENo4FwTzWyD9ddIQOr2kAJkKJ8P2+FJ\n\t5X8hAW+hMlr/oD2ME2z5BKOCcbhf3YoZ8h6HnIbkqjL58JvMa6ETYRw6URhoMzOlJi7Z\n\tWyIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=PkVAy8JKD4//JyKp91HqRUeaGzpj0+DOFnZhPTpKSIY=;\n\tb=DnhJbE2XxPNsiZWq1BgRF6oOnqqpyvKGsps2iLnlxf9QJnNb69fs6bR5i9xjSsQFrc\n\tKNDFHFaWhQxK4qjeM748k5qo5Wf1VDaZg70J8arKubIks8EQjitpvJOFWCTfy19Hhke5\n\txglBzJ5dou8CVHqVP4uxzRMt+q74j6KNUdtNfB9bXmd1ktmgWfXEuSYraxp/iow+P81s\n\tEfCTLChsiwDZcXwiEDbnX22ajJM0v3N5GC5N8bqMan6iGjKslSwMeUmbYhz0NkTIKxqo\n\tq09koskPCo7Q173jfhpGqABRYn5A+ViyxaYEQfOSzVae8oKceE/Q6bAIY/T7WkczUVwk\n\tK4ZA==","X-Gm-Message-State":"AHPjjUj6+hibRE16hZ8gbo6Wu9HZVgNPl4EkPG/vvFyOm7Jz7wqDW/4T\n\tNQOJP9lqmdB+/w77efI=","X-Google-Smtp-Source":"ADKCNb6gf2Hc/ewBEmxjWX+fqu5BAanDKleJl/1DiDSSC5tT5cpIgv+kcPs33zcnjk5IjFb+udp+aw==","X-Received":"by 10.223.182.166 with SMTP id j38mr18066910wre.55.1505332473547;\n\tWed, 13 Sep 2017 12:54:33 -0700 (PDT)","To":"=?utf-8?q?J=C3=B6rg_Krause?= <joerg.krause@embedded.rocks>,\n\tThomas Petazzoni <thomas.petazzoni@free-electrons.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>\n\t<20170903091432.659bd28f@windsurf.lan>\n\t<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>\n\t<1505328815.3138.1.camel@embedded.rocks>","From":"Romain Naour <romain.naour@gmail.com>","Message-ID":"<26528000-6f59-01d7-72bf-c0d1ed2a530a@gmail.com>","Date":"Wed, 13 Sep 2017 21:54:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505328815.3138.1.camel@embedded.rocks>","Content-Language":"en-US","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1768416,"web_url":"http://patchwork.ozlabs.org/comment/1768416/","msgid":"<20170914112527.GC18779@momiji>","list_archive_url":null,"date":"2017-09-14T08:25:27","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":71810,"url":"http://patchwork.ozlabs.org/api/people/71810/","name":"Adrian Perez de Castro","email":"aperez@igalia.com"},"content":"Hi everybody,\n\nOn Wed, 13 Sep 2017 21:54:31 +0200, Romain Naour <romain.naour@gmail.com> wrote:\n> Hi Jörg,\n> \n> Le 13/09/2017 à 20:53, Jörg Krause a écrit :\n> > Hi,\n> > \n> > On Thu, 2017-09-07 at 23:32 +0200, Romain Naour wrote:\n> >> Hi Thomas,\n> >>\n> >> Le 03/09/2017 à 09:14, Thomas Petazzoni a écrit :\n> >>> Hello,\n> >>>\n> >>> On Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n> >>>\n> >>>>> This commit log is a bit mysterious: if reallocarray() has been\n> >>>>> introduced in glibc 2.26, why isn't flex able to use it ?  \n> >>>>\n> >>>> It's a nasty issue, when reallocarray() is available for the target, flex will\n> >>>> build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n> >>>> the config.h generated for the target.\n> >>>>\n> >>>> My host doesn't have glibc 2.26, so reallocarray() is never defined while\n> >>>> building stage1flex:\n> >>>>\n> >>>> misc.c:147:8: warning : implicit declaration of function « reallocarray »\n> >>>> [-Wimplicit-function-declaration]\n> >>>>   mem = reallocarray(NULL, (size_t) size, element_size);\n> >>>>         ^~~~~~~~~~~~\n> >>>> misc.c:147:6: warning : assignment makes pointer from integer without a cast\n> >>>> [-Wint-conversion]\n> >>>>   mem = reallocarray(NULL, (size_t) size, element_size);\n> >>>>       ^\n> >>>>\n> >>>> I don't know how to fix this, except by disabling reallocarray() for the target...\n> >>>\n> >>> This should all be explained in the commit log, and a short comment in\n> >>> flex.mk should be added as well.\n> >>\n> >> Actually I looked further into this issue after sending the patch.\n> >>\n> >>>\n> >>> Generally speaking, the commit logs in this series are too terse: they\n> >>> just say \"fix build with glibc 2.26\" with no explanations, or they\n> >>> backport some seemingly random glibc patches, without explaining why\n> >>> they are needed. Could you improve this a bit ?\n> >>\n> >> Well, the glibc bump is more complicated than expected and I need to spent more\n> >> time on it to understand what's going on...\n> >>\n> >> At least we have a link to the upstream reference as a starting point.\n> >> Ok, this patch is really too terse, I added it just before sending the series :-/\n> >>\n> >> I'll try to continue this week-end.\n> > \n> > Fixed upstream:\n> > https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3d\n> > f2f6380\n> > \n> > Meanwhile, another patch was provided:\n> > http://patchwork.ozlabs.org/patch/813474/\n> \n> Tanks for the link but this is a different issue.\n> \n> The issue reported here is when the toolchain provide glibc 2.26 and the host\n> use an older glibc version which doesn't provide reallocarray().\n> \n> The issue reported by Adrian is when glibc 2.26 is installed on the host.\n\nThis is correct, I've hit the host-has-2.26 issue.\n\n> Sadly, the patch provided by Adrian doesn't fix this issue.\n\nThat's right as well. I remembered seeing Romain's patch flying by the mailing\nlist, so I took a look at it and it seemed to me like it would not fix my\nbuild issue for “host-flex”.\n\nI think we need *both* patches:\n\n - Romain's fixes building “flex” when Buildroot has glibc 2.26 and the host\n   has any libc which does not have reallocarray().\n\n - Mine fixes building “host-flex” when the host has glibc 2.26, regardless\n   if the libc being built by Buildroot.\n\nIs there anything preventing both from being merged? Would it be useful if\nwe tried to merge both patches?\n\nBest regards,\n\n\n--\n Adrián 🎩","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"afcc5v4g\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtBSQ4Jknz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 18:25:58 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2570B30F87;\n\tThu, 14 Sep 2017 08:25:56 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id glsneNRQNqpx; Thu, 14 Sep 2017 08:25:54 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5644230F84;\n\tThu, 14 Sep 2017 08:25:54 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 569C71C219A\n\tfor <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 08:25:53 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 51352887EE\n\tfor <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 08:25:53 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id glzH2-Ej62jz for <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 08:25:51 +0000 (UTC)","from fanzine.igalia.com (fanzine.igalia.com [91.117.99.155])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id D79A68878D\n\tfor <buildroot@buildroot.org>; Thu, 14 Sep 2017 08:25:50 +0000 (UTC)","from [194.100.51.2] (helo=momiji) by fanzine.igalia.com with\n\tesmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim)\n\tid 1dsPT0-0007Bw-Eb; Thu, 14 Sep 2017 10:25:46 +0200","from localhost (momiji [local])\n\tby momiji (OpenSMTPD) with ESMTPA id aa6689a6;\n\tThu, 14 Sep 2017 08:25:31 +0000 (UTC)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; \n\th=Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date;\n\tbh=KXxmpJlURZZ5bYghGMgZcTbohXnuaOCBYW37M5GSbz0=; \n\tb=afcc5v4g0Wx+bEBHI6HC166uLwuHD6l1U4lFdMZn687rofGI7R57OCVQ32Z5RAyzLeZ+m5COBD4//g0UpA4AFiQGSl2gfu8KNC/Q+V3Xl6pClHDITCar+5wC7Z+EMntUdWCXtfYB/6uIKVnDGffVcJTwVg0QveU+AXVwjB2I3oShgTpC6LY+lkqDN2z1gFYwVcotF4W7nLfxCPV5YjLCR76H3ZeF9XVeWQCYUdjFuXVKQGKH+6OJAYF2r4WwAsIaNnW0ttaTcPXaF9J7+KZEstebrJxPxxeMzJK9NdvSVvruiWP/vuImlWLFHC/C3udD1jFiLBwm6unkLOgCiOjFMQ==;","Date":"Thu, 14 Sep 2017 11:25:27 +0300","Message-ID":"<20170914112527.GC18779@momiji>","From":"Adrian Perez de Castro <aperez@igalia.com>","To":"=?utf-8?b?SsO2cmc=?= Krause <joerg.krause@embedded.rocks>,\n\tThomas Petazzoni <thomas.petazzoni@free-electrons.com>","In-Reply-To":"<26528000-6f59-01d7-72bf-c0d1ed2a530a@gmail.com>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>\n\t<20170903091432.659bd28f@windsurf.lan>\n\t<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>\n\t<1505328815.3138.1.camel@embedded.rocks>\n\t<26528000-6f59-01d7-72bf-c0d1ed2a530a@gmail.com>","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============8636155414789187925==\"","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1768503,"web_url":"http://patchwork.ozlabs.org/comment/1768503/","msgid":"<1505386264.12802.8.camel@embedded.rocks>","list_archive_url":null,"date":"2017-09-14T10:51:04","subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","submitter":{"id":65665,"url":"http://patchwork.ozlabs.org/api/people/65665/","name":"Jörg Krause","email":"joerg.krause@embedded.rocks"},"content":"On Thu, 2017-09-14 at 11:25 +0300, Adrian Perez de Castro wrote:\n> Hi everybody,\n> \n> On Wed, 13 Sep 2017 21:54:31 +0200, Romain Naour <romain.naour@gmail.com> wrote:\n> > Hi Jörg,\n> > \n> > Le 13/09/2017 à 20:53, Jörg Krause a écrit :\n> > > Hi,\n> > > \n> > > On Thu, 2017-09-07 at 23:32 +0200, Romain Naour wrote:\n> > > > Hi Thomas,\n> > > > \n> > > > Le 03/09/2017 à 09:14, Thomas Petazzoni a écrit :\n> > > > > Hello,\n> > > > > \n> > > > > On Sun, 3 Sep 2017 00:23:40 +0200, Romain Naour wrote:\n> > > > > \n> > > > > > > This commit log is a bit mysterious: if reallocarray() has been\n> > > > > > > introduced in glibc 2.26, why isn't flex able to use it ?  \n> > > > > > \n> > > > > > It's a nasty issue, when reallocarray() is available for the target, flex will\n> > > > > > build a small tool called stage1flex for the host (using _FOR_BUILD) but with\n> > > > > > the config.h generated for the target.\n> > > > > > \n> > > > > > My host doesn't have glibc 2.26, so reallocarray() is never defined while\n> > > > > > building stage1flex:\n> > > > > > \n> > > > > > misc.c:147:8: warning : implicit declaration of function « reallocarray »\n> > > > > > [-Wimplicit-function-declaration]\n> > > > > >   mem = reallocarray(NULL, (size_t) size, element_size);\n> > > > > >         ^~~~~~~~~~~~\n> > > > > > misc.c:147:6: warning : assignment makes pointer from integer without a cast\n> > > > > > [-Wint-conversion]\n> > > > > >   mem = reallocarray(NULL, (size_t) size, element_size);\n> > > > > >       ^\n> > > > > > \n> > > > > > I don't know how to fix this, except by disabling reallocarray() for the target...\n> > > > > \n> > > > > This should all be explained in the commit log, and a short comment in\n> > > > > flex.mk should be added as well.\n> > > > \n> > > > Actually I looked further into this issue after sending the patch.\n> > > > \n> > > > > \n> > > > > Generally speaking, the commit logs in this series are too terse: they\n> > > > > just say \"fix build with glibc 2.26\" with no explanations, or they\n> > > > > backport some seemingly random glibc patches, without explaining why\n> > > > > they are needed. Could you improve this a bit ?\n> > > > \n> > > > Well, the glibc bump is more complicated than expected and I need to spent more\n> > > > time on it to understand what's going on...\n> > > > \n> > > > At least we have a link to the upstream reference as a starting point.\n> > > > Ok, this patch is really too terse, I added it just before sending the series :-/\n> > > > \n> > > > I'll try to continue this week-end.\n> > > \n> > > Fixed upstream:\n> > > https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3d\n> > > f2f6380\n> > > \n> > > Meanwhile, another patch was provided:\n> > > http://patchwork.ozlabs.org/patch/813474/\n> > \n> > Tanks for the link but this is a different issue.\n> > \n> > The issue reported here is when the toolchain provide glibc 2.26 and the host\n> > use an older glibc version which doesn't provide reallocarray().\n> > \n> > The issue reported by Adrian is when glibc 2.26 is installed on the host.\n> \n> This is correct, I've hit the host-has-2.26 issue.\n> \n> > Sadly, the patch provided by Adrian doesn't fix this issue.\n> \n> That's right as well. I remembered seeing Romain's patch flying by the mailing\n> list, so I took a look at it and it seemed to me like it would not fix my\n> build issue for “host-flex”.\n> \n> I think we need *both* patches:\n> \n>  - Romain's fixes building “flex” when Buildroot has glibc 2.26 and the host\n>    has any libc which does not have reallocarray().\n> \n>  - Mine fixes building “host-flex” when the host has glibc 2.26, regardless\n>    if the libc being built by Buildroot.\n> \n> Is there anything preventing both from being merged? Would it be useful if\n> we tried to merge both patches?\n\nThe configure check for reallocarray includes the Buildroot\noutput/host/include directory, so it finds reallocarray if a Buildroot\ntoolchain with glibc 2.26 is used, despite of the host toolchains glibc\nversion:\n\n\"\"\"\nconfigure:20837: checking for reallocarray\nconfigure:20837: /usr/bin/gcc -o conftest -O2 -I$BUILDROOT/output/host/include -I$BUILDROOT/output/host/include -L$BUILDROOT/output/host/lib -Wl,-rpath,$BUILDROOT/output/host/lib conftest.c -lm  >&5\n\"\"\"\n\nBest regards,\nJörg Krause","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtFh95M9Fz9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 20:51:21 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 47E708AABD;\n\tThu, 14 Sep 2017 10:51:19 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UC3CKMzTo1vU; Thu, 14 Sep 2017 10:51:18 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CC9548AA1B;\n\tThu, 14 Sep 2017 10:51:17 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7BFED1C0DE1\n\tfor <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 10:51:16 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7715C89896\n\tfor <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 10:51:16 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VTjwcR291Pi7 for <buildroot@lists.busybox.net>;\n\tThu, 14 Sep 2017 10:51:12 +0000 (UTC)","from mout02.posteo.de (mout02.posteo.de [185.67.36.142])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BC1128980D\n\tfor <buildroot@buildroot.org>; Thu, 14 Sep 2017 10:51:11 +0000 (UTC)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 3xtFgv6Br7zypM;\n\tThu, 14 Sep 2017 12:51:07 +0200 (CEST)","from mail.embedded.rocks ([127.0.0.1])\n\tby localhost (mail.embedded.rocks [127.0.0.1]) (amavisd-new,\n\tport 10025)\n\twith ESMTP id Njdz4uBYsz6i; Thu, 14 Sep 2017 12:51:05 +0200 (CEST)","from nzxt.fritz.box (port-92-195-47-180.dynamic.qsc.de\n\t[92.195.47.180]) (Authenticated sender: joerg.krause@embedded.rocks)\n\tby mail.embedded.rocks (Postfix) with ESMTPSA;\n\tThu, 14 Sep 2017 12:51:05 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Message-ID":"<1505386264.12802.8.camel@embedded.rocks>","From":"=?iso-8859-1?q?J=F6rg?= Krause <joerg.krause@embedded.rocks>","To":"Adrian Perez de Castro <aperez@igalia.com>","Date":"Thu, 14 Sep 2017 12:51:04 +0200","In-Reply-To":"<20170914112527.GC18779@momiji>","References":"<20170902205423.21288-1-romain.naour@gmail.com>\n\t<20170902205423.21288-8-romain.naour@gmail.com>\n\t<20170902231252.44d10e64@windsurf.lan>\n\t<0425231e-af49-5b27-f5c1-bc6c91308839@gmail.com>\n\t<20170903091432.659bd28f@windsurf.lan>\n\t<8f568fb6-9ef3-39fc-ba2f-714f60dcd7be@gmail.com>\n\t<1505328815.3138.1.camel@embedded.rocks>\n\t<26528000-6f59-01d7-72bf-c0d1ed2a530a@gmail.com>\n\t<20170914112527.GC18779@momiji>","Organization":"Embedded Rocks","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tRomain Naour <romain.naour@gmail.com>, buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH v2 07/11] package/flex: disable reallocarray","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}}]