[{"id":1762275,"web_url":"http://patchwork.ozlabs.org/comment/1762275/","msgid":"<6bc19661-c4c5-5e47-a085-0844a349a37b@denx.de>","list_archive_url":null,"date":"2017-09-03T14:52:43","subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/02/2017 06:37 PM, Rob Clark wrote:\n> Want to re-use this in fat dirent iterator in next patch.\n> \n> Signed-off-by: Rob Clark \n\nReviewed-by: Łukasz Majewski \n\n> ---\n> fs/fat/fat.c | 73 +++++++++++++++++++++++++++++++++++------------------------\n> include/fat.h | 1 +\n> 2 files changed, 44 insertions(+), 30 deletions(-)\n> \n> diff --git a/fs/fat/fat.c b/fs/fat/fat.c\n> index 465a6875ed..e1c0a15dc7 100644\n> --- a/fs/fat/fat.c\n> +++ b/fs/fat/fat.c\n> @@ -808,35 +808,17 @@ exit:\n> \treturn ret;\n> }\n> \n> -__u8 do_fat_read_at_block[MAX_CLUSTSIZE]\n> -\t__aligned(ARCH_DMA_MINALIGN);\n> -\n> -int do_fat_read_at(const char *filename, loff_t pos, void *buffer,\n> -\t\t loff_t maxsize, int dols, int dogetsize, loff_t *size)\n> +static int get_fs_info(fsdata *mydata)\n> {\n> -\tchar fnamecopy[2048];\n> \tboot_sector bs;\n> \tvolume_info volinfo;\n> -\tfsdata datablock;\n> -\tfsdata *mydata = &datablock;\n> -\tdir_entry *dentptr = NULL;\n> -\t__u16 prevcksum = 0xffff;\n> -\tchar *subname = \"\";\n> -\t__u32 cursect;\n> -\tint idx, isdir = 0;\n> -\tint files = 0, dirs = 0;\n> -\tint ret = -1;\n> -\tint firsttime;\n> \t__u32 root_cluster = 0;\n> -\t__u32 read_blk;\n> -\tint rootdir_size = 0;\n> -\tint buffer_blk_cnt;\n> -\tint do_read;\n> -\t__u8 *dir_ptr;\n> +\tint ret;\n> \n> -\tif (read_bootsectandvi(&bs, &volinfo, &mydata->fatsize)) {\n> +\tret = read_bootsectandvi(&bs, &volinfo, &mydata->fatsize);\n> +\tif (ret) {\n> \t\tdebug(\"Error: reading boot sector\\n\");\n> -\t\treturn -1;\n> +\t\treturn ret;\n> \t}\n> \n> \tif (mydata->fatsize == 32) {\n> @@ -848,8 +830,7 @@ int do_fat_read_at(const char *filename, loff_t pos, void *buffer,\n> \n> \tmydata->fat_sect = bs.reserved;\n> \n> -\tcursect = mydata->rootdir_sect\n> -\t\t= mydata->fat_sect + mydata->fatlength * bs.fats;\n> +\tmydata->rootdir_sect = mydata->fat_sect + mydata->fatlength * bs.fats;\n> \n> \tmydata->sect_size = (bs.sector_size[1] << 8) + bs.sector_size[0];\n> \tmydata->clust_size = bs.cluster_size;\n> @@ -863,12 +844,12 @@ int do_fat_read_at(const char *filename, loff_t pos, void *buffer,\n> \t\tmydata->data_begin = mydata->rootdir_sect -\n> \t\t\t\t\t(mydata->clust_size * 2);\n> \t} else {\n> -\t\trootdir_size = ((bs.dir_entries[1] * (int)256 +\n> -\t\t\t\t bs.dir_entries[0]) *\n> -\t\t\t\t sizeof(dir_entry)) /\n> -\t\t\t\t mydata->sect_size;\n> +\t\tmydata->rootdir_size = ((bs.dir_entries[1] * (int)256 +\n> +\t\t\t\t\t bs.dir_entries[0]) *\n> +\t\t\t\t\t sizeof(dir_entry)) /\n> +\t\t\t\t\t mydata->sect_size;\n> \t\tmydata->data_begin = mydata->rootdir_sect +\n> -\t\t\t\t\trootdir_size -\n> +\t\t\t\t\tmydata->rootdir_size -\n> \t\t\t\t\t(mydata->clust_size * 2);\n> \t}\n> \n> @@ -893,6 +874,38 @@ int do_fat_read_at(const char *filename, loff_t pos, void *buffer,\n> \tdebug(\"Sector size: %d, cluster size: %d\\n\", mydata->sect_size,\n> \t mydata->clust_size);\n> \n> +\treturn 0;\n> +}\n> +\n> +__u8 do_fat_read_at_block[MAX_CLUSTSIZE]\n> +\t__aligned(ARCH_DMA_MINALIGN);\n> +\n> +int do_fat_read_at(const char *filename, loff_t pos, void *buffer,\n> +\t\t loff_t maxsize, int dols, int dogetsize, loff_t *size)\n> +{\n> +\tchar fnamecopy[2048];\n> +\tfsdata datablock;\n> +\tfsdata *mydata = &datablock;\n> +\tdir_entry *dentptr = NULL;\n> +\t__u16 prevcksum = 0xffff;\n> +\tchar *subname = \"\";\n> +\t__u32 cursect;\n> +\tint idx, isdir = 0;\n> +\tint files = 0, dirs = 0;\n> +\tint ret = -1;\n> +\tint firsttime;\n> +\t__u32 root_cluster = 0;\n> +\t__u32 read_blk;\n> +\tint rootdir_size = 0;\n> +\tint buffer_blk_cnt;\n> +\tint do_read;\n> +\t__u8 *dir_ptr;\n> +\n> +\tif (get_fs_info(mydata))\n> +\t\treturn -1;\n> +\n> +\tcursect = mydata->rootdir_sect;\n> +\n> \t/* \"cwd\" is always the root... */\n> \twhile (ISDIRDELIM(*filename))\n> \t\tfilename++;\n> diff --git a/include/fat.h b/include/fat.h\n> index 71879f01ca..6d3fc8e4a6 100644\n> --- a/include/fat.h\n> +++ b/include/fat.h\n> @@ -174,6 +174,7 @@ typedef struct {\n> \t__u16\tclust_size;\t/* Size of clusters in sectors */\n> \tint\tdata_begin;\t/* The sector of the first cluster, can be negative */\n> \tint\tfatbufnum;\t/* Used by get_fatent, init to -1 */\n> +\tint\trootdir_size;\n> } fsdata;\n> \n> typedef int\t(file_detectfs_func)(void);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlbYw1G9fz9s8J\n\tfor ;\n\tMon, 4 Sep 2017 00:52:52 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E754FC21E1C; Sun, 3 Sep 2017 14:52:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E1952C21C4F;\n\tSun, 3 Sep 2017 14:52:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 70019C21C4F; Sun, 3 Sep 2017 14:52:45 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 2D222C21C35\n\tfor ; Sun, 3 Sep 2017 14:52:45 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xlbYm6xn4z1qw7N;\n\tSun, 3 Sep 2017 16:52:44 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xlbYm5HYcz3hjkw;\n\tSun, 3 Sep 2017 16:52:44 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id wb4zBPRVqogz; Sun, 3 Sep 2017 16:52:43 +0200 (CEST)","from [192.168.2.222] (89-77-92-62.dynamic.chello.pl [89.77.92.62])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tSun, 3 Sep 2017 16:52:43 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"hIEmNHaWTEkpmbst9OL25414w7IE/qdnParYWdmpto8=","To":"Rob Clark ,\n\tU-Boot Mailing List ","References":"<20170902163806.27265-1-robdclark@gmail.com>\n\t<20170902163806.27265-2-robdclark@gmail.com>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<6bc19661-c4c5-5e47-a085-0844a349a37b@denx.de>","Date":"Sun, 3 Sep 2017 16:52:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170902163806.27265-2-robdclark@gmail.com>","Content-Language":"en-US","Cc":"Tien Fong Chee , Genevieve Chan ","Subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762291,"web_url":"http://patchwork.ozlabs.org/comment/1762291/","msgid":"","list_archive_url":null,"date":"2017-09-03T15:47:12","subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 3, 2017 at 10:52 AM, Łukasz Majewski wrote:\n> On 09/02/2017 06:37 PM, Rob Clark wrote:\n>>\n>> Want to re-use this in fat dirent iterator in next patch.\n>>\n>> Signed-off-by: Rob Clark \n>\n>\n> Reviewed-by: Łukasz Majewski \n>\n\nthanks\n\nbtw, is there some way to make get_maintainers.pl to find your\n@denx.de address instead of the @samsung address which bounces?\n(Sorry, I hadn't realized you had a new addr, so you were missed from\nCC on some of the patches, I think.)\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"grC86Vli\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlcmx3JxMz9t33\n\tfor ;\n\tMon, 4 Sep 2017 01:47:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 15F30C21EE3; Sun, 3 Sep 2017 15:47:17 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 85DB5C21D79;\n\tSun, 3 Sep 2017 15:47:15 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 12CBFC21D79; Sun, 3 Sep 2017 15:47:14 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 9C192C21D65\n\tfor ; Sun, 3 Sep 2017 15:47:13 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id o124so2379434lfo.1\n\tfor ; Sun, 03 Sep 2017 08:47:13 -0700 (PDT)","by 10.46.82.27 with HTTP; Sun, 3 Sep 2017 08:47:12 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=vaChUk0QZ9q/ujW9iW6eUZwnmABJiHISRw4vuDwW+bc=;\n\tb=grC86VlidaQ5AzE2GFaW78pzkCd2xUAs50qERe+487bQaEao/jGQ4CRy95jQ1bBpiG\n\thI/M0q0XHyh+XwBL/jhWuzDK1MMzLc61cWEYNuSjbMo7KHZm/nDRab2ZRulmxNInlKt4\n\tOfF2QttiHM2onBr5T0T6rzoFg8KwQMMZFObyeBo9mDxrHZtIt3IaAEroQGqRz4CNkvj4\n\t/kfFfRlDViHYM56ogNOfP1pz5vfFTLniUMxOC4Ybh9mmyWvRjVOP+BitSCacySBqkEkt\n\tZrTz85xp3afhHwEOKcT9wJTAY3zim31fXyd09d7MvbxBqienaKVHZMZZo+kkFQjloaBP\n\tQgew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=vaChUk0QZ9q/ujW9iW6eUZwnmABJiHISRw4vuDwW+bc=;\n\tb=eoXaSp8WxbogjoTJUO6xj/quwu5PkYDPuBqF58qft1KsOge2PhkQfk1TyCQJOBu4Qj\n\tjfZCATKZyPsikDCRNahkPae71PN80LkKdK+KClxCqOz6bcTIwcVGbfsJ/S26M3EDkavT\n\tYsMtMJeKItxyuc1djFa4N+j0NtW1fMxpfxyX1PHtapS72/X2AA+OTX3a91p2q0Kkgfza\n\tutCf6+NVHZ0po0S6Pt6Xl5vj9kQx9FixXzdoljrxomAJhdukkrzIqb5KOg8gD2578rva\n\tcFP98zp4wslaTw6e65LSq9XFvLpylmb3NZ5XQXmTrZXM6yVt01SC5VX6pV7K5qPQNZbV\n\tp/Aw==","X-Gm-Message-State":"AHPjjUhu7Mxm99qzXwrTsmCRcx7TXpG0r5eKaVnb7ZFzLKMsMbyd4uaS\n\tlGRVwwIXM0NgvvnJdLNZe2eyR2BLFw==","X-Google-Smtp-Source":"ADKCNb5EDvb++7IWeGnAMUXxF8B42rAzTE+wHQkAGc5yfkX6fbO59qKHgUQsH90LePcwiDWt3NIVLuigKOpas8HqBEw=","X-Received":"by 10.46.69.137 with SMTP id s131mr2515447lja.56.1504453633038; \n\tSun, 03 Sep 2017 08:47:13 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<6bc19661-c4c5-5e47-a085-0844a349a37b@denx.de>","References":"<20170902163806.27265-1-robdclark@gmail.com>\n\t<20170902163806.27265-2-robdclark@gmail.com>\n\t<6bc19661-c4c5-5e47-a085-0844a349a37b@denx.de>","From":"Rob Clark ","Date":"Sun, 3 Sep 2017 11:47:12 -0400","Message-ID":"","To":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee , Genevieve Chan ","Subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762295,"web_url":"http://patchwork.ozlabs.org/comment/1762295/","msgid":"<00aeefce-bd6f-1b00-43e7-0c347d540252@denx.de>","list_archive_url":null,"date":"2017-09-03T16:16:13","subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/03/2017 05:47 PM, Rob Clark wrote:\n> On Sun, Sep 3, 2017 at 10:52 AM, Łukasz Majewski wrote:\n>> On 09/02/2017 06:37 PM, Rob Clark wrote:\n>>>\n>>> Want to re-use this in fat dirent iterator in next patch.\n>>>\n>>> Signed-off-by: Rob Clark \n>>\n>>\n>> Reviewed-by: Łukasz Majewski \n>>\n> \n> thanks\n> \n> btw, is there some way to make get_maintainers.pl to find your\n> @denx.de address instead of the @samsung address which bounces?\n> (Sorry, I hadn't realized you had a new addr, so you were missed from\n> CC on some of the patches, I think.)\n\nI've updated git-mailrc entry (about which I've forgotten).\n\nHowever, get_maintainer looks for people making changes to the file(s) \nto which patch is applied.\nHence, you see my old address.\n\n> \n> BR,\n> -R\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xldQJ2sgbz9t3P\n\tfor ;\n\tMon, 4 Sep 2017 02:16:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1E397C21EF6; Sun, 3 Sep 2017 16:16:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 989C1C21DBF;\n\tSun, 3 Sep 2017 16:16:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 68FD8C21DBF; Sun, 3 Sep 2017 16:16:16 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 18A21C21D79\n\tfor ; Sun, 3 Sep 2017 16:16:16 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xldQ76R5Vz1r2fg;\n\tSun, 3 Sep 2017 18:16:15 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xldQ73fB7z3jgXt;\n\tSun, 3 Sep 2017 18:16:15 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 9WYRLDRrK3YN; Sun, 3 Sep 2017 18:16:14 +0200 (CEST)","from [192.168.2.222] (89-77-92-62.dynamic.chello.pl [89.77.92.62])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tSun, 3 Sep 2017 18:16:14 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"O5sLV21mbC4+rjIy81G4XIb17nPz5hKPTTEWlMSQ6bk=","To":"Rob Clark ","References":"<20170902163806.27265-1-robdclark@gmail.com>\n\t<20170902163806.27265-2-robdclark@gmail.com>\n\t<6bc19661-c4c5-5e47-a085-0844a349a37b@denx.de>\n\t","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<00aeefce-bd6f-1b00-43e7-0c347d540252@denx.de>","Date":"Sun, 3 Sep 2017 18:16:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee , Genevieve Chan ","Subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763085,"web_url":"http://patchwork.ozlabs.org/comment/1763085/","msgid":"","list_archive_url":null,"date":"2017-09-05T08:55:58","subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rob,\n\nOn 3 September 2017 at 00:37, Rob Clark wrote:\n> Want to re-use this in fat dirent iterator in next patch.\n>\n> Signed-off-by: Rob Clark \n> ---\n> fs/fat/fat.c | 73 +++++++++++++++++++++++++++++++++++------------------------\n> include/fat.h | 1 +\n> 2 files changed, 44 insertions(+), 30 deletions(-)\n>\n\nReviewed-by: Simon Glass \n\nBut please add a comment to the new structure memory you added.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"oByeStnQ\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"lRwnTTwH\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmgcF32QKz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 18:58:37 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1220DC21D7E; Tue, 5 Sep 2017 08:56:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EF2ADC21EF3;\n\tTue, 5 Sep 2017 08:56:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5BFCAC21C8F; Tue, 5 Sep 2017 08:56:23 +0000 (UTC)","from mail-qk0-f170.google.com (mail-qk0-f170.google.com\n\t[209.85.220.170])\n\tby lists.denx.de (Postfix) with ESMTPS id 76B66C21F12\n\tfor ; Tue, 5 Sep 2017 08:56:20 +0000 (UTC)","by mail-qk0-f170.google.com with SMTP id a128so9466910qkc.5\n\tfor ; Tue, 05 Sep 2017 01:56:20 -0700 (PDT)","by 10.200.28.108 with HTTP; Tue, 5 Sep 2017 01:55:58 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=eKsqofedU3mrj+bJ3p3t1wRcKQAgPUcHl4gRhkzRxas=;\n\tb=oByeStnQLIB5xySBuhsN7TL6jhbqg7+ttzds850Sl+0F0GqI1ZOm3SZnsAm64UqC5U\n\tni3NuC/fosdD6L2nAGk6Z9afDRHxbLl69D9p9rxSHoVp50SeLHZqSr+KxJaFLGc8ty4i\n\tTF6b5hOLGn4acGm5pkmEzESB564XiTi0sc6GaHhfp5slajVeeKrNUpF6ZccjqYyEzec0\n\tXA7B3aw3YgEBOetdWH1V1AF9OGNzt+wdE01IGfxq6MTsKE7lc8ENYiEW1AhJMoyWHCvA\n\tJqBztIIc+fvkCpotMpLN8v1vA6b3/e6wEx0yU0RAtCufhszHSRKjE1pkborGTLq7mZXV\n\t2OhQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=eKsqofedU3mrj+bJ3p3t1wRcKQAgPUcHl4gRhkzRxas=;\n\tb=lRwnTTwHdlh5/sQNgWzvpsCymx4HOCMBWAcePNiqzuoVzbETXW5DHI27rvB/5gHtp7\n\tt2+/ln0khKBq9/qlkFzaL3cRA2f8XVAOr+FTg8l9AeBBtZWCL3FNqdeD4+rE85ykfKE7\n\tuxgBsQlNJSUyXLeION9Zog8u2E7++3XFI5554="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=eKsqofedU3mrj+bJ3p3t1wRcKQAgPUcHl4gRhkzRxas=;\n\tb=cnNGEa+J3TC+lQ3eRdIfiySJ+C1QXsp2S7lZZgivhXj6lly0jxNzBna1SOjXMt55Ky\n\tSH1NuquXpmOkfDCZL0DPTQ8CcIDVwvD60Yvq80wNSygQ1IZMPzhAotXFhV3i2aiHg19+\n\tRrS5Uemks8WoXkK/yL0BRCGI5lSlNyw4FNdXKtkwOUYlrR9CLOAh9Zl+E/BSa26xUEd6\n\tp8gC26tQP/N7Kr8WG/18Ossnx3TfJPn/qe6lTZAQxT8cAXRhojeEvUiB7j4XguOFsMRy\n\td4bS+BE7iTyWcd4hjCWexioEfZDjXnjifCWVUlbTLf0BumD/PSyYNAPfrQRJTeBJMlJ1\n\tA1Hw==","X-Gm-Message-State":"AHPjjUiEohRyB0rniJ0fB9X+F+nY3sDl179hqzlTp1pBsNcKZNu+X6Ql\n\tjoKobp+33j9sk95Wf0VJ7DfzEWbOW9Ar","X-Google-Smtp-Source":"ADKCNb6Imc+yqfeKMIBMB5V45cRXcSUgZHwnQw9+4roRBbsvmHIFwnqI92rfjoKHmQnP8pPmUItaf1sIKjUK0XNH5D8=","X-Received":"by 10.55.146.195 with SMTP id u186mr4128969qkd.84.1504601779233; \n\tTue, 05 Sep 2017 01:56:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170902163806.27265-2-robdclark@gmail.com>","References":"<20170902163806.27265-1-robdclark@gmail.com>\n\t<20170902163806.27265-2-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 5 Sep 2017 16:55:58 +0800","X-Google-Sender-Auth":"VNcqU5yxY7XGLsxW6tzVTpnO2uw","Message-ID":"","To":"Rob Clark ","Cc":"Genevieve Chan ,\n\tU-Boot Mailing List ,\n\tTien Fong Chee ","Subject":"Re: [U-Boot] [PATCH v2 1/8] fs/fat: split out helper to init fsdata","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]