[{"id":1762154,"web_url":"http://patchwork.ozlabs.org/comment/1762154/","msgid":"<20170902161636.GA5463@lunn.ch>","list_archive_url":null,"date":"2017-09-02T16:16:36","subject":"Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Sat, Sep 02, 2017 at 08:56:45AM -0700, Florian Fainelli wrote:\n> During error injection it was possible to crash in dsa_loop_exit() because of\n> an attempt to unregister an invalid PHY. We actually want to the driver probing\n> in dsa_loop_init() even though fixed_phy_register() may return an error to\n> exercise how DSA deals with such cases, but we should not be crashing during\n> driver removal.\n> \n> Fixes: 98cd1552ea27 (\"net: dsa: Mock-up driver\")\n> Signed-off-by: Florian Fainelli \n\nReviewed-by: Andrew Lunn \n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl1TJ4x1Zz9t16\n\tfor ;\n\tSun, 3 Sep 2017 02:16:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752733AbdIBQQj (ORCPT );\n\tSat, 2 Sep 2017 12:16:39 -0400","from vps0.lunn.ch ([178.209.37.122]:54485 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752697AbdIBQQi (ORCPT );\n\tSat, 2 Sep 2017 12:16:38 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1doB64-0001bR-B0; Sat, 02 Sep 2017 18:16:36 +0200"],"Date":"Sat, 2 Sep 2017 18:16:36 +0200","From":"Andrew Lunn ","To":"Florian Fainelli ","Cc":"netdev@vger.kernel.org,\n\tVivien Didelot ,\n\topen list ","Subject":"Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY","Message-ID":"<20170902161636.GA5463@lunn.ch>","References":"<20170902155645.19071-1-f.fainelli@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170902155645.19071-1-f.fainelli@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762401,"web_url":"http://patchwork.ozlabs.org/comment/1762401/","msgid":"<20170903.201923.1025438565183602962.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-04T03:19:23","subject":"Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Florian Fainelli \nDate: Sat, 2 Sep 2017 08:56:45 -0700\n\n> During error injection it was possible to crash in dsa_loop_exit() because of\n> an attempt to unregister an invalid PHY. We actually want to the driver probing\n> in dsa_loop_init() even though fixed_phy_register() may return an error to\n> exercise how DSA deals with such cases, but we should not be crashing during\n> driver removal.\n> \n> Fixes: 98cd1552ea27 (\"net: dsa: Mock-up driver\")\n> Signed-off-by: Florian Fainelli \n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlw7Y6TZkz9sNq\n\tfor ;\n\tMon, 4 Sep 2017 13:19:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753280AbdIDDT0 (ORCPT );\n\tSun, 3 Sep 2017 23:19:26 -0400","from shards.monkeyblade.net ([184.105.139.130]:34922 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753124AbdIDDTY (ORCPT\n\t); Sun, 3 Sep 2017 23:19:24 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 0C2C9133F0681;\n\tSun, 3 Sep 2017 20:19:24 -0700 (PDT)"],"Date":"Sun, 03 Sep 2017 20:19:23 -0700 (PDT)","Message-Id":"<20170903.201923.1025438565183602962.davem@davemloft.net>","To":"f.fainelli@gmail.com","Cc":"netdev@vger.kernel.org, andrew@lunn.ch,\n\tvivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH net] net: dsa: loop: Do not unregister invalid fixed PHY","From":"David Miller ","In-Reply-To":"<20170902155645.19071-1-f.fainelli@gmail.com>","References":"<20170902155645.19071-1-f.fainelli@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Sun, 03 Sep 2017 20:19:24 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]