[{"id":1762130,"web_url":"http://patchwork.ozlabs.org/comment/1762130/","msgid":"<20170902143908.GA3396@scaer>","list_archive_url":null,"date":"2017-09-02T14:39:08","subject":"Re: [Buildroot] [PATCH 2/2] package/libpng: switch to cmake","submitter":{"id":13903,"url":"http://patchwork.ozlabs.org/api/people/13903/","name":"Yann E. MORIN","email":"yann.morin.1998@free.fr"},"content":"Bernd, All,\n\nOn 2017-09-02 16:29 +0200, Bernd Kuhls spake thusly:\n> We have no arch-specific options to control mips msa and powerpc vsx\n> support so we disable these options atm to prevent build errors.\n\nI'm not even reviewing the patch, because I noticed that a lot of\nswitch-to-cmake patches actually broke the build one way or the other.\n\nSo I would suggest that we forgo switching the buildsyustem of package\njust to switch.\n\nIf upstream has changed, or there is a *compelling* reason to switch,\nthen so be it. In this case, the commit log *must* explain the rationale\nfor switching.\n\nBut switching for the sake of switching is a big no-no from me.\n\nRegards,\nYann E. MORIN.\n\n> Tested using this defconfig:\n> \n> BR2_PACKAGE_LIBPNG=y\n> \n> armv5-ctng-linux-gnueabi [ 1/47]: OK\n> armv7-ctng-linux-gnueabihf [ 2/47]: OK\n> br-aarch64-glibc [ 3/47]: OK\n> br-arcle-hs38 [ 4/47]: OK\n> br-arm-basic [ 5/47]: OK\n> br-arm-cortex-a9-glibc [ 6/47]: OK\n> br-arm-cortex-a9-musl [ 7/47]: OK\n> br-arm-cortex-m4-full [ 8/47]: OK\n> br-arm-full [ 9/47]: OK\n> br-arm-full-nothread [10/47]: OK\n> br-arm-full-static [11/47]: OK\n> br-bfin-full [12/47]: OK\n> br-i386-pentium4-full [13/47]: OK\n> br-i386-pentium-mmx-musl [14/47]: OK\n> br-m68k-5208-full [15/47]: OK\n> br-m68k-68040-full [16/47]: OK\n> br-microblazeel-full [17/47]: OK\n> br-mips32r6-el-hf-glibc [18/47]: OK\n> br-mips64-n64-full [19/47]: OK\n> br-mips64r6-el-hf-glibc [20/47]: OK\n> br-mipsel-o32-full [21/47]: OK\n> br-nios2-glibc [22/47]: OK\n> br-openrisc-uclibc [23/47]: OK\n> br-powerpc-603e-basic-cpp [24/47]: OK\n> br-powerpc64le-power8-glibc [25/47]: OK\n> br-powerpc64-power7-glibc [26/47]: OK\n> br-powerpc-e500mc-full [27/47]: OK\n> br-sh4-full [28/47]: OK\n> br-sparc64-glibc [29/47]: OK\n> br-sparc-uclibc [30/47]: OK\n> br-x86-64-core2-full [31/47]: OK\n> br-x86-64-musl [32/47]: OK\n> br-xtensa-full [33/47]: OK\n> i686-ctng-linux-gnu [34/47]: OK\n> linaro-aarch64 [35/47]: OK\n> linaro-arm [36/47]: OK\n> mips64el-ctng_n32-linux-gnu [37/47]: OK\n> mips64el-ctng_n64-linux-gnu [38/47]: OK\n> powerpc-ctng_e500v2-linux-gnuspe [39/47]: OK\n> sourcery-arm-armv4t [40/47]: OK\n> sourcery-arm [41/47]: OK\n> sourcery-arm-thumb2 [42/47]: OK\n> sourcery-mips64 [43/47]: OK\n> sourcery-mips [44/47]: OK\n> sourcery-nios2 [45/47]: OK\n> sourcery-x86-64 [46/47]: OK\n> x86_64-ctng_locales-linux-gnu [47/47]: OK\n> 47 builds, 0 skipped, 0 build failed, 0 legal-info failed\n> \n> Signed-off-by: Bernd Kuhls \n> ---\n> ...3-CMakeLists.txt-Enable-building-asm-code.patch | 40 ++++++++++++++++++++++\n> package/libpng/libpng.mk | 22 ++++++++----\n> 2 files changed, 56 insertions(+), 6 deletions(-)\n> create mode 100644 package/libpng/0003-CMakeLists.txt-Enable-building-asm-code.patch\n> \n> diff --git a/package/libpng/0003-CMakeLists.txt-Enable-building-asm-code.patch b/package/libpng/0003-CMakeLists.txt-Enable-building-asm-code.patch\n> new file mode 100644\n> index 000000000..4bc5345fe\n> --- /dev/null\n> +++ b/package/libpng/0003-CMakeLists.txt-Enable-building-asm-code.patch\n> @@ -0,0 +1,40 @@\n> +From b47e0f5ceb525796dd98900613f3744d45331216 Mon Sep 17 00:00:00 2001\n> +From: Bernd Kuhls \n> +Date: Sat, 2 Sep 2017 15:09:30 +0200\n> +Subject: [PATCH] CMakeLists.txt: Enable building asm code\n> +\n> +NEON support is provided by filter_neon.S which is currently not build\n> +by cmake causing an error when linking with libpng16.so.16.32.0:\n> +\n> +[ 97%] Linking C executable pngstest\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_avg4_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_paeth3_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_up_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_avg3_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_paeth4_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_sub4_neon'\n> +libpng16.so.16.32.0: undefined reference to `png_read_filter_row_sub3_neon'\n> +\n> +Patch sent upstream: https://github.com/glennrp/libpng/pull/174\n> +\n> +Signed-off-by: Bernd Kuhls \n> +---\n> + CMakeLists.txt | 2 +-\n> + 1 file changed, 1 insertion(+), 1 deletion(-)\n> +\n> +diff --git a/CMakeLists.txt b/CMakeLists.txt\n> +index 4803a720d..153d6caf6 100644\n> +--- a/CMakeLists.txt\n> ++++ b/CMakeLists.txt\n> +@@ -31,7 +31,7 @@ endif(POLICY CMP0054)\n> + \n> + set(CMAKE_CONFIGURATION_TYPES \"Release;Debug;MinSizeRel;RelWithDebInfo\")\n> + \n> +-project(libpng C)\n> ++project(libpng ASM C)\n> + enable_testing()\n> + \n> + set(PNGLIB_MAJOR 1)\n> +-- \n> +2.11.0\n> +\n> diff --git a/package/libpng/libpng.mk b/package/libpng/libpng.mk\n> index 2aa021712..6e915a47f 100644\n> --- a/package/libpng/libpng.mk\n> +++ b/package/libpng/libpng.mk\n> @@ -15,17 +15,27 @@ LIBPNG_DEPENDENCIES = host-pkgconf zlib\n> HOST_LIBPNG_DEPENDENCIES = host-pkgconf host-zlib\n> LIBPNG_CONFIG_SCRIPTS = libpng$(LIBPNG_SERIES)-config libpng-config\n> \n> +LIBPNG_CONF_OPTS += -DPNG_MIPS_MSA=off -DPNG_POWERPC_VSX=off\n> +\n> +ifeq ($(BR2_STATIC_LIBS),y)\n> +LIBPNG_CONF_OPTS += -DPNG_SHARED=OFF -DPNG_STATIC=ON\n> +else ifeq ($(BR2_SHARED_LIBS),y)\n> +LIBPNG_CONF_OPTS += -DPNG_SHARED=ON -DPNG_STATIC=OFF\n> +else ifeq ($(BR2_SHARED_STATIC_LIBS),y)\n> +LIBPNG_CONF_OPTS += -DPNG_SHARED=ON -DPNG_STATIC=ON\n> +endif\n> +\n> ifeq ($(BR2_ARM_CPU_HAS_NEON),y)\n> -LIBPNG_CONF_OPTS += --enable-arm-neon\n> +LIBPNG_CONF_OPTS += -DPNG_ARM_NEON=on\n> else\n> -LIBPNG_CONF_OPTS += --disable-arm-neon\n> +LIBPNG_CONF_OPTS += -DPNG_ARM_NEON=off\n> endif\n> \n> ifeq ($(BR2_X86_CPU_HAS_SSE2),y)\n> -LIBPNG_CONF_OPTS += --enable-intel-sse\n> +LIBPNG_CONF_OPTS += -DPNG_INTEL_SSE=on\n> else\n> -LIBPNG_CONF_OPTS += --disable-intel-sse\n> +LIBPNG_CONF_OPTS += -DPNG_INTEL_SSE=off\n> endif\n> \n> -$(eval $(autotools-package))\n> -$(eval $(host-autotools-package))\n> +$(eval $(cmake-package))\n> +$(eval $(host-cmake-package))\n> -- \n> 2.11.0\n> \n> _______________________________________________\n> buildroot mailing list\n> buildroot@busybox.net\n> http://lists.busybox.net/mailman/listinfo/buildroot","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PU7cZHHt\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkzJl6qNCz9sP1\n\tfor ;\n\tSun, 3 Sep 2017 00:39:19 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 05502304AB;\n\tSat, 2 Sep 2017 14:39:17 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eKq81q08iabg; Sat, 2 Sep 2017 14:39:15 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 424EC258CF;\n\tSat, 2 Sep 2017 14:39:15 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id CC0251C0906\n\tfor ;\n\tSat, 2 Sep 2017 14:39:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C704C89F78\n\tfor ;\n\tSat, 2 Sep 2017 14:39:13 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eWtL87dL44lw for ;\n\tSat, 2 Sep 2017 14:39:12 +0000 (UTC)","from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 6146F89F3B\n\tfor ; Sat, 2 Sep 2017 14:39:12 +0000 (UTC)","by mail-wm0-f68.google.com with SMTP id 187so2355241wmn.0\n\tfor ; Sat, 02 Sep 2017 07:39:12 -0700 (PDT)","from ymorin.is-a-geek.org\n\t(2a01cb08861073003c777d9688ce0319.ipv6.abo.wanadoo.fr.\n\t[2a01:cb08:8610:7300:3c77:7d96:88ce:319])\n\tby smtp.gmail.com with ESMTPSA id\n\tl20sm1398876wrf.24.2017.09.02.07.39.09\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tSat, 02 Sep 2017 07:39:10 -0700 (PDT)","by ymorin.is-a-geek.org (sSMTP sendmail emulation);\n\tSat, 02 Sep 2017 16:39:08 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=cXY9heloQFiIj+Rtn7h5fyRAQqeY8J5CmWOg9tUy4AA=;\n\tb=PU7cZHHtHSY3Slcb85Jy9k2jlhdvx+4UwvOcXgr9EfAUNww/SBzHRTKqsiUGDLtBiZ\n\tvT4Yo5ru6JIm2Y74YfwtsU5V/Iifb2GeJEH5HuJJIS0GznAD1/1Df6wHp5+9O2y1R8aN\n\t6c86ZTik3q1u9gxkw6LlMt0q3jMsQ6ZQ+9wFb73i6juC2wQAm9iLcPlEBkEVt3Rd/bCv\n\tSPcAPHonsqL1zZfUd42aWaAPCc2/AyvmE2He2oVMip32Qw9Huqebr/vtBgbjlRxQXydf\n\tgy2EYTnsn2TJinfspQBOD6Au/UJkZ03aHp5RiUkjQRamBjc4Z7p/bVsgah/oWeOCsKTJ\n\t5P8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=cXY9heloQFiIj+Rtn7h5fyRAQqeY8J5CmWOg9tUy4AA=;\n\tb=Se5fNPge7SNF0Kq87UY9Bj9iHBM57BOVx1HeeYOBF1RoSvYWYwmsW/R1W24ApS8vDQ\n\tGnAKldJTGiL58CWMTgjqNYWUhL8pVZjAbb3MvA4EMGUm4i1pUTyWlOSbtO1QOS88r9BC\n\taf9QlyaWCqQyzt3SpbZq8BC59M3ldrc623l0qa4Ij1a1PXsr4x+vPqDF1+f8Y5VxqiQA\n\tZ6y9EQ5bIFqkxMNXK1qlB8XvV+XUpML0jko+D1H/3yZ/NVqik4qqHT9Xn7kUqqhx4BGy\n\tu9+nsQvA0KnKaXRlWpwn3yzIuIHMu2hAsPh1cMBJiGqQGVDld9X0+JdEnS+yu0ipAC11\n\tju5A==","X-Gm-Message-State":"AHPjjUjWJypn5FSOYlMK/bLh2n/QRU2kehcEHMuPYpyeX9YwYS2VI4HU\n\tAoyxyJZ9LVC2VQR9","X-Google-Smtp-Source":"ADKCNb4ZphlfPwtQ6CXui5N5b3TwKnEaUUKc6uuy4RArorxgrunSBQsmYJIXycH7bg0/xN/6HmdlDA==","X-Received":"by 10.28.17.79 with SMTP id 76mr819502wmr.74.1504363150800;\n\tSat, 02 Sep 2017 07:39:10 -0700 (PDT)","Date":"Sat, 2 Sep 2017 16:39:08 +0200","From":"\"Yann E. MORIN\" ","To":"Bernd Kuhls ","Message-ID":"<20170902143908.GA3396@scaer>","References":"<20170902142956.22181-1-bernd.kuhls@t-online.de>\n\t<20170902142956.22181-2-bernd.kuhls@t-online.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170902142956.22181-2-bernd.kuhls@t-online.de>","User-Agent":"Mutt/1.5.22 (2013-10-16)","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 2/2] package/libpng: switch to cmake","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1762161,"web_url":"http://patchwork.ozlabs.org/comment/1762161/","msgid":"<20170902184316.666a6986@windsurf.lan>","list_archive_url":null,"date":"2017-09-02T16:43:16","subject":"Re: [Buildroot] [PATCH 2/2] package/libpng: switch to cmake","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Sat, 2 Sep 2017 16:39:08 +0200, Yann E. MORIN wrote:\n\n> On 2017-09-02 16:29 +0200, Bernd Kuhls spake thusly:\n> > We have no arch-specific options to control mips msa and powerpc vsx\n> > support so we disable these options atm to prevent build errors. \n> \n> I'm not even reviewing the patch, because I noticed that a lot of\n> switch-to-cmake patches actually broke the build one way or the other.\n> \n> So I would suggest that we forgo switching the buildsyustem of package\n> just to switch.\n> \n> If upstream has changed, or there is a *compelling* reason to switch,\n> then so be it. In this case, the commit log *must* explain the rationale\n> for switching.\n> \n> But switching for the sake of switching is a big no-no from me.\n\nI agree that there needs to be an explanation for the switch. Is\nupstream moving to CMake, and getting rid of autotools support in the\nfuture ? Other reason ?\n\nAlso Bernd: for libraries, a test-pkg test is by far not enough to\nindicate that everything is alright. Look at the switch of cmake in the\nlzo package that you contributed: it was bogus because it was only\nbuilding the static library, and no longer the shared library. A\ntest-pkg test doesn't catch this kind of stuff.\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl23x6zdSz9sRW\n\tfor ;\n\tSun, 3 Sep 2017 02:43:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C0FF62F407;\n\tSat, 2 Sep 2017 16:43:22 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yeGHXS9X9ftL; Sat, 2 Sep 2017 16:43:22 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E6A5E2667E;\n\tSat, 2 Sep 2017 16:43:21 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9441E1BFB70\n\tfor ;\n\tSat, 2 Sep 2017 16:43:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8D6A189481\n\tfor ;\n\tSat, 2 Sep 2017 16:43:20 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BGbFh-0SL5ZO for ;\n\tSat, 2 Sep 2017 16:43:19 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4219E89480\n\tfor ; Sat, 2 Sep 2017 16:43:19 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2B8C820A4C; Sat, 2 Sep 2017 18:43:16 +0200 (CEST)","from windsurf.lan (LFbn-1-15133-129.w86-206.abo.wanadoo.fr\n\t[86.206.239.129])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 0A3EE2097A;\n\tSat, 2 Sep 2017 18:43:16 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 2 Sep 2017 18:43:16 +0200","From":"Thomas Petazzoni ","To":"\"Yann E. MORIN\" ","Message-ID":"<20170902184316.666a6986@windsurf.lan>","In-Reply-To":"<20170902143908.GA3396@scaer>","References":"<20170902142956.22181-1-bernd.kuhls@t-online.de>\n\t<20170902142956.22181-2-bernd.kuhls@t-online.de>\n\t<20170902143908.GA3396@scaer>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 2/2] package/libpng: switch to cmake","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]