[{"id":1762162,"web_url":"http://patchwork.ozlabs.org/comment/1762162/","msgid":"<20170902184425.071b21be@windsurf.lan>","list_archive_url":null,"date":"2017-09-02T16:44:25","subject":"Re: [Buildroot] [PATCH] package/lzo: enable shared/static libs when\n\tneeded","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Sat, 2 Sep 2017 16:28:53 +0200, Yann E. MORIN wrote:\n> In 61c4c63 (package/lzo: switch to cmake), building lzo has switched\n> from autotools to cmake. In the conversion, we've lost the build of the\n> shared library, because the cmake-based buildsystem of lzo explcitly\n> disables it by default.\n> \n> Restore the shared library build.\n> \n> Signed-off-by: \"Yann E. MORIN\" \n> Cc: Bernd Kuhls \n> \n> ---\n> Note: it was noticed because of an autobuild failure of cairo:\n> http://autobuild.buildroot.org/results/d51/d51888cbc3a743d53ce38f736ee43953e50bdf61/\n> but it has not been checked wether this patch fixes the build at all.\n> Yet, the patch is still valid even without fixing the autobuild failure.\n> ---\n> package/lzo/lzo.mk | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n\nApplied to master, thanks.\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl25F6yKyz9sRW\n\tfor ;\n\tSun, 3 Sep 2017 02:44:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 425E384DB7;\n\tSat, 2 Sep 2017 16:44:32 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6MQZXCYWYCVp; Sat, 2 Sep 2017 16:44:30 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 095DF83F08;\n\tSat, 2 Sep 2017 16:44:30 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1709C1BFB70\n\tfor ;\n\tSat, 2 Sep 2017 16:44:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 114442313D\n\tfor ;\n\tSat, 2 Sep 2017 16:44:28 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vN2Rpzj3QFWZ for ;\n\tSat, 2 Sep 2017 16:44:27 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby silver.osuosl.org (Postfix) with ESMTP id EBBA322D1C\n\tfor ; Sat, 2 Sep 2017 16:44:26 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 0F6C220A4C; Sat, 2 Sep 2017 18:44:25 +0200 (CEST)","from windsurf.lan (LFbn-1-15133-129.w86-206.abo.wanadoo.fr\n\t[86.206.239.129])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id DA05F2097A;\n\tSat, 2 Sep 2017 18:44:24 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 2 Sep 2017 18:44:25 +0200","From":"Thomas Petazzoni ","To":"\"Yann E. MORIN\" ","Message-ID":"<20170902184425.071b21be@windsurf.lan>","In-Reply-To":"<20170902142853.18011-1-yann.morin.1998@free.fr>","References":"<20170902142853.18011-1-yann.morin.1998@free.fr>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] package/lzo: enable shared/static libs when\n\tneeded","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]