[{"id":1771358,"web_url":"http://patchwork.ozlabs.org/comment/1771358/","msgid":"<20170919221246.4e46cb9e@bbrezillon>","list_archive_url":null,"date":"2017-09-19T20:12:46","subject":"Re: [PATCH] mtd: nand: remove unused blockmask variable","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"On Sat, 2 Sep 2017 10:49:38 +0200\nCorentin Labbe wrote:\n\n> This patch fix the following build warning:\n> drivers/mtd/nand/nand_base.c:2671:30: attention : variable ‘blockmask’ set but not used [-Wunused-but-set-variable]\n\nApplied.\n\nThanks,\n\nBoris\n\n> \n> Signed-off-by: Corentin Labbe \n> ---\n> drivers/mtd/nand/nand_base.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c\n> index 9900476a0afe..b875fd365084 100644\n> --- a/drivers/mtd/nand/nand_base.c\n> +++ b/drivers/mtd/nand/nand_base.c\n> @@ -2668,7 +2668,7 @@ static uint8_t *nand_fill_oob(struct mtd_info *mtd, uint8_t *oob, size_t len,\n> static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,\n> \t\t\t struct mtd_oob_ops *ops)\n> {\n> -\tint chipnr, realpage, page, blockmask, column;\n> +\tint chipnr, realpage, page, column;\n> \tstruct nand_chip *chip = mtd_to_nand(mtd);\n> \tuint32_t writelen = ops->len;\n> \n> @@ -2704,7 +2704,6 @@ static int nand_do_write_ops(struct mtd_info *mtd, loff_t to,\n> \n> \trealpage = (int)(to >> chip->page_shift);\n> \tpage = realpage & chip->pagemask;\n> -\tblockmask = (1 << (chip->phys_erase_shift - chip->page_shift)) - 1;\n> \n> \t/* Invalidate the page cache, when we write to the cached page */\n> \tif (to <= ((loff_t)chip->pagebuf << chip->page_shift) &&","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"kEtdQd4S\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYwm4d90z9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:13:44 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duOto-0000CN-SP; Tue, 19 Sep 2017 20:13:40 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duOtT-0008IE-Dv\n\tfor linux-mtd@lists.infradead.org; Tue, 19 Sep 2017 20:13:38 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 591D82090E; Tue, 19 Sep 2017 22:12:58 +0200 (CEST)","from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 1C97D208B4;\n\tTue, 19 Sep 2017 22:12:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=eQWKeBKhXQ+QGrtEiVBFfmk7EJBe6fiCeYvUzvhrmsg=;\n\tb=kEtdQd4S40J1bs\n\tlZo9k2WZ9v4hpUXiERw02Rj4CR58pr+5C3wiUVchsj0wDY5L7vMS4PrisnP0tSD/MDzBAW1LEdERP\n\trJCKAG/a7KSoTWrDImyYKhXsR3XOwxyOOLp4Se47XCiaXzN8E4691+6puzaBDX7md7WFNVMTdxkVl\n\tm3jD9jD6o29ORa20CwLxcp86Mpb0IZS6QdcP974J/JvS75BNNClsrYmYlxnzNlRZywUZ1N1C4/ACr\n\tQnq74NTZweHyS9Jb0VmgqZA/NoeYdh5T+Msy+LSMQ905hgHuOZw21rEPGXLS8BtgyzPpoLQ+yGzib\n\tJUhxjiBVZbOaZtRKn7Cg==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 19 Sep 2017 22:12:46 +0200","From":"Boris Brezillon ","To":"Corentin Labbe ","Subject":"Re: [PATCH] mtd: nand: remove unused blockmask variable","Message-ID":"<20170919221246.4e46cb9e@bbrezillon>","In-Reply-To":"<20170902084938.15942-1-clabbe.montjoie@gmail.com>","References":"<20170902084938.15942-1-clabbe.montjoie@gmail.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_131320_715390_12C37084 ","X-CRM114-Status":"GOOD ( 13.74 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com,\n\tlinux-mtd@lists.infradead.org, cyrille.pitchen@wedev4u.fr,\n\tcomputersforpeace@gmail.com, dwmw2@infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]