[{"id":1762200,"web_url":"http://patchwork.ozlabs.org/comment/1762200/","msgid":"<1504390854.4974.108.camel@kernel.crashing.org>","date":"2017-09-02T22:20:54","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Sat, 2017-09-02 at 04:43 -0400, Robert P. J. Day wrote:\n> Since, according to a recent devicetree ML posting by Rob Herring,\n> the node \"/chosen@0\" is most likely for real Open Firmware and does\n> not apply to DTSpec, remove all remaining tests and references for\n> that node, of which there are very few left:\n\nTechnically that would break Open Firmware systems where the node is\nreally called chosen@0\n\nNow I'm not sure such a thing actually exist however.\n\nMy collection of DTs don't seem to have one, except in the ancient html\nvariants that were extracted by the pengionppc folks for the original\nPowerMac 8600 but I wonder if that's a bug in the extraction script\nsince they also have @0 on /packages etc...\n\nBen.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl9cJ1vFWz9sPs\n\tfor ;\n\tSun, 3 Sep 2017 08:23:28 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xl9cJ0C1BzDqlM\n\tfor ;\n\tSun, 3 Sep 2017 08:23:28 +1000 (AEST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xl9Zc22JgzDqY3\n\tfor ;\n\tSun, 3 Sep 2017 08:22:00 +1000 (AEST)","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v82MKsW3017746;\n\tSat, 2 Sep 2017 17:20:56 -0500"],"Message-ID":"<1504390854.4974.108.camel@kernel.crashing.org>","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","From":"Benjamin Herrenschmidt ","To":"\"Robert P. J. Day\" , devicetree@vger.kernel.org","Date":"Sun, 03 Sep 2017 08:20:54 +1000","In-Reply-To":"","References":"","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mips@linux-mips.org, monstr@monstr.eu,\n\tLinux PPC Mailing List ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1762240,"web_url":"http://patchwork.ozlabs.org/comment/1762240/","msgid":"","date":"2017-09-03T10:43:33","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":2270,"url":"http://patchwork.ozlabs.org/api/people/2270/","name":"Robert P. J. Day","email":"rpjday@crashcourse.ca"},"content":"On Sun, 3 Sep 2017, Benjamin Herrenschmidt wrote:\n\n> On Sat, 2017-09-02 at 04:43 -0400, Robert P. J. Day wrote:\n> > Since, according to a recent devicetree ML posting by Rob Herring,\n> > the node \"/chosen@0\" is most likely for real Open Firmware and\n> > does not apply to DTSpec, remove all remaining tests and\n> > references for that node, of which there are very few left:\n>\n> Technically that would break Open Firmware systems where the node is\n> really called chosen@0\n>\n> Now I'm not sure such a thing actually exist however.\n>\n> My collection of DTs don't seem to have one, except in the ancient\n> html variants that were extracted by the pengionppc folks for the\n> original PowerMac 8600 but I wonder if that's a bug in the\n> extraction script since they also have @0 on /packages etc...\n\n obviously, this isn't a priority issue, i was just working off a\ncomment by rob herring that \"chosen@0\" is not defined by the current\nDTSpec 0.1, so it seemed appropriate to toss it. if there's a reason\nto hang onto it, that's fine with me.\n\n however, given the diff stat of the change to remove every single\nreference to that node name in the current kernel source:\n\n arch/microblaze/kernel/prom.c | 3 +--\n arch/mips/generic/yamon-dt.c | 4 ----\n arch/powerpc/boot/oflib.c | 7 ++-----\n drivers/of/base.c | 2 --\n drivers/of/fdt.c | 5 +----\n 5 files changed, 4 insertions(+), 17 deletions(-)\n\nit seems inconsistent that three architectures would be testing for\nthat node, but none of the rest. consistency suggests that every\narchitecture should take it into account, or none should.\n\n anyway, not a big deal, i'm fine with any decision.\n\nrday","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlV3b0mCnz9sRW\n\tfor ;\n\tSun, 3 Sep 2017 20:44:43 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xlV3Z6zlDzDrqM\n\tfor ;\n\tSun, 3 Sep 2017 20:44:42 +1000 (AEST)","from cpanel2.indieserve.net (cpanel2.indieserve.net\n\t[199.212.143.6])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xlV2P150gzDqj2\n\tfor ;\n\tSun, 3 Sep 2017 20:43:40 +1000 (AEST)","from cpec03f0ed08c7f-cm68b6fcf980b0.cpe.net.cable.rogers.com\n\t([174.118.92.171]:57626 helo=localhost.localdomain)\n\tby cpanel2.indieserve.net with esmtpsa\n\t(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1doSNL-0004Yu-KJ; Sun, 03 Sep 2017 06:43:35 -0400"],"Date":"Sun, 3 Sep 2017 06:43:33 -0400 (EDT)","From":"\"Robert P. J. Day\" ","X-X-Sender":"rpjday@localhost.localdomain","To":"Benjamin Herrenschmidt ","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","In-Reply-To":"<1504390854.4974.108.camel@kernel.crashing.org>","Message-ID":"","References":"\n\t<1504390854.4974.108.camel@kernel.crashing.org>","User-Agent":"Alpine 2.21 (LFD 202 2017-01-01)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - cpanel2.indieserve.net","Original Domain - lists.ozlabs.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - crashcourse.ca"],"X-Get-Message-Sender-Via":"cpanel2.indieserve.net: authenticated_id:\n\trpjday+crashcourse.ca/only user confirmed/virtual account not\n\tconfirmed","X-Authenticated-Sender":"cpanel2.indieserve.net: rpjday@crashcourse.ca","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, monstr@monstr.eu,\n\tLinux PPC Mailing List ,\n\tlinux-mips@linux-mips.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1762248,"web_url":"http://patchwork.ozlabs.org/comment/1762248/","msgid":"<1504440154.2250.1.camel@kernel.crashing.org>","date":"2017-09-03T12:02:34","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Sun, 2017-09-03 at 06:43 -0400, Robert P. J. Day wrote:\n> however, given the diff stat of the change to remove every single\n> reference to that node name in the current kernel source:\n> \n> arch/microblaze/kernel/prom.c | 3 +--\n> arch/mips/generic/yamon-dt.c | 4 ----\n> arch/powerpc/boot/oflib.c | 7 ++-----\n> drivers/of/base.c | 2 --\n> drivers/of/fdt.c | 5 +----\n> 5 files changed, 4 insertions(+), 17 deletions(-)\n> \n> it seems inconsistent that three architectures would be testing for\n> that node, but none of the rest. consistency suggests that every\n> architecture should take it into account, or none should.\n> \n> anyway, not a big deal, i'm fine with any decision.\n\npowerpc is the only one of the 3 who has an actual open firmware\nimplementation afaik.\n\nIn any case, I think you can probably remove from microblaze and\npossibly mips but I'm a bit worried about the generic case and powerpc\nboot.\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlWqz1kNHz9s7v\n\tfor ;\n\tSun, 3 Sep 2017 22:04:47 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xlWqz0lnVzDrnR\n\tfor ;\n\tSun, 3 Sep 2017 22:04:47 +1000 (AEST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xlWpj6YWZzDqkh\n\tfor ;\n\tSun, 3 Sep 2017 22:03:41 +1000 (AEST)","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v83C2ZoB023699;\n\tSun, 3 Sep 2017 07:02:37 -0500"],"Message-ID":"<1504440154.2250.1.camel@kernel.crashing.org>","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","From":"Benjamin Herrenschmidt ","To":"\"Robert P. J. Day\" ","Date":"Sun, 03 Sep 2017 22:02:34 +1000","In-Reply-To":"","References":"\n\t<1504390854.4974.108.camel@kernel.crashing.org>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, monstr@monstr.eu,\n\tLinux PPC Mailing List ,\n\tlinux-mips@linux-mips.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1763406,"web_url":"http://patchwork.ozlabs.org/comment/1763406/","msgid":"","date":"2017-09-05T14:30:22","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 3, 2017 at 5:43 AM, Robert P. J. Day wrote:\n> On Sun, 3 Sep 2017, Benjamin Herrenschmidt wrote:\n>\n>> On Sat, 2017-09-02 at 04:43 -0400, Robert P. J. Day wrote:\n>> > Since, according to a recent devicetree ML posting by Rob Herring,\n>> > the node \"/chosen@0\" is most likely for real Open Firmware and\n>> > does not apply to DTSpec, remove all remaining tests and\n>> > references for that node, of which there are very few left:\n>>\n>> Technically that would break Open Firmware systems where the node is\n>> really called chosen@0\n>>\n>> Now I'm not sure such a thing actually exist however.\n>>\n>> My collection of DTs don't seem to have one, except in the ancient\n>> html variants that were extracted by the pengionppc folks for the\n>> original PowerMac 8600 but I wonder if that's a bug in the\n>> extraction script since they also have @0 on /packages etc...\n>\n> obviously, this isn't a priority issue, i was just working off a\n> comment by rob herring that \"chosen@0\" is not defined by the current\n> DTSpec 0.1, so it seemed appropriate to toss it. if there's a reason\n> to hang onto it, that's fine with me.\n>\n> however, given the diff stat of the change to remove every single\n> reference to that node name in the current kernel source:\n>\n> arch/microblaze/kernel/prom.c | 3 +--\n> arch/mips/generic/yamon-dt.c | 4 ----\n> arch/powerpc/boot/oflib.c | 7 ++-----\n> drivers/of/base.c | 2 --\n> drivers/of/fdt.c | 5 +----\n> 5 files changed, 4 insertions(+), 17 deletions(-)\n>\n> it seems inconsistent that three architectures would be testing for\n> that node, but none of the rest. consistency suggests that every\n> architecture should take it into account, or none should.\n\nI generally agree and have moved various things from arch to\ndrivers/of/ to ensure that. But for legacy things, we have to allow\nfor exceptions. I agree with Ben and think that microblaze (they\ngenerally just copied PPC), MIPS, and the FDT code in drivers/of/ can\nbe changed.\n\nRob","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmq0x6vZfz9t1t\n\tfor ;\n\tWed, 6 Sep 2017 00:32:01 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmq0x60J8zDrSj\n\tfor ;\n\tWed, 6 Sep 2017 00:32:01 +1000 (AEST)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmpzV1QSHzDrJ3\n\tfor ;\n\tWed, 6 Sep 2017 00:30:45 +1000 (AEST)","from mail-qk0-f174.google.com (mail-qk0-f174.google.com\n\t[209.85.220.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id C817921E93\n\tfor ;\n\tTue, 5 Sep 2017 14:30:43 +0000 (UTC)","by mail-qk0-f174.google.com with SMTP id z143so12132813qkb.3\n\tfor ;\n\tTue, 05 Sep 2017 07:30:43 -0700 (PDT)","by 10.12.153.1 with HTTP; Tue, 5 Sep 2017 07:30:22 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=kernel.org\n\t(client-ip=198.145.29.99; helo=mail.kernel.org;\n\tenvelope-from=robh@kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org C817921E93","X-Gm-Message-State":"AHPjjUg4PQKTVPbklFAGW3ily2409i7QqwS7TG/ZBjHwA++6RP2U9/Fa\n\tBAaGABHCJFsPOUznGP8i+16Fzjcl7g==","X-Google-Smtp-Source":"ADKCNb792YFhgxvddsq4tCw3RnSu2OvGhrpTuRXR7r3H29rOQ2Ck0sENCOp23xHBcMmQ0ikbF88ejAqg/WZY72EfMTM=","X-Received":"by 10.55.160.4 with SMTP id j4mr5195505qke.357.1504621842956;\n\tTue, 05 Sep 2017 07:30:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t<1504390854.4974.108.camel@kernel.crashing.org>\n\t","From":"Rob Herring ","Date":"Tue, 5 Sep 2017 09:30:22 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","To":"\"Robert P. J. Day\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michal Simek , Linux-MIPS , \n\tLinux PPC Mailing List ,\n\t\"devicetree@vger.kernel.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1763409,"web_url":"http://patchwork.ozlabs.org/comment/1763409/","msgid":"","date":"2017-09-05T14:41:45","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Sep 2, 2017 at 3:43 AM, Robert P. J. Day wrote:\n>\n> Since, according to a recent devicetree ML posting by Rob Herring,\n> the node \"/chosen@0\" is most likely for real Open Firmware and does\n> not apply to DTSpec, remove all remaining tests and references for\n> that node, of which there are very few left:\n>\n> arch/microblaze/kernel/prom.c | 3 +--\n> arch/mips/generic/yamon-dt.c | 4 ----\n> arch/powerpc/boot/oflib.c | 7 ++-----\n> drivers/of/base.c | 2 --\n> drivers/of/fdt.c | 5 +----\n> 5 files changed, 4 insertions(+), 17 deletions(-)\n>\n> This should be innocuous as, in all of the three arch/ files above,\n> there is a test for \"chosen\" immediately before the test for\n> \"chosen@0\", so nothing should change.\n>\n> Signed-off-by: Robert P. J. Day \n>\n> ---\n>\n> if this patch is premature, then just ignore it, thanks.\n>\n> diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c\n> index 68f0999..c81bfd7 100644\n> --- a/arch/microblaze/kernel/prom.c\n> +++ b/arch/microblaze/kernel/prom.c\n> @@ -53,8 +53,7 @@ static int __init early_init_dt_scan_chosen_serial(unsigned long node,\n>\n> pr_debug(\"%s: depth: %d, uname: %s\\n\", __func__, depth, uname);\n>\n> - if (depth == 1 && (strcmp(uname, \"chosen\") == 0 ||\n> - strcmp(uname, \"chosen@0\") == 0)) {\n> + if (depth == 1 && (strcmp(uname, \"chosen\") == 0)) {\n\nI'd really hoped to remove early_init_dt_scan_chosen_serial()\naltogether. It may now be just a matter of adding the compatible\nstrings to the uartlite earlycon.\n\nRob","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmqFp5fTyz9t2W\n\tfor ;\n\tWed, 6 Sep 2017 00:43:10 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmqFp4sGvzDrT9\n\tfor ;\n\tWed, 6 Sep 2017 00:43:10 +1000 (AEST)","from mail.kernel.org (mail.kernel.org [198.145.29.99])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmqDc6cBczDrJ6\n\tfor ;\n\tWed, 6 Sep 2017 00:42:08 +1000 (AEST)","from mail-qt0-f177.google.com (mail-qt0-f177.google.com\n\t[209.85.216.177])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id DD9AC21E93\n\tfor ;\n\tTue, 5 Sep 2017 14:42:06 +0000 (UTC)","by mail-qt0-f177.google.com with SMTP id q8so8180971qtb.5\n\tfor ;\n\tTue, 05 Sep 2017 07:42:06 -0700 (PDT)","by 10.12.153.1 with HTTP; Tue, 5 Sep 2017 07:41:45 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=kernel.org\n\t(client-ip=198.145.29.99; helo=mail.kernel.org;\n\tenvelope-from=robh@kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org DD9AC21E93","X-Gm-Message-State":"AHPjjUho3Wskzhb5aQb2tnkEyt+i6YVsM6AXaUqa3Bp79dghIPwLQGze\n\t5ujjvnduNAF8dXMCt6kbQQCYa9SgXw==","X-Google-Smtp-Source":"ADKCNb54HFh8p9wvZ6VoyC5TnMTZKr/Q7Zz1W595tegxbAoxypWn6AlJ2OOEu3qdNsA/U7I/gF/63lf/u0n6k8MpVN8=","X-Received":"by 10.237.60.154 with SMTP id d26mr5940180qtf.87.1504622525928; \n\tTue, 05 Sep 2017 07:42:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"Rob Herring ","Date":"Tue, 5 Sep 2017 09:41:45 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","To":"\"Robert P. J. Day\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"devicetree@vger.kernel.org\" ,\n\tMichal Simek ,\n\tLinux PPC Mailing List ,\n\tLinux-MIPS ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1763655,"web_url":"http://patchwork.ozlabs.org/comment/1763655/","msgid":"","date":"2017-09-05T21:22:57","subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","submitter":{"id":2270,"url":"http://patchwork.ozlabs.org/api/people/2270/","name":"Robert P. J. Day","email":"rpjday@crashcourse.ca"},"content":"On Tue, 5 Sep 2017, Rob Herring wrote:\n\n> On Sun, Sep 3, 2017 at 5:43 AM, Robert P. J. Day wrote:\n> > On Sun, 3 Sep 2017, Benjamin Herrenschmidt wrote:\n> >\n> >> On Sat, 2017-09-02 at 04:43 -0400, Robert P. J. Day wrote:\n> >> > Since, according to a recent devicetree ML posting by Rob Herring,\n> >> > the node \"/chosen@0\" is most likely for real Open Firmware and\n> >> > does not apply to DTSpec, remove all remaining tests and\n> >> > references for that node, of which there are very few left:\n> >>\n> >> Technically that would break Open Firmware systems where the node is\n> >> really called chosen@0\n> >>\n> >> Now I'm not sure such a thing actually exist however.\n> >>\n> >> My collection of DTs don't seem to have one, except in the ancient\n> >> html variants that were extracted by the pengionppc folks for the\n> >> original PowerMac 8600 but I wonder if that's a bug in the\n> >> extraction script since they also have @0 on /packages etc...\n> >\n> > obviously, this isn't a priority issue, i was just working off a\n> > comment by rob herring that \"chosen@0\" is not defined by the current\n> > DTSpec 0.1, so it seemed appropriate to toss it. if there's a reason\n> > to hang onto it, that's fine with me.\n> >\n> > however, given the diff stat of the change to remove every single\n> > reference to that node name in the current kernel source:\n> >\n> > arch/microblaze/kernel/prom.c | 3 +--\n> > arch/mips/generic/yamon-dt.c | 4 ----\n> > arch/powerpc/boot/oflib.c | 7 ++-----\n> > drivers/of/base.c | 2 --\n> > drivers/of/fdt.c | 5 +----\n> > 5 files changed, 4 insertions(+), 17 deletions(-)\n> >\n> > it seems inconsistent that three architectures would be testing for\n> > that node, but none of the rest. consistency suggests that every\n> > architecture should take it into account, or none should.\n>\n> I generally agree and have moved various things from arch to\n> drivers/of/ to ensure that. But for legacy things, we have to allow\n> for exceptions. I agree with Ben and think that microblaze (they\n> generally just copied PPC), MIPS, and the FDT code in drivers/of/ can\n> be changed.\n\n i'm not quite sure what people have agreed on, so i'll just leave it\nin the hands of others here to submit patches for what they think is\nappropriate.\n\nrday","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xn08N57zPz9s7c\n\tfor ;\n\tWed, 6 Sep 2017 07:24:04 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xn08N4Bl4zDrTl\n\tfor ;\n\tWed, 6 Sep 2017 07:24:04 +1000 (AEST)","from cpanel2.indieserve.net (cpanel2.indieserve.net\n\t[199.212.143.6])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xn07F1P4RzDqZ8\n\tfor ;\n\tWed, 6 Sep 2017 07:23:04 +1000 (AEST)","from cpec03f0ed08c7f-cm68b6fcf980b0.cpe.net.cable.rogers.com\n\t([174.118.92.171]:51466 helo=localhost.localdomain)\n\tby cpanel2.indieserve.net with esmtpsa\n\t(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1dpLJD-0006Ji-Ft; Tue, 05 Sep 2017 17:22:59 -0400"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=crashcourse.ca\n\t(client-ip=199.212.143.6; helo=cpanel2.indieserve.net;\n\tenvelope-from=rpjday@crashcourse.ca; receiver=)","Date":"Tue, 5 Sep 2017 17:22:57 -0400 (EDT)","From":"\"Robert P. J. Day\" ","X-X-Sender":"rpjday@localhost.localdomain","To":"Rob Herring ","Subject":"Re: [PATCH] devicetree: Remove remaining references/tests for\n\t\"chosen@0\"","In-Reply-To":"","Message-ID":"","References":"\n\t<1504390854.4974.108.camel@kernel.crashing.org>\n\t\n\t","User-Agent":"Alpine 2.21 (LFD 202 2017-01-01)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","X-AntiAbuse":["This header was added to track abuse,\n\tplease include it with any abuse report","Primary Hostname - cpanel2.indieserve.net","Original Domain - lists.ozlabs.org","Originator/Caller UID/GID - [47 12] / [47 12]","Sender Address Domain - crashcourse.ca"],"X-Get-Message-Sender-Via":"cpanel2.indieserve.net: authenticated_id:\n\trpjday+crashcourse.ca/only user confirmed/virtual account not\n\tconfirmed","X-Authenticated-Sender":"cpanel2.indieserve.net: rpjday@crashcourse.ca","X-Source":"","X-Source-Args":"","X-Source-Dir":"","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michal Simek , Linux-MIPS , \n\tLinux PPC Mailing List ,\n\t\"devicetree@vger.kernel.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]