[{"id":1762158,"web_url":"http://patchwork.ozlabs.org/comment/1762158/","msgid":"<20170902163057.GB5463@lunn.ch>","list_archive_url":null,"date":"2017-09-02T16:30:57","subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)\n> \treg |= MII_DUMB_FWDG_EN;\n> \tcore_writel(priv, reg, CORE_SWITCH_CTRL);\n> \n> +\t/* Configure Traffic Class to QoS mapping, allow each priority to map\n> +\t * to a different queue number\n> +\t */\n> +\treg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));\n> +\tfor (i = 0; i < 8; i++)\n> +\t\treg |= i << (PRT_TO_QID_SHIFT * i);\n\nHi Florian\n\nRather than 8, would ds->num_tx_queues be more descriptive?\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl1nh4Rs6z9t16\n\tfor ;\n\tSun, 3 Sep 2017 02:31:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752743AbdIBQbC (ORCPT );\n\tSat, 2 Sep 2017 12:31:02 -0400","from vps0.lunn.ch ([178.209.37.122]:54500 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752712AbdIBQbB (ORCPT );\n\tSat, 2 Sep 2017 12:31:01 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1doBJx-0001sX-RJ; Sat, 02 Sep 2017 18:30:57 +0200"],"Date":"Sat, 2 Sep 2017 18:30:57 +0200","From":"Andrew Lunn ","To":"Florian Fainelli ","Cc":"netdev@vger.kernel.org, davem@davemloft.net,\n\tvivien.didelot@savoirfairelinux.com, jiri@resnulli.us,\n\tjhs@mojatatu.com, xiyou.wangcong@gmail.com","Subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","Message-ID":"<20170902163057.GB5463@lunn.ch>","References":"<1504310354-42773-1-git-send-email-f.fainelli@gmail.com>\n\t<1504310354-42773-5-git-send-email-f.fainelli@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504310354-42773-5-git-send-email-f.fainelli@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762159,"web_url":"http://patchwork.ozlabs.org/comment/1762159/","msgid":"","list_archive_url":null,"date":"2017-09-02T16:32:08","subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/02/2017 09:30 AM, Andrew Lunn wrote:\n>> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)\n>> \treg |= MII_DUMB_FWDG_EN;\n>> \tcore_writel(priv, reg, CORE_SWITCH_CTRL);\n>> \n>> +\t/* Configure Traffic Class to QoS mapping, allow each priority to map\n>> +\t * to a different queue number\n>> +\t */\n>> +\treg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));\n>> +\tfor (i = 0; i < 8; i++)\n>> +\t\treg |= i << (PRT_TO_QID_SHIFT * i);\n> \n> Hi Florian\n> \n> Rather than 8, would ds->num_tx_queues be more descriptive?\n\nI actually have a patch on top of this which defines a constant for the\nnumber of queues instead of open coding 8 here. Thanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rn8HGtdK\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl1q31KLXz9t16\n\tfor ;\n\tSun, 3 Sep 2017 02:32:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752747AbdIBQcM (ORCPT );\n\tSat, 2 Sep 2017 12:32:12 -0400","from mail-oi0-f47.google.com ([209.85.218.47]:34771 \"EHLO\n\tmail-oi0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752702AbdIBQcL (ORCPT\n\t); Sat, 2 Sep 2017 12:32:11 -0400","by mail-oi0-f47.google.com with SMTP id w10so20902136oie.1\n\tfor ; Sat, 02 Sep 2017 09:32:11 -0700 (PDT)","from ?IPv6:2001:470:d:73f:c96d:ffbc:6d05:de5c?\n\t([2001:470:d:73f:c96d:ffbc:6d05:de5c])\n\tby smtp.gmail.com with ESMTPSA id\n\th125sm3227298oic.54.2017.09.02.09.32.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 09:32:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=eIMD33V2GdKB5s2T42K2QesS2MluXaB6OuEcR1Xb+/U=;\n\tb=rn8HGtdKPTo5Fs5nV4AHhDacBH6PGBaIn5FIvJT/v5Pf4EljXknktYU4GWt2AxDACw\n\tYiAqQfJG/tY5hY5vHvdRBrQu5mCNA2XQpfmV+MPOl33edk7V73r/btDpXZi0EgCKC5we\n\tc5U3GI0RS1zolz6vBnH3Q+Mtl9Jvq1VQJfICYSMENtUiJnDqbPZCCw9BnyYePlRJtH1m\n\t6ssOuGH9sBX2LzysnADM9sdwfnLWd0Miql/x0R7QXDG7FmfApBnLUWjtYFijtW0jx9j1\n\tSaM6sDDdnpOYfzLtgz2JfNtWOWiIkXQZVK1FRiQiFBfaIXdN1A+wQYdV0GJDrYqnD3u1\n\tNnxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=eIMD33V2GdKB5s2T42K2QesS2MluXaB6OuEcR1Xb+/U=;\n\tb=myoicw3Tf4W6Uo98x3QfE0ulYeAZQjAiH9UaqZM2a5f0IV0zqL6yE9Ffb3yPDRUSeO\n\tKQ5CQOjSYpHvJDBCKtje65wq7da1fxLcFQR0/8ycMuDTiAGpsWHw2F8OpHVOi8EniThs\n\tA6DTgfSjv1DCLKasMUE/qJCTKrJFvgwh3sHjaFKDH8C2ec+kPpyF/WBHh9CZoPXSPoyI\n\tMwLgvdZ4KDOmXs3wpUA5T3xwQnCX9xqoAV8gULj9BOpWKn8AVCDCCtOK0NOpRMsxDJyi\n\tu7rGzu3zknMUAm6jtZBNevW/iYd58OzWT+0/9o/6lJ6+TNltBySpxX75m85JeZ8uTqOf\n\tNfLg==","X-Gm-Message-State":"AHPjjUiir4ZNkYtdDSgjuXONRvbFN3zkqd35LxoDy5+Yhd+bf32isU91\n\tHESdlvlU01beHZW7bZE=","X-Google-Smtp-Source":"ADKCNb5l0WbpID4Gip78iNbfk0G0EVffQKytf4l6QC8dzf8sQSj1PG0xIMpuL0MzXyQAukgV0aimQQ==","X-Received":"by 10.202.62.138 with SMTP id l132mr4775277oia.315.1504369931165;\n\tSat, 02 Sep 2017 09:32:11 -0700 (PDT)","Subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","To":"Andrew Lunn ","Cc":"netdev@vger.kernel.org, davem@davemloft.net,\n\tvivien.didelot@savoirfairelinux.com, jiri@resnulli.us,\n\tjhs@mojatatu.com, xiyou.wangcong@gmail.com","References":"<1504310354-42773-1-git-send-email-f.fainelli@gmail.com>\n\t<1504310354-42773-5-git-send-email-f.fainelli@gmail.com>\n\t<20170902163057.GB5463@lunn.ch>","From":"Florian Fainelli ","Message-ID":"","Date":"Sat, 2 Sep 2017 09:32:08 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170902163057.GB5463@lunn.ch>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762170,"web_url":"http://patchwork.ozlabs.org/comment/1762170/","msgid":"<20170902174753.GA8981@lunn.ch>","list_archive_url":null,"date":"2017-09-02T17:47:53","subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Sat, Sep 02, 2017 at 09:32:08AM -0700, Florian Fainelli wrote:\n> \n> \n> On 09/02/2017 09:30 AM, Andrew Lunn wrote:\n> >> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)\n> >> \treg |= MII_DUMB_FWDG_EN;\n> >> \tcore_writel(priv, reg, CORE_SWITCH_CTRL);\n> >> \n> >> +\t/* Configure Traffic Class to QoS mapping, allow each priority to map\n> >> +\t * to a different queue number\n> >> +\t */\n> >> +\treg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));\n> >> +\tfor (i = 0; i < 8; i++)\n> >> +\t\treg |= i << (PRT_TO_QID_SHIFT * i);\n> > \n> > Hi Florian\n> > \n> > Rather than 8, would ds->num_tx_queues be more descriptive?\n> \n> I actually have a patch on top of this which defines a constant for the\n> number of queues instead of open coding 8 here. Thanks!\n\nHi Florian\n\nIt sounds like it should be part of 3/4?\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl3Vh2PX7z9t16\n\tfor ;\n\tSun, 3 Sep 2017 03:48:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752734AbdIBRr7 (ORCPT );\n\tSat, 2 Sep 2017 13:47:59 -0400","from vps0.lunn.ch ([178.209.37.122]:54548 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752708AbdIBRr6 (ORCPT );\n\tSat, 2 Sep 2017 13:47:58 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1doCWP-0002Nm-Od; Sat, 02 Sep 2017 19:47:53 +0200"],"Date":"Sat, 2 Sep 2017 19:47:53 +0200","From":"Andrew Lunn ","To":"Florian Fainelli ","Cc":"netdev@vger.kernel.org, davem@davemloft.net,\n\tvivien.didelot@savoirfairelinux.com, jiri@resnulli.us,\n\tjhs@mojatatu.com, xiyou.wangcong@gmail.com","Subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","Message-ID":"<20170902174753.GA8981@lunn.ch>","References":"<1504310354-42773-1-git-send-email-f.fainelli@gmail.com>\n\t<1504310354-42773-5-git-send-email-f.fainelli@gmail.com>\n\t<20170902163057.GB5463@lunn.ch>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762171,"web_url":"http://patchwork.ozlabs.org/comment/1762171/","msgid":"","list_archive_url":null,"date":"2017-09-02T17:57:26","subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/02/2017 10:47 AM, Andrew Lunn wrote:\n> On Sat, Sep 02, 2017 at 09:32:08AM -0700, Florian Fainelli wrote:\n>>\n>>\n>> On 09/02/2017 09:30 AM, Andrew Lunn wrote:\n>>>> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)\n>>>> \treg |= MII_DUMB_FWDG_EN;\n>>>> \tcore_writel(priv, reg, CORE_SWITCH_CTRL);\n>>>> \n>>>> +\t/* Configure Traffic Class to QoS mapping, allow each priority to map\n>>>> +\t * to a different queue number\n>>>> +\t */\n>>>> +\treg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));\n>>>> +\tfor (i = 0; i < 8; i++)\n>>>> +\t\treg |= i << (PRT_TO_QID_SHIFT * i);\n>>>\n>>> Hi Florian\n>>>\n>>> Rather than 8, would ds->num_tx_queues be more descriptive?\n>>\n>> I actually have a patch on top of this which defines a constant for the\n>> number of queues instead of open coding 8 here. Thanks!\n> \n> Hi Florian\n> \n> It sounds like it should be part of 3/4?\n\nRight, let me re-submit with that change included. Thanks","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZpItJSJL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl3jc1ps9z9sDB\n\tfor ;\n\tSun, 3 Sep 2017 03:57:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752740AbdIBR5b (ORCPT );\n\tSat, 2 Sep 2017 13:57:31 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:35487 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752709AbdIBR5a (ORCPT\n\t); Sat, 2 Sep 2017 13:57:30 -0400","by mail-oi0-f66.google.com with SMTP id n18so2404669oig.2\n\tfor ; Sat, 02 Sep 2017 10:57:30 -0700 (PDT)","from ?IPv6:2001:470:d:73f:1d55:c0f3:a20f:c4aa?\n\t([2001:470:d:73f:1d55:c0f3:a20f:c4aa])\n\tby smtp.gmail.com with ESMTPSA id\n\ts83sm3219489oif.39.2017.09.02.10.57.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 10:57:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=u4/m0/TQzqf+SxIDmURzKV9AnXay1URDO22MBrsYRM4=;\n\tb=ZpItJSJL6V67YsAuuKYEgvEjUOjLX2MsLsQfmy9q5agJCThC9XZnNckkqR7VtzYdbp\n\tPA/hnuLBfVAMVHQ/M7CZVx9BOgUBIn41m7tZ7KFEfMZ4wWhiJPRsgfEV21xrknN8/gjC\n\t4iM5ASQc06P6XQwgs6Fa/IX9lBX3W35XMkaS9OQDBlVG/0fH/XwUzY+WYnmUBar1nUpF\n\tlP1yXLo8L1SNdcrYYhm5sLXZp7Ny8B4rdgsUWtFEHrsGPuXRvSOmLVR+x3e/XhRYg+RL\n\tzS56RW3s5vsPwnMEg4+XIX4fVauad+cQXFDpcFJXZwvNVjJvwxdaUz9VNowo72t2Rssb\n\tN7mA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=u4/m0/TQzqf+SxIDmURzKV9AnXay1URDO22MBrsYRM4=;\n\tb=feBV4VA86EKuOZBcGtMhAtfEr4/we8B/N7cZkVRd317kD8/P0jInXdqnvOmV4NDIY4\n\tjBlxiHrGuFehVqu+GMXPrsqpQKG62YvRz02QZkIzCvt6ivUIixefIam+FhJMg02MYDCg\n\tjn5rVHrARKGE3bHxsnATpVz9xXJuYzwxBQnISr1O8AnpPzQ9+Dr4Z/6bIJkJyxL1xJYN\n\tTM7A5A2aNEac1vsUCjj4LJ2GXCqdh5MCYSHIBUULXfDpWecjj8xEQ4E+XvtCYXd9GPHN\n\tPyqQjjbRjK+i7EzBU010DQq81gH6U5WOJNDl0PhSMp1wckQFnHQzSFABgFI1Lbw8OFRP\n\tELxw==","X-Gm-Message-State":"AHPjjUhAaWpTCTJ3bfWHLi36wOpVn8Z7r4VX0eAcRXbI9PAcOWo6LaOf\n\tJrWnZl2HHAPidw==","X-Google-Smtp-Source":"ADKCNb6L+HY1vEn63/T0HD2L64AW/WA9lIhKrMAaQJK6KURYQezML2/5S8RJ4mvtZ4RyEYELkT3WYw==","X-Received":"by 10.202.83.67 with SMTP id h64mr6910800oib.24.1504375049845;\n\tSat, 02 Sep 2017 10:57:29 -0700 (PDT)","Subject":"Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port\n\tTC2QOS mapping","To":"Andrew Lunn ","Cc":"netdev@vger.kernel.org, davem@davemloft.net,\n\tvivien.didelot@savoirfairelinux.com, jiri@resnulli.us,\n\tjhs@mojatatu.com, xiyou.wangcong@gmail.com","References":"<1504310354-42773-1-git-send-email-f.fainelli@gmail.com>\n\t<1504310354-42773-5-git-send-email-f.fainelli@gmail.com>\n\t<20170902163057.GB5463@lunn.ch>\n\t\n\t<20170902174753.GA8981@lunn.ch>","From":"Florian Fainelli ","Message-ID":"","Date":"Sat, 2 Sep 2017 10:57:26 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170902174753.GA8981@lunn.ch>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]