[{"id":1761984,"web_url":"http://patchwork.ozlabs.org/comment/1761984/","msgid":"","list_archive_url":null,"date":"2017-08-31T23:45:37","subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid, so\n> switch to this in all callers.\n\nNot seeing the rest of patches it is unclear from the patch\ndescription why this is needed/wanted.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CY3Yxyrg\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkXM61MxKz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:24:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2D18A887D1;\n\tFri, 1 Sep 2017 21:24:48 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8pUPyiH19iPa; Fri, 1 Sep 2017 21:24:45 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0A7408A37D;\n\tFri, 1 Sep 2017 21:24:45 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id BF4101CE899\n\tfor ;\n\tThu, 31 Aug 2017 23:45:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B602587A5D\n\tfor ;\n\tThu, 31 Aug 2017 23:45:43 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y2CgiW3Wi9uv for ;\n\tThu, 31 Aug 2017 23:45:39 +0000 (UTC)","from mail-vk0-f48.google.com (mail-vk0-f48.google.com\n\t[209.85.213.48])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 283B987A18\n\tfor ;\n\tThu, 31 Aug 2017 23:45:39 +0000 (UTC)","by mail-vk0-f48.google.com with SMTP id x85so2992452vkx.5\n\tfor ;\n\tThu, 31 Aug 2017 16:45:39 -0700 (PDT)","by 10.176.19.242 with HTTP; Thu, 31 Aug 2017 16:45:37 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=7S5wCFKWdws42VlK1B7ur75tyJRdgVmPwWXmTLmkjVA=;\n\tb=CY3YxyrgMi8VumEYUxzXsvoyl4AW9NfeVB2ABdAG2AfoPCYSRAe5tXtXQUshHvTtD/\n\t5aq5+ooMM4HlnhXDSFSKIwuAB4Y2GDQ09PH51Z1LGUtlfsjMLIZep4QeApNg88aKx7Hh\n\tQSMOWkzL3kRrX559K8KcxRtUh8+U8avZSkq3gZYRZta5jvFFwKT4t0eD/vMrXVMdVBMK\n\trzJWtUEPe8V2gKVcJqFE1Luteot96uoyWPN0tv0XJ0KBEHKxF2Odi0sbi2SveQef+VSu\n\tIG1AROMm0F+qI0aJSt396LW4TTjc9aB22vCW+Ev/YfUtUmw/NsOxZm/Ry8ohxFaFeHt1\n\tOAHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=7S5wCFKWdws42VlK1B7ur75tyJRdgVmPwWXmTLmkjVA=;\n\tb=kMXKEbNy5oXbjcyrQ2mjc0Wn+Yi3jZgPEaWX6urJP0+6ToznPSxHJD7zuNi0xoHfuw\n\tQVRer9C+dlF6p+r9hdPi3kQrso4jaxbIPmO+iMhoRPaw8UJ9hDQjwZ/hp14BAOaEfCHI\n\tWzmfO/kmysQkghUOVHBLC2Eg1ac5FtxLE91OgjmfLJrYnVjbBg8YUwEnaELKcm3O3Do9\n\tWWcdQiMJt0LMpmhGJG0kKoVSn/cLEENTtwmKHPoR+Okt2e3wj0liDCqzj9vx6fMrm9rf\n\toGL0hUTFph5QHJFBc2tMrhQb8SocRmY/XyzhG81B+I3tY9QfDfPpZtKIXmCL64HS3X5R\n\tVIMQ==","X-Gm-Message-State":"AHPjjUid2X7crKzJ/icPU3w+8CbE1fHGKXgpTYUvEu7JIyyLeAyRU/GT\n\tP3IEcEzlcWY6PERsnmKOCJ70woLPaQ==","X-Google-Smtp-Source":"ADKCNb7BOuuwhx8c1P1uyVWRRkShZp/eA+ZW0cXWbz7B7wSZd7zEcbb4vMN+FN+k/AHlF5493HrqFzo/lh1niCVCIFE=","X-Received":"by 10.31.8.79 with SMTP id 76mr66821vki.151.1504223137883;\n\tThu, 31 Aug 2017 16:45:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","From":"Dmitry Torokhov ","Date":"Thu, 31 Aug 2017 16:45:37 -0700","Message-ID":"","To":"Kees Cook ","X-Mailman-Approved-At":"Fri, 01 Sep 2017 21:24:44 +0000","Cc":"Len Brown ,\n\tMike Marciniszyn ,\n\t\"linux-pm@vger.kernel.org\" ,\n\tlinux-rdma@vger.kernel.org,\n\tGreg Kroah-Hartman , \n\tDennis Dalessandro ,\n\t\"Rafael J. Wysocki\" ,\n\tlkml , \n\tHal Rosenstock ,\n\tDoug Ledford , \n\tnetdev , intel-wired-lan@lists.osuosl.org,\n\tPavel Machek ,\n\t\"linux-input@vger.kernel.org\" ,\n\tThomas Gleixner , Sean Hefty ","Subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1761985,"web_url":"http://patchwork.ozlabs.org/comment/1761985/","msgid":"","list_archive_url":null,"date":"2017-09-01T01:06:29","subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook wrote:\n> On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov\n> wrote:\n>> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote:\n>>> In several places, .data is checked for initialization to gate early\n>>> calls to del_timer_sync(). Checking for .function is equally valid, so\n>>> switch to this in all callers.\n>>\n>> Not seeing the rest of patches it is unclear from the patch\n>> description why this is needed/wanted.\n>\n> The CC list would have been really giant, but here is the first patch\n> and the earlier series list:\n>\n> https://lkml.org/lkml/2017/8/31/904\n> https://lkml.org/lkml/2017/8/30/760\n>\n> tl;dr: We're going to switch all struct timer_list callbacks to get\n> the timer pointer as the argument instead of from the .data field.\n> This patch is one step in removing open-coded users of the .data\n> field.\n>\n\nAnd that is exactly what should have been in the patch description.\n\nFWIW for input bits:\n\nAcked-by: Dmitry Torokhov \n\nThanks.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"syUF5Y9y\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkXM63R2Cz9sRY\n\tfor ;\n\tSat, 2 Sep 2017 07:24:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EA3C988F59;\n\tFri, 1 Sep 2017 21:24:48 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NHJWscUgsZFM; Fri, 1 Sep 2017 21:24:46 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3D7DD88FD7;\n\tFri, 1 Sep 2017 21:24:46 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id D8D691C00BB\n\tfor ;\n\tFri, 1 Sep 2017 01:06:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D108F88A88\n\tfor ;\n\tFri, 1 Sep 2017 01:06:32 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o+sS6gXiRGlh for ;\n\tFri, 1 Sep 2017 01:06:31 +0000 (UTC)","from mail-ua0-f195.google.com (mail-ua0-f195.google.com\n\t[209.85.217.195])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 477808890C\n\tfor ;\n\tFri, 1 Sep 2017 01:06:31 +0000 (UTC)","by mail-ua0-f195.google.com with SMTP id c27so300106uah.1\n\tfor ;\n\tThu, 31 Aug 2017 18:06:31 -0700 (PDT)","by 10.176.19.242 with HTTP; Thu, 31 Aug 2017 18:06:29 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=r6WqfEA+P+1NxkVoCd+CuTQ7UoY9Db5GpktX1mKnEbY=;\n\tb=syUF5Y9yL/TNqSuW3yKTCu9uXBQTRckpYroC+mbg7deOOb2map+A3QTofYVb1YFNEG\n\tvtuUJJchmb0rFTGfyHIxD1uBYlCBGYT3RTTS2lIazNBwNCwWGhE3UOR5MmudP8nliPaf\n\tf7dxzGiIeGPiPnv3FmIP+G0IjdCadhwMLrD1bgl44j8ToCeG33eX5CLZ6+ECjPJv1r0R\n\t8YIevl/oHzreepyfC04nV4TPRAaANPzGWLKYTAAeN+OWaAtZw3RLqmw2uSv5js+aTYez\n\tm/UFcOSb6ykxmQK29OxQ6/okT4hRjh+4lniYNRpaZ4uPRHCW1UFhPd0uT6y/qKx54+Bf\n\tw+GQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=r6WqfEA+P+1NxkVoCd+CuTQ7UoY9Db5GpktX1mKnEbY=;\n\tb=YlQ/ZmePkG5/azDpZUD8hZLkC0agyYtrU04ebHZv7M8vABIwmuzfuSVaQcuL7KhCve\n\taV+k0YUIZhdtRI3dQZ/jmq/yyGOUsIXNAYiafLNu9iOl7TSqAHk6JqHa5PDOCVe8S7OO\n\tfXtveS8XNwmkEBBs21KTnaZZgvG0kiE930Wst+y+ZT3n4KTVS8lvp6RKTNsg8Xlvf3Zk\n\tyc1khjf1UBXiq0qjQry3EGCFvezVA3KCc+8r8R/0u2vYC0nmxyNSoFU56jDboh4micXs\n\t3yYZuD4NX5Kx3onRyGOZV5hQ9GpHWE+HjaFhR+dSISnL94jfPX5+rbNRdbSNNJahD523\n\tEqKg==","X-Gm-Message-State":"AHPjjUhm2E3VXzfCQG9iUGQKpqwZ6fDPfbfgZSwR3aeGmZDU9d9Lt8Jc\n\tejqLCPeKPG2+Ij/SPkdP+0UgRyFE9A==","X-Google-Smtp-Source":"ADKCNb5PX/r/Cql6nyUNxcDUaVKj/WpTDw+iunv2Zn9B//YVHSSYjdpSo/iuNIiPNd8eAVt92SAtcnbePWEd4Gpa6ZE=","X-Received":"by 10.176.90.50 with SMTP id l47mr217571uad.150.1504227990060;\n\tThu, 31 Aug 2017 18:06:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>\n\t\n\t","From":"Dmitry Torokhov ","Date":"Thu, 31 Aug 2017 18:06:29 -0700","Message-ID":"","To":"Kees Cook ","X-Mailman-Approved-At":"Fri, 01 Sep 2017 21:24:44 +0000","Cc":"Len Brown ,\n\tMike Marciniszyn ,\n\t\"linux-pm@vger.kernel.org\" ,\n\tlinux-rdma ,\n\tGreg Kroah-Hartman ,\n\tDennis Dalessandro ,\n\t\"Rafael J. Wysocki\" ,\n\tlkml , \n\tHal Rosenstock ,\n\tDoug Ledford , \n\tnetdev , intel-wired-lan@lists.osuosl.org,\n\tPavel Machek ,\n\t\"linux-input@vger.kernel.org\" ,\n\tThomas Gleixner , Sean Hefty ","Subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1761999,"web_url":"http://patchwork.ozlabs.org/comment/1761999/","msgid":"<1504301657.3922.47.camel@intel.com>","list_archive_url":null,"date":"2017-09-01T21:34:17","subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Thu, 2017-08-31 at 16:29 -0700, Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid,\n> so\n> switch to this in all callers.\n> \n> Cc: \"Rafael J. Wysocki\" \n> Cc: Pavel Machek \n> Cc: Len Brown \n> Cc: Greg Kroah-Hartman \n> Cc: Mike Marciniszyn \n> Cc: Dennis Dalessandro \n> Cc: Doug Ledford \n> Cc: Sean Hefty \n> Cc: Hal Rosenstock \n> Cc: Dmitry Torokhov \n> Cc: Jeff Kirsher \n> Cc: linux-pm@vger.kernel.org\n> Cc: linux-rdma@vger.kernel.org\n> Cc: linux-input@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook \n\nFor the changes to i40e...\n\nAcked-by: Jeff Kirsher ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkXbN41TJz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:35:28 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E292088E16;\n\tFri, 1 Sep 2017 21:35:26 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ea9jy66MPR-X; Fri, 1 Sep 2017 21:35:24 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AC70D88CA2;\n\tFri, 1 Sep 2017 21:35:24 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 411691C143E\n\tfor ;\n\tFri, 1 Sep 2017 21:34:27 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3740C8A372\n\tfor ;\n\tFri, 1 Sep 2017 21:34:27 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mF-YZu9hQiUe for ;\n\tFri, 1 Sep 2017 21:34:26 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 380CF8A371\n\tfor ;\n\tFri, 1 Sep 2017 21:34:26 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga104.jf.intel.com with ESMTP; 01 Sep 2017 14:34:25 -0700","from maguila2-mobl.amr.corp.intel.com ([10.252.196.46])\n\tby fmsmga006.fm.intel.com with ESMTP; 01 Sep 2017 14:34:24 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498546800\"; \n\td=\"asc'?scan'208\";a=\"147251982\"","Message-ID":"<1504301657.3922.47.camel@intel.com>","From":"Jeff Kirsher ","To":"Kees Cook , Thomas Gleixner ","Date":"Fri, 01 Sep 2017 14:34:17 -0700","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","X-Mailman-Approved-At":"Fri, 01 Sep 2017 21:35:23 +0000","Cc":"Len Brown ,\n\tMike Marciniszyn , linux-pm@vger.kernel.org, \n\tlinux-rdma@vger.kernel.org,\n\tGreg Kroah-Hartman , \n\tDennis Dalessandro ,\n\tDmitry Torokhov ,\n\t\"Rafael J. Wysocki\" , linux-kernel@vger.kernel.org,\n\tDoug Ledford , netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, Pavel Machek ,\n\tlinux-input@vger.kernel.org, Sean Hefty ,\n\tHal Rosenstock ","Subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============9085245000764940604==\"","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1762179,"web_url":"http://patchwork.ozlabs.org/comment/1762179/","msgid":"<1857082.urnTVIQKcg@aspire.rjw.lan>","list_archive_url":null,"date":"2017-09-02T13:47:20","subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","submitter":{"id":26536,"url":"http://patchwork.ozlabs.org/api/people/26536/","name":"Rafael J. Wysocki","email":"rjw@rjwysocki.net"},"content":"On Friday, September 1, 2017 1:29:43 AM CEST Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid, so\n> switch to this in all callers.\n> \n> Cc: \"Rafael J. Wysocki\" \n> Cc: Pavel Machek \n> Cc: Len Brown \n> Cc: Greg Kroah-Hartman \n> Cc: Mike Marciniszyn \n> Cc: Dennis Dalessandro \n> Cc: Doug Ledford \n> Cc: Sean Hefty \n> Cc: Hal Rosenstock \n> Cc: Dmitry Torokhov \n> Cc: Jeff Kirsher \n> Cc: linux-pm@vger.kernel.org\n> Cc: linux-rdma@vger.kernel.org\n> Cc: linux-input@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook \n> ---\n> drivers/base/power/wakeup.c | 3 +--\n> drivers/infiniband/hw/hfi1/chip.c | 6 ++----\n> drivers/infiniband/hw/hfi1/init.c | 2 +-\n> drivers/infiniband/hw/qib/qib_iba7220.c | 2 +-\n> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-\n> drivers/infiniband/hw/qib/qib_init.c | 14 +++++---------\n> drivers/infiniband/hw/qib/qib_mad.c | 2 +-\n> drivers/input/input.c | 5 ++---\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n> 9 files changed, 15 insertions(+), 23 deletions(-)\n> \n> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c\n> index 144e6d8fafc8..79a3c1b204af 100644\n> --- a/drivers/base/power/wakeup.c\n> +++ b/drivers/base/power/wakeup.c\n> @@ -479,8 +479,7 @@ static bool wakeup_source_not_registered(struct wakeup_source *ws)\n> \t * Use timer struct to check if the given source is initialized\n> \t * by wakeup_source_add.\n> \t */\n> -\treturn ws->timer.function != pm_wakeup_timer_fn ||\n> -\t\t ws->timer.data != (unsigned long)ws;\n> +\treturn ws->timer.function != pm_wakeup_timer_fn;\n> }\n> \n> /*\n\nAcked-by: Rafael J. Wysocki \n\nfor the above.\n\nThanks!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl6Lx4LLrz9s7h\n\tfor ;\n\tSun, 3 Sep 2017 05:56:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4B85888B57;\n\tSat, 2 Sep 2017 19:56:39 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9HTF3lxVgaJR; Sat, 2 Sep 2017 19:56:37 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 000A088B2E;\n\tSat, 2 Sep 2017 19:56:36 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E68EA1C3F8C\n\tfor ;\n\tSat, 2 Sep 2017 13:56:09 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DED1B8769E\n\tfor ;\n\tSat, 2 Sep 2017 13:56:09 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LasddVT3fpwv for ;\n\tSat, 2 Sep 2017 13:56:08 +0000 (UTC)","from cloudserver094114.home.net.pl (cloudserver094114.home.net.pl\n\t[79.96.170.134])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id F13F587698\n\tfor ;\n\tSat, 2 Sep 2017 13:56:07 +0000 (UTC)","from 79.184.253.199.ipv4.supernova.orange.pl (79.184.253.199) (HELO\n\taspire.rjw.lan)\n\tby serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer\n\t0.82) id dcd8555db90b710d; Sat, 2 Sep 2017 15:56:04 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","From":"\"Rafael J. Wysocki\" ","To":"Kees Cook ","Date":"Sat, 02 Sep 2017 15:47:20 +0200","Message-ID":"<1857082.urnTVIQKcg@aspire.rjw.lan>","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","MIME-Version":"1.0","X-Mailman-Approved-At":"Sat, 02 Sep 2017 19:56:35 +0000","Cc":"Len Brown ,\n\tMike Marciniszyn , linux-pm@vger.kernel.org, \n\tlinux-rdma@vger.kernel.org,\n\tGreg Kroah-Hartman , \n\tDennis Dalessandro ,\n\tDmitry Torokhov ,\n\tlinux-kernel@vger.kernel.org, Hal Rosenstock ,\n\tDoug Ledford , \n\tnetdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tPavel Machek , linux-input@vger.kernel.org,\n\tThomas Gleixner , Sean Hefty ","Subject":"Re: [Intel-wired-lan] [PATCH 31/31] timer: Switch to testing for\n\t.function instead of .data","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]