[{"id":1762048,"web_url":"http://patchwork.ozlabs.org/comment/1762048/","msgid":"<20170901.173349.1060795224955256278.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-02T00:33:49","subject":"Re: [PATCH net-next] inetpeer: fix RCU lookup()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet \nDate: Fri, 01 Sep 2017 14:03:32 -0700\n\n> From: Eric Dumazet \n> \n> Excess of seafood or something happened while I cooked the commit\n> adding RB tree to inetpeer.\n> \n> Of course, RCU rules need to be respected or bad things can happen.\n> \n> In this particular loop, we need to read *pp once per iteration, not\n> twice.\n> \n> Fixes: b145425f269a (\"inetpeer: remove AVL implementation in favor of RB tree\")\n> Reported-by: John Sperbeck \n> Signed-off-by: Eric Dumazet \n\nCheers for excess seafood :-)\n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkcYM6Xltz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 10:33:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752634AbdIBAdy (ORCPT );\n\tFri, 1 Sep 2017 20:33:54 -0400","from shards.monkeyblade.net ([184.105.139.130]:55736 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752622AbdIBAdy (ORCPT\n\t); Fri, 1 Sep 2017 20:33:54 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9B32B13534D88;\n\tFri, 1 Sep 2017 17:33:53 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 17:33:49 -0700 (PDT)","Message-Id":"<20170901.173349.1060795224955256278.davem@davemloft.net>","To":"eric.dumazet@gmail.com","Cc":"netdev@vger.kernel.org","Subject":"Re: [PATCH net-next] inetpeer: fix RCU lookup()","From":"David Miller ","In-Reply-To":"<1504299812.15310.26.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<1504299812.15310.26.camel@edumazet-glaptop3.roam.corp.google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 17:33:53 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]