[{"id":1762002,"web_url":"http://patchwork.ozlabs.org/comment/1762002/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9769@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-01T21:37:10","subject":"Re: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize\n\tand\tre-number feature flags","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Jeff Kirsher\n> Sent: Friday, September 1, 2017 1:54 PM\n> To: intel-wired-lan@lists.osuosl.org\n> Subject: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and re-\n> number feature flags\n> \n> From: Jacob Keller \n> \n> Now that we've reduced the number of flags, organize similar flags together\n> and re-number them accordingly.\n> \n> Since we don't yet have more than 32 flags, we'll use a u32 for both the\n> hw_features and flag field. Should we gain more flags in the future, we may\n> need to convert to a u64 or separate flags out into two fields.\n> \n> One alternative approach considered, but not implemented here, was to use\n> an enumeration for the flag variables, and create a macro\n> I40E_FLAG() which used string concatenation to generate BIT_ULL values.\n> This has the advantage of making the actual bit values compile-time dynamic\n> so that we do not need to worry about matching the order to the bit value.\n> However, this does produce a high level of code churn, and makes it more\n> difficult to read a dumped flags value when debugging.\n> \n> v3: rebased patch based on the current dev-queue branch\n> \n> Signed-off-by: Jacob Keller \n> Reviewed-by: Mitch Williams \n> Change-ID: I8653fff69453cd547d6fe98d29dfa9d8710387d1\n> ---\n> drivers/net/ethernet/intel/i40e/i40e.h | 98 +++++++++++++-------------\n> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +-\n> drivers/net/ethernet/intel/i40evf/i40evf.h | 32 ++++-----\n> 3 files changed, 68 insertions(+), 68 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkXdV5FJqz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:37:18 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CCB3830BCD;\n\tFri, 1 Sep 2017 21:37:16 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tRsjslpOCViT; Fri, 1 Sep 2017 21:37:15 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6C47230BBF;\n\tFri, 1 Sep 2017 21:37:15 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0B4031C143E\n\tfor ;\n\tFri, 1 Sep 2017 21:37:14 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 00A6288C0D\n\tfor ;\n\tFri, 1 Sep 2017 21:37:14 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fqQKS-E4R39j for ;\n\tFri, 1 Sep 2017 21:37:12 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8E1BC88B9A\n\tfor ;\n\tFri, 1 Sep 2017 21:37:12 +0000 (UTC)","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Sep 2017 14:37:12 -0700","from orsmsx105.amr.corp.intel.com ([10.22.225.132])\n\tby fmsmga004.fm.intel.com with ESMTP; 01 Sep 2017 14:37:11 -0700","from orsmsx153.amr.corp.intel.com (10.22.226.247) by\n\tORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 1 Sep 2017 14:37:11 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX153.amr.corp.intel.com ([169.254.12.217]) with mapi id\n\t14.03.0319.002; Fri, 1 Sep 2017 14:37:11 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498546800\"; d=\"scan'208\";a=\"307090926\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and\n\tre-number feature flags","Thread-Index":"AQHTI2R+q06jfck/7UmJM9NAKO9HE6Kgjg9A","Date":"Fri, 1 Sep 2017 21:37:10 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EA9769@ORSMSX104.amr.corp.intel.com>","References":"<20170901205407.41800-1-jeffrey.t.kirsher@intel.com>","In-Reply-To":"<20170901205407.41800-1-jeffrey.t.kirsher@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDBkMzc5OTItNzk1My00MTdjLWIxYWQtZWRhNzY3MTg2MmJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IndDdEJpNWU1K0hWbzhXVXZERSszT1NUTmtJNm9CS3BydWlOZmRzUVFGTVk9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize\n\tand\tre-number feature flags","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1764981,"web_url":"http://patchwork.ozlabs.org/comment/1764981/","msgid":"<02874ECE860811409154E81DA85FBB5882A9EE9F@ORSMSX115.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-07T22:21:02","subject":"Re: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and\n\tre-number feature flags","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"> -----Original Message-----\n> From: Kirsher, Jeffrey T\n> Sent: Friday, September 01, 2017 1:54 PM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: Keller, Jacob E \n> Subject: [next-queue v3] i40e/i40evf: organize and re-number feature flags\n> \n> From: Jacob Keller \n> \n> Now that we've reduced the number of flags, organize similar flags\n> together and re-number them accordingly.\n> \n> Since we don't yet have more than 32 flags, we'll use a u32 for both the\n> hw_features and flag field. Should we gain more flags in the future, we\n> may need to convert to a u64 or separate flags out into two fields.\n> \n> One alternative approach considered, but not implemented here, was to\n> use an enumeration for the flag variables, and create a macro\n> I40E_FLAG() which used string concatenation to generate BIT_ULL values.\n> This has the advantage of making the actual bit values compile-time\n> dynamic so that we do not need to worry about matching the order to the\n> bit value. However, this does produce a high level of code churn, and\n> makes it more difficult to read a dumped flags value when debugging.\n> \n> v3: rebased patch based on the current dev-queue branch\n> \n> Signed-off-by: Jacob Keller \n> Reviewed-by: Mitch Williams \n> Change-ID: I8653fff69453cd547d6fe98d29dfa9d8710387d1\n> ---\n\nThis version has a u64 instead of u32 for the flags variable, and that causes cmpxchg warnings. I sent a v4 to resolve this.\n\nThanks,\nJake","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpFKN5RKSz9s71\n\tfor ;\n\tFri, 8 Sep 2017 08:21:12 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BB71688BA6;\n\tThu, 7 Sep 2017 22:21:10 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WXkjXUHOTkrj; Thu, 7 Sep 2017 22:21:09 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 552AC88B32;\n\tThu, 7 Sep 2017 22:21:09 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 346421C3F85\n\tfor ;\n\tThu, 7 Sep 2017 22:21:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2A51788B32\n\tfor ;\n\tThu, 7 Sep 2017 22:21:08 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YaRNlIufH1sD for ;\n\tThu, 7 Sep 2017 22:21:06 +0000 (UTC)","from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 23C08889F8\n\tfor ;\n\tThu, 7 Sep 2017 22:21:04 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2017 15:21:04 -0700","from orsmsx107.amr.corp.intel.com ([10.22.240.5])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2017 15:21:03 -0700","from orsmsx155.amr.corp.intel.com (10.22.240.21) by\n\tORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Thu, 7 Sep 2017 15:21:03 -0700","from orsmsx115.amr.corp.intel.com ([169.254.4.109]) by\n\tORSMSX155.amr.corp.intel.com ([169.254.7.237]) with mapi id\n\t14.03.0319.002; Thu, 7 Sep 2017 15:21:03 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,360,1500966000\"; d=\"scan'208\";a=\"898185137\"","From":"\"Keller, Jacob E\" ","To":"\"Kirsher, Jeffrey T\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[next-queue v3] i40e/i40evf: organize and re-number feature\n\tflags","Thread-Index":"AQHTI2SBrDFfs+vwC0C3z+bE5rxk/6KqCCvA","Date":"Thu, 7 Sep 2017 22:21:02 +0000","Message-ID":"<02874ECE860811409154E81DA85FBB5882A9EE9F@ORSMSX115.amr.corp.intel.com>","References":"<20170901205407.41800-1-jeffrey.t.kirsher@intel.com>","In-Reply-To":"<20170901205407.41800-1-jeffrey.t.kirsher@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTdjM2QzMzQtMmM3Yy00Nzg3LWFmZTktYTViN2ZhYzBhOWU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InRwT1dWbm9SaHhzWTMrSndcL1JzSGkwMVY3ZUpBWGNBZkRKRzJIUjdaRDBVPSJ9","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.140]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next-queue v3] i40e/i40evf: organize and\n\tre-number feature flags","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]