[{"id":1761978,"web_url":"http://patchwork.ozlabs.org/comment/1761978/","msgid":"","list_archive_url":null,"date":"2017-09-01T20:51:46","subject":"Re: [PATCH nf] netfilter: xtables: add scheduling opportunity in\n\tget_counters","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/people/13357/","name":"Eric Dumazet","email":"edumazet@google.com"},"content":"On Fri, Sep 1, 2017 at 1:41 PM, Florian Westphal wrote:\n> There are reports about spurious softlockups during iptables-restore, a\n> backtrace i saw points at get_counters -- it uses a sequence lock and also\n> has unbounded restart loop.\n>\n> Signed-off-by: Florian Westphal \n> ---\n> net/ipv4/netfilter/arp_tables.c | 1 +\n> net/ipv4/netfilter/ip_tables.c | 1 +\n> net/ipv6/netfilter/ip6_tables.c | 1 +\n> 3 files changed, 3 insertions(+)\n\nSGTM, thanks Florian !\n\nAcked-by: Eric Dumazet \n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"YUWiaXkt\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkWd15QZ4z9sNr\n\tfor ;\n\tSat, 2 Sep 2017 06:51:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752555AbdIAUvs (ORCPT );\n\tFri, 1 Sep 2017 16:51:48 -0400","from mail-yw0-f172.google.com ([209.85.161.172]:34510 \"EHLO\n\tmail-yw0-f172.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752393AbdIAUvs (ORCPT\n\t);\n\tFri, 1 Sep 2017 16:51:48 -0400","by mail-yw0-f172.google.com with SMTP id t188so6283331ywb.1\n\tfor ;\n\tFri, 01 Sep 2017 13:51:48 -0700 (PDT)","by 10.37.50.194 with HTTP; Fri, 1 Sep 2017 13:51:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=jzB8bTcoD863IdTyQHwH0Lla+6jXEZoKZDtsBbrZtGc=;\n\tb=YUWiaXktiDp6VOjfi2dDSF2s6KBsT0QUw0Z1j61hiYxUq2GIYAfsKqm9Z7Jgb1w31G\n\tO5391eScBCIuCEuboPIT4gaw1yXqpIgrHobLBO9u2jFhI2Ue9MstWwkc5ZQXZXwr8XmL\n\tOtAvsov5KJTiX5WGaZ46ldfk3nNU/4exbkA0Nq6ab3+sUxUK6fP9l1eRpXWkvpDBQwgs\n\teOZh7duX4UZ4qiOTNjSTNrB4WnteejhbpGIPKnCaIX9zEsVS+MoviDKhwUNyIH/J+SIF\n\t17+eRscAYxOuKn4/XbdccmuUOM78GJTyNOLePyoc0emD3ExR3e7s0XL0lhu3sb7Ce2qt\n\tQaTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=jzB8bTcoD863IdTyQHwH0Lla+6jXEZoKZDtsBbrZtGc=;\n\tb=aZUEmZZfzBHteyImCyvh4ZapXOPu1x826ZQGCsRHBLF7EblmqW7NkttVFN0s1BAQ3v\n\t3RlJeQf9ZLVfC/XlNvOkjLN/7ys2JaOIEbVBaGE3qzR5NYoJaI/t98b+IWjoKuXwqvGm\n\tqisR6gQyDCVkIn1Hjl19+0J2hY1vYLWn+8HNPThikS3DeNLTqDpNxW9QQgzLon532iA1\n\tjpAAtmWmVvIrkyOcti20XlOu96XsGe/eqg64iv5C2j6fAIECEKFCYjYiPpesKsDRk3mz\n\tYtN6lNMbC9e5eGws2L4sXYs8Knu9e3GQEAC4gR4gSHRJgN7hXmeEPTkGBnLfQKaW6Nzi\n\t6sJQ==","X-Gm-Message-State":"AHPjjUg7nWe/0pRS9LncBw2eYIz+6DwCYsao+SYjWwuk52WS1laeIk43\n\txZ84ZM24Jfj87oZ29f30I+C9x53qVB3+","X-Google-Smtp-Source":"ADKCNb6o+dAIRsMQ68Hl299/zO4OnTHYXuWpyD2r2+2igK5FPDKB7ovYDnHXDzdXuRlU68aJA+uaMAQFG7+A+UijVzg=","X-Received":"by 10.129.56.135 with SMTP id f129mr2851457ywa.3.1504299107251; \n\tFri, 01 Sep 2017 13:51:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901204103.16129-1-fw@strlen.de>","References":"<20170901204103.16129-1-fw@strlen.de>","From":"Eric Dumazet ","Date":"Fri, 1 Sep 2017 13:51:46 -0700","Message-ID":"","Subject":"Re: [PATCH nf] netfilter: xtables: add scheduling opportunity in\n\tget_counters","To":"Florian Westphal ","Cc":"netfilter-devel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}},{"id":1765275,"web_url":"http://patchwork.ozlabs.org/comment/1765275/","msgid":"<20170908114754.GB13597@salvia>","list_archive_url":null,"date":"2017-09-08T11:47:54","subject":"Re: [PATCH nf] netfilter: xtables: add scheduling opportunity in\n\tget_counters","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Fri, Sep 01, 2017 at 10:41:03PM +0200, Florian Westphal wrote:\n> There are reports about spurious softlockups during iptables-restore, a\n> backtrace i saw points at get_counters -- it uses a sequence lock and also\n> has unbounded restart loop.\n\nApplied, thanks.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpbDg6Yzhz9sCZ\n\tfor ;\n\tFri, 8 Sep 2017 21:48:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754938AbdIHLsT (ORCPT );\n\tFri, 8 Sep 2017 07:48:19 -0400","from ganesha.gnumonks.org ([213.95.27.120]:34460 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754358AbdIHLsS (ORCPT\n\t);\n\tFri, 8 Sep 2017 07:48:18 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dqHlL-0003H1-Jb; Fri, 08 Sep 2017 13:47:57 +0200"],"Date":"Fri, 8 Sep 2017 13:47:54 +0200","From":"Pablo Neira Ayuso ","To":"Florian Westphal ","Cc":"netfilter-devel@vger.kernel.org, edumazet@google.com","Subject":"Re: [PATCH nf] netfilter: xtables: add scheduling opportunity in\n\tget_counters","Message-ID":"<20170908114754.GB13597@salvia>","References":"<20170901204103.16129-1-fw@strlen.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901204103.16129-1-fw@strlen.de>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]