[{"id":1762116,"web_url":"http://patchwork.ozlabs.org/comment/1762116/","msgid":"","list_archive_url":null,"date":"2017-09-02T12:38:21","subject":"Re: [PATCH] Fix a pasto in lra-remat.c (reg_overlap_for_remat_p)","submitter":{"id":1765,"url":"http://patchwork.ozlabs.org/api/people/1765/","name":"Richard Biener","email":"richard.guenther@gmail.com"},"content":"On September 1, 2017 10:33:10 PM GMT+02:00, Jakub Jelinek wrote:\n>Hi!\n>\n>This is something that has been reported privately to me.\n>This is in code introduced in\n>https://gcc.gnu.org/ml/gcc-patches/2016-03/msg00660.html\n>and looks indeed like a pasto to me, before the loop there is\n>a very similar set of stmts without the 2 suffix, and unless\n>regno being a hard reg (after possible reg_renumber) implies\n>that regno2 (after possible reg_renumber) is a hard reg, if\n>unlucky we might access out of bounds.\n>\n>I don't have a testcase for this, but have bootstrapped/regtested\n>it on x86_64-linux and i686-linux, ok for trunk?\n\nOK. \n\nRichard. \n\n>2017-09-01 Jakub Jelinek \n>\n>\t* lra-remat.c (reg_overlap_for_remat_p): Fix a pasto.\n>\n>--- gcc/lra-remat.c.jj\t2017-05-25 10:37:00.000000000 +0200\n>+++ gcc/lra-remat.c\t2017-09-01 19:42:07.615291583 +0200\n>@@ -684,7 +684,7 @@ reg_overlap_for_remat_p (lra_insn_reg *r\n> \n> \tif (regno2 >= FIRST_PSEUDO_REGISTER && reg_renumber[regno2] >= 0)\n> \t regno2 = reg_renumber[regno2];\n>-\tif (regno >= FIRST_PSEUDO_REGISTER)\n>+\tif (regno2 >= FIRST_PSEUDO_REGISTER)\n> \t nregs2 = 1;\n> \telse\n> \t nregs2 = hard_regno_nregs[regno2][reg->biggest_mode];\n>\n>\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461342-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Msxes7ou\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkwdY0xCDz9s7h\n\tfor ;\n\tSat, 2 Sep 2017 22:38:40 +1000 (AEST)","(qmail 59846 invoked by alias); 2 Sep 2017 12:38:33 -0000","(qmail 59342 invoked by uid 89); 2 Sep 2017 12:38:32 -0000","from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com)\n\t(74.125.82.67) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tSat, 02 Sep 2017 12:38:26 +0000","by mail-wm0-f67.google.com with SMTP id p17so2401062wmd.3 for\n\t; Sat, 02 Sep 2017 05:38:26 -0700 (PDT)","from android-f83b394395796e13.fritz.box\n\t(p5494E583.dip0.t-ipconnect.de. [84.148.229.131]) by\n\tsmtp.gmail.com with ESMTPSA id\n\tb70sm1827747wmf.7.2017.09.02.05.38.23 (version=TLS1_2\n\tcipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 05:38:24 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:in-reply-to:references:mime-version:content-type\n\t:content-transfer-encoding:subject:to:cc:from:message-id; q=dns;\n\ts=default; b=j8UP8/rHcqSR85VQhuLX19eu0Fbm3RH/9vBn1S1iyKrAzRTb5G\n\trtAPUkLRThYT9FbITKlVfMkyXZCTbO2IIwQjc57P7XN40+uwRImoZGoCCU49GQzk\n\tB0wyDdTRMM5ruVJbWGMxTc4li1BhSivCYKMFEA5mRIg8yLUI+ka45s54k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:in-reply-to:references:mime-version:content-type\n\t:content-transfer-encoding:subject:to:cc:from:message-id; s=\n\tdefault; bh=Y7BpKv7F+vXOpaymbB67Nd4Z/8w=; b=Msxes7ouA7Gpcu+6BiLH\n\tWwNGrt4f0QNFzqkR0NnsMhB8GNYS/FAgEL1x9hytfMEf44J6oIbbumUe68Qshl5L\n\tMu8mDvvlgPlvgVcHkhb7BrmfB2Aqw8qQNeBPXY8NUPcnFFdRWiHs/Vj2DooRWNqm\n\tTmWoNOXB85uovmqj1BNo1Kc=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-10.8 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-wm0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:cc:from\n\t:message-id; bh=rkVivwJm50C8HK9SStZidolQhG/R2CkqGescVTsTSzA=;\n\tb=ayZqull3vbKRWhSgzRp3YF4MquBMj/jTI8utTu3JMCg7emgS+awaUfU96lt9aIXlbo\n\t/OelivOX9AOiZ88fliboKzjVPIwPPFfVg3kEh7oPEXeD/dEMzjBdD/XbPBTsuZfFaX/q\n\tYRBZCcTr2IJwLqRoyOZhRIZ2XIO9FDiSWXq4VcoQPtvQd1ywCwXOHsdLgzYQS2XA5oxU\n\tOH+lYKNyJNqKjk92BZUnFt2xadKjwx4o3ZwjtWD++1fL2netIJOQI08z5BgYqxKfpsm8\n\tYFfSoiwEwGpzK5b9ccuLpwjs+LC+b1p1d4BAqTXD1L8hEO2ExUQvMqzBD5cYKJoMlBBD\n\t7PMQ==","X-Gm-Message-State":"AHPjjUhJ8efuIfODnFJPQzCFhJVtMbdFhkWajzSjftdge9WoA6dIITzT\tUqO1FDVG/akzkA==","X-Google-Smtp-Source":"ADKCNb5vaW8n5fsIzwrDUpfu3V653CJyhuI31zGf5YCIl6MdHXJ8PC1C2Ptg/0f2NfF+x1aBziSIUw==","X-Received":"by 10.28.139.72 with SMTP id n69mr730628wmd.15.1504355904852;\n\tSat, 02 Sep 2017 05:38:24 -0700 (PDT)","Date":"Sat, 02 Sep 2017 14:38:21 +0200","User-Agent":"K-9 Mail for Android","In-Reply-To":"<20170901203310.GS2323@tucnak>","References":"<20170901203310.GS2323@tucnak>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH] Fix a pasto in lra-remat.c (reg_overlap_for_remat_p)","To":"Jakub Jelinek , Vladimir Makarov ,\n\tJeff Law , Bernd Schmidt ","CC":"gcc-patches@gcc.gnu.org","From":"Richard Biener ","Message-ID":"","X-IsSubscribed":"yes"}}]