[{"id":1762042,"web_url":"http://patchwork.ozlabs.org/comment/1762042/","msgid":"<8e442540-5f6e-bb7a-2b85-0f805884a6bc@amsat.org>","list_archive_url":null,"date":"2017-09-02T00:07:32","subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/01/2017 03:03 PM, Eric Blake wrote:\n> As a general rule, we prefer avoiding implicit global state\n> because it makes code harder to safely copy and paste without\n> thinking about the global state. It turns out that with the\n> recent changes to libqos, fw_cfg-test was not even using\n> global_qtest any more. Avoid a pointless strdup while at it.\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> ---\n> tests/fw_cfg-test.c | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c\n> index 47596c57a1..3a8dc7a2cd 100644\n> --- a/tests/fw_cfg-test.c\n> +++ b/tests/fw_cfg-test.c\n> @@ -102,14 +102,11 @@ static void test_fw_cfg_boot_menu(void)\n> int main(int argc, char **argv)\n> {\n> QTestState *s;\n> - char *cmdline;\n> int ret;\n> \n> g_test_init(&argc, &argv, NULL);\n> \n> - cmdline = g_strdup_printf(\"-uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 \");\n> - s = qtest_start(cmdline);\n> - g_free(cmdline);\n> + s = qtest_init(\"-uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8\");\n> \n> fw_cfg = pc_fw_cfg_init(s);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"X0hgeO2F\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkbzg34svz9sQl\n\tfor ;\n\tSat, 2 Sep 2017 10:08:10 +1000 (AEST)","from localhost ([::1]:40102 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnvyp-00034X-Ib\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 20:08:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49137)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnvyQ-00033p-RM\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:07:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnvyL-0005Yt-Tk\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:07:42 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35981)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnvyL-0005Yd-PI\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:07:37 -0400","by mail-qk0-x244.google.com with SMTP id l65so1212314qkc.3\n\tfor ; Fri, 01 Sep 2017 17:07:37 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\ti51sm1064225qta.75.2017.09.01.17.07.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 17:07:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=HUsIvO7nMlQusdLCqZ1qTr/pmh6qmOVqbd+J2H3QKr8=;\n\tb=X0hgeO2Fo4l0O5Xe4CwbuXYhrxw0L4aPbnDpetXZHE93j8zvWDxbceTv/RHXSOtZwZ\n\tymi6ZsLC2250dqdDw2wDDE11KVYOi9B1Czpmm3S+X5M/GTMt/PjYYmvOVLJpbkwc6Qtz\n\t3gyWq0J0uc1YOa0CmS5uQC4xTSfFmY0LH7q9bWs4D+EuXF5yGLqSfYne1IjuuJkCo4ma\n\tEmNXQU4c4DYaaejXv3Cc31MM9e7HQgtlgwfzNb8EOEi7oiLh4ONLhymoOda4mwbWlFXO\n\tYMnUWFxftm84O4XWDK2FAndrsyUffY2u4HeVHLDJgQqp2obCUuZwrSM2ybG1lbzIVl1F\n\tvBYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HUsIvO7nMlQusdLCqZ1qTr/pmh6qmOVqbd+J2H3QKr8=;\n\tb=id5Rx+aOapq6y5rfORQ4T4v6wtWWTtm5qJwXDTpDJ6QEDUdu+eZhCQppDM9bHmGP0X\n\twhZzeR2JlAGtQmv8rOPJl26FbriL0+CLejZ5/KzyejjeJJmZMWDTnpf3qgjFHL/etDHV\n\tYCIFi0+ud9EWmjodANLCJwfTlAfPkd1lRGG878l3MeSzm/Y168hhUBt+pFBhFiSAwR4M\n\tx2wTTRR06gL+8aPiM3uCotY6O90a13706F4cdSxAhmW2RDKTWO/WfRfYWnbHX8rcT7b0\n\tXgBvyPWn9Mm9QK9CKp8GXQuXCWVPjmUurnLmrWn+xx7s/pNJPI9E1IEsiDFO0Z3QaiMR\n\tAluw==","X-Gm-Message-State":"AHPjjUgKABmEOXsF6XqXhl/LruQbyF6fwaSd65gXBEYYG84i2sa0gL2L\n\tMs0p9oSno/zgvA==","X-Google-Smtp-Source":"ADKCNb6m7PEP787xm50lKalu0MIitb8HNwABqybPUNhZXU4sg0r18izWzB6wNOOArG3QtZcSwirfLg==","X-Received":"by 10.55.49.65 with SMTP id x62mr4771809qkx.150.1504310857192;\n\tFri, 01 Sep 2017 17:07:37 -0700 (PDT)","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-27-eblake@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<8e442540-5f6e-bb7a-2b85-0f805884a6bc@amsat.org>","Date":"Fri, 1 Sep 2017 21:07:32 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-27-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763215,"web_url":"http://patchwork.ozlabs.org/comment/1763215/","msgid":"","list_archive_url":null,"date":"2017-09-05T11:05:51","subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> As a general rule, we prefer avoiding implicit global state\n> because it makes code harder to safely copy and paste without\n> thinking about the global state. It turns out that with the\n> recent changes to libqos, fw_cfg-test was not even using\n> global_qtest any more. Avoid a pointless strdup while at it.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/fw_cfg-test.c | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c\n> index 47596c57a1..3a8dc7a2cd 100644\n> --- a/tests/fw_cfg-test.c\n> +++ b/tests/fw_cfg-test.c\n> @@ -102,14 +102,11 @@ static void test_fw_cfg_boot_menu(void)\n> int main(int argc, char **argv)\n> {\n> QTestState *s;\n> - char *cmdline;\n> int ret;\n> \n> g_test_init(&argc, &argv, NULL);\n> \n> - cmdline = g_strdup_printf(\"-uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 \");\n> - s = qtest_start(cmdline);\n> - g_free(cmdline);\n> + s = qtest_init(\"-uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8\");\n> \n> fw_cfg = pc_fw_cfg_init(s);\n> \n\nWhy don't you merge this with patch 14/29?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmkRv6nfzz9s83\n\tfor ;\n\tTue, 5 Sep 2017 21:06:35 +1000 (AEST)","from localhost ([::1]:58112 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpBgg-00021l-1O\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 07:06:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42474)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpBgE-00021T-Av\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 07:06:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpBg5-0003fh-1N\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 07:06:06 -0400","from mx1.redhat.com ([209.132.183.28]:53906)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpBg4-0003fB-S5\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 07:05:56 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F171261475\n\tfor ; Tue, 5 Sep 2017 11:05:55 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 66A257D3FA;\n\tTue, 5 Sep 2017 11:05:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F171261475","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-27-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 5 Sep 2017 13:05:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-27-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 05 Sep 2017 11:05:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764399,"web_url":"http://patchwork.ozlabs.org/comment/1764399/","msgid":"<34d47331-3ba6-68ba-8b80-830fc5e0f657@redhat.com>","list_archive_url":null,"date":"2017-09-06T21:45:53","subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/05/2017 06:05 AM, Thomas Huth wrote:\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> As a general rule, we prefer avoiding implicit global state\n>> because it makes code harder to safely copy and paste without\n>> thinking about the global state. It turns out that with the\n>> recent changes to libqos, fw_cfg-test was not even using\n>> global_qtest any more. Avoid a pointless strdup while at it.\n>>\n>> Signed-off-by: Eric Blake \n>> ---\n>> tests/fw_cfg-test.c | 5 +----\n>> 1 file changed, 1 insertion(+), 4 deletions(-)\n>>\n\n>>\n> \n> Why don't you merge this with patch 14/29?\n\nSure.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xncby5Hw3z9s8J\n\tfor ;\n\tThu, 7 Sep 2017 07:46:38 +1000 (AEST)","from localhost ([::1]:37899 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpi9c-0004MQ-Sa\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 17:46:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41777)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpi95-0004LB-Hv\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:46:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpi90-0004PH-Te\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:46:03 -0400","from mx1.redhat.com ([209.132.183.28]:51294)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpi90-0004Oz-L6\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 17:45:58 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ABE7AC04B941\n\tfor ; Wed, 6 Sep 2017 21:45:57 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C5F4317B9B;\n\tWed, 6 Sep 2017 21:45:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ABE7AC04B941","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-27-eblake@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<34d47331-3ba6-68ba-8b80-830fc5e0f657@redhat.com>","Date":"Wed, 6 Sep 2017 16:45:53 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"MHfGeNpWSc9HwJ08vAUq2IGLoesKGnfVI\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 06 Sep 2017 21:45:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 26/29] fw_cfg-test: Drop dependence on\n\tglobal_qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]