[{"id":1763009,"web_url":"http://patchwork.ozlabs.org/comment/1763009/","msgid":"<6fa7c1bb-ec7f-0722-03ad-32563b37c935@redhat.com>","list_archive_url":null,"date":"2017-09-05T07:11:44","subject":"Re: [Qemu-devel] [PATCH v6 21/29] qmp-test: Drop dependence on\n\tglobal_qtest","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> As a general rule, we prefer avoiding implicit global state\n> because it makes code harder to safely copy and paste without\n> thinking about the global state. Although qmp-test does not\n> maintain parallel qtest connections, it was the last test\n> assigning to global_qtest. It's just as easy to be explicit\n> about the state; once all tests have been cleaned up, a later\n> patch can then get rid of global_qtest and a layer of wrappers\n> in libqtest.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/qmp-test.c | 35 ++++++++++++++++++-----------------\n> 1 file changed, 18 insertions(+), 17 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmdFm1Srdz9sP3\n\tfor ;\n\tTue, 5 Sep 2017 17:12:26 +1000 (AEST)","from localhost ([::1]:57186 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp821-0004tJ-8B\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 03:12:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42722)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp81a-0004rd-N1\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:11:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp81W-0006Li-2T\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:11:54 -0400","from mx1.redhat.com ([209.132.183.28]:36982)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp81V-0006L8-SP\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:11:49 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D5A687572C\n\tfor ; Tue, 5 Sep 2017 07:11:48 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 671FD812D6;\n\tTue, 5 Sep 2017 07:11:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D5A687572C","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-22-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<6fa7c1bb-ec7f-0722-03ad-32563b37c935@redhat.com>","Date":"Tue, 5 Sep 2017 09:11:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-22-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 05 Sep 2017 07:11:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 21/29] qmp-test: Drop dependence on\n\tglobal_qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]