[{"id":1763311,"web_url":"http://patchwork.ozlabs.org/comment/1763311/","msgid":"","list_archive_url":null,"date":"2017-09-05T12:46:54","subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> Several callers were formatting a string into a temporary\n> variable before calling qtest_init(); factor that into the\n> common code.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqtest.h | 7 ++++---\n> tests/libqtest.c | 13 ++++++++++--\n> tests/bios-tables-test.c | 7 +------\n> tests/postcopy-test.c | 4 ++--\n> tests/vhost-user-test.c | 51 ++++++++++++++----------------------------------\n> 5 files changed, 33 insertions(+), 49 deletions(-)\n> \n> diff --git a/tests/libqtest.h b/tests/libqtest.h\n> index 3ae570927a..d338de3e22 100644\n> --- a/tests/libqtest.h\n> +++ b/tests/libqtest.h\n> @@ -25,11 +25,12 @@ extern QTestState *global_qtest;\n> \n> /**\n> * qtest_init:\n> - * @extra_args: other arguments to pass to QEMU.\n> + * @extra_args...: other arguments to pass to QEMU, formatted as if by\n> + * sprintf().\n> *\n> * Returns: #QTestState instance.\n> */\n> -QTestState *qtest_init(const char *extra_args);\n> +QTestState *qtest_init(const char *extra_args, ...) GCC_FMT_ATTR(1, 2);\n\nMaybe the parameter should be called \"fmt\" or \"format\" now instead?\n(similar to printf() and friends)\n\n> /**\n> * qtest_init_without_qmp_handshake:\n> @@ -518,7 +519,7 @@ void qtest_add_abrt_handler(GHookFunc fn, const void *data);\n> */\n> static inline QTestState *qtest_start(const char *args)\n> {\n> - global_qtest = qtest_init(args);\n> + global_qtest = qtest_init(\"%s\", args);\n\nThat's a little bit sad that there are some spots which need an explicit\n\"%s\" now ... maybe it would be nicer to add a new function called\nqtest_initf() instead and keep the old one (without the \"f\") as it is?\n\n> return global_qtest;\n> }\n> \n> diff --git a/tests/libqtest.c b/tests/libqtest.c\n> index b6dd26e54a..18facbf130 100644\n> --- a/tests/libqtest.c\n> +++ b/tests/libqtest.c\n> @@ -347,9 +347,18 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n> return s;\n> }\n> \n> -QTestState *qtest_init(const char *extra_args)\n> +QTestState *qtest_init(const char *extra_args, ...)\n> {\n> - QTestState *s = qtest_init_without_qmp_handshake(extra_args);\n> + va_list ap;\n> + QTestState *s;\n> + char *cmd;\n> +\n> + va_start(ap, extra_args);\n> + cmd = g_strdup_vprintf(extra_args, ap);\n> + va_end(ap);\n> +\n> + s = qtest_init_without_qmp_handshake(cmd);\n> + g_free(cmd);\n> \n> /* Read the QMP greeting and then do the handshake */\n> qtest_qmp_discard_response(s, \"\");\n> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c\n> index 976792f2c5..f8a107499f 100644\n> --- a/tests/bios-tables-test.c\n> +++ b/tests/bios-tables-test.c\n> @@ -623,18 +623,14 @@ static void test_smbios_structs(test_data *data)\n> \n> static void test_acpi_one(const char *params, test_data *data)\n> {\n> - char *args;\n> -\n> /* Disable kernel irqchip to be able to override apic irq0. */\n> - args = g_strdup_printf(\"-machine %s,accel=%s,kernel-irqchip=off \"\n> + data->qts = qtest_init(\"-machine %s,accel=%s,kernel-irqchip=off \"\n> \"-net none -display none %s \"\n> \"-drive id=hd0,if=none,file=%s,format=raw \"\n> \"-device ide-hd,drive=hd0 \",\n> data->machine, \"kvm:tcg\",\n> params ? params : \"\", disk);\n> \n> - data->qts = qtest_init(args);\n> -\n> boot_sector_test(data->qts);\n> \n> test_acpi_rsdp_address(data);\n> @@ -657,7 +653,6 @@ static void test_acpi_one(const char *params, test_data *data)\n> test_smbios_structs(data);\n> \n> qtest_quit(data->qts);\n> - g_free(args);\n> }\n> \n> static uint8_t base_required_struct_types[] = {\n> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c\n> index 0e5fe20a83..20cfb280f6 100644\n> --- a/tests/postcopy-test.c\n> +++ b/tests/postcopy-test.c\n> @@ -403,10 +403,10 @@ static void test_migrate(void)\n> \n> g_free(bootpath);\n> \n> - from = qtest_init(cmd_src);\n> + from = qtest_init(\"%s\", cmd_src);\n> g_free(cmd_src);\n> \n> - to = qtest_init(cmd_dst);\n> + to = qtest_init(\"%s\", cmd_dst);\n> g_free(cmd_dst);\n> \n> assert(!global_qtest);\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmhs3gBDz9sRm\n\tfor ;\n\tTue, 5 Sep 2017 22:47:57 +1000 (AEST)","from localhost ([::1]:58748 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDGl-0002JO-CB\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:47:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33737)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDFx-0002C2-My\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:47:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDFs-0005Je-Sx\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:47:05 -0400","from mx1.redhat.com ([209.132.183.28]:56904)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpDFs-0005JC-KF\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:47:00 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A1B4B90143\n\tfor ; Tue, 5 Sep 2017 12:46:59 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1B7B784D0C;\n\tTue, 5 Sep 2017 12:46:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A1B4B90143","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-28-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 5 Sep 2017 14:46:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-28-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 05 Sep 2017 12:46:59 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, \"Michael S. Tsirkin\" ,\n\tarmbru@redhat.com, Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764867,"web_url":"http://patchwork.ozlabs.org/comment/1764867/","msgid":"","list_archive_url":null,"date":"2017-09-07T18:00:48","subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/05/2017 07:46 AM, Thomas Huth wrote:\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> Several callers were formatting a string into a temporary\n>> variable before calling qtest_init(); factor that into the\n>> common code.\n>>\n>> Signed-off-by: Eric Blake \n>> ---\n\n>> -QTestState *qtest_init(const char *extra_args);\n>> +QTestState *qtest_init(const char *extra_args, ...) GCC_FMT_ATTR(1, 2);\n> \n> Maybe the parameter should be called \"fmt\" or \"format\" now instead?\n> (similar to printf() and friends)\n\nSure.\n\n> \n>> /**\n>> * qtest_init_without_qmp_handshake:\n>> @@ -518,7 +519,7 @@ void qtest_add_abrt_handler(GHookFunc fn, const void *data);\n>> */\n>> static inline QTestState *qtest_start(const char *args)\n>> {\n>> - global_qtest = qtest_init(args);\n>> + global_qtest = qtest_init(\"%s\", args);\n> \n> That's a little bit sad that there are some spots which need an explicit\n> \"%s\" now ... maybe it would be nicer to add a new function called\n> qtest_initf() instead and keep the old one (without the \"f\") as it is?\n\nIndeed, and looking back over my series, I see we could also benefit\nfrom a va_list form.\n\nAlso, since you already questioned me on the churn from qtest_start() =>\nqtest_init() => qtest_start(), I can make less churn in the next spin by\nconverging on qtest_start() from the get-go.\n\nSo I will go with qtest_start() (plain string), qtest_startf()\n(formatted like sprintf), and qtest_vstartf() (formatted like vsprintf).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp7Yp6dQMz9t2M\n\tfor ;\n\tFri, 8 Sep 2017 04:01:33 +1000 (AEST)","from localhost ([::1]:41589 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq17L-0002mH-FA\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 14:01:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34438)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq16r-0002kK-At\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:01:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq16m-0003y3-BM\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:01:01 -0400","from mx1.redhat.com ([209.132.183.28]:56340)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq16m-0003xm-13\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:00:56 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 05A5D80F79\n\tfor ; Thu, 7 Sep 2017 18:00:55 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 775CD5D6A3;\n\tThu, 7 Sep 2017 18:00:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 05A5D80F79","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-28-eblake@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Thu, 7 Sep 2017 13:00:48 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"AMJko6aG5E1oK9sjmvthTUQA25FT4wuiw\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 07 Sep 2017 18:00:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, \"Michael S. Tsirkin\" ,\n\tarmbru@redhat.com, Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764899,"web_url":"http://patchwork.ozlabs.org/comment/1764899/","msgid":"<718433c5-59b8-f949-12a1-6f2cd3242d3c@redhat.com>","list_archive_url":null,"date":"2017-09-07T19:07:42","subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 07.09.2017 20:00, Eric Blake wrote:\n> On 09/05/2017 07:46 AM, Thomas Huth wrote:\n>> On 01.09.2017 20:03, Eric Blake wrote:\n>>> Several callers were formatting a string into a temporary\n>>> variable before calling qtest_init(); factor that into the\n>>> common code.\n>>>\n>>> Signed-off-by: Eric Blake \n>>> ---\n> \n>>> -QTestState *qtest_init(const char *extra_args);\n>>> +QTestState *qtest_init(const char *extra_args, ...) GCC_FMT_ATTR(1, 2);\n>>\n>> Maybe the parameter should be called \"fmt\" or \"format\" now instead?\n>> (similar to printf() and friends)\n> \n> Sure.\n> \n>>\n>>> /**\n>>> * qtest_init_without_qmp_handshake:\n>>> @@ -518,7 +519,7 @@ void qtest_add_abrt_handler(GHookFunc fn, const void *data);\n>>> */\n>>> static inline QTestState *qtest_start(const char *args)\n>>> {\n>>> - global_qtest = qtest_init(args);\n>>> + global_qtest = qtest_init(\"%s\", args);\n>>\n>> That's a little bit sad that there are some spots which need an explicit\n>> \"%s\" now ... maybe it would be nicer to add a new function called\n>> qtest_initf() instead and keep the old one (without the \"f\") as it is?\n> \n> Indeed, and looking back over my series, I see we could also benefit\n> from a va_list form.\n> \n> Also, since you already questioned me on the churn from qtest_start() =>\n> qtest_init() => qtest_start(), I can make less churn in the next spin by\n> converging on qtest_start() from the get-go.\n> \n> So I will go with qtest_start() (plain string), qtest_startf()\n> (formatted like sprintf), and qtest_vstartf() (formatted like vsprintf).\n\nThanks, that sounds like a better way to me, too!\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp92z2fy3z9sQl\n\tfor ;\n\tFri, 8 Sep 2017 05:08:26 +1000 (AEST)","from localhost ([::1]:41831 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dq2A2-0001L7-Ma\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 15:08:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33164)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dq29e-0001Kj-Dy\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:08:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dq29Z-0002Yx-Km\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:07:58 -0400","from mx1.redhat.com ([209.132.183.28]:42676)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dq29Z-0002YS-Bs\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:07:53 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 625AD81DFD\n\tfor ; Thu, 7 Sep 2017 19:07:52 +0000 (UTC)","from [10.36.116.55] (ovpn-116-55.ams2.redhat.com [10.36.116.55])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C06137C768;\n\tThu, 7 Sep 2017 19:07:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 625AD81DFD","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-28-eblake@redhat.com>\n\t\n\t","From":"Thomas Huth ","Message-ID":"<718433c5-59b8-f949-12a1-6f2cd3242d3c@redhat.com>","Date":"Thu, 7 Sep 2017 21:07:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"udjwfcU8urBjkNHb3q0DAc2VpDmKFhg1U\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 07 Sep 2017 19:07:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 27/29] libqtest: Make qtest_init()\n\taccept format string","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, \"Michael S. Tsirkin\" ,\n\tarmbru@redhat.com, Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]