[{"id":1763200,"web_url":"http://patchwork.ozlabs.org/comment/1763200/","msgid":"<91d59927-971e-1ad3-d426-156f9c3e0aa0@redhat.com>","list_archive_url":null,"date":"2017-09-05T10:41:57","subject":"Re: [Qemu-devel] [PATCH v6 19/29] postcopy-test: Drop dependence on\n\tglobal_qtest","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> Managing parallel connections to two different monitors via\n> the implicit global_qtest makes it hard to copy-and-paste code\n> to tests that are not aware of the implicit state. We are\n> already half-using the explicit APIs, so fix the remaining\n> spots to also be explicit about which connection is in use,\n> and avoid global_qtest.\n> \n> We can assert that the conversion is correct by checking that\n> global_qtest remains NULL throughout the test (a later patch\n> that changes global_qtest to not be a public global variable\n> will drop the assertions).\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/postcopy-test.c | 84 ++++++++++++++++++++++++---------------------------\n> 1 file changed, 40 insertions(+), 44 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmjwS6tyJz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 20:42:48 +1000 (AEST)","from localhost ([::1]:58028 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpBJe-0000On-Q7\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:42:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57407)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpBJ0-0000LP-Ou\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:42:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpBIw-0007rM-7T\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:42:06 -0400","from mx1.redhat.com ([209.132.183.28]:38426)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpBIw-0007qq-1G\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:42:02 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1260E6587D\n\tfor ; Tue, 5 Sep 2017 10:42:01 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 83135901EC;\n\tTue, 5 Sep 2017 10:41:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1260E6587D","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-20-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<91d59927-971e-1ad3-d426-156f9c3e0aa0@redhat.com>","Date":"Tue, 5 Sep 2017 12:41:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-20-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 05 Sep 2017 10:42:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 19/29] postcopy-test: Drop dependence on\n\tglobal_qtest","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]