[{"id":1762043,"web_url":"http://patchwork.ozlabs.org/comment/1762043/","msgid":"","list_archive_url":null,"date":"2017-09-02T00:10:48","subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/01/2017 03:03 PM, Eric Blake wrote:\n> There was only one caller; it's easier to inline things.\n> \n> Signed-off-by: Eric Blake \n\nAcked-by: Philippe Mathieu-Daudé \n\n> ---\n> tests/libqtest.c | 22 ++++++----------------\n> 1 file changed, 6 insertions(+), 16 deletions(-)\n> \n> diff --git a/tests/libqtest.c b/tests/libqtest.c\n> index 5d16351e24..b6dd26e54a 100644\n> --- a/tests/libqtest.c\n> +++ b/tests/libqtest.c\n> @@ -244,20 +244,6 @@ redo:\n> return words;\n> }\n> \n> -static int qtest_query_target_endianness(QTestState *s)\n> -{\n> - gchar **args;\n> - int big_endian;\n> -\n> - qtest_sendf(s, \"endianness\\n\");\n> - args = qtest_rsp(s, 1);\n> - g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n> - big_endian = strcmp(args[1], \"big\") == 0;\n> - g_strfreev(args);\n> -\n> - return big_endian;\n> -}\n> -\n> static void cleanup_sigabrt_handler(void)\n> {\n> sigaction(SIGABRT, &sigact_old, NULL);\n> @@ -288,6 +274,7 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n> gchar *qmp_socket_path;\n> gchar *command;\n> const char *qemu_binary;\n> + gchar **args;\n> \n> qemu_binary = getenv(\"QTEST_QEMU_BINARY\");\n> if (!qemu_binary) {\n> @@ -351,8 +338,11 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n> }\n> \n> /* ask endianness of the target */\n> -\n> - s->big_endian = qtest_query_target_endianness(s);\n> + qtest_sendf(s, \"endianness\\n\");\n> + args = qtest_rsp(s, 1);\n> + g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n> + s->big_endian = strcmp(args[1], \"big\") == 0;\n> + g_strfreev(args);\n> \n> return s;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZXyvjY1f\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkc3L5MRQz9sQl\n\tfor ;\n\tSat, 2 Sep 2017 10:11:26 +1000 (AEST)","from localhost ([::1]:40232 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnw20-00056h-Ox\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 20:11:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50178)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnw1a-00055r-P7\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:11:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnw1V-0007TW-Pn\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:10:58 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:37697)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnw1V-0007TN-Kr\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 20:10:53 -0400","by mail-qk0-x244.google.com with SMTP id c6so474046qkh.4\n\tfor ; Fri, 01 Sep 2017 17:10:53 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tn3sm1034162qte.33.2017.09.01.17.10.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 17:10:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=OLS3d9t6nQhnjtRhRM1pvUAfHi+MNWM5h8U+RATzCJU=;\n\tb=ZXyvjY1f6wwfJAlJnxZPwZH7c2SLzLOoHzXbm2x+bTgr6Bn8Um2r051ET5w/3IrWz1\n\tWN0ksougBAqaALLvPJcSkjGCcXRE1nDTuZox8HjIq8nDmOqQYcOjB6+UB/LQ6g/QvpCc\n\tSMjwbPRxJST0qqhWlO4m1AFjaAxqlMt7ILsQPhtO0Aw0uZc5JHwNxeKCxYvJqk9KStFh\n\tQWp/H1W/DOJ+34E13KX2VJiDmZXomErRDRrqkE6E6PkcPnhTCn1srcJfGHRQNSuvmZfO\n\tCNwrB5A18OdHlhcSB/wZ5YYJDAkpu3MisBtrCBmlVtnaIRVCglu0jaNNqJvnKhUIAGOr\n\tNfpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OLS3d9t6nQhnjtRhRM1pvUAfHi+MNWM5h8U+RATzCJU=;\n\tb=P9j6p6UVu6gnmxpfkI2qVNrXa6DK/z5rvMohyfYjFALJ1TAVUcbxSpo3w3xALWTdw2\n\tADhKhNoJhGr7EPipArXy2p8MO12oQB5G6oPuFbpvXzYuiTWEGKsIz0HanmCOZC79u+5F\n\tN6sJJ/rc90Rg2Tz3+KtG6DAv0sXoqblGzq0E+g0fX+lizo9qv4pD4A2EpBPZqIviXKNH\n\td36goWS135+lu7J9GHJfSrCKtwvuHEpNHWQu8lif+Yb0MQXHgT/wxKbuS1cuJ+ItYeOa\n\taWswj98NZ9d4bt04lNOkDeH9KqTmgR15XudUVgbq47Cf3xWRP0laK41ZKZmmuZVksIri\n\tlaZA==","X-Gm-Message-State":"AHPjjUgNaNrF++LlKdtDLyQii4o9zhRgFCZZPIJdHrM2n5H174YOrAa0\n\tCmnVWSa0VTLk3g==","X-Google-Smtp-Source":"ADKCNb5uA8BUgxxEcLmRLurOTj4q5bOdbhCuSLb7iHitr65JGt/fpl/rpteUjxm34g/PcMgrZcjNPw==","X-Received":"by 10.55.158.148 with SMTP id h142mr5186099qke.336.1504311053029;\n\tFri, 01 Sep 2017 17:10:53 -0700 (PDT)","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-12-eblake@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Fri, 1 Sep 2017 21:10:48 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-12-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763128,"web_url":"http://patchwork.ozlabs.org/comment/1763128/","msgid":"","list_archive_url":null,"date":"2017-09-05T09:25:54","subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> There was only one caller; it's easier to inline things.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqtest.c | 22 ++++++----------------\n> 1 file changed, 6 insertions(+), 16 deletions(-)\n> \n> diff --git a/tests/libqtest.c b/tests/libqtest.c\n> index 5d16351e24..b6dd26e54a 100644\n> --- a/tests/libqtest.c\n> +++ b/tests/libqtest.c\n> @@ -244,20 +244,6 @@ redo:\n> return words;\n> }\n> \n> -static int qtest_query_target_endianness(QTestState *s)\n> -{\n> - gchar **args;\n> - int big_endian;\n> -\n> - qtest_sendf(s, \"endianness\\n\");\n> - args = qtest_rsp(s, 1);\n> - g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n> - big_endian = strcmp(args[1], \"big\") == 0;\n> - g_strfreev(args);\n> -\n> - return big_endian;\n> -}\n> -\n> static void cleanup_sigabrt_handler(void)\n> {\n> sigaction(SIGABRT, &sigact_old, NULL);\n> @@ -288,6 +274,7 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n> gchar *qmp_socket_path;\n> gchar *command;\n> const char *qemu_binary;\n> + gchar **args;\n> \n> qemu_binary = getenv(\"QTEST_QEMU_BINARY\");\n> if (!qemu_binary) {\n> @@ -351,8 +338,11 @@ QTestState *qtest_init_without_qmp_handshake(const char *extra_args)\n> }\n> \n> /* ask endianness of the target */\n> -\n> - s->big_endian = qtest_query_target_endianness(s);\n> + qtest_sendf(s, \"endianness\\n\");\n> + args = qtest_rsp(s, 1);\n> + g_assert(strcmp(args[1], \"big\") == 0 || strcmp(args[1], \"little\") == 0);\n> + s->big_endian = strcmp(args[1], \"big\") == 0;\n> + g_strfreev(args);\n> \n> return s;\n> }\n\nAh, well, now that's another way of getting rid of the forward\ndeclaration in the previous patch - so may I suggest to drop the\nprevious patch, and simply do the code inlining here instead?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmhKq5l2lz9s0g\n\tfor ;\n\tTue, 5 Sep 2017 19:31:11 +1000 (AEST)","from localhost ([::1]:57701 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpACL-0008Gy-Rt\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 05:31:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43430)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpA7T-0004GP-DE\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:26:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpA7K-00054k-E7\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:26:03 -0400","from mx1.redhat.com ([209.132.183.28]:45112)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpA7K-00054F-8d\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:25:58 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5A96BC04B31B\n\tfor ; Tue, 5 Sep 2017 09:25:57 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2D2B619168;\n\tTue, 5 Sep 2017 09:25:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5A96BC04B31B","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-12-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 5 Sep 2017 11:25:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-12-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 05 Sep 2017 09:25:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764345,"web_url":"http://patchwork.ozlabs.org/comment/1764345/","msgid":"<4edd36c2-771c-587c-fd45-01dd1f40f8b0@redhat.com>","list_archive_url":null,"date":"2017-09-06T20:12:12","subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/05/2017 04:25 AM, Thomas Huth wrote:\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> There was only one caller; it's easier to inline things.\n>>\n>> Signed-off-by: Eric Blake \n>> ---\n>> tests/libqtest.c | 22 ++++++----------------\n>> 1 file changed, 6 insertions(+), 16 deletions(-)\n>>\n\n> \n> Ah, well, now that's another way of getting rid of the forward\n> declaration in the previous patch - so may I suggest to drop the\n> previous patch, and simply do the code inlining here instead?\n\nWill do.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnZWn5qKFz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 06:12:51 +1000 (AEST)","from localhost ([::1]:37649 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpggo-0008JT-E0\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 16:12:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50439)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpggQ-0008JK-T1\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:12:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpggM-00034M-8J\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:12:22 -0400","from mx1.redhat.com ([209.132.183.28]:59814)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpggL-00033w-Tl\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 16:12:18 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 31A105AFD9\n\tfor ; Wed, 6 Sep 2017 20:12:16 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 819315C88F;\n\tWed, 6 Sep 2017 20:12:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 31A105AFD9","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-12-eblake@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<4edd36c2-771c-587c-fd45-01dd1f40f8b0@redhat.com>","Date":"Wed, 6 Sep 2017 15:12:12 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"9f9C1Hqdm1Uo5x049mWqHkCCKg2pEuJtO\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 06 Sep 2017 20:12:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline\n\tqtest_query_target_endianness()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]