[{"id":1762034,"web_url":"http://patchwork.ozlabs.org/comment/1762034/","msgid":"<7704d989-2671-bb5e-1a1d-936512897702@redhat.com>","list_archive_url":null,"date":"2017-09-01T23:17:44","subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/01/2017 02:03 PM, Eric Blake wrote:\n> We already have another qtest_init() in the tree, for the\n> top-level qtest.c device; having two functions with different\n> signatures is confusing. Rename the libqtest version to\n> qtest_start() to eliminate the duplication.\n> \n> Signed-off-by: Eric Blake \n\nWhy not.\n\nReviewed-by: John Snow ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkZvW2KC8z9sRV\n\tfor ;\n\tSat, 2 Sep 2017 09:19:35 +1000 (AEST)","from localhost ([::1]:38146 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnvDp-0000uT-Fn\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 19:19:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33357)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnvCN-00008c-C2\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 19:18:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnvCI-0006v0-MG\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 19:18:03 -0400","from mx1.redhat.com ([209.132.183.28]:40482)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnvCC-0006oN-V3; Fri, 01 Sep 2017 19:17:53 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 055D5356FD;\n\tFri, 1 Sep 2017 23:17:52 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C960D60C20;\n\tFri, 1 Sep 2017 23:17:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 055D5356FD","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-30-eblake@redhat.com>","From":"John Snow ","Message-ID":"<7704d989-2671-bb5e-1a1d-936512897702@redhat.com>","Date":"Fri, 1 Sep 2017 19:17:44 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-30-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 23:17:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth ,\n\t\"open list:Floppy\" , Ben Warren\n\t, Amit Shah , Jason Wang\n\t, \"Michael S. Tsirkin\" ,\n\tarmbru@redhat.com, Alexander Graf ,\n\tKeith Busch , \"open list:sPAPR\"\n\t, Gerd Hoffmann , Stefan\n\tHajnoczi , pbonzini@redhat.com, Igor Mammedov\n\t, =?utf-8?q?Andreas_F=C3=A4rber?=\n\t, \t\"Dr. David Alan Gilbert\" ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763352,"web_url":"http://patchwork.ozlabs.org/comment/1763352/","msgid":"<3e70c2c4-3266-6cc7-3682-2cf3c2c61d42@redhat.com>","list_archive_url":null,"date":"2017-09-05T13:10:40","subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> We already have another qtest_init() in the tree, for the\n> top-level qtest.c device; having two functions with different\n> signatures is confusing. Rename the libqtest version to\n> qtest_start() to eliminate the duplication.\n\nThis is too much code churn for my taste, and I also do not like the\nidea of naming the function qtest_start() - since this was a function\nwith different semantics before your patch 28/29, so this will cause\nconfusion for all the people who are used to the old qtest_start()\nfunction or who want to backport patches that have done after this\nchange to a code level before this change.\n\nIf you are really bugged by the qtest_init() name clash, I think it's\nway easier if you rename the qtest_init() in the qtest.c file instead.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmnGW3gH3z9t24\n\tfor ;\n\tTue, 5 Sep 2017 23:13:39 +1000 (AEST)","from localhost ([::1]:58861 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpDfb-0007K4-P7\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 09:13:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42433)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpDdT-0005qY-8k\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 09:11:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpDdL-00079w-LY\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 09:11:23 -0400","from mx1.redhat.com ([209.132.183.28]:46364)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpDd7-0006yi-1k; Tue, 05 Sep 2017 09:11:01 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D177C1585F9;\n\tTue, 5 Sep 2017 13:10:59 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8E59F7FB90;\n\tTue, 5 Sep 2017 13:10:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D177C1585F9","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-30-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<3e70c2c4-3266-6cc7-3682-2cf3c2c61d42@redhat.com>","Date":"Tue, 5 Sep 2017 15:10:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-30-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 05 Sep 2017 13:11:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:Floppy\" ,\n\tBen Warren , Amit Shah ,\n\tJason Wang ,\n\t\"Michael S. Tsirkin\" , armbru@redhat.com,\n\tAlexander Graf , Keith Busch , \n\t\"open list:sPAPR\" ,\n\tGerd Hoffmann , \n\tStefan Hajnoczi , pbonzini@redhat.com,\n\tIgor Mammedov , John Snow ,\n\t\"Dr. David Alan Gilbert\" ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764479,"web_url":"http://patchwork.ozlabs.org/comment/1764479/","msgid":"","list_archive_url":null,"date":"2017-09-07T02:57:20","subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/05/2017 08:10 AM, Thomas Huth wrote:\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> We already have another qtest_init() in the tree, for the\n>> top-level qtest.c device; having two functions with different\n>> signatures is confusing. Rename the libqtest version to\n>> qtest_start() to eliminate the duplication.\n> \n> This is too much code churn for my taste, and I also do not like the\n> idea of naming the function qtest_start() - since this was a function\n> with different semantics before your patch 28/29, so this will cause\n> confusion for all the people who are used to the old qtest_start()\n> function or who want to backport patches that have done after this\n> change to a code level before this change.\n> \n> If you are really bugged by the qtest_init() name clash, I think it's\n> way easier if you rename the qtest_init() in the qtest.c file instead.\n\nExcept the qtest_init() in qtest.c really is our normal pattern of\n*_init for devices, so that one's named correctly. Our testsuite is the\none that is using a name different from its normal usage in the rest of\nthe tree.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnlWT49CPz9rxm\n\tfor ;\n\tThu, 7 Sep 2017 12:58:13 +1000 (AEST)","from localhost ([::1]:38644 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpn19-0003nA-Lm\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 22:58:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48348)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpn0f-0003kh-Ok\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 22:57:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpn0e-0003ER-TF\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 22:57:41 -0400","from mx1.redhat.com ([209.132.183.28]:57314)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpn0Y-0003B4-Qw; Wed, 06 Sep 2017 22:57:35 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 361F7859F7;\n\tThu, 7 Sep 2017 02:57:33 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 04A125D6A3;\n\tThu, 7 Sep 2017 02:57:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 361F7859F7","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-30-eblake@redhat.com>\n\t<3e70c2c4-3266-6cc7-3682-2cf3c2c61d42@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 6 Sep 2017 21:57:20 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<3e70c2c4-3266-6cc7-3682-2cf3c2c61d42@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"V0GHL4LVMSHcA3iPH0tuQ04sFMF0Bh9PP\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 07 Sep 2017 02:57:33 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 29/29] libqtest: Rename qtest_init() to\n\tqtest_start()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:Floppy\" ,\n\tBen Warren , Amit Shah ,\n\tJason Wang ,\n\t\"Michael S. Tsirkin\" , armbru@redhat.com,\n\tAlexander Graf , Keith Busch , \n\t\"open list:sPAPR\" ,\n\tGerd Hoffmann , \n\tStefan Hajnoczi , pbonzini@redhat.com,\n\tIgor Mammedov , John Snow ,\n\t\"Dr. David Alan Gilbert\" ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]