[{"id":1778099,"web_url":"http://patchwork.ozlabs.org/comment/1778099/","msgid":"","list_archive_url":null,"date":"2017-10-01T22:37:16","subject":"Re: [PATCH 32/58] Hide internal signal functions [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu wrote:\n> Hide internal signal functions to allow direct access within libc.so and\n> libc.a without using GOT nor PLT.\n>\n> __GI___kill and __GI___sigaltstack are defined when syscalls.list is\n> used to generate them. Otherwise libc_hidden_def is needed explicitly.\n>\n> \t[BZ #18822]\n> \t* include/signal.h (__kill): Add libc_hidden_proto.\n> \t(__sigblock): Likewise.\n> \t(__sigprocmask): Likewise.\n> \t(__sigaltstack): Likewise.\n> \t* signal/kill.c (__kill): Add libc_hidden_def.\n> \t* signal/sigblock.c (__sigblock): Likewise.\n> \t* signal/sigprocmask.c (__sigprocmask): Likewise.\n> \t* sysdeps/mach/hurd/kill.c (__kill): Likewise.\n> \t* sysdeps/mach/hurd/sigaltstack.c (__sigaltstack): Likewise.\n> \t* sysdeps/mach/hurd/sigprocmask.c (__sigprocmask): Likewise.\n> \t* sysdeps/posix/sigblock.c (__sigblock): Likewise.\n> \t* sysdeps/unix/sysv/linux/alpha/sigprocmask.c (__sigprocmask):\n> \tLikewise.\n> \t* sysdeps/unix/sysv/linux/ia64/sigprocmask.c (__sigprocmask):\n> \tLikewise.\n> \t* sysdeps/unix/sysv/linux/s390/s390-64/sigprocmask.c\n> \t(__sigprocmask): Likewise.\n> \t* sysdeps/unix/sysv/linux/sigprocmask.c (__sigprocmask):\n> \tLikewise.\n> \t* /sysdeps/unix/sysv/linux/sparc/sparc64/sigprocmask.c\n> \t(__sigprocmask): Likewise.\n> \t* sysdeps/unix/sysv/linux/x86_64/sigprocmask.c (__sigprocmask):\n> \tLikewise.\n\nTested with build-many-glibcs.py. I am checking it in.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85219-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"bJv4A4M5\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y50Y43wmsz9t2m\n\tfor ;\n\tMon, 2 Oct 2017 09:37:28 +1100 (AEDT)","(qmail 23292 invoked by alias); 1 Oct 2017 22:37:20 -0000","(qmail 23282 invoked by uid 89); 1 Oct 2017 22:37:19 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=J9ljWlf\n\t+PBkd6bj1tDIHFsXejFCP4Ueth2Z74Qkbsks8AAs5JOXpSS2H42U6Fea36WGLFQp\n\tMMxftDNXhN5iBqhsaF1UiqlaIlxiyw/60bcX9nmzJg96kAZHqh0n3R7aKgSSy9vR\n\tUDigJHkb5dSXuirQ7Mc7+hgUiTufLtT22/0w=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=rpL/ST/wZHplh\n\t39kregPF9dNqKs=; b=bJv4A4M5g8fkZc2My3jnvURAEPEXPA03lqvxzSC+01mzE\n\t759Hys9nXeeGfxEajm+K9x5EhTuS9WdwVrPMrVBbNdMx5J2AlmqV0+NZrH81gEgV\n\tRCD0kHFa5kURa7IKxkhrtKMAzSm8xi4ucy0qWF04iWeccNd3jCH0mJrcF6ZeFs=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-oi0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=Atj9SpEv2AurmWloEFk7fJwdSMKWyyfHRkWE/qJdy1g=;\n\tb=AUSi0ew3Adz7vOeQouVdmal0czoPQIwLTPz9s7yZsFygFAmHvMIH3ODBJfVeF258wQ\n\tO274XW4AYPv78qv4Qgp/bV/ytKofNZz4uNOnNK0Xbfuu/YakPhnb3fBX/Ew5tTsZ06fZ\n\t6F/2izZq11p6dbaizpjw1TbM9nau6ImtMqFUClGTj4DLICmsoDKruGTWsS5RpIDoKVdG\n\tWp0/tPVyCALTx8ZGhLNYnEqmalejDbHlMW76NhX8XyTn3w4UGe17U3m0bwfMsb29cgZs\n\tUvy3Dp6UH+dlsmTehIOkFV3Ir0cp7WtbxvMWsnoPWrD958LW9Y6iu0jZM3NiGb2DaoFk\n\t3tMw==","X-Gm-Message-State":"AMCzsaUUzpJg9vHag09ywd+skv+SHsFC2xF9GM7LdFuHIaZQLZi8UUIh\n\t8EHA6t+rQ5dk2z/9hqgQmhuzgL7/7/DRQNO7JVY=","X-Google-Smtp-Source":"AOwi7QCGQArYO/cyYO4RwO4k5rAzGI2YiKIGW0hnsmZUsDdOgf5uCTdpyljCTaLDQI24nJ+KqOFS/WDMuNcxo22vpMU=","X-Received":"by 10.157.1.164 with SMTP id e33mr768900ote.469.1506897436760;\n\tSun, 01 Oct 2017 15:37:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-33-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-33-hjl.tools@gmail.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 15:37:16 -0700","Message-ID":"","Subject":"Re: [PATCH 32/58] Hide internal signal functions [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]