[{"id":1762791,"web_url":"http://patchwork.ozlabs.org/comment/1762791/","msgid":"","list_archive_url":null,"date":"2017-09-04T17:02:21","subject":"Re: [Qemu-devel] [PATCH v6 07/29] libqtest: Remove dead\n\tqtest_instances variable","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> Prior to commit 063c23d9, we were tracking a list of parallel\n> qtest objects, in order to safely clean up a SIGABRT handler\n> only after the last connection quits. But when we switched to\n> more of glib's infrastructure, the list became dead code that\n> is never assigned to.\n> \n> Signed-off-by: Eric Blake \n> Reviewed-by: Philippe Mathieu-Daudé \n> ---\n> tests/libqtest.c | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmGPZ6XhSz9t16\n\tfor ;\n\tTue, 5 Sep 2017 03:02:57 +1000 (AEST)","from localhost ([::1]:54930 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1doulz-0005ff-N1\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 13:02:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34967)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doula-0005fC-Bk\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:02:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doulV-0003T3-Sw\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:02:30 -0400","from mx1.redhat.com ([209.132.183.28]:46378)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1doulV-0003Sp-NP\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:02:25 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9719712BBC\n\tfor ; Mon, 4 Sep 2017 17:02:24 +0000 (UTC)","from [10.36.116.102] (ovpn-116-102.ams2.redhat.com [10.36.116.102])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 70321B545A;\n\tMon, 4 Sep 2017 17:02:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9719712BBC","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-8-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 4 Sep 2017 19:02:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-8-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 04 Sep 2017 17:02:24 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 07/29] libqtest: Remove dead\n\tqtest_instances variable","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]